-
Notifications
You must be signed in to change notification settings - Fork 167
Refactored and optimized app details #1187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
oraveczandrew
wants to merge
11
commits into
Droid-ify:main
Choose a base branch
from
oraveczandrew:optimized-app-details
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactored and optimized app details #1187
oraveczandrew
wants to merge
11
commits into
Droid-ify:main
from
oraveczandrew:optimized-app-details
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b059829 to
ad032f8
Compare
Member
|
This is a large PR will need some time to review this properly And as I have little time now a days please assume delays |
2d7216d to
b8b6a4f
Compare
Signed-off-by: András Oravecz <info@oandras.hu>
0246b0e to
ff18291
Compare
Signed-off-by: András Oravecz <info@oandras.hu>
Signed-off-by: András Oravecz <info@oandras.hu>
Signed-off-by: András Oravecz <info@oandras.hu>
Signed-off-by: András Oravecz <info@oandras.hu>
… fragments and viewModels on backpress Signed-off-by: András Oravecz <info@oandras.hu>
Signed-off-by: András Oravecz <info@oandras.hu>
Signed-off-by: András Oravecz <info@oandras.hu>
Signed-off-by: András Oravecz <info@oandras.hu>
Signed-off-by: András Oravecz <info@oandras.hu>
Signed-off-by: András Oravecz <info@oandras.hu>
ff18291 to
c21366d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon the work in #1184.
It moves most data-related calculations off the main thread, including some binder calls, HTML parsing, permission data access, and shadow text measurement.
It also adds adapter item diffing to avoid unnecessary notifyItemChanged() calls in the affected adapters.