Change AllocScqRing's MODE from bool to usize#5
Open
khyperia wants to merge 1 commit intoDiscordJim:mainfrom
Open
Change AllocScqRing's MODE from bool to usize#5khyperia wants to merge 1 commit intoDiscordJim:mainfrom
khyperia wants to merge 1 commit intoDiscordJim:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Unfortunately, there is a breaking change happening soon in the Rust compiler. Generics in type aliases were not previously fully checked, causing type errors to not be reported properly. You can read more about the change here.
It seems like the
AllocScqRingtype alias has a slight typo in it, theScqRingtype takes ausizeMODE, butAllocScqRinghas aboolparameter. This will cause a compiler error in future Rust versions.Sorry for the hassle! If you have questions, feel free to ask me here, or reach out to me or the rust team on the rust-lang Zulip chat.