Conversation
📚 Documentation Check Results📦
|
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
🔒 Cargo Deny Results✅ No issues found! 📦
|
e80e1ee to
78104b8
Compare
BenchmarksComparisonBenchmark execution time: 2026-03-20 17:01:36 Comparing candidate commit f952dd9 in PR branch Found 4 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 2 unstable metrics.
|
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | f952dd9 | 1774024888 | bob/prevent-unprocessed |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| receiver_entry_point/report/2598 | execution_time | 3.407ms | 3.443ms ± 0.035ms | 3.433ms ± 0.008ms | 3.443ms | 3.503ms | 3.576ms | 3.662ms | 6.69% | 3.481 | 15.546 | 1.01% | 0.002ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| receiver_entry_point/report/2598 | execution_time | [3.438ms; 3.448ms] or [-0.140%; +0.140%] | None | None | None |
Group 2
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | f952dd9 | 1774024888 | bob/prevent-unprocessed |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| tags/replace_trace_tags | execution_time | 2.373µs | 2.408µs ± 0.016µs | 2.405µs ± 0.007µs | 2.413µs | 2.453µs | 2.458µs | 2.460µs | 2.31% | 1.563 | 3.181 | 0.65% | 0.001µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| tags/replace_trace_tags | execution_time | [2.406µs; 2.410µs] or [-0.091%; +0.091%] | None | None | None |
Group 3
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | f952dd9 | 1774024888 | bob/prevent-unprocessed |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| benching string interning on wordpress profile | execution_time | 162.920µs | 163.732µs ± 0.277µs | 163.677µs ± 0.116µs | 163.804µs | 164.215µs | 164.942µs | 165.046µs | 0.84% | 2.130 | 7.304 | 0.17% | 0.020µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| benching string interning on wordpress profile | execution_time | [163.693µs; 163.770µs] or [-0.023%; +0.023%] | None | None | None |
Group 4
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | f952dd9 | 1774024888 | bob/prevent-unprocessed |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| profile_add_sample_frames_x1000 | execution_time | 4.159ms | 4.164ms ± 0.002ms | 4.163ms ± 0.001ms | 4.165ms | 4.167ms | 4.171ms | 4.173ms | 0.23% | 1.169 | 2.833 | 0.05% | 0.000ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| profile_add_sample_frames_x1000 | execution_time | [4.163ms; 4.164ms] or [-0.007%; +0.007%] | None | None | None |
Group 5
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | f952dd9 | 1774024888 | bob/prevent-unprocessed |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| profile_add_sample_timestamped_x1000 | execution_time | 4.149ms | 4.154ms ± 0.008ms | 4.152ms ± 0.001ms | 4.154ms | 4.158ms | 4.161ms | 4.263ms | 2.66% | 12.100 | 158.410 | 0.20% | 0.001ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| profile_add_sample_timestamped_x1000 | execution_time | [4.153ms; 4.155ms] or [-0.027%; +0.027%] | None | None | None |
Group 6
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | f952dd9 | 1774024888 | bob/prevent-unprocessed |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| two way interface | execution_time | 13.837µs | 13.928µs ± 0.036µs | 13.927µs ± 0.017µs | 13.944µs | 13.982µs | 14.037µs | 14.144µs | 1.56% | 1.460 | 7.042 | 0.26% | 0.003µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| two way interface | execution_time | [13.923µs; 13.933µs] or [-0.036%; +0.036%] | None | None | None |
Group 7
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | f952dd9 | 1774024888 | bob/prevent-unprocessed |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| benching serializing traces from their internal representation to msgpack | execution_time | 14.301ms | 14.350ms ± 0.031ms | 14.348ms ± 0.014ms | 14.361ms | 14.383ms | 14.470ms | 14.534ms | 1.30% | 2.418 | 9.356 | 0.22% | 0.002ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| benching serializing traces from their internal representation to msgpack | execution_time | [14.346ms; 14.355ms] or [-0.030%; +0.030%] | None | None | None |
Group 8
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | f952dd9 | 1774024888 | bob/prevent-unprocessed |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| benching deserializing traces from msgpack to their internal representation | execution_time | 47.945ms | 48.318ms ± 1.492ms | 48.086ms ± 0.060ms | 48.219ms | 48.395ms | 57.227ms | 62.952ms | 30.92% | 8.315 | 69.943 | 3.08% | 0.106ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| benching deserializing traces from msgpack to their internal representation | execution_time | [48.111ms; 48.525ms] or [-0.428%; +0.428%] | None | None | None |
Group 9
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | f952dd9 | 1774024888 | bob/prevent-unprocessed |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| write only interface | execution_time | 5.574µs | 5.691µs ± 0.050µs | 5.708µs ± 0.027µs | 5.729µs | 5.748µs | 5.757µs | 5.769µs | 1.07% | -0.722 | -0.664 | 0.87% | 0.004µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| write only interface | execution_time | [5.684µs; 5.697µs] or [-0.121%; +0.121%] | None | None | None |
Group 10
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | f952dd9 | 1774024888 | bob/prevent-unprocessed |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| sql/obfuscate_sql_string | execution_time | 84.618µs | 84.780µs ± 0.156µs | 84.766µs ± 0.050µs | 84.807µs | 84.914µs | 85.128µs | 86.592µs | 2.15% | 8.135 | 90.201 | 0.18% | 0.011µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| sql/obfuscate_sql_string | execution_time | [84.758µs; 84.801µs] or [-0.025%; +0.025%] | None | None | None |
Group 11
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | f952dd9 | 1774024888 | bob/prevent-unprocessed |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| single_flag_killswitch/rules-based | execution_time | 190.600ns | 193.403ns ± 2.141ns | 193.189ns ± 1.362ns | 194.481ns | 197.526ns | 200.526ns | 202.908ns | 5.03% | 1.254 | 2.298 | 1.10% | 0.151ns | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| single_flag_killswitch/rules-based | execution_time | [193.107ns; 193.700ns] or [-0.153%; +0.153%] | None | None | None |
Group 12
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | f952dd9 | 1774024888 | bob/prevent-unprocessed |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| credit_card/is_card_number/ | execution_time | 3.891µs | 3.912µs ± 0.003µs | 3.912µs ± 0.002µs | 3.914µs | 3.917µs | 3.919µs | 3.927µs | 0.39% | -0.439 | 9.453 | 0.08% | 0.000µs | 1 | 200 |
| credit_card/is_card_number/ | throughput | 254636713.476op/s | 255625497.706op/s ± 209545.212op/s | 255640410.220op/s ± 122654.203op/s | 255755869.871op/s | 255882271.381op/s | 255930398.898op/s | 256970771.861op/s | 0.52% | 0.467 | 9.566 | 0.08% | 14817.084op/s | 1 | 200 |
| credit_card/is_card_number/ 3782-8224-6310-005 | execution_time | 79.441µs | 80.061µs ± 0.339µs | 80.002µs ± 0.194µs | 80.236µs | 80.669µs | 81.145µs | 81.638µs | 2.05% | 1.105 | 2.208 | 0.42% | 0.024µs | 1 | 200 |
| credit_card/is_card_number/ 3782-8224-6310-005 | throughput | 12249144.863op/s | 12490661.703op/s ± 52719.151op/s | 12499744.383op/s ± 30304.475op/s | 12524304.044op/s | 12559494.758op/s | 12576783.129op/s | 12587929.203op/s | 0.71% | -1.068 | 2.055 | 0.42% | 3727.807op/s | 1 | 200 |
| credit_card/is_card_number/ 378282246310005 | execution_time | 72.703µs | 73.372µs ± 0.313µs | 73.387µs ± 0.187µs | 73.534µs | 73.787µs | 74.178µs | 75.302µs | 2.61% | 1.281 | 6.850 | 0.43% | 0.022µs | 1 | 200 |
| credit_card/is_card_number/ 378282246310005 | throughput | 13279900.957op/s | 13629354.548op/s ± 57923.285op/s | 13626452.600op/s ± 34723.633op/s | 13667225.706op/s | 13723034.663op/s | 13744937.603op/s | 13754569.881op/s | 0.94% | -1.192 | 6.296 | 0.42% | 4095.795op/s | 1 | 200 |
| credit_card/is_card_number/37828224631 | execution_time | 3.891µs | 3.912µs ± 0.003µs | 3.912µs ± 0.002µs | 3.914µs | 3.917µs | 3.919µs | 3.926µs | 0.34% | -0.956 | 8.844 | 0.08% | 0.000µs | 1 | 200 |
| credit_card/is_card_number/37828224631 | throughput | 254732297.475op/s | 255597035.541op/s ± 210560.139op/s | 255600814.218op/s ± 138455.854op/s | 255738789.181op/s | 255862852.917op/s | 255983312.622op/s | 256979939.987op/s | 0.54% | 0.980 | 8.983 | 0.08% | 14888.850op/s | 1 | 200 |
| credit_card/is_card_number/378282246310005 | execution_time | 69.712µs | 70.376µs ± 0.307µs | 70.344µs ± 0.207µs | 70.560µs | 70.892µs | 71.198µs | 71.363µs | 1.45% | 0.542 | 0.177 | 0.43% | 0.022µs | 1 | 200 |
| credit_card/is_card_number/378282246310005 | throughput | 14012815.410op/s | 14209637.146op/s ± 61780.738op/s | 14215916.876op/s ± 41790.256op/s | 14255164.652op/s | 14298170.787op/s | 14320181.604op/s | 14344699.285op/s | 0.91% | -0.518 | 0.133 | 0.43% | 4368.558op/s | 1 | 200 |
| credit_card/is_card_number/37828224631000521389798 | execution_time | 52.137µs | 52.207µs ± 0.079µs | 52.196µs ± 0.022µs | 52.220µs | 52.269µs | 52.318µs | 53.018µs | 1.57% | 7.769 | 70.980 | 0.15% | 0.006µs | 1 | 200 |
| credit_card/is_card_number/37828224631000521389798 | throughput | 18861676.227op/s | 19154536.187op/s ± 28728.340op/s | 19158393.718op/s ± 8053.936op/s | 19165886.638op/s | 19172923.328op/s | 19178330.366op/s | 19180135.134op/s | 0.11% | -7.712 | 70.197 | 0.15% | 2031.400op/s | 1 | 200 |
| credit_card/is_card_number/x371413321323331 | execution_time | 5.690µs | 5.826µs ± 0.084µs | 5.824µs ± 0.064µs | 5.890µs | 5.968µs | 6.000µs | 6.031µs | 3.55% | 0.238 | -0.783 | 1.43% | 0.006µs | 1 | 200 |
| credit_card/is_card_number/x371413321323331 | throughput | 165805381.028op/s | 171684857.924op/s ± 2456454.023op/s | 171695887.971op/s ± 1898374.162op/s | 173551923.756op/s | 175542937.420op/s | 175619095.736op/s | 175733309.998op/s | 2.35% | -0.189 | -0.812 | 1.43% | 173697.530op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/ | execution_time | 3.893µs | 3.911µs ± 0.003µs | 3.911µs ± 0.002µs | 3.913µs | 3.915µs | 3.917µs | 3.918µs | 0.20% | -1.275 | 9.851 | 0.07% | 0.000µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/ | throughput | 255203628.942op/s | 255685987.444op/s ± 168000.923op/s | 255703912.271op/s ± 100072.049op/s | 255785566.667op/s | 255917947.402op/s | 255951941.739op/s | 256839055.527op/s | 0.44% | 1.295 | 9.998 | 0.07% | 11879.459op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | execution_time | 64.192µs | 64.447µs ± 0.177µs | 64.390µs ± 0.082µs | 64.516µs | 64.823µs | 64.967µs | 65.038µs | 1.01% | 1.146 | 0.667 | 0.27% | 0.013µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | throughput | 15375632.619op/s | 15516807.306op/s ± 42580.617op/s | 15530408.242op/s ± 19770.179op/s | 15544915.814op/s | 15564667.429op/s | 15576349.090op/s | 15578297.873op/s | 0.31% | -1.135 | 0.637 | 0.27% | 3010.904op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 378282246310005 | execution_time | 57.303µs | 57.602µs ± 0.120µs | 57.587µs ± 0.068µs | 57.661µs | 57.792µs | 58.039µs | 58.189µs | 1.05% | 1.474 | 4.612 | 0.21% | 0.008µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 378282246310005 | throughput | 17185495.797op/s | 17360446.136op/s ± 36078.451op/s | 17365089.226op/s ± 20637.095op/s | 17383780.936op/s | 17405254.997op/s | 17423186.929op/s | 17451114.314op/s | 0.50% | -1.446 | 4.493 | 0.21% | 2551.132op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631 | execution_time | 3.894µs | 3.911µs ± 0.003µs | 3.911µs ± 0.002µs | 3.913µs | 3.916µs | 3.918µs | 3.919µs | 0.22% | -0.543 | 6.056 | 0.07% | 0.000µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631 | throughput | 255151042.532op/s | 255675322.549op/s ± 185534.193op/s | 255711813.886op/s ± 104105.148op/s | 255787261.832op/s | 255898888.464op/s | 255944278.095op/s | 256808900.834op/s | 0.43% | 0.560 | 6.153 | 0.07% | 13119.249op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/378282246310005 | execution_time | 54.640µs | 54.987µs ± 0.255µs | 54.900µs ± 0.146µs | 55.149µs | 55.516µs | 55.770µs | 55.876µs | 1.78% | 1.062 | 0.726 | 0.46% | 0.018µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/378282246310005 | throughput | 17896709.828op/s | 18186410.764op/s ± 83779.944op/s | 18214930.779op/s ± 48703.381op/s | 18251900.193op/s | 18280473.753op/s | 18294565.623op/s | 18301500.120op/s | 0.48% | -1.040 | 0.655 | 0.46% | 5924.137op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | execution_time | 52.137µs | 52.205µs ± 0.032µs | 52.203µs ± 0.022µs | 52.227µs | 52.259µs | 52.281µs | 52.291µs | 0.17% | 0.293 | -0.383 | 0.06% | 0.002µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | throughput | 19123747.880op/s | 19155338.124op/s ± 11691.394op/s | 19156138.192op/s ± 8106.119op/s | 19164035.812op/s | 19173399.018op/s | 19176162.477op/s | 19180079.569op/s | 0.12% | -0.290 | -0.386 | 0.06% | 826.706op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/x371413321323331 | execution_time | 5.690µs | 5.790µs ± 0.083µs | 5.777µs ± 0.064µs | 5.847µs | 5.948µs | 5.997µs | 6.040µs | 4.55% | 0.730 | -0.213 | 1.43% | 0.006µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/x371413321323331 | throughput | 165562274.957op/s | 172754831.287op/s ± 2455294.839op/s | 173102932.733op/s ± 1947503.930op/s | 174900314.679op/s | 175619940.437op/s | 175716245.299op/s | 175751226.392op/s | 1.53% | -0.677 | -0.340 | 1.42% | 173615.563op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| credit_card/is_card_number/ | execution_time | [3.912µs; 3.912µs] or [-0.011%; +0.011%] | None | None | None |
| credit_card/is_card_number/ | throughput | [255596456.755op/s; 255654538.657op/s] or [-0.011%; +0.011%] | None | None | None |
| credit_card/is_card_number/ 3782-8224-6310-005 | execution_time | [80.014µs; 80.108µs] or [-0.059%; +0.059%] | None | None | None |
| credit_card/is_card_number/ 3782-8224-6310-005 | throughput | [12483355.335op/s; 12497968.070op/s] or [-0.058%; +0.058%] | None | None | None |
| credit_card/is_card_number/ 378282246310005 | execution_time | [73.329µs; 73.416µs] or [-0.059%; +0.059%] | None | None | None |
| credit_card/is_card_number/ 378282246310005 | throughput | [13621326.937op/s; 13637382.158op/s] or [-0.059%; +0.059%] | None | None | None |
| credit_card/is_card_number/37828224631 | execution_time | [3.912µs; 3.913µs] or [-0.011%; +0.011%] | None | None | None |
| credit_card/is_card_number/37828224631 | throughput | [255567853.931op/s; 255626217.151op/s] or [-0.011%; +0.011%] | None | None | None |
| credit_card/is_card_number/378282246310005 | execution_time | [70.334µs; 70.419µs] or [-0.060%; +0.060%] | None | None | None |
| credit_card/is_card_number/378282246310005 | throughput | [14201074.930op/s; 14218199.362op/s] or [-0.060%; +0.060%] | None | None | None |
| credit_card/is_card_number/37828224631000521389798 | execution_time | [52.196µs; 52.218µs] or [-0.021%; +0.021%] | None | None | None |
| credit_card/is_card_number/37828224631000521389798 | throughput | [19150554.715op/s; 19158517.659op/s] or [-0.021%; +0.021%] | None | None | None |
| credit_card/is_card_number/x371413321323331 | execution_time | [5.814µs; 5.837µs] or [-0.199%; +0.199%] | None | None | None |
| credit_card/is_card_number/x371413321323331 | throughput | [171344417.021op/s; 172025298.826op/s] or [-0.198%; +0.198%] | None | None | None |
| credit_card/is_card_number_no_luhn/ | execution_time | [3.911µs; 3.911µs] or [-0.009%; +0.009%] | None | None | None |
| credit_card/is_card_number_no_luhn/ | throughput | [255662704.132op/s; 255709270.756op/s] or [-0.009%; +0.009%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | execution_time | [64.422µs; 64.471µs] or [-0.038%; +0.038%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | throughput | [15510906.042op/s; 15522708.570op/s] or [-0.038%; +0.038%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 378282246310005 | execution_time | [57.586µs; 57.619µs] or [-0.029%; +0.029%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 378282246310005 | throughput | [17355446.010op/s; 17365446.262op/s] or [-0.029%; +0.029%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631 | execution_time | [3.911µs; 3.912µs] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631 | throughput | [255649609.294op/s; 255701035.804op/s] or [-0.010%; +0.010%] | None | None | None |
| credit_card/is_card_number_no_luhn/378282246310005 | execution_time | [54.952µs; 55.023µs] or [-0.064%; +0.064%] | None | None | None |
| credit_card/is_card_number_no_luhn/378282246310005 | throughput | [18174799.670op/s; 18198021.859op/s] or [-0.064%; +0.064%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | execution_time | [52.200µs; 52.209µs] or [-0.008%; +0.008%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | throughput | [19153717.809op/s; 19156958.439op/s] or [-0.008%; +0.008%] | None | None | None |
| credit_card/is_card_number_no_luhn/x371413321323331 | execution_time | [5.778µs; 5.801µs] or [-0.199%; +0.199%] | None | None | None |
| credit_card/is_card_number_no_luhn/x371413321323331 | throughput | [172414551.036op/s; 173095111.538op/s] or [-0.197%; +0.197%] | None | None | None |
Group 13
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | f952dd9 | 1774024888 | bob/prevent-unprocessed |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| ip_address/quantize_peer_ip_address_benchmark | execution_time | 4.984µs | 5.081µs ± 0.049µs | 5.064µs ± 0.030µs | 5.138µs | 5.150µs | 5.152µs | 5.156µs | 1.82% | 0.128 | -1.327 | 0.96% | 0.003µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| ip_address/quantize_peer_ip_address_benchmark | execution_time | [5.074µs; 5.088µs] or [-0.134%; +0.134%] | None | None | None |
Group 14
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | f952dd9 | 1774024888 | bob/prevent-unprocessed |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| normalization/normalize_trace/test_trace | execution_time | 237.101ns | 248.321ns ± 13.695ns | 243.078ns ± 4.017ns | 250.349ns | 284.091ns | 286.881ns | 290.692ns | 19.59% | 1.789 | 2.089 | 5.50% | 0.968ns | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| normalization/normalize_trace/test_trace | execution_time | [246.423ns; 250.219ns] or [-0.764%; +0.764%] | None | None | None |
Group 15
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | f952dd9 | 1774024888 | bob/prevent-unprocessed |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | execution_time | 185.874µs | 186.251µs ± 0.205µs | 186.238µs ± 0.135µs | 186.374µs | 186.573µs | 186.764µs | 186.964µs | 0.39% | 0.473 | -0.027 | 0.11% | 0.015µs | 1 | 200 |
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | throughput | 5348631.132op/s | 5369105.593op/s ± 5920.916op/s | 5369461.937op/s ± 3903.057op/s | 5373223.789op/s | 5377573.086op/s | 5379491.096op/s | 5379987.147op/s | 0.20% | -0.468 | -0.039 | 0.11% | 418.672op/s | 1 | 200 |
| normalization/normalize_name/normalize_name/bad-name | execution_time | 17.886µs | 17.967µs ± 0.038µs | 17.964µs ± 0.020µs | 17.983µs | 18.043µs | 18.054µs | 18.112µs | 0.83% | 0.802 | 1.314 | 0.21% | 0.003µs | 1 | 200 |
| normalization/normalize_name/normalize_name/bad-name | throughput | 55212398.385op/s | 55657322.920op/s ± 116105.414op/s | 55668308.571op/s ± 61913.836op/s | 55730389.492op/s | 55826935.243op/s | 55880843.924op/s | 55908756.909op/s | 0.43% | -0.785 | 1.272 | 0.21% | 8209.893op/s | 1 | 200 |
| normalization/normalize_name/normalize_name/good | execution_time | 10.250µs | 10.475µs ± 0.089µs | 10.492µs ± 0.051µs | 10.532µs | 10.599µs | 10.640µs | 10.649µs | 1.50% | -0.664 | -0.014 | 0.85% | 0.006µs | 1 | 200 |
| normalization/normalize_name/normalize_name/good | throughput | 93905664.646op/s | 95471642.224op/s ± 818060.118op/s | 95314017.087op/s ± 459274.114op/s | 95839390.609op/s | 97096906.980op/s | 97467549.404op/s | 97556288.870op/s | 2.35% | 0.704 | 0.031 | 0.85% | 57845.586op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | execution_time | [186.223µs; 186.279µs] or [-0.015%; +0.015%] | None | None | None |
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | throughput | [5368285.011op/s; 5369926.175op/s] or [-0.015%; +0.015%] | None | None | None |
| normalization/normalize_name/normalize_name/bad-name | execution_time | [17.962µs; 17.972µs] or [-0.029%; +0.029%] | None | None | None |
| normalization/normalize_name/normalize_name/bad-name | throughput | [55641231.827op/s; 55673414.014op/s] or [-0.029%; +0.029%] | None | None | None |
| normalization/normalize_name/normalize_name/good | execution_time | [10.463µs; 10.487µs] or [-0.118%; +0.118%] | None | None | None |
| normalization/normalize_name/normalize_name/good | throughput | [95358266.959op/s; 95585017.488op/s] or [-0.119%; +0.119%] | None | None | None |
Group 16
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | f952dd9 | 1774024888 | bob/prevent-unprocessed |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| sdk_test_data/rules-based | execution_time | 143.983µs | 146.200µs ± 1.859µs | 145.883µs ± 0.497µs | 146.499µs | 148.190µs | 153.796µs | 165.043µs | 13.13% | 6.266 | 54.830 | 1.27% | 0.131µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| sdk_test_data/rules-based | execution_time | [145.943µs; 146.458µs] or [-0.176%; +0.176%] | None | None | None |
Group 17
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | f952dd9 | 1774024888 | bob/prevent-unprocessed |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| concentrator/add_spans_to_concentrator | execution_time | 13.090ms | 13.128ms ± 0.019ms | 13.126ms ± 0.012ms | 13.141ms | 13.158ms | 13.174ms | 13.207ms | 0.61% | 0.623 | 0.882 | 0.14% | 0.001ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| concentrator/add_spans_to_concentrator | execution_time | [13.125ms; 13.131ms] or [-0.020%; +0.020%] | None | None | None |
Group 18
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | f952dd9 | 1774024888 | bob/prevent-unprocessed |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | execution_time | 495.258µs | 496.136µs ± 0.406µs | 496.133µs ± 0.270µs | 496.355µs | 496.864µs | 497.101µs | 498.061µs | 0.39% | 0.723 | 1.759 | 0.08% | 0.029µs | 1 | 200 |
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | throughput | 2007785.747op/s | 2015576.424op/s ± 1649.809op/s | 2015589.126op/s ± 1096.226op/s | 2016746.503op/s | 2018009.988op/s | 2018488.534op/s | 2019150.974op/s | 0.18% | -0.715 | 1.728 | 0.08% | 116.659op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | execution_time | 369.712µs | 370.476µs ± 0.322µs | 370.468µs ± 0.205µs | 370.673µs | 370.885µs | 371.199µs | 372.540µs | 0.56% | 1.274 | 7.351 | 0.09% | 0.023µs | 1 | 200 |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | throughput | 2684275.827op/s | 2699235.603op/s ± 2340.523op/s | 2699285.300op/s ± 1492.833op/s | 2700757.031op/s | 2702826.315op/s | 2703992.615op/s | 2704809.657op/s | 0.20% | -1.254 | 7.212 | 0.09% | 165.500op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | execution_time | 168.792µs | 169.114µs ± 0.124µs | 169.105µs ± 0.076µs | 169.182µs | 169.327µs | 169.457µs | 169.548µs | 0.26% | 0.518 | 0.867 | 0.07% | 0.009µs | 1 | 200 |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | throughput | 5898019.404op/s | 5913172.029op/s ± 4331.458op/s | 5913482.453op/s ± 2660.536op/s | 5916093.084op/s | 5919132.821op/s | 5922894.482op/s | 5924450.580op/s | 0.19% | -0.512 | 0.859 | 0.07% | 306.280op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/[empty string] | execution_time | 36.809µs | 37.014µs ± 0.123µs | 37.021µs ± 0.108µs | 37.118µs | 37.202µs | 37.263µs | 37.298µs | 0.75% | 0.093 | -1.164 | 0.33% | 0.009µs | 1 | 200 |
| normalization/normalize_service/normalize_service/[empty string] | throughput | 26810968.544op/s | 27017010.517op/s ± 89992.884op/s | 27011357.471op/s ± 78820.835op/s | 27104085.492op/s | 27141834.278op/s | 27157600.897op/s | 27167025.803op/s | 0.58% | -0.084 | -1.171 | 0.33% | 6363.458op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/test_ASCII | execution_time | 46.198µs | 46.285µs ± 0.039µs | 46.280µs ± 0.023µs | 46.308µs | 46.365µs | 46.389µs | 46.412µs | 0.29% | 0.679 | 0.500 | 0.08% | 0.003µs | 1 | 200 |
| normalization/normalize_service/normalize_service/test_ASCII | throughput | 21546000.477op/s | 21605327.916op/s ± 17969.168op/s | 21607768.275op/s ± 10573.562op/s | 21617183.876op/s | 21629676.707op/s | 21640388.800op/s | 21646126.767op/s | 0.18% | -0.674 | 0.491 | 0.08% | 1270.612op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | execution_time | [496.080µs; 496.193µs] or [-0.011%; +0.011%] | None | None | None |
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | throughput | [2015347.777op/s; 2015805.072op/s] or [-0.011%; +0.011%] | None | None | None |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | execution_time | [370.431µs; 370.520µs] or [-0.012%; +0.012%] | None | None | None |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | throughput | [2698911.229op/s; 2699559.977op/s] or [-0.012%; +0.012%] | None | None | None |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | execution_time | [169.097µs; 169.131µs] or [-0.010%; +0.010%] | None | None | None |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | throughput | [5912571.730op/s; 5913772.327op/s] or [-0.010%; +0.010%] | None | None | None |
| normalization/normalize_service/normalize_service/[empty string] | execution_time | [36.997µs; 37.031µs] or [-0.046%; +0.046%] | None | None | None |
| normalization/normalize_service/normalize_service/[empty string] | throughput | [27004538.368op/s; 27029482.665op/s] or [-0.046%; +0.046%] | None | None | None |
| normalization/normalize_service/normalize_service/test_ASCII | execution_time | [46.280µs; 46.290µs] or [-0.012%; +0.012%] | None | None | None |
| normalization/normalize_service/normalize_service/test_ASCII | throughput | [21602837.562op/s; 21607818.270op/s] or [-0.012%; +0.012%] | None | None | None |
Group 19
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | f952dd9 | 1774024888 | bob/prevent-unprocessed |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| redis/obfuscate_redis_string | execution_time | 34.137µs | 34.666µs ± 0.896µs | 34.269µs ± 0.049µs | 34.344µs | 36.536µs | 36.601µs | 38.444µs | 12.18% | 1.830 | 1.833 | 2.58% | 0.063µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| redis/obfuscate_redis_string | execution_time | [34.542µs; 34.790µs] or [-0.358%; +0.358%] | None | None | None |
Group 20
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | f952dd9 | 1774024888 | bob/prevent-unprocessed |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| profile_add_sample2_frames_x1000 | execution_time | 718.467µs | 719.264µs ± 0.413µs | 719.228µs ± 0.267µs | 719.478µs | 719.976µs | 720.537µs | 720.792µs | 0.22% | 0.953 | 1.206 | 0.06% | 0.029µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| profile_add_sample2_frames_x1000 | execution_time | [719.207µs; 719.321µs] or [-0.008%; +0.008%] | None | None | None |
Baseline
Omitted due to size.
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1742 +/- ##
==========================================
- Coverage 71.28% 70.48% -0.81%
==========================================
Files 431 409 -22
Lines 64585 62047 -2538
==========================================
- Hits 46038 43732 -2306
+ Misses 18547 18315 -232
🚀 New features to boost your workflow:
|
78104b8 to
b763a37
Compare
b763a37 to
3e890d5
Compare
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> # Conflicts: # datadog-sidecar-ffi/src/lib.rs # datadog-sidecar/src/service/blocking.rs # datadog-sidecar/src/service/session_info.rs # datadog-sidecar/src/service/sidecar_interface.rs # datadog-sidecar/src/service/sidecar_server.rs
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
…ry growth Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
e94054e to
fbe1e59
Compare
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
fbe1e59 to
adbae41
Compare
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
…-unprocessed * 'main' of github.com:DataDog/libdatadog: feat(sidecar): add thread mode as fallback connection for restricted environments (#1447) feat(profiling-ffi): ProfilesDictionary_insert_strs (#1764) chore(release): merge release branch to main (#1760) fix(libdd-crashtracker-ffi)!: add missing fields for endpoint configuration (#1758) ci: prevent running macos tests on release branches (#1765) chore(datadog-tracer-flare): remove unnecessary features/deps (#1761) fix(profiling-ffi): Windows extern statics need __declspec(dllimport) (#1468) feat(profiling): thread id/name as well-known strs (#1757) ci: switch to ephemeral branches (#1731) chore(crashtracker): use weaker mem ordering for OP_COUNTERS (#1744) refactor(trace-utils)!: change header name type to accept dynamic values (#1722)
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: f952dd9 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Everything we used tarpc for was dispatching ... and not much else.
But it also imposed some constraints on the messaging stream, like it did not directly allow us to backpressure directly on the read stream.
Finally, the old code, under some, not understood circumstances, would have file descriptors pile up in the sink, which were not ending up being associated with a message. (I suspect, when a message was dropped on the sender side?!)
This proposes a radically different approach based on message passing instead of streaming:
The messaging approach promises to strongly tie file descriptors to the passed text, structurally eliminating the possibility of file descriptions leaking.
It also avoids a manual length delimiting codec and stream buffering. It generally avoids all buffering, except the send and receive buffers. In fact, previously we had multiple additional buffering channels around the different executors - and still, in the end we execute stuff serially...
Avoiding tarpc also allows us to trivially tie some metadata directly to the connection. This can still be improved upon. E.g. session_ids are now fundamentally tied to the connection.
Finally we also improve upon connection state stability when messages are dropped: the SidecarOutbox will buffer state-critical data and resubmit when space becomes available.