Adds Selection Criteria parameter to aws account level logs#289
Open
correnarsprowls wants to merge 1 commit intoDataDog:masterfrom
Open
Adds Selection Criteria parameter to aws account level logs#289correnarsprowls wants to merge 1 commit intoDataDog:masterfrom
correnarsprowls wants to merge 1 commit intoDataDog:masterfrom
Conversation
bwebster
reviewed
Mar 10, 2026
bwebster
left a comment
bwebster
left a comment
There was a problem hiding this comment.
Had one question trying to understand what the Default value is used for.
| Description: >- | ||
| Optional subscription selection criteria. | ||
| Type: String | ||
| Default: "LogGroupName NOT IN [\"MyLogGroup\", \"MyAnotherLogGroup\"]" |
There was a problem hiding this comment.
Is Default used as the actual default value, or use to show an example value? If it becomes the actual default value, maybe we need to move this into the description.
Author
There was a problem hiding this comment.
It's the actual default value. I would prefer the default be a blank string, but that would create drift for other people using the template without SelectionCriteria set.
Author
There was a problem hiding this comment.
Technically I think what we would set it to is !Ref "AWS::NoValue" if no value was given
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This allows users to enter their own value for SelectionCriteria for the log subscription filter.
Motivation
We created a new log group that we don't want to be forwarded to Datadog
Testing Guidelines
I made these changes to the templates, uploaded them to s3 (with the addition that
main.yamlreferenced the newly uploadedsingle-region.yaml) and then used them to add my own SelectionCriteria. It applied cleanly and logs from that log group weren't being sent to datadog anymore.Additional Notes
I opted for easy readability here and required the entire filter (ex
"LogGroupName NOT IN [\"MyLogGroup1\", \"MyLogGroup2\"]", but we could add anExcludedLogGroupparameter instead and build out the filter. I'm open to suggestions.I also kept the default value the same as what was hardcoded for SelectionCriteria before. Not sure if that's something you would like to keep or change.