Merge agentless scanning params into single AgentlessVulnerabilityScanning#280
Merge agentless scanning params into single AgentlessVulnerabilityScanning#280
Conversation
Added to the PR description! |
d3f04ab to
f9e4023
Compare
ksirrah13
left a comment
There was a problem hiding this comment.
❓question(nonblocking): Won't updating the parameters here cause it to break for customers using this to set those previous parameters? Or how is this template used right now and will there be followup changes to update how these parameters are being set?
Right now this is not something that is controllable from Datadog UI as the 3 toggles are already bundled in one. |
f9e4023 to
d134e89
Compare
…nning Replace AgentlessHostScanning, AgentlessContainerScanning, and AgentlessLambdaScanning with a single AgentlessVulnerabilityScanning parameter. The Lambda function fans out the single value to the three fine-grained API attributes (vuln_host_os, vuln_containers_os, lambda) that the Datadog API expects. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
d134e89 to
524be52
Compare
Motivation
Most customers enable everything, keeping options as they are pre-filled.
By exposing less params, we simplify a bit the CloudFormation template.
It's more consistent with the AWS Side Panel view of the settings page where the 3 options are toggled together.
Prepares the ground for adding a new AgentlessComplianceScanning (not sure about the naming) for CSPM Agentless. (<- we remain consistent with the AWS side panel view, given that we plan to add a tile there too!)
Summary
AgentlessHostScanning,AgentlessContainerScanning,AgentlessLambdaScanning) with a singleAgentlessVulnerabilityScanningparameter across all CloudFormation templatesdatadog_agentless_api_call.py) to fan out the single value to the three fine-grained API attributes (vuln_host_os,vuln_containers_os,lambda) that the Datadog API expectsFn::Orconditions and rules inmain_extended.yamlandmain_extended_workflow.yamlfrom 4 branches to 2datadog_agentless_delegate_role_stackset.yamlcustom resource with the new Lambda interface (singleVulnerabilityScanningproperty instead of three)Test plan
python3 -m unittest datadog_agentless_api_call_test -v)AgentlessHostScanning,AgentlessContainerScanning, orAgentlessLambdaScanning🤖 Generated with Claude Code