Refactor Config Loading, Optimize Dashboard, and Fix Nextcloud Config#205
Refactor Config Loading, Optimize Dashboard, and Fix Nextcloud Config#205
Conversation
… security - Refactor `Config::load` and `Config::load_async` to support `/opt/server_manager/config.yaml` as a fallback path and correctly manage caching with file path awareness. - Optimize web dashboard by wrapping blocking `sysinfo` refresh in `tokio::task::spawn_blocking` to prevent blocking the async runtime. - Fix potential security issue in Nextcloud configuration by escaping `$` characters in generated PHP autoconfig to prevent variable interpolation. - Bump version to 1.0.8 in `Cargo.toml` and `README.md`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR includes several improvements and fixes:
Config::loadandConfig::load_asyncto check forconfig.yamlin/opt/server_manager/if it doesn't exist in the current directory. This aligns withUserManagerbehavior. The caching logic now correctly tracks the loaded file path.tokio::task::spawn_blocking. This prevents the heavy synchronoussysinfocalls from blocking the async executor, improving responsiveness.$characters in the Nextcloud PHP autoconfig generation. This prevents passwords containing$from being misinterpreted as PHP variables.1.0.8inCargo.tomland updated theREADME.mdbadge.PR created automatically by Jules for task 4109007814059015812 started by @Cylae