fix: ignore protobuf files without messages when generating code#210
Open
infastin wants to merge 1 commit intoCrowdStrike:mainfrom
Open
fix: ignore protobuf files without messages when generating code#210infastin wants to merge 1 commit intoCrowdStrike:mainfrom
infastin wants to merge 1 commit intoCrowdStrike:mainfrom
Conversation
wmorgan6796
requested changes
Mar 2, 2026
Contributor
wmorgan6796
left a comment
There was a problem hiding this comment.
Overall looks good. There are 2 things:
- It feels like there needs to be a test case added somewhere for this (I'm not entirely sure where though) to validate the new behavior.
- There is a typo (that was there from the moved function before) that should be fixed.
| queue = queue[1:] | ||
| msgs = append(msgs, m) | ||
| for _, mm := range m.Messages { | ||
| // skip "messgaes" that represent map fields |
Contributor
There was a problem hiding this comment.
Suggested change
| // skip "messgaes" that represent map fields | |
| // skip "messages" that represent map fields |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fastmarshalat the moment generates empty files if a protobuf file doesn't contain any messages.So, for this file:
fastmarshalgenerates this:This PR makes it so
fastmarshalfirst checks if there are any messages in a protobuf file before generating the code.grpcanddrpcgenerators do the same thing.