fix: support custom variable names in expo-font-loaded-check#49
Merged
danielchen0 merged 1 commit intomainfrom Feb 26, 2026
Merged
fix: support custom variable names in expo-font-loaded-check#49danielchen0 merged 1 commit intomainfrom
danielchen0 merged 1 commit intomainfrom
Conversation
The rule previously only matched the exact variable name `loaded` when checking for font load guards. Now it tracks the actual destructured variable name from useFonts() (e.g. `fontsLoaded`), so patterns like `if (!fontsLoaded && !fontError) return null` are correctly recognized.
arnavsurve
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expo-font-loaded-checkrule previously only matched the exact variable nameloadeduseFonts()(e.g.fontsLoaded)if (!fontsLoaded && !fontError) return nullare now correctly recognizedExample