Fix broken functions in concoredocker.hpp to match Python behavior #234
+78
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- safe_literal_eval now reads and parses file content instead of always returning default - load_params populates the params map from concore.params file - read() parses list data, extracts simtime from first element, returns rest - Added initval() to parse simtime string and extract data portion - Fixed naming to match codebase style (no underscores in function names) Fixes ControlCore-Project#224
Author
|
@pradeeban hey, The 4 CI failures are pre-existing, they're all Python tests on concoredocker.py with a path concatenation bug in the test setup. My PR only touches concoredocker.hpp, zero overlap. Pls take a look |
Member
|
Yes, it is not your PR. I am merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed four critical bugs where C++ functions weren't actually doing anything. safe_literal_eval() now reads files, load_params() populates the map, read() extracts simtime and returns data and added missing initval(). All helper functions renamed to match the codebase style (no underscores).
Fixes #224