Add missing pyzmq dependency for unconditional zmq import #230
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rahuljagwani
approved these changes
Feb 9, 2026
Contributor
|
@GaneshPatil7517 lgtm @pradeeban, I reviewed it, looks good to me. |
Member
|
This was a PR against the main branch. Please test and develop against the dev branch. This is already fixed in the dev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
concore.pyimportszmqunconditionally at line 6, but the correspondingpackage
pyzmqwas missing fromrequirements.txt. This causes a freshinstall to fail with
ModuleNotFoundError: No module named 'zmq'.Fix
pyzmqtorequirements.txtVerification
python -c "import concore"→ModuleNotFoundErrorpython -c "import concore"→ SuccessImpact
Fixes #227