Fix sample script to use correct concore function names #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@pradeeban The CI failures are in test_concoredocker.py, this PR only modifies init.py. The failing tests are catching a path construction bug in concoredocker.py (os.path.join(inpath + str(port), name) should use proper path joining). That fix is already in #219. Happy to rebase once #219 is merged or I can include that fix here if preferred. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sample script.py generated by
concore initwas using MATLAB-style function names (concore_unchanged,concore_read,concore_write) that don't exist in Python. Changed it to use the actual function names (unchanged, read, write) and added the required initialization pattern from the existing demosthis Fixes #223