Add validation for multiple attributes on Refund and Activity#1246
Open
wwahammy wants to merge 9 commits intosupporter_level_goalfrom
Open
Add validation for multiple attributes on Refund and Activity#1246wwahammy wants to merge 9 commits intosupporter_level_goalfrom
wwahammy wants to merge 9 commits intosupporter_level_goalfrom
Conversation
Member
Author
|
There's a bug here that I need to handle. I'll resubmit in a few |
wwahammy
requested review from
caseyhelbling
and removed request for
caseyhelbling
wwahammy
changed the base branch from
supporter_level_goal
to
remove-reassignment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some validations to the attributes in Refund and Activity along with some specs for them.
Additionally, I had to reorganize
InsertRefundso certain things happened in the correct order, i.ePaymentwas created beforeRefund.NOTE: DO NOT discuss internal CommitChange information in your PR; this PR will be public.
Link back to the issue in the Tix repo when you need to do that.