Handling disk names containing a space#45
Open
Jaxom99 wants to merge 1 commit intoColinWaddell:masterfrom
Open
Handling disk names containing a space#45Jaxom99 wants to merge 1 commit intoColinWaddell:masterfrom
Jaxom99 wants to merge 1 commit intoColinWaddell:masterfrom
Conversation
Handling disk names containing a space ("Hard drive") by replacing the splitting-line tool : explode() -> preg_split().
I'm no regexp expert, so the prosed one will only match names with one space and letters after the space (so as to not match with the size numbers returned by 'df'.
Tested on RPi-2 running Raspbian Jessie with Nginx 1.6.2
Owner
|
Good catch! I'll be on my Xmas holidays soon so I'll try and sort this out
then.
Cheers!
…On 14 Dec 2017 11:41 a.m., "Jaxom99" ***@***.***> wrote:
Handling disk names containing a space ("Hard drive") by replacing the
splitting-line tool : explode() -> preg_split(). Otherwise the resulting
table in HTML has a row mismatch.
I'm no regexp expert, so the prosed one will only match names with one
space and letters after the space. Things can be improved I suppose...
Tested on RPi-2 running Raspbian Jessie with Nginx 1.6.2
------------------------------
You can view, comment on, or merge this pull request online at:
#45
Commit Summary
- Handling disk names containing a space
File Changes
- *M* content/storage/StorageData.php
<https://github.com/ColinWaddell/CurrantPi/pull/45/files#diff-0> (3)
Patch Links:
- https://github.com/ColinWaddell/CurrantPi/pull/45.patch
- https://github.com/ColinWaddell/CurrantPi/pull/45.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#45>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABw0BXkt7Ng8mej6onp_6jD56ogAPITGks5tAQlOgaJpZM4RB74Z>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handling disk names containing a space ("Hard drive") by replacing the splitting-line tool : explode() -> preg_split(). Otherwise the resulting table in HTML has a row mismatch.
I'm no regexp expert, so the prosed one will only match names with one space and letters after the space. Things can be improved I suppose...
Tested on RPi-2 running Raspbian Jessie with Nginx 1.6.2