Skip to content

Raise testutil coverage above main gate#32

Merged
davidahmann merged 3 commits intomainfrom
codex/fix-main-postmerge-ci
Mar 11, 2026
Merged

Raise testutil coverage above main gate#32
davidahmann merged 3 commits intomainfrom
codex/fix-main-postmerge-ci

Conversation

@davidahmann
Copy link
Contributor

Summary

  • add coverage for the stale binary cache path in internal/testutil
  • keep the existing BuildBinary behavior unchanged
  • restore the main workflow package coverage gate after the post-merge follow-up fixes

Validation

  • go test ./... -coverprofile=coverage.out
  • ./scripts/check_go_package_coverage.py coverage.out 75 github.com/Clyra-AI/proof/core/exitcode
  • make lint

@davidahmann davidahmann merged commit 8383e6f into main Mar 11, 2026
11 checks passed
@davidahmann davidahmann deleted the codex/fix-main-postmerge-ci branch March 11, 2026 02:55
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 79761a5c2a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


concurrency:
group: pr-${{ github.workflow }}-${{ github.event.pull_request.head.ref || github.ref_name }}
group: pr-${{ github.workflow }}-${{ github.event.pull_request.head.repo.full_name || github.repository }}-${{ github.event.pull_request.number || github.ref_name }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Unify push/PR concurrency key to avoid duplicate runs

In .github/workflows/pr.yml I checked that this workflow is triggered by both pull_request and push, but the new concurrency key now resolves to ...-<repo>-<pr_number> for PR events and ...-<repo>-<branch> for push events. For same-repo PRs, a single commit therefore lands in two different groups, so cross-event cancellation no longer happens and the same pr workflow runs twice per commit; that increases CI load and can block merges if either duplicate run flakes.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant