#2079: Disable submit buttons and adds error notification#2096
Open
#2079: Disable submit buttons and adds error notification#2096
Conversation
…ht_disable_submit_buttons
markmandell
approved these changes
Jan 16, 2020
Contributor
markmandell
left a comment
There was a problem hiding this comment.
Looks good! 👍 Tested all functionality and ran through our automated tests. Really like the addition of the notifications as well!
shaungc-su
approved these changes
Jan 27, 2020
Contributor
shaungc-su
left a comment
There was a problem hiding this comment.
Nice catch on the type button to submit for submitBusy! The error notification component looks handy, would be useful for other feature as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to Test #2079
Steps to Test Error Notification