#313: Adds delete button to PubMed articles in GDMs with no evidence#2092
#313: Adds delete button to PubMed articles in GDMs with no evidence#2092
Conversation
| "description": "The affiliation this annotation is associated with.", | ||
| "type": "string" | ||
| }, | ||
| "articleNotes": { |
There was a problem hiding this comment.
Do we have to update schema version here? Saw that this schema is liked to curatorHistory, not sure if we forgot or if it's not necessary due to the link.
There was a problem hiding this comment.
I think you're right, the version should be updated. I feel like I purposefully left it unchanged for a reason, but I may have just forgotten. I'll add it in.
| "properties": { | ||
| "schema_version": { | ||
| "default": "3" | ||
| "default": "5" |
There was a problem hiding this comment.
Should schema version be "4" here? If not, let me know!
There was a problem hiding this comment.
This is 5 because this is branched off of the pubmed notes branch. The other branch upgrades to 4 and this branch upgrades to 5.
There was a problem hiding this comment.
Sweet, thanks for clarifying!
markmandell
left a comment
markmandell
left a comment
There was a problem hiding this comment.
Looks good to me! Will wait for that small schema change before approving 👍
2 participants
Steps to Test #313
Note: This branch is branched from #2025