Connects to #1824, #2011: Adds confirm modal for no criteria summary#1941
Open
Connects to #1824, #2011: Adds confirm modal for no criteria summary#1941
Conversation
h-tong
commented
Jun 10, 2019
src/clincoded/static/components/variant_central/interpretation/summary.js
Outdated
Show resolved
Hide resolved
bryanwulf
reviewed
Aug 17, 2019
src/clincoded/static/components/variant_central/interpretation/summary.js
Outdated
Show resolved
Hide resolved
bryanwulf
requested changes
Aug 17, 2019
Contributor
bryanwulf
left a comment
There was a problem hiding this comment.
Per Matt, the absence of criteria in the Not yet evaluated table/panel of the standalone summary (e.g. the new tab/window that appears when clicking on the View Provisional Summary button) needs to be corrected before this can go live. This change, plus some others (for both interpretation summary views), is described in #2011. If you're amenable, I'd like to assign #2011 to you and have it be incorporated into this branch/PR.
added 2 commits
August 20, 2019 10:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to test #1824
Steps to test #2011