[v4.0] Restrict top-level design space types. #1015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only product and hierarchical design spaces are allowed as the top-level design space type. Any top-level formulation or data source design spaces that remain on the platform can no longer be read by the SDK. Additionally, support for enumerated design spaces has been dropped entirely. All such design spaces will eventually be removed from the platform.
anoto-moniz
changed the title
kroenlein
reviewed
Jan 28, 2026
Collaborator
kroenlein
left a comment
kroenlein
left a comment
There was a problem hiding this comment.
Generally looks good. Only wondering if we've got the proper deprecations in place for retiring the namespaces.
| from citrine._serialization import properties | ||
| from citrine.informatics.data_sources import DataSource | ||
| from citrine.informatics.design_spaces.design_space import DesignSpace | ||
| from citrine.informatics.design_spaces.subspace import DesignSubspace |
Collaborator
There was a problem hiding this comment.
Is this technically a migration? It doesn't look like running
from citrine.informatics.design_spaces.design_space import DesignSpace
currently issues a deprecation warning. Am I missing something?
Collaborator
Author
There was a problem hiding this comment.
The deprecation warning is only issued if the user attempts to read or write any of the deprecated types.
kroenlein
approved these changes
Jan 28, 2026
Collaborator
kroenlein
left a comment
kroenlein
left a comment
There was a problem hiding this comment.
Seems to cover the bases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only product and hierarchical design spaces are allowed as the top-level design space type. Any top-level formulation or data source design spaces that remain on the platform can no longer be read by the SDK. Additionally, support for enumerated design spaces has been dropped entirely. All such design spaces will eventually be removed from the platform.
PR Type:
Adherence to team decisions