-
Notifications
You must be signed in to change notification settings - Fork 7
[v4.0] Make a bunch of updates to the docs. #1014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| --------------- | ||
|
|
||
| After registering an asset, the ``status`` command can be used to obtain a static readout of the state of the asset on the platform (e.g., VALID, INVALID, VALIDATING, SUCCEEDED, FAILED, INPROGRESS). | ||
| After registering an asset, the ``status`` command can be used to obtain a static readout of the state of the asset on the platform (e.g., READY, INVALID, VALIDATING, SUCCEEDED, FAILED, INPROGRESS). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ironically, VALID is not a valid state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not today, but I've created enumerated lists for these status fields in mock-client. We might want to just incorporate them into the main library.
| if project.name == project_name), None) | ||
| project = next((project for project in all_projects if project.name == project_name), None) | ||
|
|
||
| or use the :func:`~citrine.seeding.find_or_create.find_or_create_project` convenience method: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a reason we previously didn't mention find_or_create_project? Or was this just written before it was created?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably just legacy. Good add.
| Hierarchical Design Space | ||
| ------------------------- | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intentionally left blank for now. @jspeerless has offered to put together this section before release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrapping design spaces in ProductDesignSpace, dropping references to EnumeratedDesignSpace, and mentioning that DataSourceDesignSpace and FormulationDesignSpace must be part of a ProductDesignSpace.
| Validation status can be one of the following states: | ||
|
|
||
| - **Created:** The module/workflow has been registered with a project and has been queued for validation. | ||
| - **Created:** The module/workflow has been registered with a project, but validation has not begun. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although the SDK automatically starts validation, the UI does not. Also, in the SDK, you can prevent automatically training a predictor when registering or updating with train=False.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dehydrated predictors are no longer supported. Subpredictor training_data is hoisted up to the graph predictor in the backend; by disallowing it in the SDK, we can finally get rid of that code. And all the examples should register only GraphPredictor.
kroenlein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deltas look good, but it probably warrants a detailed reread by Product before release. As I think it planned.
| ======= | ||
|
|
||
| In version 4.0, :py:class:`Predictor Evaluation Workflows <citrine.resources.predictor_evaluation_workflow.PredictorEvaluationWorkflowCollection>` and :py:class:`Predictor Evaluation Executions <citrine.resources.predictor_evaluation_execution.PredictorEvaluationExecutionCollection>` (collectively, PEWs) will be merged into a single entity called :py:class:`Predictor Evaluations <citrine.resources.predictor_evaluation.PredictorEvaluationCollection>`. The new entity will retain the functionality of its predecessors, while simplyfing interactions with it. And it will support the continuing evolution of the platform. | ||
| `Predictor Evaluation Workflows` and `Predictor Evaluation Executions` (collectively, PEWs) have been merged into a single entity called :py:class:`Predictor Evaluations <citrine.resources.predictor_evaluation.PredictorEvaluationCollection>`. The new entity retains the functionality of its predecessors, while simplyfing interactions with it. And it will support the continuing evolution of the platform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `Predictor Evaluation Workflows` and `Predictor Evaluation Executions` (collectively, PEWs) have been merged into a single entity called :py:class:`Predictor Evaluations <citrine.resources.predictor_evaluation.PredictorEvaluationCollection>`. The new entity retains the functionality of its predecessors, while simplyfing interactions with it. And it will support the continuing evolution of the platform. | |
| `Predictor Evaluation Workflows` and `Predictor Evaluation Executions` (collectively, PEWs) have been merged into a single entity called :py:class:`Predictor Evaluations <citrine.resources.predictor_evaluation.PredictorEvaluationCollection>`. The new entity retains the functionality of its predecessors, while simplyfing interactions with it, while supporting the continuing evolution of the platform. |
Personal issue with starting a sentence with an And.
| --------------- | ||
|
|
||
| After registering an asset, the ``status`` command can be used to obtain a static readout of the state of the asset on the platform (e.g., VALID, INVALID, VALIDATING, SUCCEEDED, FAILED, INPROGRESS). | ||
| After registering an asset, the ``status`` command can be used to obtain a static readout of the state of the asset on the platform (e.g., READY, INVALID, VALIDATING, SUCCEEDED, FAILED, INPROGRESS). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not today, but I've created enumerated lists for these status fields in mock-client. We might want to just incorporate them into the main library.
| if project.name == project_name), None) | ||
| project = next((project for project in all_projects if project.name == project_name), None) | ||
|
|
||
| or use the :func:`~citrine.seeding.find_or_create.find_or_create_project` convenience method: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably just legacy. Good add.
Some was made incorrect by the v4.0 release, but there was also a lot of old information that hasn't been corrct for some time. I corrected as much of it as I could find. This deliberately omits a new section in the design space docs on hierarchical design spaces. That will be added separately, pre-release.
029a7b8 to
865ca6a
Compare
Some was made incorrect by the v4.0 release, but there was also a lot of old information that hasn't been corrct for some time. I corrected as much of it as I could find.
This deliberately omits a new section in the design space docs on hierarchical design spaces. That will be added separately, pre-release.
PR Type:
Adherence to team decisions