Skip to content

Conversation

@anoto-moniz
Copy link
Collaborator

Some was made incorrect by the v4.0 release, but there was also a lot of old information that hasn't been corrct for some time. I corrected as much of it as I could find.

This deliberately omits a new section in the design space docs on hierarchical design spaces. That will be added separately, pre-release.

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

---------------

After registering an asset, the ``status`` command can be used to obtain a static readout of the state of the asset on the platform (e.g., VALID, INVALID, VALIDATING, SUCCEEDED, FAILED, INPROGRESS).
After registering an asset, the ``status`` command can be used to obtain a static readout of the state of the asset on the platform (e.g., READY, INVALID, VALIDATING, SUCCEEDED, FAILED, INPROGRESS).
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ironically, VALID is not a valid state

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not today, but I've created enumerated lists for these status fields in mock-client. We might want to just incorporate them into the main library.

if project.name == project_name), None)
project = next((project for project in all_projects if project.name == project_name), None)

or use the :func:`~citrine.seeding.find_or_create.find_or_create_project` convenience method:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a reason we previously didn't mention find_or_create_project? Or was this just written before it was created?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably just legacy. Good add.

Comment on lines +123 to +125
Hierarchical Design Space
-------------------------

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentionally left blank for now. @jspeerless has offered to put together this section before release.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrapping design spaces in ProductDesignSpace, dropping references to EnumeratedDesignSpace, and mentioning that DataSourceDesignSpace and FormulationDesignSpace must be part of a ProductDesignSpace.

Validation status can be one of the following states:

- **Created:** The module/workflow has been registered with a project and has been queued for validation.
- **Created:** The module/workflow has been registered with a project, but validation has not begun.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the SDK automatically starts validation, the UI does not. Also, in the SDK, you can prevent automatically training a predictor when registering or updating with train=False.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dehydrated predictors are no longer supported. Subpredictor training_data is hoisted up to the graph predictor in the backend; by disallowing it in the SDK, we can finally get rid of that code. And all the examples should register only GraphPredictor.

@anoto-moniz anoto-moniz marked this pull request as ready for review January 23, 2026 19:04
@anoto-moniz anoto-moniz requested a review from a team as a code owner January 23, 2026 19:04
Copy link
Collaborator

@kroenlein kroenlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deltas look good, but it probably warrants a detailed reread by Product before release. As I think it planned.

=======

In version 4.0, :py:class:`Predictor Evaluation Workflows <citrine.resources.predictor_evaluation_workflow.PredictorEvaluationWorkflowCollection>` and :py:class:`Predictor Evaluation Executions <citrine.resources.predictor_evaluation_execution.PredictorEvaluationExecutionCollection>` (collectively, PEWs) will be merged into a single entity called :py:class:`Predictor Evaluations <citrine.resources.predictor_evaluation.PredictorEvaluationCollection>`. The new entity will retain the functionality of its predecessors, while simplyfing interactions with it. And it will support the continuing evolution of the platform.
`Predictor Evaluation Workflows` and `Predictor Evaluation Executions` (collectively, PEWs) have been merged into a single entity called :py:class:`Predictor Evaluations <citrine.resources.predictor_evaluation.PredictorEvaluationCollection>`. The new entity retains the functionality of its predecessors, while simplyfing interactions with it. And it will support the continuing evolution of the platform.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`Predictor Evaluation Workflows` and `Predictor Evaluation Executions` (collectively, PEWs) have been merged into a single entity called :py:class:`Predictor Evaluations <citrine.resources.predictor_evaluation.PredictorEvaluationCollection>`. The new entity retains the functionality of its predecessors, while simplyfing interactions with it. And it will support the continuing evolution of the platform.
`Predictor Evaluation Workflows` and `Predictor Evaluation Executions` (collectively, PEWs) have been merged into a single entity called :py:class:`Predictor Evaluations <citrine.resources.predictor_evaluation.PredictorEvaluationCollection>`. The new entity retains the functionality of its predecessors, while simplyfing interactions with it, while supporting the continuing evolution of the platform.

Personal issue with starting a sentence with an And.

---------------

After registering an asset, the ``status`` command can be used to obtain a static readout of the state of the asset on the platform (e.g., VALID, INVALID, VALIDATING, SUCCEEDED, FAILED, INPROGRESS).
After registering an asset, the ``status`` command can be used to obtain a static readout of the state of the asset on the platform (e.g., READY, INVALID, VALIDATING, SUCCEEDED, FAILED, INPROGRESS).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not today, but I've created enumerated lists for these status fields in mock-client. We might want to just incorporate them into the main library.

if project.name == project_name), None)
project = next((project for project in all_projects if project.name == project_name), None)

or use the :func:`~citrine.seeding.find_or_create.find_or_create_project` convenience method:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably just legacy. Good add.

Some was made incorrect by the v4.0 release, but there was also a lot of
old information that hasn't been corrct for some time. I corrected as
much of it as I could find.

This deliberately omits a new section in the design space docs on
hierarchical design spaces. That will be added separately, pre-release.
@anoto-moniz anoto-moniz merged commit 0418ae4 into release/v4.0 Jan 29, 2026
41 checks passed
@anoto-moniz anoto-moniz deleted the feature/update-docs branch January 29, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants