-
Notifications
You must be signed in to change notification settings - Fork 39
Migration from Azure to Github Actions #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jdegenstein
wants to merge
31
commits into
CadQuery:master
Choose a base branch
from
jdegenstein:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GH actions
Member
|
Thanks, it does look faster! I will try to take a look after the release is finished though - I don't want to enter another rabbit hole right now. |
Author
|
Sounds good, let me know if you want me to update this PR with any further changes that might occur. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the Azure "runs" seemed slow, so I decided to experiment with porting these "runs" to GitHub Actions. In the process of getting this working I noted that GitHub runners tend to execute somewhere around 36% faster. Absent any restrictions on runtime limits maybe this wouldn't be worth it -- but I noticed that some prior jobs simply failed because they exceeded said limits. Furthermore, being able to run additional jobs in a given day may make it easier to maintain CadQuery/OCP.
There are other benefits as well, such as direct integration of these workflows into this GitHub repository and it can possibly simplify access control and management of secrets as well. GitHub Actions also has a robust ecosystem of re-usable first and 3rd party actions that make it easier to add additional functionality to the workflows.
In the end, I was able to get all of the major steps working on GitHub actions. Creating the following artifacts:
Other notable details:
-j 1on the Windows compilation step to more closely reflect the workflow on Azure.Example jdegenstein/OCP GitHub Actions run with all artifacts attached:
https://github.com/jdegenstein/OCP/actions/runs/20280362367