Skip to content

Conversation

@skyc4ffe1ne
Copy link

Make script more portable and enable strict mode

@CCleanerShot
Copy link
Owner

CCleanerShot commented Oct 27, 2025

Some issus:

1.
Screenshot from 2025-10-27 11-38-31

Under here: https://github.com/CCleanerShot/cc-react/pull/2/files?diff=split&w=0#diff-05c749ef9bc981c3d82b0cf415a8652dfb298cc8183632b828e82f7fdcdc89beR5-R7

Colors like the foreground do not match the previous colors, as the foreground is left blank.

2.
https://github.com/CCleanerShot/cc-react/pull/2/files?diff=split&w=0#diff-876c076817b4e593cf797bdfa378ac3a24b6dc76c6f6408dd2f27da903bb331dR3

The annoying part about using set -e is that in reality, a number of commands (notice the 2> redirect from tsc) will return a non-zero (they may use numerical values from 1+ to define results, or to just be annoying), and you will have to handle each code. That's fine, but they are not handled with your latest commit.

3.
https://github.com/CCleanerShot/cc-react/pull/2/files?diff=split&w=0#diff-05c749ef9bc981c3d82b0cf415a8652dfb298cc8183632b828e82f7fdcdc89beR10

https://github.com/CCleanerShot/cc-react/pull/2/files?diff=split&w=0#diff-05c749ef9bc981c3d82b0cf415a8652dfb298cc8183632b828e82f7fdcdc89beR20

these are unused.

4.
https://github.com/CCleanerShot/cc-react/pull/2/files?diff=split&w=0#diff-876c076817b4e593cf797bdfa378ac3a24b6dc76c6f6408dd2f27da903bb331dR21

https://github.com/CCleanerShot/cc-react/pull/2/files?diff=split&w=0#diff-876c076817b4e593cf797bdfa378ac3a24b6dc76c6f6408dd2f27da903bb331dR27

these were meant to represent a conditional action, and set as a different color (hence they were on the original scripts)

edit: accidentally pressed enter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants