Skip to content

Conversation

@StephenMcConnel
Copy link
Contributor

@StephenMcConnel StephenMcConnel commented Apr 23, 2025

This change is Reviewable

@andrew-polk
Copy link
Contributor

Converting to draft as I think the introduction of the gap for other sizes is a show-stopper.
And I'm deprioritizing this card.

@andrew-polk andrew-polk marked this pull request as draft April 24, 2025 15:56
@StephenMcConnel StephenMcConnel force-pushed the BL-14614-OverlappingUI branch from 291d82a to 124f775 Compare April 24, 2025 22:06
Copy link
Contributor Author

@StephenMcConnel StephenMcConnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured out how to avoid increasing the gap when it's not needed.

Reviewable status: 0 of 2 files reviewed, all discussions resolved

@StephenMcConnel StephenMcConnel marked this pull request as ready for review April 24, 2025 22:09
Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @StephenMcConnel)


src/BloomBrowserUI/bookEdit/css/editMode.less line 1313 at r1 (raw file):

        top: -22px;
    }
}

It looks like we can do this dynamically with

.above-page-control-container {
    container-type: inline-size;
    container-name: above-page-control;
}
@container above-page-control (max-width: 450px) {
    #drag-activity-tab-control {
        top: -22px;
    }
}

(I don't what the 450 should be)

But I'm not sure this is sufficient.
Probably we need JH to take a look since the wrapped text looks bad to me. Particularly that the button and text next to it wrap differently (aren't lined up).
There's also a problem when zooming in. The controls appear to move up relative to the view and thus start to get cut off on top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants