Conversation
|
@codex review pls, rate X/5 merge confidence. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7c870087bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let folder = resolve_list_folder(cli, command_folder) | ||
| .cloned() | ||
| .unwrap_or_else(|| PathBuf::from(config::DEFAULT_FOLDER)); |
There was a problem hiding this comment.
The list command always falls back to config::DEFAULT_FOLDER when no --folder flag is passed, and it never consults the project config loader (e.g., iconmate.config.json) that the rest of the app uses for defaults. In projects that set a non-default folder in config, iconmate list will look in src/assets/icons and print “No icons found” even though icons exist in the configured folder unless users remember to pass --folder every time. This makes the new command inconsistent with configured defaults and will confuse users who rely on config.
Useful? React with 👍 / 👎.
1 participant
No description provided.