AGC improvements for LocalMicrophoneDriver#539
Merged
dooly123 merged 3 commits intoBasisVR:developerfrom Feb 19, 2026
Merged
Conversation
When sound is silence/bg noise, it shouldn't update the AGC. When sound is loud, AGC will hold its current level for a short period before trying to update
With a buffer the size of the sample rate, AGC will take 1 second to take effect. By performing AGC on a smaller chunk, the changes can take effect much faster. This change also changes denoising to use the smaller buffer. RollingRMS was also corrected to not average the values directly (which is incorrect as RMS is a non-linear scale) and instead average the power/mean square before taking the sqrt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: