Skip to content

Comments

Remove all StructuredBody fields from public results#6963

Merged
Jinming-Hu merged 2 commits intoAzure:mainfrom
Jinming-Hu:pr2
Feb 24, 2026
Merged

Remove all StructuredBody fields from public results#6963
Jinming-Hu merged 2 commits intoAzure:mainfrom
Jinming-Hu:pr2

Conversation

@Jinming-Hu
Copy link
Member

Pull Request Checklist

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the contributing guide.

  • C++ Guidelines
  • Doxygen docs
  • Unit tests
  • No unwanted commits/changes
  • Descriptive title/description
    • PR is single purpose
    • Related issue listed
  • Comments in source
  • No typos
  • Update changelog
  • Not work-in-progress
  • External references or docs updated
  • Self review of PR done
  • Any breaking changes?

Copilot AI review requested due to automatic review settings February 19, 2026 03:41
@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Feb 19, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the StructuredBodyType (x-ms-structured-body) surface from public result models in the Storage Blobs / Files Shares / Files DataLake SDKs, aligning the generated Swagger transforms with the C++ REST client result types.

Changes:

  • Updates Swagger transform directives to delete the x-ms-structured-body response header where it previously generated public result fields.
  • Removes StructuredBodyType from affected public result structs in generated rest_client.hpp.
  • Removes REST response-header parsing that populated StructuredBodyType in generated rest_client.cpp.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
sdk/storage/azure-storage-files-shares/swagger/README.md Deletes x-ms-structured-body from the UploadRange response headers in Swagger transforms.
sdk/storage/azure-storage-files-shares/src/rest_client.cpp Stops reading x-ms-structured-body into the UploadRange result model.
sdk/storage/azure-storage-files-shares/inc/azure/storage/files/shares/rest_client.hpp Removes StructuredBodyType from UploadFileRangeResult.
sdk/storage/azure-storage-files-datalake/swagger/README.md Deletes x-ms-structured-body from the Append response headers in Swagger transforms.
sdk/storage/azure-storage-files-datalake/src/rest_client.cpp Stops reading x-ms-structured-body into the Append result model.
sdk/storage/azure-storage-files-datalake/inc/azure/storage/files/datalake/rest_client.hpp Removes StructuredBodyType from AppendFileResult.
sdk/storage/azure-storage-blobs/swagger/README.md Deletes x-ms-structured-body from several Blob upload-related response headers in Swagger transforms.
sdk/storage/azure-storage-blobs/src/rest_client.cpp Stops reading x-ms-structured-body into several blob upload-related result models.
sdk/storage/azure-storage-blobs/inc/azure/storage/blobs/rest_client.hpp Removes StructuredBodyType from several blob upload-related public result structs.

@Jinming-Hu Jinming-Hu merged commit 15840d5 into Azure:main Feb 24, 2026
85 checks passed
@Jinming-Hu Jinming-Hu deleted the pr2 branch February 24, 2026 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants