Skip to content

Fix extension commands picking wrong version due to incorrect sort-order assumption #6914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hemarina merged 14 commits into from
Feb 28, 2026
Merged

Fix extension commands picking wrong version due to incorrect sort-order assumption #6914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
80e4ba8
Initial plan
Copilot Feb 26, 2026
eaf1a50
Fix extension upgrade picking oldest version due to descending regist…
Copilot Feb 26, 2026
56e87e4
Restore unrelated extension go.mod/go.sum files
Copilot Feb 26, 2026
f3cc488
Optimize LatestVersion to compare only first and last elements
Copilot Feb 27, 2026
0c91205
Update cli/azd/pkg/extensions/registry_cache_test.go
hemarina Feb 27, 2026
cc824fc
Update cli/azd/pkg/extensions/version_compatibility_test.go
hemarina Feb 27, 2026
e23ba6b
Fix LatestVersion to scan all elements and consolidate with manager.g…
Copilot Feb 27, 2026
b269f66
Remove unrelated extension go.mod/go.sum files from commit
Copilot Feb 27, 2026
a9bdb86
Consolidate latest version detection into Manager.GetLatestVersion
Copilot Feb 27, 2026
0d591bc
Revert Manager.GetLatestVersion; keep LatestVersion called from Insta…
Copilot Feb 27, 2026
dc2da64
Extract constraint-matching logic from manager.go Install into Latest…
Copilot Feb 27, 2026
6fecec0
Merge LatestVersionForConstraint into LatestVersion with optional var…
Copilot Feb 27, 2026
2f8242a
Revert LatestVersion to simple signature; restore inline constraint l…
Copilot Feb 27, 2026
ad48f73
fall back to last element
hemarina Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cli/azd/cmd/extension.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ func (a *extensionListAction) Run(ctx context.Context) (*actions.ActionResult, e
}

// Always show the true latest version
latestVersion := extension.Versions[len(extension.Versions)-1].Version
latestVersion := extensions.LatestVersion(extension.Versions).Version

var installedVersion string
var updateAvailable bool
Expand Down Expand Up @@ -536,7 +536,7 @@ func (a *extensionShowAction) Run(ctx context.Context) (*actions.ActionResult, e
return nil, err
}

latestVersion := registryExtension.Versions[len(registryExtension.Versions)-1]
latestVersion := extensions.LatestVersion(registryExtension.Versions)

var otherVersions []string
for _, version := range registryExtension.Versions {
Expand Down Expand Up @@ -706,7 +706,7 @@ func (a *extensionInstallAction) Run(ctx context.Context) (*actions.ActionResult
// Determine target version
targetVersion := a.flags.version
if targetVersion == "" || targetVersion == "latest" {
targetVersion = compatibleExtension.Versions[len(compatibleExtension.Versions)-1].Version
targetVersion = extensions.LatestVersion(compatibleExtension.Versions).Version
}

var extensionVersion *extensions.ExtensionVersion
Expand Down Expand Up @@ -1014,7 +1014,7 @@ func (a *extensionUpgradeAction) Run(ctx context.Context) (*actions.ActionResult
if a.flags.version != "" && a.flags.version != "latest" {
targetVersionStr = a.flags.version
} else {
targetVersionStr = compatibleExtension.Versions[len(compatibleExtension.Versions)-1].Version
targetVersionStr = extensions.LatestVersion(compatibleExtension.Versions).Version
}

// Parse semantic versions for proper comparison
Expand Down
55 changes: 31 additions & 24 deletions cli/azd/extensions/azure.appservice/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@ module azureappservice
go 1.25

require (
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.20.0
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.21.0
github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.13.1
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/appservice/armappservice/v2 v2.3.0
github.com/azure/azure-dev/cli/azd v0.0.0-20260122173819-89795b295491
github.com/fatih/color v1.18.0
github.com/spf13/cobra v1.10.1
github.com/spf13/cobra v1.10.2
)

require (
Expand All @@ -17,27 +17,30 @@ require (
github.com/Azure/azure-sdk-for-go/sdk/internal v1.11.2 // indirect
github.com/AzureAD/microsoft-authentication-library-for-go v1.6.0 // indirect
github.com/Masterminds/semver/v3 v3.4.0 // indirect
github.com/alecthomas/chroma/v2 v2.20.0 // indirect
github.com/alecthomas/chroma/v2 v2.23.1 // indirect
github.com/aymanbagabas/go-osc52/v2 v2.0.1 // indirect
github.com/aymerick/douceur v0.2.0 // indirect
github.com/bahlo/generic-list-go v0.2.0 // indirect
github.com/blang/semver/v4 v4.0.0 // indirect
github.com/braydonk/yaml v0.9.0 // indirect
github.com/buger/jsonparser v1.1.1 // indirect
github.com/charmbracelet/colorprofile v0.3.2 // indirect
github.com/cespare/xxhash/v2 v2.3.0 // indirect
github.com/charmbracelet/colorprofile v0.4.1 // indirect
github.com/charmbracelet/glamour v0.10.0 // indirect
github.com/charmbracelet/lipgloss v1.1.1-0.20250404203927-76690c660834 // indirect
github.com/charmbracelet/x/ansi v0.10.2 // indirect
github.com/charmbracelet/x/cellbuf v0.0.13 // indirect
github.com/charmbracelet/x/exp/slice v0.0.0-20251008171431-5d3777519489 // indirect
github.com/charmbracelet/x/term v0.2.1 // indirect
github.com/clipperhouse/uax29/v2 v2.2.0 // indirect
github.com/charmbracelet/x/ansi v0.11.6 // indirect
github.com/charmbracelet/x/cellbuf v0.0.15 // indirect
github.com/charmbracelet/x/exp/slice v0.0.0-20260204111555-7642919e0bee // indirect
github.com/charmbracelet/x/term v0.2.2 // indirect
github.com/clipperhouse/displaywidth v0.9.0 // indirect
github.com/clipperhouse/stringish v0.1.1 // indirect
github.com/clipperhouse/uax29/v2 v2.5.0 // indirect
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
github.com/dlclark/regexp2 v1.11.5 // indirect
github.com/drone/envsubst v1.0.3 // indirect
github.com/go-logr/logr v1.4.3 // indirect
github.com/go-logr/stdr v1.2.2 // indirect
github.com/golang-jwt/jwt/v5 v5.3.0 // indirect
github.com/golang-jwt/jwt/v5 v5.3.1 // indirect
github.com/golobby/container/v3 v3.3.2 // indirect
github.com/google/uuid v1.6.0 // indirect
github.com/gorilla/css v1.0.1 // indirect
Expand All @@ -48,6 +51,7 @@ require (
github.com/kylelemons/godebug v1.1.0 // indirect
github.com/lucasb-eyer/go-colorful v1.3.0 // indirect
github.com/mailru/easyjson v0.9.1 // indirect
github.com/mark3labs/mcp-go v0.43.2 // indirect
github.com/mattn/go-colorable v0.1.14 // indirect
github.com/mattn/go-isatty v0.0.20 // indirect
github.com/mattn/go-runewidth v0.0.19 // indirect
Expand All @@ -62,27 +66,30 @@ require (
github.com/rivo/uniseg v0.4.7 // indirect
github.com/santhosh-tekuri/jsonschema/v6 v6.0.2 // indirect
github.com/sethvargo/go-retry v0.3.0 // indirect
github.com/spf13/cast v1.10.0 // indirect
github.com/spf13/pflag v1.0.10 // indirect
github.com/stretchr/testify v1.11.1 // indirect
github.com/wk8/go-ordered-map/v2 v2.1.8 // indirect
github.com/xo/terminfo v0.0.0-20220910002029-abceb7e1c41e // indirect
github.com/yuin/goldmark v1.7.13 // indirect
github.com/yosida95/uritemplate/v3 v3.0.2 // indirect
github.com/yuin/goldmark v1.7.16 // indirect
github.com/yuin/goldmark-emoji v1.0.6 // indirect
go.opentelemetry.io/auto/sdk v1.2.1 // indirect
go.opentelemetry.io/otel v1.38.0 // indirect
go.opentelemetry.io/otel/metric v1.38.0 // indirect
go.opentelemetry.io/otel/sdk v1.38.0 // indirect
go.opentelemetry.io/otel/trace v1.38.0 // indirect
go.opentelemetry.io/otel v1.40.0 // indirect
go.opentelemetry.io/otel/metric v1.40.0 // indirect
go.opentelemetry.io/otel/sdk v1.40.0 // indirect
go.opentelemetry.io/otel/trace v1.40.0 // indirect
go.uber.org/atomic v1.11.0 // indirect
golang.org/x/crypto v0.46.0 // indirect
golang.org/x/exp v0.0.0-20250911091902-df9299821621 // indirect
golang.org/x/net v0.48.0 // indirect
golang.org/x/sys v0.39.0 // indirect
golang.org/x/term v0.38.0 // indirect
golang.org/x/text v0.32.0 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20251007200510-49b9836ed3ff // indirect
google.golang.org/grpc v1.76.0 // indirect
google.golang.org/protobuf v1.36.10 // indirect
golang.org/x/crypto v0.47.0 // indirect
golang.org/x/exp v0.0.0-20260112195511-716be5621a96 // indirect
golang.org/x/net v0.49.0 // indirect
golang.org/x/sys v0.40.0 // indirect
golang.org/x/term v0.39.0 // indirect
golang.org/x/text v0.33.0 // indirect
golang.org/x/time v0.14.0 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20260203192932-546029d2fa20 // indirect
google.golang.org/grpc v1.78.0 // indirect
google.golang.org/protobuf v1.36.11 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
)

Expand Down
Loading
Loading