Skip to content

Fix playlist table favorite action on web #13876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cursor wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −13
Draft

Fix playlist table favorite action on web #13876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3986102
Fix playlist table favorite action dispatch
cursoragent Mar 10, 2026
4beaa2c
Fix table favorite active icon class
cursoragent Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/web/src/components/table/components/TableFavoriteButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export const TableFavoriteButton = ({
<div
onClick={onClick}
className={cn(styles.tableFavoriteButton, className, {
[styles.notFavorited]: !favorited
[styles.favorited]: favorited
})}
>
<AnimatedIconButton
Expand Down
19 changes: 7 additions & 12 deletions packages/web/src/pages/collection-page/components/desktop/CollectionPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { useCallback, useMemo } from 'react'

import { useFavoriteTrack, useUnfavoriteTrack } from '@audius/common/api'
import {
Variant,
Status,
Expand All @@ -13,12 +12,14 @@ import {
import {
CollectionTrack,
CollectionsPageType,
tracksSocialActions,
usePremiumContentPurchaseModal,
PurchaseableContentType
} from '@audius/common/store'
import { removeNullable } from '@audius/common/utils'
import { Divider, Flex, Paper, Text } from '@audius/harmony'
import { Id } from '@audius/sdk'
import { useDispatch } from 'react-redux'

import { CollectionDogEar } from 'components/collection'
import { CollectionHeader } from 'components/collection/desktop/CollectionHeader'
Expand Down Expand Up @@ -86,6 +87,7 @@ type CollectionPageProps = {
}

const CollectionPage = ({ type }: CollectionPageProps) => {
const dispatch = useDispatch()
const mainContentRef = useMainContentRef()
const {
collection,
Expand Down Expand Up @@ -127,23 +129,16 @@ const CollectionPage = ({ type }: CollectionPageProps) => {
[openPremiumContentModal]
)

const { mutate: favoriteTrack } = useFavoriteTrack()
const { mutate: unfavoriteTrack } = useUnfavoriteTrack()
const { saveTrack, unsaveTrack } = tracksSocialActions
const toggleSaveTrack = useCallback(
(track: Track) => {
if (track.has_current_user_saved) {
unfavoriteTrack({
trackId: track.track_id,
source: FavoriteSource.COLLECTION_PAGE
})
dispatch(unsaveTrack(track.track_id, FavoriteSource.COLLECTION_PAGE))
} else {
favoriteTrack({
trackId: track.track_id,
source: FavoriteSource.COLLECTION_PAGE
})
dispatch(saveTrack(track.track_id, FavoriteSource.COLLECTION_PAGE))
}
},
[favoriteTrack, unfavoriteTrack]
[dispatch, saveTrack, unsaveTrack]
)

// Compute values needed for useMemo (handle undefined collection case)
Expand Down