Move redirect URI validation to backend for non-registered case#721
Merged
rickyrombo merged 3 commits intomainfrom Mar 15, 2026
Merged
Move redirect URI validation to backend for non-registered case#721rickyrombo merged 3 commits intomainfrom
rickyrombo merged 3 commits intomainfrom
Conversation
4 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Updates OAuth authorization redirect URI validation so that apps with no registered redirect URIs (legacy/unconfigured) are validated by a backend format-based policy rather than accepting any value, while still requiring exact matches for apps that have registered URIs.
Changes:
- Add backend fallback validation for
redirect_uriwhen a client has no registered redirect URIs (http/https or postmessage; block creds/fragment/traversal/non-loopback IPs). - Refactor and expand OAuth authorize tests to cover accepted/rejected legacy redirect URI formats.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| api/v1_oauth.go | Implements fallback redirect_uri format validation when no URIs are registered. |
| api/v1_oauth_test.go | Adds helper seeding + multiple test cases for the new legacy validation rules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches what is in https://github.com/AudiusProject/apps/blob/fc87e67a77d66cb47491740ff51e5c37fb2f7996/packages/web/src/pages/oauth-login-page/utils.ts#L13 but only runs on non-registered URIs. This way, custom mobile schemes can be registered and considered valid.