Keep MetricsCollector enabled in local dev; only disable RateLimitMiddleware#716
Merged
rickyrombo merged 3 commits intomjp-rate-limit-devfrom Mar 11, 2026
Merged
Conversation
…itMiddleware Co-authored-by: rickyrombo <3690498+rickyrombo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on disabling rate limits in local dev setup
Keep MetricsCollector enabled in local dev; only disable RateLimitMiddleware
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous change mistakenly disabled both
metricsCollectorandrateLimitMiddlewarein local dev environments. Only rate limiting should be skipped in local dev.Changes
api/server.go: Split the single initialization guard into two separate conditions:metricsCollector— gated onwritePool != nil && config.Env != "test"(enabled in local dev)rateLimitMiddleware— additionally gated on!isLocalDev(disabled in local dev)💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.