Skip to content

Initializer parameter naming#92

Merged
ArcadeMode merged 5 commits intomasterfrom
initializer-param-name
Mar 1, 2026
Merged

Initializer parameter naming#92
ArcadeMode merged 5 commits intomasterfrom
initializer-param-name

Conversation

@ArcadeMode
Copy link
Owner

@ArcadeMode ArcadeMode commented Mar 1, 2026

jsObject was technically correct but didnt convey much intent to the user, this was especially apparent after including it in constructor comments. New name is initializer to convey what it does.

Added some e2e tests for different parameterized constructors too

@ArcadeMode ArcadeMode added this to the v1.4.0 milestone Mar 1, 2026
@github-actions
Copy link

github-actions bot commented Mar 1, 2026

Test Results

    9 files     73 suites   36s ⏱️
  695 tests   691 ✅  4 💤 0 ❌
1 986 runs  1 961 ✅ 25 💤 0 ❌

Results for commit f12e210.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 1, 2026


BenchmarkDotNet v0.15.8, Linux Ubuntu 24.04.3 LTS (Noble Numbat)
AMD EPYC 7763 2.63GHz, 1 CPU, 4 logical and 2 physical cores
.NET SDK 10.0.103
  [Host]     : .NET 10.0.3 (10.0.3, 10.0.326.7603), X64 RyuJIT x86-64-v3
  Job-MLTFGY : .NET 10.0.3 (10.0.3, 10.0.326.7603), X64 RyuJIT x86-64-v3

InvocationCount=1  IterationCount=1  LaunchCount=10  
RunStrategy=ColdStart  UnrollFactor=1  WarmupCount=0  

Method Compilation ClassCount Mean Error StdDev Min Max
Generate AOT 0 14.91 ms 0.712 ms 0.471 ms 14.32 ms 16.03 ms
Generate AOT 1 32.92 ms 1.187 ms 0.785 ms 31.02 ms 33.99 ms
Generate AOT 10 32.30 ms 1.309 ms 0.866 ms 31.42 ms 34.44 ms
Generate AOT 25 44.77 ms 0.964 ms 0.637 ms 43.70 ms 45.60 ms
Generate AOT 50 57.25 ms 2.440 ms 1.614 ms 54.84 ms 59.47 ms
Generate AOT 100 92.73 ms 3.650 ms 2.414 ms 89.46 ms 96.00 ms
Generate AOT 200 95.85 ms 1.695 ms 1.121 ms 94.33 ms 98.25 ms
Generate JIT 0 43.66 ms 0.524 ms 0.347 ms 43.27 ms 44.16 ms
Generate JIT 1 822.08 ms 14.874 ms 9.838 ms 808.15 ms 837.55 ms
Generate JIT 10 824.45 ms 16.683 ms 11.035 ms 810.80 ms 844.65 ms
Generate JIT 25 864.39 ms 15.041 ms 9.949 ms 847.66 ms 881.58 ms
Generate JIT 50 890.22 ms 13.942 ms 9.221 ms 878.02 ms 905.39 ms
Generate JIT 100 990.07 ms 13.565 ms 8.972 ms 978.11 ms 1,007.38 ms
Generate JIT 200 977.50 ms 17.032 ms 11.266 ms 959.29 ms 991.38 ms

@ArcadeMode ArcadeMode changed the title Better name for initializer parameter Initializer parameter naming Mar 1, 2026
@ArcadeMode ArcadeMode merged commit 36361fb into master Mar 1, 2026
13 checks passed
@ArcadeMode ArcadeMode deleted the initializer-param-name branch March 1, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant