Refactor timing: Code review issues, masks refactoring in progress

[shamansir]

No description provided.

[shamansir]

@skavish please take a look

[shamansir]

@skavish I am uncertain in this part. The matrix is calculated once, but current bounds affect the mask canvas size. Is it safe to move it to mask render cycle?

[skavish]

mask canvas size does not change during one rendering cycle. the masked elements and the mask itself are rendered into canvases the same size.

you need to draw all masked elements into a canvas first, then (after all masked elements are rendered) you need to render mask itself

[shamansir]

I've made a draft for this, not yet tested: refactor-timing...refactor-masks. I will ensure if order of rendering (masked elements before mask itself) is right later, but may be you'll see some pitfalls obvious for you.

[skavish]

I want to comment there, but I cannot comment on a diff, only on pullrequest

[shamansir]

You are welcome: #368 :)