Support multiple Microsoft cookie payload formats#961
Open
FoxYolk wants to merge 1 commit intoAlexProgrammerDE:mainfrom
Open
Support multiple Microsoft cookie payload formats#961FoxYolk wants to merge 1 commit intoAlexProgrammerDE:mainfrom
FoxYolk wants to merge 1 commit intoAlexProgrammerDE:mainfrom
Conversation
Replace the simple line-based parsing in loadFromString with splitAccountPayloads to better handle MICROSOFT_JAVA_COOKIES payloads. The new method trims input, returns empty for blank data, and for Microsoft cookie auth can detect cookie-jar (tab-separated entries containing login.live.com) or CookieEditor JSON arrays (simple starts/ends and contains "name"/"value"). Those formats are split on double-newlines, stripped, filtered and deduplicated; otherwise the original line-based splitting/stripping/filtering/distinct behavior is used. Added helper predicates looksLikeCookieJar and looksLikeCookieEditorJson.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the simple line-based parsing in loadFromString with splitAccountPayloads to better handle MICROSOFT_JAVA_COOKIES payloads. The new method trims input, returns empty for blank data, and for Microsoft cookie auth can detect cookie-jar (tab-separated entries containing login.live.com) or CookieEditor JSON arrays (simple starts/ends and contains "name"/"value"). Those formats are split on double-newlines, stripped, filtered and deduplicated; otherwise the original line-based splitting/stripping/filtering/distinct behavior is used. Added helper predicates looksLikeCookieJar and looksLikeCookieEditorJson.