Open
Conversation
CheezItMan
reviewed
Jan 28, 2022
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Aida, you hit the learning goals here. Well done. I left some minor comments, let me know what questions you have.
Comment on lines
2
to
7
| def grouped_anagrams(strings): | ||
| """ This method will return an array of arrays. | ||
| Each subarray will have strings which are anagrams of each other | ||
| Time Complexity: ? | ||
| Space Complexity: ? | ||
| Time Complexity: O(n) | ||
| Space Complexity: O(n) | ||
| """ |
There was a problem hiding this comment.
👍 , Time/space are correct if the words are limited in length (like English words) Otherwise it would be O(n * m log m) where m is the length of each word.
Comment on lines
24
to
29
| def top_k_frequent_elements(nums, k): | ||
| """ This method will return the k most common elements | ||
| In the case of a tie it will select the first occuring element. | ||
| Time Complexity: ? | ||
| Space Complexity: ? | ||
| Space Complexity: O(n) | ||
| """ |
There was a problem hiding this comment.
👍 Because of the loop in lines 40-43, the time complexity is O(nk) because you have a loop going k times and each time finding the max element from the frequency map.
| return result | ||
|
|
||
|
|
||
| def valid_sudoku(table): |
There was a problem hiding this comment.
board dictionary is not reset when checking the columns or subgrids.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hash Table Practice
Congratulations! You're submitting your assignment!
Comprehension Questions