Open
Conversation
- Update CSS variables to use Inter (UI) and Space Mono (mono/numbers) - Replace all font-inter → font-sans, font-space-mono → font-mono - Remove .pro-* classes from globals.css (competing design system) - Replace pro-* class usage in components with semantic equivalents - Fix scrollbar colors to use CSS variables instead of hardcoded hex
Replace 313 instances of hardcoded slate-*/indigo-* Tailwind colors across 20+ component files with CSS variable-based semantic tokens: - bg-slate-* → bg-muted, bg-card, bg-background - text-slate-* → text-foreground, text-muted-foreground - border-slate-* → border-border - bg/text-indigo-* → bg/text-primary - ring-indigo-* → ring-ring - red/green-* → destructive/success tokens Also fixes: - dropdown-menu.tsx hardcoded colors → semantic tokens - ReceiptScanner image viewer controls → foreground tokens - motion-reduce:animate-none added to EmptyStates and MobileFirstUI - ARIA label added to ProBillBreakdownView share graph bars
- Extract PERSON_COLORS, SPLIT_METHOD_OPTIONS, formatCurrency to lib/design-tokens.ts - Extract SplitSimpleIcon to components/SplitSimpleIcon.tsx - Extract GridCell to components/GridCell.tsx - Extract bill calculations to hooks/use-bill-calculations.ts - Update all imports (MobileSpreadsheetView, MobileCardView) - ProBillSplitter: 2121 → 1932 lines
Remove unused utility classes: .drag-handle, .receipt-line-dashed, .receipt-input, .float-panel, .glass-header, .floating-dock, .dock-divider, .ledger-expand-btn globals.css: 1170 → 978 lines (-192 lines of dead CSS)
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 similar comment
|
Coverage after merging receipt-theme-refactor into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
1. Replace built-in ease-out with custom cubic-bezier curves 2. Fix prefers-reduced-motion: keep opacity crossfades instead of killing all animation (polish-dont-remove-all) 3. Simplify ledger-row hover to bg-color only (props-transform-opacity) 4. Asymmetric btn-press timing: 80ms press, 200ms release 5. Limit animate-bounce to 3 iterations instead of infinite 6. Reduce CelebrationOverlay timeout 1200ms→300ms, AddPersonForm 500→250ms 7. Remove --duration-slow (0.4s) and --duration-slower (0.6s) 8. Add will-change:transform to rAF-animated number components 9. Fix mobile button scale 0.95→0.97 (transform-scale-097) 10. Remove mislabeled --ease-smooth variable
|
Coverage after merging receipt-theme-refactor into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
1 similar comment
|
Coverage after merging receipt-theme-refactor into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
- Add htmlFor to person editor labels (Display Name, Color Theme) - Add name/autoComplete to person name input - Add role="radiogroup" + aria-labelledby to color picker - Add hidden <h1> for heading hierarchy (was jumping to <h2>) - Add touch-action: manipulation to app shell - Fix footer link hover (was same color as rest state) - Fix active:scale-95 → scale-[0.97] on person assignment cards - Remove duplicate overflow-auto classes (3 instances)
|
Coverage after merging receipt-theme-refactor into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
1 similar comment
|
Coverage after merging receipt-theme-refactor into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bg-card,text-foreground,bg-primary, etc.) — making the app fully themeable and dark-mode readyfont-sans/font-monoGridCell,SplitSimpleIcon,use-bill-calculationshook,design-tokensmotion-reduce:animate-noneon animated elements, ARIA labels on share graph bars, dropdown-menu semantic tokensTest plan
npm run buildpasses cleannpm test)slate-/indigo-colors remain in components