Add a payu init script to auto-generate updated diag_table after payu…#86
Add a payu init script to auto-generate updated diag_table after payu…#86minghangli-uni wants to merge 3 commits intomainfrom
Conversation
|
Not for production use - just a helper for testing diagnostic changes using experiment-generator/runner. Would anyone mind reviewing it? @ACCESS-NRI/ocean @aekiss ? EDIT: Apologies - this is quite an old PR and doesnt include the recent config updates. I'll update it and ping again for another review. |
|
|
||
| case $MODEL in | ||
| access-om3) | ||
| DEST="diagnostic_profiles/source_yaml_files/make_diag_table" |
There was a problem hiding this comment.
wrong path - see ACCESS-NRI/access-om3-configs#959
| cd $BASE | ||
| echo "-- Cloned make_diag_table repo to $DEST" | ||
|
|
||
| if [ $MODEL = "access-om2" ]; then |
There was a problem hiding this comment.
or access-om3 - see ACCESS-NRI/access-om3-configs#959
| mkdir -p $BASE | ||
|
|
||
| rm -rf $DEST | ||
| git clone https://github.com/COSIMA/make_diag_table $DEST |
There was a problem hiding this comment.
this will update to whatever is the latest, which breaks provenance - would be better to have make_diag_table as a submodule
aekiss
left a comment
aekiss
left a comment
There was a problem hiding this comment.
I'm not sure why you'd want to do it this way. It would be neater and have proper provenance to include make_diag_table as a git submodule
|
or use |
|
I think we want to add |
I remember this being discussed a while ago and we were seeking approval from @aekiss on making |
minghangli-uni
force-pushed
the
85-payu-init-diag_table-generation
branch
from
62669f3 to
b2c9bb1
Compare
|
I'm happy for payu to depend on make_diag_table, but it sounds more like something @aidanheerdegen or team would be better positioned to approve |
|
I APPROVE! |
|
@aekiss are you okay with me moving |
|
I suppose, if it's actually necessary |
|
Necessary, no. Though if we are going to deploy to our conda channel it does make things a little cleaner. We'll likely move to yaml file support in FMS with the next ACCESS-OM3 release and this may change how we want to handle these files anyway. So let's just leave in the COSIMA org for now and I'll only just the ability to install with pip. |
4 participants
closes #85
This PR introduces a Payu init script that automates running
make_diag_table.pywhen using the experiment generator and experiment runner workflow.With this change, users no longer need to manually execute:
after creating branches.
This is Intended primarily for testing and development, not for production runs.