Support non-periodic longitude in regional bottom roughness calculations#113
Closed
minghangli-uni wants to merge 1 commit intomainfrom
Closed
Support non-periodic longitude in regional bottom roughness calculations#113minghangli-uni wants to merge 1 commit intomainfrom
minghangli-uni wants to merge 1 commit intomainfrom
Conversation
Contributor
|
Is this the PR you wanted me to look at @minghangli-uni ? It's still in draft. |
Collaborator
Author
|
Yeah this is still a draft. There are nans appearing in wet cells for the regional configuration and I am investigating it at the moment. |
Collaborator
Author
|
Had a bit of a brain fade there... Our panan configuration is also periodic in longitude, so the existing script works just fine for it. But this would still be an issue for genuinely regional configs. Since it’s not a priority at the moment, I'll close this for now. Happy to reopen it if and when we decide to prioritise regional support. Dropping the error here so I don't lose it later... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #112
In regional grid, longitude does not wrap hence in this PR, only use neighbours that are inside the domain and skip neighbours outside bounds. So this is basically a homogenous Neumann boundary condition