Skip to content

Proposal: converting Integer with DataView #29

@dukelec

Description

@dukelec

First of all, thank you for your work.

Currently only float is being converted using DataView, why not use DataView to convert Integer uniformly?
If we all use DataView, the code will be shorter and easier to read, also less prone to errors.

Recently I needed to use the little-endian version of msgpack.
I modified a python library and all I had to do to modify the endianness was to change the symbol ">" to "<".
To modify the javascript library, I only had to change the DataView functions parameter from false to true, but since you don't use DataView, it's a bit confusing: https://github.com/dukelec/msgpackel

Modification for the python library:

Screenshot_2021-10-18_18-03-22

Modification for the javascript library:

Screenshot_2021-10-18_18-02-19

Screenshot_2021-10-18_18-01-55

Screenshot_2021-10-18_18-01-15

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions