Exception rendering with other view renderers

[DevPandi]

Tempest version

3.0.1

PHP version

8.4

Operating system

macOS

Description

Hello everyone,

On the one hand, I'm excited about version 3.0.1 and the new features, but at the same time—and now I'm being a typical Berliner—you've totally messed up the exception handling.

You offer the option to replace the template engine, which is a great idea. However, with your new exception handling, you're triggering a cascade of errors that makes debugging impossible during development and theoretically means that I not only have to replace the template engine, but also the entire exception handling.

It would be important at this point for you to overwrite the ViewRenderer/TemplateRenderer in the appropriate place for your exception handling.

I generally find it a bit unsightly that you use such a “complex” solution for exceptions, but that's just a matter of personal taste.

Steps to reproduce

Use Twig or Blade as Renderer for the Views.

[DevPandi]

Since I don't really have the time to do more right now, I took a look at it and managed to do it.

The sendContent method in GenericResponseSender would have to be adjusted accordingly.

`private function sendContent(Response $response): void
{
if ($response instanceof EventStream) {
$this->sendEventStream($response);
return;
}

    $body = $response->body;

    if ($response instanceof File || $response instanceof Download) {
        readfile($body);
    } elseif (is_array($body) || $body instanceof JsonSerializable) {
        echo json_encode($body);
    } elseif ($body instanceof View) {
        if ($response instanceof DevelopmentException) {
            $viewRenderer = $this->container->get(TempestViewRenderer::class);
            echo $viewRenderer->render($response->body);
        } else {
            echo $this->viewRenderer->render($body);
        }
    } else {
        echo $body;
    }

    ob_flush();
}`

It's just the quick fix.

[brendt]

Thank you, typical Berliner! Appreciate the feedback, we're going to look into this, I agree it's something that should be better, and frankly we simply forgot about it 😅

[brendt]

@innocenzi let's sync on this. I'm happy to make the fix but I'd like your input

[innocenzi]

@DevPandi sorry for the "unsightly" engineering here, this oversight is fixed in #1968.

[brendt]

Fixed in 3.1.0: https://github.com/tempestphp/tempest-framework/releases/tag/v3.1.0