Skip to content

Invalid return for signed bytes in GetNumberSize #14

@jtsylve

Description

@jtsylve

if (value < byte.MinValue || value > byte.MaxValue) return B2;

This function returns an invalid number of bytes for signed 8-bit integers. I believe the check should be referencing SByte.MinValue and SByte.MaxValue rather than byte.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions