support extracting zip archives

[maxfisher-g]

Some packages such as proactive-jupyter-kernel upload their source as a zip file which currently fails as the static analysis archive extraction expects a .tar.gz file.

We should do filetype detection using file (NOT the file extension) so that we can do static analysis on zip archives too

[gliptak]

code to be updated seem to be at

package-analysis/internal/utils/archive_extract.go

Line 16 in c473e2d

func ExtractTarGzFile(tgzPath string, outputDir string) error {

might you be open to introducing something like https://github.com/mholt/archiver?

[maxfisher-g]

Hi @gliptak, yes that's a good suggestion! I'd be open to introducing something like that. Please feel free to submit a PR.

[tiegz]

@maxfisher-g I could give that a shot if you assign me to this?

[tiegz]

PR here: #1108

[gliptak]

#1035 also implemented this functionality (with support for additional archive types) ...

[tiegz]

@gliptak 😭 I totally missed that

[maxfisher-g]

Hi @gliptak @tiegz, so sorry for the silence on this. I am no longer working with this project, and I believe @calebbrown is the sole maintainer now.

@gliptak from memory I think there was some hesitation to merge your PR because of introducing extra third party dependencies (it was around the time of the xz incident). Sorry to leave you hanging.

Unfortunately I can't comment on whether either PR will be merged, though.