[Exposure request]: Publisher Event "OnBeforeCalculateSalesTax" for Report 1305 / 1303 same like 1304

[preetgor]

Describe the request

Describe the issue
Microsoft has marked reports (204, 205, 206, 207) as "Obsolete" with Obsolete status "Pending" and Reason "Replaced with the report below Standard.

Report 204 will be replaced by Report 1304.
Report 205 will be replaced by Report 1305.
Report 206 will be replaced by Report 1306.
Report 207 will be replaced by Report 1307

Current :
As reports will be replaced in future BC releases and we want to add integration to all respective Reports. Based on old git hub ticket MS added events to 1304 / 1306 / 1307 against https://github.com/microsoft/ALAppExtensions/issues/6507and #12884

and #22825
Report | Comments -- | -- report 1304 "Standard Sales - Quote" | MS made changes as requested OnAfterCalculateSalesTax / OnBeforeCalculateSalesTax report 1305 "Standard Sales - Order Conf." | MS changes not found against #6507 and #12884 report 1306 "Standard Sales - Invoice" | MS made changes as requested OnAfterCalculateSalesTax / OnBeforeCalculateSalesTax report 1307 "Standard Sales - Credit Memo" | MS made changes as requested OnAfterCalculateSalesTax / OnBeforeCalculateSalesTax
Expected :
Need publisher event and respective code for OnAfterCalculateSalesTax / OnBeforeCalculateSalesTax on Report 1305
Need publisher event and respective code for OnAfterCalculateSalesTax / OnBeforeCalculateSalesTax on Report 1303

As of the latest Business Central build (BC 22.2), the events requested for above reports are still missing. Please let us know the major/minor release details in which the fix is available. as of the latest ticket is it fixed in Build ID: 10902 #22825

Versions:
Version: US Business Central 25.0

Microsoft has marked reports (204, 205, 206, 207) as "Obsolete" with Obsolete status "Pending" and Reason "Replaced with the report below Standard.
Report 204 will be replaced by Report 1304.
Report 205 will be replaced by Report 1305.
Report 206 will be replaced by Report 1306.
Report 207 will be replaced by Report 1307

Current :
As reports will be replaced in future BC releases and we want to add integration to all respective Reports. Based on old git hub ticket MS added events to 1304 / 1306 / 1307 against https://github.com/microsoft/ALAppExtensions/issues/6507and #12884

and #22825
Report Comments
report 1304 "Standard Sales - Quote" MS made changes as requested OnAfterCalculateSalesTax / OnBeforeCalculateSalesTax
report 1305 "Standard Sales - Order Conf." MS changes not found against #6507 and #12884
report 1306 "Standard Sales - Invoice" MS made changes as requested OnAfterCalculateSalesTax / OnBeforeCalculateSalesTax
report 1307 "Standard Sales - Credit Memo" MS made changes as requested OnAfterCalculateSalesTax / OnBeforeCalculateSalesTax
Expected :
Need publisher event and respective code for OnAfterCalculateSalesTax / OnBeforeCalculateSalesTax on Report 1305 with following parameters
(var SalesHeader: Record "Sales Header"; var SalesLine: Record "Sales Line"; var VATAmountLine: Record "VAT Amount Line")
Need publisher event and respective code for OnAfterCalculateSalesTax / OnBeforeCalculateSalesTax on Report 1303 with following parameters
(var SalesHeader: Record "Sales Header"; var SalesLine: Record "Sales Line"; var VATAmountLine: Record "VAT Amount Line")

We have suggestion from microsoft to use below events

OnHeaderOnAfterGetRecordOnAfterUpdateVATOnLines
OnLineOnAfterGetRecordOnAfterCalcTotals
But both the events dont have var VATAmountLine: Record "VAT Amount Line" as a parameter

As of the latest Business Central build (BC 25.0), the events requested for above reports are still missing. #24012

Versions:
Version: US Business Central 25.0

Additional context

Need publisher event and respective code for OnAfterCalculateSalesTax / OnBeforeCalculateSalesTax on Report 1305 with following parameters
(var SalesHeader: Record "Sales Header"; var SalesLine: Record "Sales Line"; var VATAmountLine: Record "VAT Amount Line")
Need publisher event and respective code for OnAfterCalculateSalesTax / OnBeforeCalculateSalesTax on Report 1303 with following parameters
(var SalesHeader: Record "Sales Header"; var SalesLine: Record "Sales Line"; var VATAmountLine: Record "VAT Amount Line")

We have suggestion from microsoft to use below events

OnHeaderOnAfterGetRecordOnAfterUpdateVATOnLines
OnLineOnAfterGetRecordOnAfterCalcTotals
But both the events dont have var VATAmountLine: Record "VAT Amount Line" as a parameter

As of the latest Business Central build (BC 25.0), the events requested for above reports are still missing. #24012
Internal work item: AB#561530

[pri-kise]

report 1303 "Standard Sales - Draft Invoice"

In report 1303 "Standard Sales - Draft Invoice" there's the event OnHeaderOnAfterGetRecordOnAfterUpdateVATOnLines that provides acces to the VATAmountLine.

    [IntegrationEvent(false, false)]
    local procedure OnHeaderOnAfterGetRecordOnAfterUpdateVATOnLines(var SalesHeader: Record "Sales Header"; var SalesLine: Record "Sales Line"; var VATAmountLine: Record "VAT Amount Line")
    begin
    end;

https://github.com/StefanMaron/MSDyn365BC.Code.History/blob/us-27/BaseApp/Source/Base%20Application/Sales/Document/StandardSalesDraftInvoice.Report.al

Requested Change (If I understand your request correctly):
Add Event OnHeaderOnAfterGetRecordOnBeforeCalcSalesTaxLines

            trigger OnAfterGetRecord()
            var
            begin
                ...
                Line.CalcVATAmountLines(0, Header, Line, VATAmountLine);
                Line.UpdateVATOnLines(0, Header, Line, VATAmountLine);
                OnHeaderOnAfterGetRecordOnBeforeCalcSalesTaxLines(Header, Line, VATAmountLine); //NEW EVENT
                Line.CalcSalesTaxLines(Header, Line);
                OnHeaderOnAfterGetRecordOnAfterUpdateVATOnLines(Header, Line, VATAmountLine);

    [IntegrationEvent(false, false)]
    local procedure OnHeaderOnAfterGetRecordOnBeforeCalcSalesTaxLines(var SalesHeader: Record "Sales Header"; var SalesLine: Record "Sales Line"; var VATAmountLine: Record "VAT Amount Line")
    begin
    end;

---

report 1304 "Standard Sales - Quote"
In report 1304 "Standard Sales - Quote" there's the event OnBeforeCalculateSalesTax.
The name is a little bit misleading, but currently this event is called after CalcSalesTaxLines.

            trigger OnAfterGetRecord()
            begin
                FirstLineHasBeenOutput := false;
                Clear(Line);
                Clear(SalesPost);
                VATAmountLine.DeleteAll();
                Line.DeleteAll();
                SalesPost.GetSalesLines(Header, Line, 0);
                OnBeforeCalcVATAmountLines(Header, Line);
                Line.CalcVATAmountLines(0, Header, Line, VATAmountLine);
                Line.UpdateVATOnLines(0, Header, Line, VATAmountLine);
                OnLineOnAfterGetRecordOnAfterUpdateVATOnLines(Header, Line);
                Line.CalcSalesTaxLines(Header, Line);
                OnBeforeCalculateSalesTax(Header, Line, VATAmountLine);

https://github.com/StefanMaron/MSDyn365BC.Code.History/blob/us-27/BaseApp/Source/Base%20Application/Sales/Document/StandardSalesQuote.Report.al

Requested Change (If I understand your request correctly):
Add VATAmountLine to event OnLineOnAfterGetRecordOnAfterUpdateVATOnLines

                Line.UpdateVATOnLines(0, Header, Line, VATAmountLine);
                //>Change
                //OnLineOnAfterGetRecordOnAfterUpdateVATOnLines(Header, Line);
                OnLineOnAfterGetRecordOnAfterUpdateVATOnLines(Header, Line, VATAmountLine);
                //<Change
                Line.CalcSalesTaxLines(Header, Line);
                OnBeforeCalculateSalesTax(Header, Line, VATAmountLine);

    [IntegrationEvent(false, false)]
    //>>Change
    //local procedure OnLineOnAfterGetRecordOnAfterUpdateVATOnLines(var SalesHeader: Record "Sales Header"; var SalesLine: Record "Sales Line")
    local procedure OnLineOnAfterGetRecordOnAfterUpdateVATOnLines(var SalesHeader: Record "Sales Header"; var SalesLine: Record "Sales Line"; var VATAmountLine: Record "VAT Amount Line")
    //<<Change
    begin
    end;

---

report 1305 "Standard Sales - Order Conf."

in report 1305 "Standard Sales - Order Conf." there is already one of the requested event:
https://github.com/StefanMaron/MSDyn365BC.Code.History/blame/us-27/BaseApp/Source/Base%20Application/Sales/Document/StandardSalesOrderConf.Report.al

Requested Change (If I understand your request correctly):
Add Event OnHeaderOnAfterGetRecordOnBeforeCalcSalesTaxLines before Line.CalcSalesTaxLines

            trigger OnAfterGetRecord()
            begin
                ...
                Line.CalcVATAmountLines(0, Header, Line, VATAmountLine);
                Line.UpdateVATOnLines(0, Header, Line, VATAmountLine);
                OnHeaderOnAfterGetRecordOnBeforeCalcSalesTaxLines(Header, Line, VATAmountLine); //NEW EVENT
                Line.CalcSalesTaxLines(Header, Line);
                OnHeaderOnAfterGetRecordOnAfterUpdateVATOnLines(Header, Line, VATAmountLine);

    [IntegrationEvent(false, false)]
    local procedure OnHeaderOnAfterGetRecordOnBeforeCalcSalesTaxLines(var SalesHeader: Record "Sales Header"; var SalesLine: Record "Sales Line"; var VATAmountLine: Record "VAT Amount Line")
    begin
    end;

I'm not totally sure if I understood your requests correctly. Could you please confirm the suggest events.
It would be useful if you add some comments about why you need those events for your customization.

[AleksandricMarko]

Hello @preetgor
If this request is still valid, please create new one (also consider comments from @pri-kise).