From 5c4620b95f6683c2f56d65dd211031cdede010bd Mon Sep 17 00:00:00 2001 From: Cursor Agent Date: Mon, 29 Dec 2025 01:02:39 +0000 Subject: [PATCH] Refactor: Rename .claude/skills to .codex/skills Co-authored-by: jake --- .agents/commands/update-devagent.md | 2 +- .../skills/create-slash-command/SKILL.md | 0 .../assets/command-template.md | 0 .../references/command-structure.md | 0 .../scripts/create_command.py | 0 .../scripts/create_symlink.py | 0 .../skills/github-cli-operations/SKILL.md | 0 .../references/commands.md | 0 .../skills/linear-mcp-integration/SKILL.md | 0 .../references/mcp-functions.md | 0 .../skills/pr-review-integration/SKILL.md | 4 ++-- .../references/patterns.md | 0 .../skills/skill-creator/SKILL.md | 0 .../references/output-patterns.md | 0 .../skill-creator/references/workflows.md | 0 .../skill-creator/scripts/init_skill.py | 0 .../skill-creator/scripts/package_skill.py | 0 .../skill-creator/scripts/quick_validate.py | 0 .devagent/core/scripts/update-core.sh | 24 +++++++++---------- .devagent/core/workflows/compare-prs.md | 12 +++++----- .devagent/core/workflows/review-pr.md | 12 +++++----- .../2025-12-25_pr-review-agent/AGENTS.md | 8 +++---- .../plan/2025-12-25_pr-review-agent-plan.md | 12 +++++----- ...-12-25_github-linear-integration-skills.md | 16 ++++++------- .../research/2025-12-25_pr-review-approach.md | 22 ++++++++--------- .../research/2025-12-25_skills-review.md | 18 +++++++------- ...-12-25_workflow-vs-skill-decision-guide.md | 2 +- ...5-12-25_workflow-vs-skill-decision-tree.md | 4 ++-- 28 files changed, 68 insertions(+), 68 deletions(-) rename {.claude => .codex}/skills/create-slash-command/SKILL.md (100%) rename {.claude => .codex}/skills/create-slash-command/assets/command-template.md (100%) rename {.claude => .codex}/skills/create-slash-command/references/command-structure.md (100%) rename {.claude => .codex}/skills/create-slash-command/scripts/create_command.py (100%) rename {.claude => .codex}/skills/create-slash-command/scripts/create_symlink.py (100%) rename {.claude => .codex}/skills/github-cli-operations/SKILL.md (100%) rename {.claude => .codex}/skills/github-cli-operations/references/commands.md (100%) rename {.claude => .codex}/skills/linear-mcp-integration/SKILL.md (100%) rename {.claude => .codex}/skills/linear-mcp-integration/references/mcp-functions.md (100%) rename {.claude => .codex}/skills/pr-review-integration/SKILL.md (95%) rename {.claude => .codex}/skills/pr-review-integration/references/patterns.md (100%) rename {.claude => .codex}/skills/skill-creator/SKILL.md (100%) rename {.claude => .codex}/skills/skill-creator/references/output-patterns.md (100%) rename {.claude => .codex}/skills/skill-creator/references/workflows.md (100%) rename {.claude => .codex}/skills/skill-creator/scripts/init_skill.py (100%) rename {.claude => .codex}/skills/skill-creator/scripts/package_skill.py (100%) rename {.claude => .codex}/skills/skill-creator/scripts/quick_validate.py (100%) diff --git a/.agents/commands/update-devagent.md b/.agents/commands/update-devagent.md index f7fa524..ebedd42 100644 --- a/.agents/commands/update-devagent.md +++ b/.agents/commands/update-devagent.md @@ -5,7 +5,7 @@ 1. Run the DevAgent core update script located at `.devagent/core/scripts/update-core.sh` to update core files, commands, and skills from the DevAgent repository. 2. After the script completes successfully, provide a summary of what was updated, including: - - Which directories were updated (`.devagent/core/`, `.agents/commands/`, `.claude/skills/`) + - Which directories were updated (`.devagent/core/`, `.agents/commands/`, `.codex/skills/`) - Any specific skills or commands that were updated - Any backup information (if kept) - Note that changes were NOT committed (as per user preference) diff --git a/.claude/skills/create-slash-command/SKILL.md b/.codex/skills/create-slash-command/SKILL.md similarity index 100% rename from .claude/skills/create-slash-command/SKILL.md rename to .codex/skills/create-slash-command/SKILL.md diff --git a/.claude/skills/create-slash-command/assets/command-template.md b/.codex/skills/create-slash-command/assets/command-template.md similarity index 100% rename from .claude/skills/create-slash-command/assets/command-template.md rename to .codex/skills/create-slash-command/assets/command-template.md diff --git a/.claude/skills/create-slash-command/references/command-structure.md b/.codex/skills/create-slash-command/references/command-structure.md similarity index 100% rename from .claude/skills/create-slash-command/references/command-structure.md rename to .codex/skills/create-slash-command/references/command-structure.md diff --git a/.claude/skills/create-slash-command/scripts/create_command.py b/.codex/skills/create-slash-command/scripts/create_command.py similarity index 100% rename from .claude/skills/create-slash-command/scripts/create_command.py rename to .codex/skills/create-slash-command/scripts/create_command.py diff --git a/.claude/skills/create-slash-command/scripts/create_symlink.py b/.codex/skills/create-slash-command/scripts/create_symlink.py similarity index 100% rename from .claude/skills/create-slash-command/scripts/create_symlink.py rename to .codex/skills/create-slash-command/scripts/create_symlink.py diff --git a/.claude/skills/github-cli-operations/SKILL.md b/.codex/skills/github-cli-operations/SKILL.md similarity index 100% rename from .claude/skills/github-cli-operations/SKILL.md rename to .codex/skills/github-cli-operations/SKILL.md diff --git a/.claude/skills/github-cli-operations/references/commands.md b/.codex/skills/github-cli-operations/references/commands.md similarity index 100% rename from .claude/skills/github-cli-operations/references/commands.md rename to .codex/skills/github-cli-operations/references/commands.md diff --git a/.claude/skills/linear-mcp-integration/SKILL.md b/.codex/skills/linear-mcp-integration/SKILL.md similarity index 100% rename from .claude/skills/linear-mcp-integration/SKILL.md rename to .codex/skills/linear-mcp-integration/SKILL.md diff --git a/.claude/skills/linear-mcp-integration/references/mcp-functions.md b/.codex/skills/linear-mcp-integration/references/mcp-functions.md similarity index 100% rename from .claude/skills/linear-mcp-integration/references/mcp-functions.md rename to .codex/skills/linear-mcp-integration/references/mcp-functions.md diff --git a/.claude/skills/pr-review-integration/SKILL.md b/.codex/skills/pr-review-integration/SKILL.md similarity index 95% rename from .claude/skills/pr-review-integration/SKILL.md rename to .codex/skills/pr-review-integration/SKILL.md index 8b80340..61c27b3 100644 --- a/.claude/skills/pr-review-integration/SKILL.md +++ b/.codex/skills/pr-review-integration/SKILL.md @@ -160,5 +160,5 @@ mcp_Linear_update_issue({ ## Reference Documentation - **Review Patterns**: See [patterns.md](references/patterns.md) for detailed patterns, edge cases, and checklist templates -- **GitHub CLI Operations**: `.claude/skills/github-cli-operations/SKILL.md` - GitHub CLI patterns -- **Linear MCP Integration**: `.claude/skills/linear-mcp-integration/SKILL.md` - Linear MCP functions +- **GitHub CLI Operations**: `.codex/skills/github-cli-operations/SKILL.md` - GitHub CLI patterns +- **Linear MCP Integration**: `.codex/skills/linear-mcp-integration/SKILL.md` - Linear MCP functions diff --git a/.claude/skills/pr-review-integration/references/patterns.md b/.codex/skills/pr-review-integration/references/patterns.md similarity index 100% rename from .claude/skills/pr-review-integration/references/patterns.md rename to .codex/skills/pr-review-integration/references/patterns.md diff --git a/.claude/skills/skill-creator/SKILL.md b/.codex/skills/skill-creator/SKILL.md similarity index 100% rename from .claude/skills/skill-creator/SKILL.md rename to .codex/skills/skill-creator/SKILL.md diff --git a/.claude/skills/skill-creator/references/output-patterns.md b/.codex/skills/skill-creator/references/output-patterns.md similarity index 100% rename from .claude/skills/skill-creator/references/output-patterns.md rename to .codex/skills/skill-creator/references/output-patterns.md diff --git a/.claude/skills/skill-creator/references/workflows.md b/.codex/skills/skill-creator/references/workflows.md similarity index 100% rename from .claude/skills/skill-creator/references/workflows.md rename to .codex/skills/skill-creator/references/workflows.md diff --git a/.claude/skills/skill-creator/scripts/init_skill.py b/.codex/skills/skill-creator/scripts/init_skill.py similarity index 100% rename from .claude/skills/skill-creator/scripts/init_skill.py rename to .codex/skills/skill-creator/scripts/init_skill.py diff --git a/.claude/skills/skill-creator/scripts/package_skill.py b/.codex/skills/skill-creator/scripts/package_skill.py similarity index 100% rename from .claude/skills/skill-creator/scripts/package_skill.py rename to .codex/skills/skill-creator/scripts/package_skill.py diff --git a/.claude/skills/skill-creator/scripts/quick_validate.py b/.codex/skills/skill-creator/scripts/quick_validate.py similarity index 100% rename from .claude/skills/skill-creator/scripts/quick_validate.py rename to .codex/skills/skill-creator/scripts/quick_validate.py diff --git a/.devagent/core/scripts/update-core.sh b/.devagent/core/scripts/update-core.sh index 0d2528a..80fab3f 100755 --- a/.devagent/core/scripts/update-core.sh +++ b/.devagent/core/scripts/update-core.sh @@ -52,18 +52,18 @@ git config core.sparseCheckout true git config index.sparse true echo "$CORE_PATH/" >> .git/info/sparse-checkout echo ".agents/" >> .git/info/sparse-checkout -echo ".claude/skills/" >> .git/info/sparse-checkout +echo ".codex/skills/" >> .git/info/sparse-checkout git pull origin main --quiet --depth=1 # Ensure sparse checkout is applied (sometimes needs explicit checkout) git sparse-checkout reapply 2>/dev/null || true # Debug: verify what was checked out -if [ ! -d "$TEMP_DIR/.claude/skills" ]; then - echo "Warning: .claude/skills directory not found in repository after checkout." +if [ ! -d "$TEMP_DIR/.codex/skills" ]; then + echo "Warning: .codex/skills directory not found in repository after checkout." echo "This may be expected if skills haven't been added to the repository yet." - echo "Checking if .claude directory exists..." - ls -la "$TEMP_DIR/.claude" 2>/dev/null || echo " .claude directory not found in repository." + echo "Checking if .codex directory exists..." + ls -la "$TEMP_DIR/.codex" 2>/dev/null || echo " .codex directory not found in repository." fi # Merge updated core into project; overwrite upstream files, keep local additions @@ -77,27 +77,27 @@ if [ -d "$TEMP_DIR/.agents/commands" ]; then echo "Updated .agents/commands directory from repository." fi -# Merge .claude/skills directory if it exists in the repository +# Merge .codex/skills directory if it exists in the repository # Only overwrite skills that exist in the source, keep other skills in target untouched -if [ -d "$TEMP_DIR/.claude/skills" ]; then - mkdir -p "$PROJECT_ROOT/.claude/skills" +if [ -d "$TEMP_DIR/.codex/skills" ]; then + mkdir -p "$PROJECT_ROOT/.codex/skills" SKILLS_UPDATED=0 # Iterate through each skill directory, only updating skills that exist in source # Use find to handle cases where directory might be empty or have hidden files while IFS= read -r skill_dir; do [ -n "$skill_dir" ] || continue skill_name=$(basename "$skill_dir") - rsync -a "$skill_dir/" "$PROJECT_ROOT/.claude/skills/$skill_name/" + rsync -a "$skill_dir/" "$PROJECT_ROOT/.codex/skills/$skill_name/" SKILLS_UPDATED=$((SKILLS_UPDATED + 1)) echo " Updated skill: $skill_name" - done < <(find "$TEMP_DIR/.claude/skills" -mindepth 1 -maxdepth 1 -type d 2>/dev/null) + done < <(find "$TEMP_DIR/.codex/skills" -mindepth 1 -maxdepth 1 -type d 2>/dev/null) if [ $SKILLS_UPDATED -gt 0 ]; then - echo "Updated $SKILLS_UPDATED skill(s) in .claude/skills directory." + echo "Updated $SKILLS_UPDATED skill(s) in .codex/skills directory." else echo "No skills found in repository to update." fi else - echo "Note: .claude/skills directory not found in repository (may not exist yet)." + echo "Note: .codex/skills directory not found in repository (may not exist yet)." fi # Cleanup temp dir diff --git a/.devagent/core/workflows/compare-prs.md b/.devagent/core/workflows/compare-prs.md index 8d3a680..ad94458 100644 --- a/.devagent/core/workflows/compare-prs.md +++ b/.devagent/core/workflows/compare-prs.md @@ -23,8 +23,8 @@ Follow standard execution directive in `.devagent/core/AGENTS.md` → Standard W ## Resource Strategy - **Comparison artifacts:** `.devagent/workspace/reviews/YYYY-MM-DD_pr-comparison_.md` — storage for PR comparison artifacts. - **Comparison template:** `.devagent/core/templates/pr-comparison-template.md` — template for consistent comparison format. -- **GitHub CLI Operations Skill:** `.claude/skills/github-cli-operations/` — **Consult this skill for detailed GitHub CLI command patterns, examples, and best practices.** Use for PR operations (view PR details, get diff, extract Linear issue references, fetch review comments). The skill contains comprehensive command reference and usage patterns. -- **Linear MCP Integration Skill:** `.claude/skills/linear-mcp-integration/` — **Consult this skill for Linear MCP function usage patterns and examples.** Use for Linear issue operations (get issue details, fetch requirements, update issues, post comments). The skill contains MCP function reference and integration patterns. +- **GitHub CLI Operations Skill:** `.codex/skills/github-cli-operations/` — **Consult this skill for detailed GitHub CLI command patterns, examples, and best practices.** Use for PR operations (view PR details, get diff, extract Linear issue references, fetch review comments). The skill contains comprehensive command reference and usage patterns. +- **Linear MCP Integration Skill:** `.codex/skills/linear-mcp-integration/` — **Consult this skill for Linear MCP function usage patterns and examples.** Use for Linear issue operations (get issue details, fetch requirements, update issues, post comments). The skill contains MCP function reference and integration patterns. - **Project standards:** `.devagent/core/AGENTS.md` (workflow guidelines), `.cursorrules` or workspace rules (code style), `.devagent/workspace/memory/constitution.md` (principles). - **Feature hubs:** `.devagent/workspace/features/{status}/YYYY-MM-DD_feature-slug/` — optional linking for feature-scoped comparisons. - **Code repository:** Analyze code changes via GitHub CLI diff and file inspection. @@ -40,20 +40,20 @@ Follow standard execution directive in `.devagent/core/AGENTS.md` → Standard W - Identify common task/feature: extract from PR descriptions, Linear issues, or use provided task description 2. **Context gathering (for each PR):** - - **Fetch PR details** using GitHub CLI (see `.claude/skills/github-cli-operations/` for detailed command patterns): + - **Fetch PR details** using GitHub CLI (see `.codex/skills/github-cli-operations/` for detailed command patterns): - Get PR title, body, author, state, base/head refs: `gh pr view --json title,body,author,state,baseRefName,headRefName` - Get changed files: `gh pr view --json files --jq '.files[].path'` - Get PR diff: `gh pr diff ` - Get PR size metrics: `gh pr view --json additions,deletions,changedFiles` - - **Fetch PR review comments** using GitHub CLI (see `.claude/skills/github-cli-operations/` for comment fetching patterns): + - **Fetch PR review comments** using GitHub CLI (see `.codex/skills/github-cli-operations/` for comment fetching patterns): - Get review comments: `gh pr view --json reviews,comments --jq '.reviews[] | select(.state != "APPROVED") | {state, body, author}'` - Get PR review thread comments: `gh api repos/:owner/:repo/pulls//comments` (if available) - Analyze comment importance: identify blocking comments, critical comments, and minor comments - Count comments by category for scoring - - **Extract Linear issue references** from PR (see `.claude/skills/github-cli-operations/` for extraction patterns): + - **Extract Linear issue references** from PR (see `.codex/skills/github-cli-operations/` for extraction patterns): - Search PR title and body for Linear issue patterns (e.g., `LIN-123`, `[LIN-123]`) - Extract all issue IDs found - - **Fetch Linear issue requirements** (if issues found; see `.claude/skills/linear-mcp-integration/` for MCP function usage): + - **Fetch Linear issue requirements** (if issues found; see `.codex/skills/linear-mcp-integration/` for MCP function usage): - For each Linear issue ID, use Linear MCP to get issue details: `mcp_Linear_get_issue({ id: "LIN-123", includeRelations: true })` - Extract acceptance criteria from issue description - Parse requirements, checkboxes, and feature specifications diff --git a/.devagent/core/workflows/review-pr.md b/.devagent/core/workflows/review-pr.md index f209957..646f790 100644 --- a/.devagent/core/workflows/review-pr.md +++ b/.devagent/core/workflows/review-pr.md @@ -24,8 +24,8 @@ Follow standard execution directive in `.devagent/core/AGENTS.md` → Standard W ## Resource Strategy - **Review artifacts:** `.devagent/workspace/reviews/YYYY-MM-DD_pr--review.md` — storage for all PR review artifacts. - **Review artifact template:** `.devagent/core/templates/review-artifact-template.md` — template for consistent review format. -- **GitHub CLI Operations Skill:** `.claude/skills/github-cli-operations/` — **Consult this skill for detailed GitHub CLI command patterns, examples, and best practices.** Use for PR operations (view PR details, get diff, extract Linear issue references, fetch review comments). The skill contains comprehensive command reference and usage patterns. -- **Linear MCP Integration Skill:** `.claude/skills/linear-mcp-integration/` — **Consult this skill for Linear MCP function usage patterns and examples.** Use for Linear issue operations (get issue details, fetch requirements, update issues, post comments). The skill contains MCP function reference and integration patterns. +- **GitHub CLI Operations Skill:** `.codex/skills/github-cli-operations/` — **Consult this skill for detailed GitHub CLI command patterns, examples, and best practices.** Use for PR operations (view PR details, get diff, extract Linear issue references, fetch review comments). The skill contains comprehensive command reference and usage patterns. +- **Linear MCP Integration Skill:** `.codex/skills/linear-mcp-integration/` — **Consult this skill for Linear MCP function usage patterns and examples.** Use for Linear issue operations (get issue details, fetch requirements, update issues, post comments). The skill contains MCP function reference and integration patterns. - **Project standards:** `.devagent/core/AGENTS.md` (workflow guidelines), `.cursorrules` or workspace rules (code style), `.devagent/workspace/memory/constitution.md` (principles). - **Feature hubs:** `.devagent/workspace/features/{status}/YYYY-MM-DD_feature-slug/` — optional linking for feature-scoped reviews. - **Code repository:** Analyze code changes via GitHub CLI diff and file inspection. @@ -39,18 +39,18 @@ Follow standard execution directive in `.devagent/core/AGENTS.md` → Standard W - Confirm review artifact template exists 2. **Context gathering:** - - **Fetch PR details** using GitHub CLI (see `.claude/skills/github-cli-operations/` for detailed command patterns): + - **Fetch PR details** using GitHub CLI (see `.codex/skills/github-cli-operations/` for detailed command patterns): - Get PR title, body, author, state, base/head refs: `gh pr view --json title,body,author,state,baseRefName,headRefName` - Get changed files: `gh pr view --json files --jq '.files[].path'` - Get PR diff: `gh pr diff ` - - **Fetch PR review comments** using GitHub CLI (see `.claude/skills/github-cli-operations/` for comment fetching patterns): + - **Fetch PR review comments** using GitHub CLI (see `.codex/skills/github-cli-operations/` for comment fetching patterns): - Get review comments: `gh pr view --json reviews,comments --jq '.reviews[] | select(.state != "APPROVED") | {state, body, author}'` - Get PR review thread comments: `gh api repos/:owner/:repo/pulls//comments` (if available) - Analyze comment importance: identify blocking comments (e.g., "blocking", "must fix", "critical"), critical comments (e.g., "important", "should fix"), and minor comments (e.g., "nice to have", "optional") - - **Extract Linear issue references** from PR (see `.claude/skills/github-cli-operations/` for extraction patterns): + - **Extract Linear issue references** from PR (see `.codex/skills/github-cli-operations/` for extraction patterns): - Search PR title and body for Linear issue patterns (e.g., `LIN-123`, `[LIN-123]`) - Extract all issue IDs found - - **Fetch Linear issue requirements** (if issues found; see `.claude/skills/linear-mcp-integration/` for MCP function usage): + - **Fetch Linear issue requirements** (if issues found; see `.codex/skills/linear-mcp-integration/` for MCP function usage): - For each Linear issue ID, use Linear MCP to get issue details: `mcp_Linear_get_issue({ id: "LIN-123", includeRelations: true })` - Extract acceptance criteria from issue description - Parse requirements, checkboxes, and feature specifications diff --git a/.devagent/workspace/features/completed/2025-12-25_pr-review-agent/AGENTS.md b/.devagent/workspace/features/completed/2025-12-25_pr-review-agent/AGENTS.md index 1c023f5..12de986 100644 --- a/.devagent/workspace/features/completed/2025-12-25_pr-review-agent/AGENTS.md +++ b/.devagent/workspace/features/completed/2025-12-25_pr-review-agent/AGENTS.md @@ -21,7 +21,7 @@ Agent that reviews pull requests by analyzing code changes, checking attached Li ## Progress Log - [2025-12-25] Event: Feature hub scaffolded via `devagent new-feature`. Initial structure created with research/, plan/, and tasks/ directories. -- [2025-12-25] Event: Research completed on GitHub and Linear integration skills. Created research document and three Agent Skills for GitHub CLI operations, Linear MCP integration, and PR review integration patterns. See research/2025-12-25_github-linear-integration-skills.md and .claude/skills/ directory. +- [2025-12-25] Event: Research completed on GitHub and Linear integration skills. Created research document and three Agent Skills for GitHub CLI operations, Linear MCP integration, and PR review integration patterns. See research/2025-12-25_github-linear-integration-skills.md and .codex/skills/ directory. - [2025-12-25] Event: Research completed on PR review approach and architecture. Analyzed workflow vs skill decision, review process design, and integration patterns. Recommendation: Create DevAgent workflow (`devagent review-pr`) that uses existing skills for tool operations while producing structured artifacts. See research/2025-12-25_pr-review-approach.md. - [2025-12-25] Event: Implementation plan created via `devagent create-plan`. Plan includes 5 implementation tasks covering template creation, workflow definition, command file, documentation updates, and testing. See plan/2025-12-25_pr-review-agent-plan.md. - [2025-12-25] Event: Implementation completed. All 5 tasks finished: review artifact template created (`.devagent/core/templates/review-artifact-template.md`), workflow definition created (`.devagent/core/workflows/review-pr.md`), command file created (`.agents/commands/review-pr.md`), workflow roster updated (`.devagent/core/AGENTS.md`), and reviews directory structure created (`.devagent/workspace/reviews/`). Workflow is ready for testing. @@ -51,9 +51,9 @@ Agent that reviews pull requests by analyzing code changes, checking attached Li - Review Progress Workflow: `.devagent/core/workflows/review-progress.md` (2025-12-25) — Related workflow for progress tracking and code verification patterns - Feature Directory Structure: `.devagent/workspace/features/README.md` (2025-12-25) — Standard structure for feature hubs and artifact organization - **Research: GitHub/Linear Integration Skills**: `.devagent/workspace/features/completed/2025-12-25_pr-review-agent/research/2025-12-25_github-linear-integration-skills.md` (2025-12-25) — Research on GitHub and Linear integration options and skill design -- **GitHub CLI Operations Skill**: `.claude/skills/github-cli-operations/SKILL.md` (2025-12-25) — Agent skill for GitHub CLI operations and PR management -- **Linear MCP Integration Skill**: `.claude/skills/linear-mcp-integration/SKILL.md` (2025-12-25) — Agent skill for Linear MCP functions and issue management -- **PR Review Integration Skill**: `.claude/skills/pr-review-integration/SKILL.md` (2025-12-25) — Combined patterns for PR review workflows integrating GitHub and Linear (to be evaluated/repurposed) +- **GitHub CLI Operations Skill**: `.codex/skills/github-cli-operations/SKILL.md` (2025-12-25) — Agent skill for GitHub CLI operations and PR management +- **Linear MCP Integration Skill**: `.codex/skills/linear-mcp-integration/SKILL.md` (2025-12-25) — Agent skill for Linear MCP functions and issue management +- **PR Review Integration Skill**: `.codex/skills/pr-review-integration/SKILL.md` (2025-12-25) — Combined patterns for PR review workflows integrating GitHub and Linear (to be evaluated/repurposed) - **Research: PR Review Approach**: `.devagent/workspace/features/completed/2025-12-25_pr-review-agent/research/2025-12-25_pr-review-approach.md` (2025-12-25) — Research on PR review architecture, workflow vs skill decision, and recommended approach - **Research: Skills Review**: `.devagent/workspace/features/completed/2025-12-25_pr-review-agent/research/2025-12-25_skills-review.md` (2025-12-25) — Review of existing skills, assessment of quality and appropriateness, recommendations for workflow integration - **Implementation Plan**: `.devagent/workspace/features/completed/2025-12-25_pr-review-agent/plan/2025-12-25_pr-review-agent-plan.md` (2025-12-25) — Complete implementation plan with 5 tasks covering template, workflow, command file, documentation, and testing diff --git a/.devagent/workspace/features/completed/2025-12-25_pr-review-agent/plan/2025-12-25_pr-review-agent-plan.md b/.devagent/workspace/features/completed/2025-12-25_pr-review-agent/plan/2025-12-25_pr-review-agent-plan.md index 8d3b69c..22dd97d 100644 --- a/.devagent/workspace/features/completed/2025-12-25_pr-review-agent/plan/2025-12-25_pr-review-agent-plan.md +++ b/.devagent/workspace/features/completed/2025-12-25_pr-review-agent/plan/2025-12-25_pr-review-agent-plan.md @@ -135,9 +135,9 @@ Research completed: **Dependencies:** - GitHub CLI (`gh`) must be installed and authenticated - Linear MCP server must be configured and available -- **GitHub CLI Operations Skill**: `.claude/skills/github-cli-operations/` (✅ Keep - referenced in workflow for PR operations) -- **Linear MCP Integration Skill**: `.claude/skills/linear-mcp-integration/` (✅ Keep - referenced in workflow for issue operations) -- **PR Review Integration Skill**: `.claude/skills/pr-review-integration/` (❌ Remove - replaced by this workflow) +- **GitHub CLI Operations Skill**: `.codex/skills/github-cli-operations/` (✅ Keep - referenced in workflow for PR operations) +- **Linear MCP Integration Skill**: `.codex/skills/linear-mcp-integration/` (✅ Keep - referenced in workflow for issue operations) +- **PR Review Integration Skill**: `.codex/skills/pr-review-integration/` (❌ Remove - replaced by this workflow) - DevAgent workflow structure and templates **Technical Considerations:** @@ -350,9 +350,9 @@ Refer to the AGENTS.md file in the feature directory (`.devagent/workspace/featu - Research Workflow: `.devagent/core/workflows/research.md` (workflow structure reference) **Skills:** -- GitHub CLI Operations: `.claude/skills/github-cli-operations/SKILL.md` (✅ Keep - referenced in workflow) -- Linear MCP Integration: `.claude/skills/linear-mcp-integration/SKILL.md` (✅ Keep - referenced in workflow) -- PR Review Integration: `.claude/skills/pr-review-integration/SKILL.md` (❌ Remove - replaced by workflow) +- GitHub CLI Operations: `.codex/skills/github-cli-operations/SKILL.md` (✅ Keep - referenced in workflow) +- Linear MCP Integration: `.codex/skills/linear-mcp-integration/SKILL.md` (✅ Keep - referenced in workflow) +- PR Review Integration: `.codex/skills/pr-review-integration/SKILL.md` (❌ Remove - replaced by workflow) **Constitution References:** - C3: Delivery Principles (human-in-the-loop, traceable artifacts) — `.devagent/workspace/memory/constitution.md` diff --git a/.devagent/workspace/features/completed/2025-12-25_pr-review-agent/research/2025-12-25_github-linear-integration-skills.md b/.devagent/workspace/features/completed/2025-12-25_pr-review-agent/research/2025-12-25_github-linear-integration-skills.md index 4cab951..2e398ab 100644 --- a/.devagent/workspace/features/completed/2025-12-25_pr-review-agent/research/2025-12-25_github-linear-integration-skills.md +++ b/.devagent/workspace/features/completed/2025-12-25_pr-review-agent/research/2025-12-25_github-linear-integration-skills.md @@ -30,7 +30,7 @@ 3. **Agent Skills Format** - SKILL.md structure with YAML frontmatter - - Directory structure (`.claude//`) + - Directory structure (`.codex//`) - Best practices for skill descriptions and auto-discovery 4. **Skill Design Patterns** @@ -108,7 +108,7 @@ **Required Structure:** ``` -.claude/skills// +.codex/skills// SKILL.md # Required: YAML frontmatter + instructions scripts/ # Optional: Helper scripts references/ # Optional: Detailed documentation @@ -150,12 +150,12 @@ Create three skills: ## Repo Next Steps - [x] Research GitHub and Linear integration options -- [x] Create `.claude/skills/github-cli-operations/` skill directory -- [x] Create `.claude/skills/github-cli-operations/SKILL.md` with GitHub CLI patterns -- [x] Create `.claude/skills/linear-mcp-integration/` skill directory -- [x] Create `.claude/skills/linear-mcp-integration/SKILL.md` with Linear MCP patterns -- [x] Create `.claude/skills/pr-review-integration/` skill directory (optional, for combined patterns) -- [x] Create `.claude/skills/pr-review-integration/SKILL.md` (optional) +- [x] Create `.codex/skills/github-cli-operations/` skill directory +- [x] Create `.codex/skills/github-cli-operations/SKILL.md` with GitHub CLI patterns +- [x] Create `.codex/skills/linear-mcp-integration/` skill directory +- [x] Create `.codex/skills/linear-mcp-integration/SKILL.md` with Linear MCP patterns +- [x] Create `.codex/skills/pr-review-integration/` skill directory (optional, for combined patterns) +- [x] Create `.codex/skills/pr-review-integration/SKILL.md` (optional) - [ ] Update PR review agent feature hub with skill references - [ ] Test skills in Cursor/Claude environment diff --git a/.devagent/workspace/features/completed/2025-12-25_pr-review-agent/research/2025-12-25_pr-review-approach.md b/.devagent/workspace/features/completed/2025-12-25_pr-review-agent/research/2025-12-25_pr-review-approach.md index 5311734..3d67c8b 100644 --- a/.devagent/workspace/features/completed/2025-12-25_pr-review-agent/research/2025-12-25_pr-review-approach.md +++ b/.devagent/workspace/features/completed/2025-12-25_pr-review-agent/research/2025-12-25_pr-review-approach.md @@ -45,7 +45,7 @@ 3. **DevAgent Workflow Roster**: `.devagent/core/AGENTS.md` (2025-12-25) — Available workflows and usage patterns 4. **Review Progress Workflow**: `.devagent/core/workflows/review-progress.md` (2025-12-25) — Related workflow for progress tracking 5. **GitHub/Linear Integration Skills**: `.devagent/workspace/features/completed/2025-12-25_pr-review-agent/research/2025-12-25_github-linear-integration-skills.md` (2025-12-25) — Integration options research -6. **PR Review Integration Skill**: `.claude/skills/pr-review-integration/SKILL.md` (2025-12-25) — Current skill implementation +6. **PR Review Integration Skill**: `.codex/skills/pr-review-integration/SKILL.md` (2025-12-25) — Current skill implementation 7. **External**: AI agent PR review patterns and best practices ## Findings & Tradeoffs @@ -83,8 +83,8 @@ ``` **Integration:** -- Uses GitHub CLI skill (`.claude/skills/github-cli-operations/`) for PR operations -- Uses Linear MCP skill (`.claude/skills/linear-mcp-integration/`) for issue operations +- Uses GitHub CLI skill (`.codex/skills/github-cli-operations/`) for PR operations +- Uses Linear MCP skill (`.codex/skills/linear-mcp-integration/`) for issue operations - Produces review artifacts that link to feature hubs and Linear issues #### Option 2: Agent Skill (Auto-Discovery) @@ -99,7 +99,7 @@ - ✅ Automatic discovery and activation - ✅ Cross-platform (Cursor, VS Code, GitHub, etc.) - ✅ Lightweight and flexible -- ✅ Already implemented (`.claude/skills/pr-review-integration/`) +- ✅ Already implemented (`.codex/skills/pr-review-integration/`) **Cons:** - ❌ Doesn't produce structured artifacts in `.devagent/workspace/` @@ -242,8 +242,8 @@ - **Linear Issues**: Reviews validate against and update Linear issues **Tool Integration:** -- Uses `.claude/skills/github-cli-operations/` for GitHub operations -- Uses `.claude/skills/linear-mcp-integration/` for Linear operations +- Uses `.codex/skills/github-cli-operations/` for GitHub operations +- Uses `.codex/skills/linear-mcp-integration/` for Linear operations - Workflow remains tool-agnostic (C4) while leveraging tool-specific skills ## Recommendation @@ -270,9 +270,9 @@ ### Keep Skills for Tool Operations **Maintain existing skills:** -- `.claude/skills/github-cli-operations/` — GitHub CLI patterns -- `.claude/skills/linear-mcp-integration/` — Linear MCP functions -- **Remove or repurpose** `.claude/skills/pr-review-integration/` — This skill doesn't fit DevAgent's model (no artifact production, no coordination with feature hubs) +- `.codex/skills/github-cli-operations/` — GitHub CLI patterns +- `.codex/skills/linear-mcp-integration/` — Linear MCP functions +- **Remove or repurpose** `.codex/skills/pr-review-integration/` — This skill doesn't fit DevAgent's model (no artifact production, no coordination with feature hubs) **Skills provide tool capabilities; workflow provides structure and artifacts.** @@ -305,7 +305,7 @@ - [ ] Create `.agents/commands/review-pr.md` command file - [ ] Update `.devagent/core/AGENTS.md` to include `review-pr` workflow - [ ] Create review artifact template in `.devagent/core/templates/` -- [ ] Decide on `.claude/skills/pr-review-integration/` — remove or repurpose? +- [ ] Decide on `.codex/skills/pr-review-integration/` — remove or repurpose? - [ ] Test workflow with sample PR - [ ] Update PR review agent feature hub with decision @@ -335,5 +335,5 @@ - DevAgent Workflow Roster: `.devagent/core/AGENTS.md` — Available workflows and patterns - Review Progress Workflow: `.devagent/core/workflows/review-progress.md` — Related workflow pattern - GitHub/Linear Integration Research: `.devagent/workspace/features/completed/2025-12-25_pr-review-agent/research/2025-12-25_github-linear-integration-skills.md` -- PR Review Integration Skill: `.claude/skills/pr-review-integration/SKILL.md` — Current skill implementation (to be evaluated) +- PR Review Integration Skill: `.codex/skills/pr-review-integration/SKILL.md` — Current skill implementation (to be evaluated) - PR Review Agent Feature: `.devagent/workspace/features/completed/2025-12-25_pr-review-agent/AGENTS.md` diff --git a/.devagent/workspace/features/completed/2025-12-25_pr-review-agent/research/2025-12-25_skills-review.md b/.devagent/workspace/features/completed/2025-12-25_pr-review-agent/research/2025-12-25_skills-review.md index d7e3f34..2386b6d 100644 --- a/.devagent/workspace/features/completed/2025-12-25_pr-review-agent/research/2025-12-25_skills-review.md +++ b/.devagent/workspace/features/completed/2025-12-25_pr-review-agent/research/2025-12-25_skills-review.md @@ -7,7 +7,7 @@ ## Purpose -Review existing skills in `.claude/skills/` to assess: +Review existing skills in `.codex/skills/` to assess: 1. Quality and alignment with skill-creator guidelines 2. Appropriateness as skills vs workflows 3. Whether they can/should be referenced in DevAgent workflows @@ -17,7 +17,7 @@ Review existing skills in `.claude/skills/` to assess: ### 1. github-cli-operations -**Location:** `.claude/skills/github-cli-operations/` +**Location:** `.codex/skills/github-cli-operations/` **Structure:** - `SKILL.md` (84 lines) - Main skill file @@ -44,7 +44,7 @@ Review existing skills in `.claude/skills/` to assess: ✅ **Can Be Referenced in Workflows:** - **YES** - Workflows can reference this skill for GitHub CLI operations - The `review-pr` workflow should reference this skill for PR operations -- Example: "Use GitHub CLI Operations skill (`.claude/skills/github-cli-operations/`) for PR operations" +- Example: "Use GitHub CLI Operations skill (`.codex/skills/github-cli-operations/`) for PR operations" **Recommendations:** - ✅ No changes needed - skill is well-structured and appropriate @@ -54,7 +54,7 @@ Review existing skills in `.claude/skills/` to assess: ### 2. linear-mcp-integration -**Location:** `.claude/skills/linear-mcp-integration/` +**Location:** `.codex/skills/linear-mcp-integration/` **Structure:** - `SKILL.md` (115 lines) - Main skill file @@ -81,7 +81,7 @@ Review existing skills in `.claude/skills/` to assess: ✅ **Can Be Referenced in Workflows:** - **YES** - Workflows can reference this skill for Linear MCP operations - The `review-pr` workflow should reference this skill for issue operations -- Example: "Use Linear MCP Integration skill (`.claude/skills/linear-mcp-integration/`) for issue operations" +- Example: "Use Linear MCP Integration skill (`.codex/skills/linear-mcp-integration/`) for issue operations" **Recommendations:** - ✅ No changes needed - skill is well-structured and appropriate @@ -91,7 +91,7 @@ Review existing skills in `.claude/skills/` to assess: ### 3. pr-review-integration -**Location:** `.claude/skills/pr-review-integration/` +**Location:** `.codex/skills/pr-review-integration/` **Structure:** - `SKILL.md` (165 lines) - Main skill file @@ -168,8 +168,8 @@ In workflow definition files (`.devagent/core/workflows/review-pr.md`), referenc ```markdown ## Resource Strategy -- **GitHub CLI Operations**: `.claude/skills/github-cli-operations/` - Use for PR operations (view, diff, comments) -- **Linear MCP Integration**: `.claude/skills/linear-mcp-integration/` - Use for issue operations (fetch, update, comment) +- **GitHub CLI Operations**: `.codex/skills/github-cli-operations/` - Use for PR operations (view, diff, comments) +- **Linear MCP Integration**: `.codex/skills/linear-mcp-integration/` - Use for issue operations (fetch, update, comment) - `.devagent/workspace/reviews/` - Storage for review artifacts ``` @@ -197,7 +197,7 @@ In workflow definition files (`.devagent/core/workflows/review-pr.md`), referenc ## References -- Skill Creator Guide: `.claude/skills/skill-creator/SKILL.md` +- Skill Creator Guide: `.codex/skills/skill-creator/SKILL.md` - Workflow vs Skill Decision Guide: `.devagent/workspace/research/2025-12-25_workflow-vs-skill-decision-guide.md` - PR Review Approach Research: `.devagent/workspace/features/completed/2025-12-25_pr-review-agent/research/2025-12-25_pr-review-approach.md` - PR Review Agent Plan: `.devagent/workspace/features/completed/2025-12-25_pr-review-agent/plan/2025-12-25_pr-review-agent-plan.md` diff --git a/.devagent/workspace/research/2025-12-25_workflow-vs-skill-decision-guide.md b/.devagent/workspace/research/2025-12-25_workflow-vs-skill-decision-guide.md index 03fcdce..4fa9b3c 100644 --- a/.devagent/workspace/research/2025-12-25_workflow-vs-skill-decision-guide.md +++ b/.devagent/workspace/research/2025-12-25_workflow-vs-skill-decision-guide.md @@ -84,7 +84,7 @@ Decision criteria and best practices for choosing between creating a DevAgent wo - Better suited to skill's instruction-based format **Agent Skill Structure (Open Standard):** -- Location: `.claude//` or platform-specific skill directory +- Location: `.codex//` or platform-specific skill directory - Required file: `SKILL.md` with YAML frontmatter (name, description) - Optional: `scripts/`, `references/`, `assets/` subdirectories - Portable: **Yes** - Works across Cursor, VS Code, GitHub, OpenAI Codex, Claude, and other skills-compatible platforms diff --git a/.devagent/workspace/research/2025-12-25_workflow-vs-skill-decision-tree.md b/.devagent/workspace/research/2025-12-25_workflow-vs-skill-decision-tree.md index 1fc88f4..8fe0d6c 100644 --- a/.devagent/workspace/research/2025-12-25_workflow-vs-skill-decision-tree.md +++ b/.devagent/workspace/research/2025-12-25_workflow-vs-skill-decision-tree.md @@ -23,7 +23,7 @@ flowchart TD Q7 -->|Yes| Q9{Should this work
across multiple
skills-compatible
platforms?
Cursor, VS Code, GitHub, etc.} Q7 -->|No| Q10{Is this still
experimental or
evolving?} - Q8 -->|Yes| Skill[✅ Agent Skill
.claude/skill-name/
SKILL.md format
Auto-discovery
Cross-platform] + Q8 -->|Yes| Skill[✅ Agent Skill
.codex/skill-name/
SKILL.md format
Auto-discovery
Cross-platform] Q8 -->|No| Q10 Q9 -->|Yes| Skill @@ -37,7 +37,7 @@ flowchart TD Workflow --> End1([Create workflow file:
.devagent/core/workflows/name.md
Create command file:
.agents/commands/name.md
Update workflow roster]) - Skill --> End2([Create skill directory:
.claude/skill-name/
Create SKILL.md with
YAML frontmatter
Add scripts/references/assets
Follow agentskills.io spec]) + Skill --> End2([Create skill directory:
.codex/skill-name/
Create SKILL.md with
YAML frontmatter
Add scripts/references/assets
Follow agentskills.io spec]) style Workflow fill:#e1f5ff,stroke:#0277bd,stroke-width:2px style Skill fill:#fff3e0,stroke:#ef6c00,stroke-width:2px