Skip to content

Add changes in the ui #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harshitsan wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add changes in the ui #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d566fc5
changed the design how the shortened link and the error appears + lit…
harshitsan Oct 11, 2018
b062487
a little change on how link appears in hover
harshitsan Oct 11, 2018
fcf0dcc
the shortened link was not working did the changes
harshitsan Oct 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ app.post('/shorten',function(req,res){

var regex = /(https?:\/\/(?:www\.|(?!www))[a-zA-Z0-9][a-zA-Z0-9-]+[a-zA-Z0-9]\.[^\s]{2,}|www\.[a-zA-Z0-9][a-zA-Z0-9-]+[a-zA-Z0-9]\.[^\s]{2,}|https?:\/\/(?:www\.|(?!www))[a-zA-Z0-9]\.[^\s]{2,}|www\.[a-zA-Z0-9]\.[^\s]{2,})/
if(!regex.test(originalUrl)) {
res.render('error',{message:'not a valid url'})
res.render('error',{message:'Enter a valid url'})
} else {
//passing the originalurl to encoder to get the shorten url;
var shortenUrl=encoder(originalUrl);
Expand Down
98 changes: 49 additions & 49 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "Url shortner with the help of MongoDB and Base58 decoder",
"main": "app.js",
"scripts": {
"start":"node app.js"
"start": "node app.js"
},
"author": "Ashutosh Dwivedi",
"license": "ISC",
Expand Down
Loading