-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Open
Labels
cleanupCleanup of legacy code or code smellsCleanup of legacy code or code smellsconfirmedThe issue has been verifiedThe issue has been verifiedenhancementImprove existing functionality or small fixesImprove existing functionality or small fixesui & uxThis PR or issue mainly concerns UI & UXThis PR or issue mainly concerns UI & UX
Description
Styling overrides in the following files should be removed:
- https://github.com/jellyfin/jellyfin-web/blob/78eeb992840187c91cda7a95192edcd78819ed02/dashboard-ui/bower_components/emby-webcomponents/fonts/fonts.css
- https://github.com/jellyfin/jellyfin-web/blob/78eeb992840187c91cda7a95192edcd78819ed02/dashboard-ui/bower_components/emby-webcomponents/fonts/fonts.sized.css
I believe these overrides were made with good intentions to make the typography look better on screen, but they also affect the spacing and sizing of other elements.
ISSUE: Such changes make the UI look different from what was originally designed.
Any style change that occurs in the UI should be defined in the design system itself, not added on top of it.
Do this when the "Experimental layout" becomes the default.
Metadata
Metadata
Assignees
Labels
cleanupCleanup of legacy code or code smellsCleanup of legacy code or code smellsconfirmedThe issue has been verifiedThe issue has been verifiedenhancementImprove existing functionality or small fixesImprove existing functionality or small fixesui & uxThis PR or issue mainly concerns UI & UXThis PR or issue mainly concerns UI & UX