59.94 Dropframe calculation

[stephenbickle]

Thanks for making such a great library, curiuos, it doesn't seem to like 59.94 DropFrame as far as I can tell, is there a way to make that calculation work?

I get: InvalidArgumentException: Frame rate not supported

Thank you so very much!
S

[dbpolito]

Hey @stephenbickle , maybe the docs needs some improvements but i think it is supported:

https://github.com/fireworkweb/smpte.php/blob/master/src/FrameRate.php#L13

So if you use the constant it should work as it's a big number...

[stephenbickle]

I think you are right, it was an issue that the timecode was 00:00:00:00 instead of 00:00:00;00 but I had seen an error earlier when I tried to do dropframe calc that said only 29.97, its at the end of Validation.php

Thanks for the reply and a kickass library! Have a great weekend!

public static function isFrameRateSupported(float $frameRate, bool $dropFrame) : bool { if ($frameRate !== 30000/1001 && $dropFrame) { throw new \InvalidArgumentException('Only 29.97 frame rate has drop frame support.'); }
return in_array($frameRate, self::SUPPORTED_FRAMERATES); }