Refactor SemOptimizer API #299
Open
+488
−416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## devel #299 +/- ##
==========================================
- Coverage 72.94% 71.66% -1.29%
==========================================
Files 50 51 +1
Lines 2218 2227 +9
==========================================
- Hits 1618 1596 -22
- Misses 600 631 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit 9729819.
This reverts commit 81a4bd9.
This reverts commit f0df653.
It is a simple and intuitive syntax and avoids declaring new types. Also allow specifying default constraint tolerance as `constraint_tol`.
use SemOptimizer(engine = :NLopt) instead of SemOptimizerNLopt() as this is a more universal scheme
It works around docstring errors during SemOptimizer{:E} parsing.
Instead of engine-specific subtype as it might be not available in the user session.
alyst
force-pushed
the
refactor_semopt_api
branch
from
fe23e46 to
8dacd43
Compare
Contributor
Author
|
Rebased to the current devel |
added 6 commits
January 27, 2026 13:50
since it moved from struct to ctor
alyst
commented
Jan 27, 2026
Collaborator
|
I opened alyst#4 to try to streamline the access of the docs a bit further - let me know what you think. |
return the type that implements SemOptimizer{engine}
Contributor
Author
|
@Maximilian-Stefan-Ernst I've merged your PR into my branch, thank you!
|
Co-authored-by: Maximilian Ernst <34346372+Maximilian-Stefan-Ernst@users.noreply.github.com>
Contributor
Author
|
@Maximilian-Stefan-Ernst Thank you for another review round! Is there anything else except |
Collaborator
|
Thanks a lot for this great set of changes! Once the last remaining comments are addressed, I would merge it. |
Co-authored-by: Maximilian Ernst <34346372+Maximilian-Stefan-Ernst@users.noreply.github.com>
Co-authored-by: Maximilian Ernst <34346372+Maximilian-Stefan-Ernst@users.noreply.github.com>
temporary until the links are fixed Co-authored-by: Maximilian Ernst <34346372+Maximilian-Stefan-Ernst@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #245 -- moving all engine-specific code (types) into extensions for modularity and leaner API, updating docstrings to make all optimizer help available for the user.
Requires #245 to be merged first.