From 701c5497e80ce91c3783924e05a1593c2e043e2e Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Fri, 30 Jan 2026 11:35:56 -0500 Subject: [PATCH 01/52] add utility constructor --- src/tensors/tensor.jl | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/tensors/tensor.jl b/src/tensors/tensor.jl index 526f4e489..6e6cce626 100644 --- a/src/tensors/tensor.jl +++ b/src/tensors/tensor.jl @@ -105,6 +105,11 @@ TensorMapWithStorage{T, A}(::UndefInitializer, codomain::TensorSpace, domain::Te TensorMapWithStorage{T, A}(undef, codomain ← domain) TensorWithStorage{T, A}(::UndefInitializer, V::TensorSpace) where {T, A} = TensorMapWithStorage{T, A}(undef, V ← one(V)) +# Utility constructors +# -------------------- +TensorMap(t::TensorMap) = copy(t) + + # raw data constructors # --------------------- # - dispatch starts with TensorMap{T}(::DenseVector{T}, ...) From 157915fd22cdbb0c4c34bca2a19d1c1bc546fe63 Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Fri, 30 Jan 2026 11:53:04 -0500 Subject: [PATCH 02/52] add `check_spacetype` utility function --- src/planar/planaroperations.jl | 3 +-- src/spaces/vectorspaces.jl | 26 +++++++++++++++++++------- src/tensors/diagonal.jl | 4 ++-- src/tensors/indexmanipulations.jl | 4 ++-- src/tensors/linalg.jl | 5 ++--- src/tensors/tensoroperations.jl | 9 ++++----- 6 files changed, 30 insertions(+), 21 deletions(-) diff --git a/src/planar/planaroperations.jl b/src/planar/planaroperations.jl index a06f4431d..982a848f8 100644 --- a/src/planar/planaroperations.jl +++ b/src/planar/planaroperations.jl @@ -69,8 +69,7 @@ function planartrace!( α::Number, β::Number, backend, allocator ) - (S = spacetype(C)) == spacetype(A) || - throw(SpaceMismatch("incompatible spacetypes")) + S = check_spacetype(C, A) if BraidingStyle(sectortype(S)) == Bosonic() return trace_permute!(C, A, (p₁, p₂), (q₁, q₂), α, β, backend) end diff --git a/src/spaces/vectorspaces.jl b/src/spaces/vectorspaces.jl index 5ef171c31..867d18959 100644 --- a/src/spaces/vectorspaces.jl +++ b/src/spaces/vectorspaces.jl @@ -376,19 +376,31 @@ abstract type CompositeSpace{S <: ElementarySpace} <: VectorSpace end InnerProductStyle(::Type{<:CompositeSpace{S}}) where {S} = InnerProductStyle(S) """ - spacetype(a) -> Type{S<:IndexSpace} - spacetype(::Type) -> Type{S<:IndexSpace} + spacetype(a) -> Type{S <: IndexSpace} + spacetype(::Type) -> Type{S <: IndexSpace} -Return the type of the elementary space `S` of object `a` (e.g. a tensor). Also works in -type domain. +Return the type of the elementary space `S` of object `a` (e.g. a tensor). +Also works in type domain. """ spacetype(x) = spacetype(typeof(x)) -function spacetype(::Type{T}) where {T} - throw(MethodError(spacetype, (T,))) -end +spacetype(::Type{T}) where {T} = throw(MethodError(spacetype, (T,))) spacetype(::Type{E}) where {E <: ElementarySpace} = E spacetype(::Type{S}) where {E, S <: CompositeSpace{E}} = E +""" + check_spacetype(Bool, x, y, z...) -> Bool + check_spacetype(x, y, z...) -> Type{<:IndexSpace} + +Check whether the given inputs have matching spacetypes. +The first signature returns a `Bool` to indicate whether all spacetypes are equal, +while the second will return the spacetype if all types are equal, and throw a [`SpaceMismatch`](@ref) if not. +""" +check_spacetype(::Type{Bool}, x, y, z...) = _allequal(spacetype, (x, y, z...)) +@noinline function check_spacetype(x, y, z...) + check_spacetype(Bool, x, y, z...) || throw(SpaceMismatch("incompatible space types")) + return spacetype(x) +end + # make ElementarySpace instances behave similar to ProductSpace instances blocksectors(V::ElementarySpace) = collect(sectors(V)) blockdim(V::ElementarySpace, c::Sector) = dim(V, c) diff --git a/src/tensors/diagonal.jl b/src/tensors/diagonal.jl index c191bb6b5..4064ea910 100644 --- a/src/tensors/diagonal.jl +++ b/src/tensors/diagonal.jl @@ -263,8 +263,8 @@ function TO.tensorcontract_type( M = similarstoragetype(A, TC) M == similarstoragetype(B, TC) || throw(ArgumentError("incompatible storage types:\n$(M) ≠ $(similarstoragetype(B, TC))")) - spacetype(A) == spacetype(B) || throw(SpaceMismatch("incompatible space types")) - return DiagonalTensorMap{TC, spacetype(A), M} + S = check_spacetype(A, B) + return DiagonalTensorMap{TC, S, M} end function TO.tensoralloc( diff --git a/src/tensors/indexmanipulations.jl b/src/tensors/indexmanipulations.jl index 0c918e85e..d6a073ec9 100644 --- a/src/tensors/indexmanipulations.jl +++ b/src/tensors/indexmanipulations.jl @@ -413,7 +413,7 @@ end spacecheck_transform(f, tdst::AbstractTensorMap, tsrc::AbstractTensorMap, args...) = spacecheck_transform(f, space(tdst), space(tsrc), args...) @noinline function spacecheck_transform(f, Vdst::TensorMapSpace, Vsrc::TensorMapSpace, p::Index2Tuple) - spacetype(Vdst) == spacetype(Vsrc) || throw(SectorMismatch("incompatible sector types")) + check_spacetype(Vdst, Vsrc) f(Vsrc, p) == Vdst || throw( SpaceMismatch( @@ -427,7 +427,7 @@ spacecheck_transform(f, tdst::AbstractTensorMap, tsrc::AbstractTensorMap, args.. return nothing end @noinline function spacecheck_transform(::typeof(braid), Vdst::TensorMapSpace, Vsrc::TensorMapSpace, p::Index2Tuple, levels::IndexTuple) - spacetype(Vdst) == spacetype(Vsrc) || throw(SectorMismatch("incompatible sector types")) + check_spacetype(Vdst, Vsrc) braid(Vsrc, p, levels) == Vdst || throw( SpaceMismatch( diff --git a/src/tensors/linalg.jl b/src/tensors/linalg.jl index d174bef71..e122821a0 100644 --- a/src/tensors/linalg.jl +++ b/src/tensors/linalg.jl @@ -538,8 +538,7 @@ absorb(tdst::AbstractTensorMap, tsrc::AbstractTensorMap) = absorb!(copy(tdst), t function absorb!(tdst::AbstractTensorMap, tsrc::AbstractTensorMap) numin(tdst) == numin(tsrc) && numout(tdst) == numout(tsrc) || throw(DimensionError("Incompatible number of indices for source and destination")) - S = spacetype(tdst) - S == spacetype(tsrc) || throw(SpaceMismatch("incompatible spacetypes")) + S = check_spacetype(tdst, tsrc) dom = mapreduce(infimum, ⊗, domain(tdst), domain(tsrc); init = one(S)) cod = mapreduce(infimum, ⊗, codomain(tdst), codomain(tsrc); init = one(S)) for (f1, f2) in fusiontrees(cod ← dom) @@ -561,7 +560,7 @@ new `TensorMap` instance whose codomain is `codomain(t1) ⊗ codomain(t2)` and w is `domain(t1) ⊗ domain(t2)`. """ function ⊗(A::AbstractTensorMap, B::AbstractTensorMap) - (S = spacetype(A)) === spacetype(B) || throw(SpaceMismatch("incompatible space types")) + check_spacetype(A, B) # allocate destination with correct scalartype pA = ((codomainind(A)..., domainind(A)...), ()) diff --git a/src/tensors/tensoroperations.jl b/src/tensors/tensoroperations.jl index 6b01d1b2c..9454dcf87 100644 --- a/src/tensors/tensoroperations.jl +++ b/src/tensors/tensoroperations.jl @@ -103,7 +103,7 @@ end VB::TensorMapSpace, pB::Index2Tuple, conjB::Bool, pAB::Index2Tuple ) - spacetype(VC) == spacetype(VA) == spacetype(VB) || throw(SectorMismatch("incompatible sector types")) + check_spacetype(VC, VA, VB) TO.tensorcontract(VA, pA, conjA, VB, pB, conjB, pAB) == VC || throw( SpaceMismatch( @@ -153,11 +153,11 @@ function TO.tensorcontract_type( B::AbstractTensorMap, ::Index2Tuple, ::Bool, ::Index2Tuple{N₁, N₂} ) where {N₁, N₂} - spacetype(A) == spacetype(B) || throw(SpaceMismatch("incompatible space types")) + S = check_spacetype(A, B) I = sectortype(A) TC′ = isreal(I) ? TC : complex(TC) M = promote_storagetype(similarstoragetype(A, TC′), similarstoragetype(B, TC′)) - return tensormaptype(spacetype(A), N₁, N₂, M) + return tensormaptype(S, N₁, N₂, M) end # TODO: handle actual promotion rule system @@ -213,8 +213,7 @@ function trace_permute!( backend = TO.DefaultBackend() ) # some input checks - (S = spacetype(tdst)) == spacetype(tsrc) || - throw(SpaceMismatch("incompatible spacetypes")) + S = check_spacetype(tdst, tsrc) if !(BraidingStyle(sectortype(S)) isa SymmetricBraiding) throw(SectorMismatch("only tensors with symmetric braiding rules can be contracted; try `@planar` instead")) end From 05b997ef191a6124b6003029fb27b00cb8e6b171 Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Fri, 30 Jan 2026 14:59:26 -0500 Subject: [PATCH 03/52] `compose_dest` without complex promotion --- src/tensors/diagonal.jl | 9 +++++++++ src/tensors/linalg.jl | 16 +++++++--------- 2 files changed, 16 insertions(+), 9 deletions(-) diff --git a/src/tensors/diagonal.jl b/src/tensors/diagonal.jl index 4064ea910..ed3ae42c5 100644 --- a/src/tensors/diagonal.jl +++ b/src/tensors/diagonal.jl @@ -291,6 +291,15 @@ function Base.zero(d::DiagonalTensorMap) return DiagonalTensorMap(zero.(d.data), d.domain) end +function compose_dest(A::DiagonalTensorMap, B::DiagonalTensorMap) + S = check_spacetype(A, B) + TC = TO.promote_contract(scalartype(A), scalartype(B), One) + M = promote_storagetype(similarstoragetype(A, TC), similarstoragetype(B, TC)) + TTC = DiagonalTensorMap{TC, S, M} + structure = codomain(A) ← domain(B) + return TO.tensoralloc(TTC, structure, Val(false)) +end + function LinearAlgebra.mul!( dC::DiagonalTensorMap, dA::DiagonalTensorMap, dB::DiagonalTensorMap, α::Number, β::Number ) diff --git a/src/tensors/linalg.jl b/src/tensors/linalg.jl index e122821a0..e28ec8153 100644 --- a/src/tensors/linalg.jl +++ b/src/tensors/linalg.jl @@ -19,17 +19,15 @@ LinearAlgebra.normalize!(t::AbstractTensorMap, p::Real = 2) = scale!(t, inv(norm LinearAlgebra.normalize(t::AbstractTensorMap, p::Real = 2) = scale(t, inv(norm(t, p))) # destination allocation for matrix multiplication +# note that we don't fall back to `tensoralloc_contract` since that needs to account for +# permutations, which might require complex scalartypes even if the inputs are real. function compose_dest(A::AbstractTensorMap, B::AbstractTensorMap) + S = check_spacetype(A, B) TC = TO.promote_contract(scalartype(A), scalartype(B), One) - pA = (codomainind(A), domainind(A)) - pB = (codomainind(B), domainind(B)) - pAB = (codomainind(A), ntuple(i -> i + numout(A), numin(B))) - return TO.tensoralloc_contract( - TC, - A, pA, false, - B, pB, false, - pAB, Val(false) - ) + M = promote_storagetype(similarstoragetype(A, TC), similarstoragetype(B, TC)) + TTC = tensormaptype(S, numout(A), numin(B), M) + structure = codomain(A) ← domain(B) + return TO.tensoralloc(TTC, structure, Val(false)) end """ From f878cc729af7778bc2fb853e09d2f0d9fecf6e14 Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Fri, 30 Jan 2026 14:59:36 -0500 Subject: [PATCH 04/52] use `promote_storagetype` --- src/tensors/diagonal.jl | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/tensors/diagonal.jl b/src/tensors/diagonal.jl index ed3ae42c5..169ef38c9 100644 --- a/src/tensors/diagonal.jl +++ b/src/tensors/diagonal.jl @@ -260,10 +260,8 @@ function TO.tensorcontract_type( B::DiagonalTensorMap, ::Index2Tuple{1, 1}, ::Bool, ::Index2Tuple{1, 1} ) - M = similarstoragetype(A, TC) - M == similarstoragetype(B, TC) || - throw(ArgumentError("incompatible storage types:\n$(M) ≠ $(similarstoragetype(B, TC))")) S = check_spacetype(A, B) + M = promote_storagetype(similarstoragetype(A, TC), similarstoragetype(B, TC)) return DiagonalTensorMap{TC, S, M} end From 48a9fe31178fbc7841a40ad564d162933250b7bb Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Fri, 30 Jan 2026 14:59:44 -0500 Subject: [PATCH 05/52] twist! with complex promotion --- src/tensors/indexmanipulations.jl | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/tensors/indexmanipulations.jl b/src/tensors/indexmanipulations.jl index d6a073ec9..a08504c32 100644 --- a/src/tensors/indexmanipulations.jl +++ b/src/tensors/indexmanipulations.jl @@ -296,6 +296,10 @@ function twist!(t::AbstractTensorMap, inds; inv::Bool = false) throw(ArgumentError(msg)) end has_shared_twist(t, inds) && return t + + (scalartype(t) <: Real && !(sectorscalartype(sectortype(t)) <: Real)) && + throw(ArgumentError("No in-place `twist!` for a real tensor with complex sector type")) + N₁ = numout(t) for (f₁, f₂) in fusiontrees(t) θ = prod(i -> i <= N₁ ? twist(f₁.uncoupled[i]) : twist(f₂.uncoupled[i - N₁]), inds) @@ -317,7 +321,8 @@ See [`twist!`](@ref) for storing the result in place. """ function twist(t::AbstractTensorMap, inds; inv::Bool = false, copy::Bool = false) !copy && has_shared_twist(t, inds) && return t - return twist!(Base.copy(t), inds; inv) + tdst = similar(t, sectorscalartype(sectortype(t)) <: Real ? scalartype(t) : complex(scalartype(t))) + return twist!(tdst, inds; inv) end # Methods which change the number of indices, implement using `Val(i)` for type inference From 7de05cb36a0497f0e72e76056a088c6d58043291 Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Fri, 30 Jan 2026 15:01:23 -0500 Subject: [PATCH 06/52] flip with complex promotion --- src/tensors/indexmanipulations.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tensors/indexmanipulations.jl b/src/tensors/indexmanipulations.jl index a08504c32..2c5b5e7ae 100644 --- a/src/tensors/indexmanipulations.jl +++ b/src/tensors/indexmanipulations.jl @@ -15,7 +15,7 @@ Return a new tensor that is isomorphic to `t` but where the arrows on the indice """ function flip(t::AbstractTensorMap, I; inv::Bool = false) P = flip(space(t), I) - t′ = similar(t, P) + t′ = sectorscalartype(sectortype(t)) <: Real ? similar(t, P) : similar(t, complex(scalartype(t)), P) for (f₁, f₂) in fusiontrees(t) (f₁′, f₂′), factor = only(flip(f₁, f₂, I; inv)) scale!(t′[f₁′, f₂′], t[f₁, f₂], factor) From 688434e981673d098ccab7fd21819844c430e200 Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Fri, 30 Jan 2026 15:35:10 -0500 Subject: [PATCH 07/52] try and centralize tensor allocation --- src/tensors/abstracttensor.jl | 5 +++ src/tensors/diagonal.jl | 3 +- src/tensors/indexmanipulations.jl | 71 ++++++++++--------------------- src/tensors/tensoroperations.jl | 6 +-- 4 files changed, 31 insertions(+), 54 deletions(-) diff --git a/src/tensors/abstracttensor.jl b/src/tensors/abstracttensor.jl index 4b3149a4c..0f580c17c 100644 --- a/src/tensors/abstracttensor.jl +++ b/src/tensors/abstracttensor.jl @@ -103,6 +103,11 @@ similarstoragetype(::Type{D}, ::Type{T}) where {D <: AbstractDict{<:Sector, <:Ab similarstoragetype(::Type{T}) where {T <: Number} = Vector{T} +# helper function to determine the scalartype taking into account that recouplings might happen +recoupled_scalartype(::Type{T}, ::Type{I}) where {T <: Number, I <: Sector} = isreal(I) ? T : complex(T) +recoupled_scalartype(t::AbstractTensorMap) = recoupled_scalartype(typeof(t)) +recoupled_scalartype(::Type{T}) where {T <: AbstractTensorMap} = recoupled_scalartype(scalartype(T), sectortype(T)) + # tensor characteristics: space and index information #----------------------------------------------------- """ diff --git a/src/tensors/diagonal.jl b/src/tensors/diagonal.jl index 169ef38c9..f25a81961 100644 --- a/src/tensors/diagonal.jl +++ b/src/tensors/diagonal.jl @@ -261,7 +261,8 @@ function TO.tensorcontract_type( ::Index2Tuple{1, 1} ) S = check_spacetype(A, B) - M = promote_storagetype(similarstoragetype(A, TC), similarstoragetype(B, TC)) + TC′ = recoupled_scalartype(TC, sectortype(S)) + M = promote_storagetype(similarstoragetype(A, TC′), similarstoragetype(B, TC′)) return DiagonalTensorMap{TC, S, M} end diff --git a/src/tensors/indexmanipulations.jl b/src/tensors/indexmanipulations.jl index 2c5b5e7ae..041eec608 100644 --- a/src/tensors/indexmanipulations.jl +++ b/src/tensors/indexmanipulations.jl @@ -15,7 +15,7 @@ Return a new tensor that is isomorphic to `t` but where the arrows on the indice """ function flip(t::AbstractTensorMap, I; inv::Bool = false) P = flip(space(t), I) - t′ = sectorscalartype(sectortype(t)) <: Real ? similar(t, P) : similar(t, complex(scalartype(t)), P) + t′ = similar(t, recoupled_scalartype(t), P) for (f₁, f₂) in fusiontrees(t) (f₁′, f₂′), factor = only(flip(f₁, f₂, I; inv)) scale!(t′[f₁′, f₂′], t[f₁, f₂], factor) @@ -39,53 +39,35 @@ See [`permute`](@ref) for creating a new tensor and [`add_permute!`](@ref) for a end """ - permute(tsrc::AbstractTensorMap, (p₁, p₂)::Index2Tuple; - copy::Bool=false) - -> tdst::TensorMap + permute(tsrc::AbstractTensorMap, (p₁, p₂)::Index2Tuple; copy::Bool = false) -> tdst::TensorMap Return tensor `tdst` obtained by permuting the indices of `tsrc`. The codomain and domain of `tdst` correspond to the indices in `p₁` and `p₂` of `tsrc` respectively. -If `copy=false`, `tdst` might share data with `tsrc` whenever possible. Otherwise, a copy is always made. +If `copy = false`, `tdst` might share data with `tsrc` whenever possible. +Otherwise, a copy is always made. To permute into an existing destination, see [permute!](@ref) and [`add_permute!`](@ref) """ -function permute( - t::AbstractTensorMap, (p₁, p₂)::Index2Tuple{N₁, N₂}; copy::Bool = false - ) where {N₁, N₂} - space′ = permute(space(t), (p₁, p₂)) - # share data if possible - if !copy && p₁ === codomainind(t) && p₂ === domainind(t) - return t - end - # general case - @inbounds begin - return permute!(similar(t, space′), t, (p₁, p₂)) - end -end -function permute(t::TensorMap, (p₁, p₂)::Index2Tuple{N₁, N₂}; copy::Bool = false) where {N₁, N₂} - space′ = permute(space(t), (p₁, p₂)) +function permute(t::AbstractTensorMap, (p₁, p₂)::Index2Tuple; copy::Bool = false) # share data if possible if !copy if p₁ === codomainind(t) && p₂ === domainind(t) return t - elseif has_shared_permute(t, (p₁, p₂)) + elseif t isa TensorMap && has_shared_permute(t, (p₁, p₂)) return TensorMap(t.data, space′) end end + tdst = TO.tensoralloc_add(scalartype(t), t, (p₁, p₂), false, Val(false)) # general case - @inbounds begin - return permute!(similar(t, space′), t, (p₁, p₂)) - end + return @inbounds permute!(tdst, t, (p₁, p₂)) end function permute(t::AdjointTensorMap, (p₁, p₂)::Index2Tuple; copy::Bool = false) p₁′ = adjointtensorindices(t, p₂) p₂′ = adjointtensorindices(t, p₁) return adjoint(permute(adjoint(t), (p₁′, p₂′); copy)) end -function permute(t::AbstractTensorMap, p::IndexTuple; copy::Bool = false) - return permute(t, (p, ()); copy) -end +permute(t::AbstractTensorMap, p::IndexTuple; copy::Bool = false) = permute(t, (p, ()); copy) function has_shared_permute(t::AbstractTensorMap, (p₁, p₂)::Index2Tuple) return (p₁ === codomainind(t) && p₂ === domainind(t)) @@ -145,18 +127,14 @@ To braid into an existing destination, see [braid!](@ref) and [`add_braid!`](@re function braid( t::AbstractTensorMap, (p₁, p₂)::Index2Tuple, levels::IndexTuple; copy::Bool = false ) - @assert length(levels) == numind(t) - if BraidingStyle(sectortype(t)) isa SymmetricBraiding - return permute(t, (p₁, p₂); copy = copy) - end - if !copy && p₁ == codomainind(t) && p₂ == domainind(t) - return t - end + length(levels) == numind(t) || throw(ArgumentError("invalid levels")) + + BraidingStyle(sectortype(t)) isa SymmetricBraiding && return permute(t, (p₁, p₂); copy = copy) + (!copy && p₁ == codomainind(t) && p₂ == domainind(t)) && return t + # general case - space′ = permute(space(t), (p₁, p₂)) - @inbounds begin - return braid!(similar(t, space′), t, (p₁, p₂), levels) - end + tdst = TO.tensoralloc_add(scalartype(t), t, (p₁, p₂), false, Val(false)) + return @inbounds braid!(tdst, t, (p₁, p₂), levels) end # TODO: braid for `AdjointTensorMap`; think about how to map the `levels` argument. @@ -199,17 +177,12 @@ function LinearAlgebra.transpose( t::AbstractTensorMap, (p₁, p₂)::Index2Tuple = _transpose_indices(t); copy::Bool = false ) - if sectortype(t) === Trivial - return permute(t, (p₁, p₂); copy = copy) - end - if !copy && p₁ == codomainind(t) && p₂ == domainind(t) - return t - end + sectortype(t) === Trivial && return permute(t, (p₁, p₂); copy) + (!copy && p₁ == codomainind(t) && p₂ == domainind(t)) && return t + # general case - space′ = permute(space(t), (p₁, p₂)) - @inbounds begin - return transpose!(similar(t, space′), t, (p₁, p₂)) - end + tdst = TO.tensoralloc_add(scalartype(t), t, (p₁, p₂), false, Val(false)) + return @inbounds transpose!(tdst, t, (p₁, p₂)) end function LinearAlgebra.transpose( @@ -321,7 +294,7 @@ See [`twist!`](@ref) for storing the result in place. """ function twist(t::AbstractTensorMap, inds; inv::Bool = false, copy::Bool = false) !copy && has_shared_twist(t, inds) && return t - tdst = similar(t, sectorscalartype(sectortype(t)) <: Real ? scalartype(t) : complex(scalartype(t))) + tdst = TO.tensoralloc_add(scalartype(t), (codomainind(t), domainind(t)), false, Val(false)) return twist!(tdst, inds; inv) end diff --git a/src/tensors/tensoroperations.jl b/src/tensors/tensoroperations.jl index 9454dcf87..bc5d4beeb 100644 --- a/src/tensors/tensoroperations.jl +++ b/src/tensors/tensoroperations.jl @@ -54,8 +54,7 @@ end function TO.tensoradd_type( TC, A::AbstractTensorMap, ::Index2Tuple{N₁, N₂}, ::Bool ) where {N₁, N₂} - I = sectortype(A) - M = similarstoragetype(A, sectorscalartype(I) <: Real ? TC : complex(TC)) + M = similarstoragetype(A, recoupled_scalartype(TC, sectortype(A))) return tensormaptype(spacetype(A), N₁, N₂, M) end @@ -154,8 +153,7 @@ function TO.tensorcontract_type( ::Index2Tuple{N₁, N₂} ) where {N₁, N₂} S = check_spacetype(A, B) - I = sectortype(A) - TC′ = isreal(I) ? TC : complex(TC) + TC′ = recoupled_scalartype(TC, sectortype(S)) M = promote_storagetype(similarstoragetype(A, TC′), similarstoragetype(B, TC′)) return tensormaptype(S, N₁, N₂, M) end From dc98966f3101e23d76b22064eb170b4f73598df6 Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Fri, 30 Jan 2026 15:56:40 -0500 Subject: [PATCH 08/52] update link in docs --- docs/src/lib/tensors.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/lib/tensors.md b/docs/src/lib/tensors.md index 3e9520cbc..6bb19dee7 100644 --- a/docs/src/lib/tensors.md +++ b/docs/src/lib/tensors.md @@ -184,7 +184,7 @@ type `add_transform!`, for additional expert-mode options that allows for additi scaling, as well as the selection of a custom backend. ```@docs -permute(::AbstractTensorMap, ::Index2Tuple{N₁,N₂}) where {N₁,N₂} +permute(::AbstractTensorMap, ::Index2Tuple) braid(::AbstractTensorMap, ::Index2Tuple, ::IndexTuple) transpose(::AbstractTensorMap, ::Index2Tuple) repartition(::AbstractTensorMap, ::Int, ::Int) From 561bbedb13ba971d60e950f6b686a370dce4235d Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Fri, 30 Jan 2026 15:58:27 -0500 Subject: [PATCH 09/52] fix reference to unused variable --- src/tensors/indexmanipulations.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tensors/indexmanipulations.jl b/src/tensors/indexmanipulations.jl index 041eec608..d30a732a5 100644 --- a/src/tensors/indexmanipulations.jl +++ b/src/tensors/indexmanipulations.jl @@ -55,7 +55,7 @@ function permute(t::AbstractTensorMap, (p₁, p₂)::Index2Tuple; copy::Bool = f if p₁ === codomainind(t) && p₂ === domainind(t) return t elseif t isa TensorMap && has_shared_permute(t, (p₁, p₂)) - return TensorMap(t.data, space′) + return TensorMap(t.data, permute(space(t), (p₁, p₂))) end end tdst = TO.tensoralloc_add(scalartype(t), t, (p₁, p₂), false, Val(false)) From df2bb3faa5ac9be2ff72dfd59bc20e2b2da08a60 Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Sat, 17 Jan 2026 09:03:23 +0100 Subject: [PATCH 10/52] add `arrayify` for adjoint tensor --- ext/TensorKitMooncakeExt/tangent.jl | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/ext/TensorKitMooncakeExt/tangent.jl b/ext/TensorKitMooncakeExt/tangent.jl index 761e626f0..9fa6e401a 100644 --- a/ext/TensorKitMooncakeExt/tangent.jl +++ b/ext/TensorKitMooncakeExt/tangent.jl @@ -5,3 +5,11 @@ function Mooncake.arrayify(A_dA::CoDual{<:TensorMap}) dA = typeof(A)(data, A.space) return A, dA end + +function Mooncake.arrayify(Aᴴ_ΔAᴴ::CoDual{<:TensorKit.AdjointTensorMap}) + Aᴴ = Mooncake.primal(Aᴴ_ΔAᴴ) + ΔAᴴ = Mooncake.tangent(Aᴴ_ΔAᴴ) + A_ΔA = CoDual(Aᴴ', ΔAᴴ.data.parent) + A, ΔA = arrayify(A_ΔA) + return A', ΔA' +end From 652521ff20fa15bd58a42fc397ce1a46bf9c45fb Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Sat, 17 Jan 2026 09:03:29 +0100 Subject: [PATCH 11/52] add vectorinterface rules --- .../TensorKitMooncakeExt.jl | 6 +- ext/TensorKitMooncakeExt/vectorinterface.jl | 93 +++++++++++++++++++ test/autodiff/mooncake.jl | 25 +++++ 3 files changed, 121 insertions(+), 3 deletions(-) create mode 100644 ext/TensorKitMooncakeExt/vectorinterface.jl diff --git a/ext/TensorKitMooncakeExt/TensorKitMooncakeExt.jl b/ext/TensorKitMooncakeExt/TensorKitMooncakeExt.jl index b35c73f4c..2cc64f49b 100644 --- a/ext/TensorKitMooncakeExt/TensorKitMooncakeExt.jl +++ b/ext/TensorKitMooncakeExt/TensorKitMooncakeExt.jl @@ -1,17 +1,17 @@ module TensorKitMooncakeExt using Mooncake -using Mooncake: @zero_derivative, DefaultCtx, ReverseMode, NoRData, CoDual, arrayify, primal +using Mooncake: @zero_derivative, DefaultCtx, ReverseMode, NoFData, NoRData, CoDual, arrayify, primal using TensorKit +using VectorInterface using TensorOperations: TensorOperations, IndexTuple, Index2Tuple, linearize import TensorOperations as TO -using VectorInterface: One, Zero using TupleTools - include("utility.jl") include("tangent.jl") include("linalg.jl") +include("vectorinterface.jl") include("tensoroperations.jl") end diff --git a/ext/TensorKitMooncakeExt/vectorinterface.jl b/ext/TensorKitMooncakeExt/vectorinterface.jl new file mode 100644 index 000000000..2c1bfe984 --- /dev/null +++ b/ext/TensorKitMooncakeExt/vectorinterface.jl @@ -0,0 +1,93 @@ +Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(scale!), AbstractTensorMap, Number} + +function Mooncake.rrule!!(::CoDual{typeof(scale!)}, C_ΔC::CoDual{<:AbstractTensorMap}, α_Δα::CoDual{<:Number}) + # prepare arguments + C, ΔC = arrayify(C_ΔC) + α = primal(α_Δα) + + # primal call + C_cache = copy(C) + scale!(C, α) + + function scale_pullback(::NoRData) + copy!(C, C_cache) + scale!(ΔC, conj(α)) + TΔα = Mooncake.rdata_type(Mooncake.tangent_type(typeof(α))) + Δαr = TΔα === NoRData ? NoRData() : inner(C, ΔC) + return NoRData(), NoRData(), Δαr + end + + return C_ΔC, scale_pullback +end + +Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(scale!), AbstractTensorMap, AbstractTensorMap, Number} + +function Mooncake.rrule!!(::CoDual{typeof(scale!)}, C_ΔC::CoDual{<:AbstractTensorMap}, A_ΔA::CoDual{<:AbstractTensorMap}, α_Δα::CoDual{<:Number}) + # prepare arguments + C, ΔC = arrayify(C_ΔC) + A, ΔA = arrayify(A_ΔA) + α = primal(α_Δα) + + # primal call + C_cache = copy(C) + scale!(C, A, α) + + function scale_pullback(::NoRData) + copy!(C, C_cache) + zerovector!(ΔC) + scale!(ΔA, conj(α)) + TΔα = Mooncake.rdata_type(Mooncake.tangent_type(typeof(α))) + Δαr = TΔα === NoRData ? NoRData() : inner(C, ΔC) + return NoRData(), NoRData(), NoRData(), Δαr + end + + return C_ΔC, scale_pullback +end + +Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(add!), AbstractTensorMap, AbstractTensorMap, Number, Number} + +function Mooncake.rrule!!(::CoDual{typeof(add!)}, C_ΔC::CoDual{<:AbstractTensorMap}, A_ΔA::CoDual{<:AbstractTensorMap}, α_Δα::CoDual{<:Number}, β_Δβ::CoDual{<:Number}) + # prepare arguments + C, ΔC = arrayify(C_ΔC) + A, ΔA = arrayify(A_ΔA) + α = primal(α_Δα) + β = primal(β_Δβ) + + # primal call + C_cache = copy(C) + add!(C, A, α, β) + + function add_pullback(::NoRData) + copy!(C, C_cache) + scale!(ΔC, conj(β)) + scale!(ΔA, conj(α)) + + TΔα = Mooncake.rdata_type(Mooncake.tangent_type(typeof(α))) + Δαr = TΔα === NoRData ? NoRData() : inner(A, ΔC) + TΔβ = Mooncake.rdata_type(Mooncake.tangent_type(typeof(β))) + Δβr = TΔβ === NoRData ? NoRData() : inner(C, ΔC) + + return NoRData(), NoRData(), NoRData(), Δαr, Δβr + end + + return C_ΔC, add_pullback +end + +Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(inner), AbstractTensorMap, AbstractTensorMap} + +function Mooncake.rrule!!(::CoDual{typeof(inner)}, A_ΔA::CoDual{<:AbstractTensorMap}, B_ΔB::CoDual{<:AbstractTensorMap}) + # prepare arguments + A, ΔA = arrayify(A_ΔA) + B, ΔB = arrayify(B_ΔB) + + # primal call + s = inner(A, B) + + function inner_pullback(Δs) + scale!(ΔA, B, conj(Δs)) + scale!(ΔB, A, Δs) + return NoRData(), NoRData(), NoRData() + end + + return CoDual(s, NoFData()), inner_pullback +end diff --git a/test/autodiff/mooncake.jl b/test/autodiff/mooncake.jl index 1cd74fa27..37eb932b5 100644 --- a/test/autodiff/mooncake.jl +++ b/test/autodiff/mooncake.jl @@ -68,6 +68,31 @@ for V in spacelist println("Mooncake with symmetry: $Istr") println("---------------------------------------") eltypes = (Float64,) # no complex support yet + + @timedtestset "VectorInterface with scalartype $T" for T in eltypes + atol = precision(T) + rtol = precision(T) + + C = randn(T, V[1] ⊗ V[2] ← V[3] ⊗ V[4] ⊗ V[5]) + A = randn(T, V[1] ⊗ V[2] ← V[3] ⊗ V[4] ⊗ V[5]) + α = randn(T) + β = randn(T) + + Mooncake.TestUtils.test_rule(rng, scale!, C, α; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, scale!, C', α; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, scale!, C, A, α; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, scale!, C', A', α; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, scale!, copy(C'), A', α; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, scale!, C', copy(A'), α; atol, rtol, mode) + + Mooncake.TestUtils.test_rule(rng, add!, C, A; atol, rtol, mode, is_primitive = false) + Mooncake.TestUtils.test_rule(rng, add!, C, A, α; atol, rtol, mode, is_primitive = false) + Mooncake.TestUtils.test_rule(rng, add!, C, A, α, β; atol, rtol, mode) + + Mooncake.TestUtils.test_rule(rng, inner, C, A; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, inner, C', A'; atol, rtol, mode) + end + symmetricbraiding && @timedtestset "TensorOperations with scalartype $T" for T in eltypes atol = precision(T) rtol = precision(T) From 127a4bec352090540fac95214e368c8c739360be Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Sat, 17 Jan 2026 12:37:19 +0100 Subject: [PATCH 12/52] add tensoroperations rules --- ext/TensorKitMooncakeExt/tensoroperations.jl | 178 +++++++++++++++++++ test/autodiff/mooncake.jl | 44 +++++ 2 files changed, 222 insertions(+) diff --git a/ext/TensorKitMooncakeExt/tensoroperations.jl b/ext/TensorKitMooncakeExt/tensoroperations.jl index d663a3281..7b9a674f8 100644 --- a/ext/TensorKitMooncakeExt/tensoroperations.jl +++ b/ext/TensorKitMooncakeExt/tensoroperations.jl @@ -1,3 +1,91 @@ +# tensoradd! +# ---------- +Mooncake.@is_primitive( + DefaultCtx, + ReverseMode, + Tuple{ + typeof(TO.tensoradd!), + AbstractTensorMap, + AbstractTensorMap, Index2Tuple, Bool, + Number, Number, Vararg{Any}, + } +) + +function Mooncake.rrule!!( + ::CoDual{typeof(TO.tensoradd!)}, + C_ΔC::CoDual{<:AbstractTensorMap}, + A_ΔA::CoDual{<:AbstractTensorMap}, pA_ΔpA::CoDual{<:Index2Tuple}, conjA_ΔconjA::CoDual{Bool}, + α_Δα::CoDual{<:Number}, β_Δβ::CoDual{<:Number}, + ba_Δba::CoDual... + ) + # prepare arguments + C, ΔC = arrayify(C_ΔC) + A, ΔA = arrayify(A_ΔA) + pA = primal(pA_ΔpA) + conjA = primal(conjA_ΔconjA) + α, β = primal.((α_Δα, β_Δβ)) + ba = primal.(ba_Δba) + + # primal call + C_cache = copy(C) + TO.tensoradd!(C, A, pA, conjA, α, β, ba...) + + function tensoradd_pullback(::NoRData) + copy!(C, C_cache) + + ΔCr = tensoradd_pullback_ΔC!(ΔC, β) + ΔAr = tensoradd_pullback_ΔA!(ΔA, ΔC, A, pA, conjA, α, ba...) + Δαr = tensoradd_pullback_Δα(ΔC, A, pA, conjA, α, ba...) + Δβr = tensoradd_pullback_Δβ(ΔC, C, β) + + return NoRData(), + ΔCr, + ΔAr, NoRData(), NoRData(), + Δαr, Δβr, + map(Returns(NoRData()), ba)... + end + + return C_ΔC, tensoradd_pullback +end + +tensoradd_pullback_ΔC!(ΔC, β) = (scale!(ΔC, conj(β)); NoRData()) + +function tensoradd_pullback_ΔA!( + ΔA, ΔC, A, pA, conjA, α, ba... + ) + ipA = invperm(linearize(pA)) + pΔA = _repartition(ipA, A) + TO.tensoradd!(ΔA, ΔC, pΔA, conjA, conjA ? α : conj(α), Zero(), ba...) + return NoRData() +end + +function tensoradd_pullback_Δα( + ΔC, A, pA, conjA, α, ba... + ) + Tdα = Mooncake.rdata_type(Mooncake.tangent_type(typeof(α))) + Tdα === NoRData && return NoRData() + + tΔC = twist(ΔC, filter(x -> isdual(space(ΔC, x)), allind(ΔC)); copy = false) + Δα = TO.tensorscalar( + TO.tensorcontract( + A, ((), linearize(pA)), !conjA, + tΔC, (trivtuple(TO.numind(pA)), ()), false, + ((), ()), One(), ba... + ) + ) + return Mooncake._rdata(Δα) +end + +function tensoradd_pullback_Δβ(ΔC, C, β) + Tdβ = Mooncake.rdata_type(Mooncake.tangent_type(typeof(β))) + Tdβ === NoRData && return NoRData() + + Δβ = inner(C, ΔC) + return Mooncake._rdata(Δβ) +end + +# tensorcontract! +# --------------- Mooncake.@is_primitive( DefaultCtx, ReverseMode, @@ -135,3 +223,93 @@ function tensorcontract_pullback_Δβ(ΔC, C, β) Δβ = inner(C, ΔC) return Mooncake._rdata(Δβ) end + +# tensortrace! +# ------------ +Mooncake.@is_primitive( + DefaultCtx, + ReverseMode, + Tuple{ + typeof(TO.tensortrace!), + AbstractTensorMap, + AbstractTensorMap, Index2Tuple, Index2Tuple, Bool, + Number, Number, + Vararg{Any}, + } +) + +function Mooncake.rrule!!( + ::CoDual{typeof(TO.tensortrace!)}, + C_ΔC::CoDual{<:AbstractTensorMap}, + A_ΔA::CoDual{<:AbstractTensorMap}, p_Δp::CoDual{<:Index2Tuple}, q_Δq::CoDual{<:Index2Tuple}, conjA_ΔconjA::CoDual{Bool}, + α_Δα::CoDual{<:Number}, β_Δβ::CoDual{<:Number}, + ba_Δba::CoDual... + ) + # prepare arguments + C, ΔC = arrayify(C_ΔC) + A, ΔA = arrayify(A_ΔA) + p = primal(p_Δp) + q = primal(q_Δq) + conjA = primal(conjA_ΔconjA) + α, β = primal.((α_Δα, β_Δβ)) + ba = primal.(ba_Δba) + + # primal call + C_cache = copy(C) + TO.tensortrace!(C, A, p, q, conjA, α, β, ba...) + + function tensortrace_pullback(::NoRData) + copy!(C, C_cache) + + ΔCr = tensortrace_pullback_ΔC!(ΔC, β) + ΔAr = tensortrace_pullback_ΔA!(ΔA, ΔC, A, p, q, conjA, α, ba...) + Δαr = tensortrace_pullback_Δα(ΔC, A, p, q, conjA, α, ba...) + Δβr = tensortrace_pullback_Δβ(ΔC, C, β) + + return NoRData(), + ΔCr, + ΔAr, NoRData(), NoRData(), NoRData(), + Δαr, Δβr, + map(Returns(NoRData()), ba)... + end + + return C_ΔC, tensortrace_pullback +end + +tensortrace_pullback_ΔC!(ΔC, β) = (scale!(ΔC, conj(β)); NoRData()) + +function tensortrace_pullback_ΔA!( + ΔA, ΔC, A, p, q, conjA, α, ba... + ) + ip = invperm((linearize(p)..., q[1]..., q[2]...)) + pdA = _repartition(ip, A) + E = one!(TO.tensoralloc_add(scalartype(A), A, q, conjA)) + twist!(E, filter(x -> !isdual(space(E, x)), codomainind(E))) + pE = ((), trivtuple(TO.numind(q))) + pΔC = (trivtuple(TO.numind(p)), ()) + TO.tensorproduct!( + ΔA, ΔC, pΔC, conjA, E, pE, conjA, pdA, conjA ? α : conj(α), Zero(), ba... + ) + return NoRData() +end + +function tensortrace_pullback_Δα( + ΔC, A, p, q, conjA, α, ba... + ) + Tdα = Mooncake.rdata_type(Mooncake.tangent_type(typeof(α))) + Tdα === NoRData && return NoRData() + + # TODO: this result might be easier to compute as: + # C′ = βC + α * trace(A) ⟹ At = (C′ - βC) / α + At = TO.tensortrace(A, p, q, conjA) + Δα = inner(At, ΔC) + return Mooncake._rdata(Δα) +end + +function tensortrace_pullback_Δβ(ΔC, C, β) + Tdβ = Mooncake.rdata_type(Mooncake.tangent_type(typeof(β))) + Tdβ === NoRData && return NoRData() + + Δβ = inner(C, ΔC) + return Mooncake._rdata(Δβ) +end diff --git a/test/autodiff/mooncake.jl b/test/autodiff/mooncake.jl index 37eb932b5..38fa23c15 100644 --- a/test/autodiff/mooncake.jl +++ b/test/autodiff/mooncake.jl @@ -97,6 +97,25 @@ for V in spacelist atol = precision(T) rtol = precision(T) + @timedtestset "tensoradd!" begin + A = randn(T, V[1] ⊗ V[2] ← V[4] ⊗ V[5]) + α = randn(T) + β = randn(T) + + # repeat a couple times to get some distribution of arrows + for _ in 1:5 + p = randindextuple(numind(A)) + + C1 = randn!(TensorOperations.tensoralloc_add(T, A, p, false, Val(false))) + Mooncake.TestUtils.test_rule(rng, tensoradd!, C1, A, p, false, α, β; atol, rtol, mode) + + C2 = randn!(TensorOperations.tensoralloc_add(T, A, p, true, Val(false))) + Mooncake.TestUtils.test_rule(rng, tensoradd!, C2, A, p, true, α, β; atol, rtol, mode) + + A = rand(Bool) ? C1 : C2 + end + end + @timedtestset "tensorcontract!" begin for _ in 1:5 d = 0 @@ -138,5 +157,30 @@ for V in spacelist end end end + + @timedtestset "tensortrace!" begin + for _ in 1:5 + k1 = rand(0:2) + k2 = rand(1:2) + V1 = map(v -> rand(Bool) ? v' : v, rand(V, k1)) + V2 = map(v -> rand(Bool) ? v' : v, rand(V, k2)) + + (_p, _q) = randindextuple(k1 + 2 * k2, k1) + p = _repartition(_p, rand(0:k1)) + q = _repartition(_q, k2) + ip = _repartition(invperm(linearize((_p, _q))), rand(0:(k1 + 2 * k2))) + A = randn(T, permute(prod(V1) ⊗ prod(V2) ← prod(V2), ip)) + + α = randn(T) + β = randn(T) + for conjA in (false, true) + C = randn!(TensorOperations.tensoralloc_add(T, A, p, conjA, Val(false))) + Mooncake.TestUtils.test_rule( + rng, tensortrace!, C, A, p, q, conjA, α, β; + atol, rtol, mode, is_primitive = false + ) + end + end + end end end From 28a8e8def7e83b654f9a1a3c3da5f3b637350e2d Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Sun, 18 Jan 2026 08:49:45 -0500 Subject: [PATCH 13/52] add indexmanipulations rules --- .../TensorKitMooncakeExt.jl | 2 + .../indexmanipulations.jl | 153 ++++++++++++++++ ext/TensorKitMooncakeExt/tensoroperations.jl | 166 +++++++++--------- test/autodiff/mooncake.jl | 61 ++++++- 4 files changed, 297 insertions(+), 85 deletions(-) create mode 100644 ext/TensorKitMooncakeExt/indexmanipulations.jl diff --git a/ext/TensorKitMooncakeExt/TensorKitMooncakeExt.jl b/ext/TensorKitMooncakeExt/TensorKitMooncakeExt.jl index 2cc64f49b..15e0c4c9f 100644 --- a/ext/TensorKitMooncakeExt/TensorKitMooncakeExt.jl +++ b/ext/TensorKitMooncakeExt/TensorKitMooncakeExt.jl @@ -3,6 +3,7 @@ module TensorKitMooncakeExt using Mooncake using Mooncake: @zero_derivative, DefaultCtx, ReverseMode, NoFData, NoRData, CoDual, arrayify, primal using TensorKit +import TensorKit as TK using VectorInterface using TensorOperations: TensorOperations, IndexTuple, Index2Tuple, linearize import TensorOperations as TO @@ -11,6 +12,7 @@ using TupleTools include("utility.jl") include("tangent.jl") include("linalg.jl") +include("indexmanipulations.jl") include("vectorinterface.jl") include("tensoroperations.jl") diff --git a/ext/TensorKitMooncakeExt/indexmanipulations.jl b/ext/TensorKitMooncakeExt/indexmanipulations.jl new file mode 100644 index 000000000..a0b73dde2 --- /dev/null +++ b/ext/TensorKitMooncakeExt/indexmanipulations.jl @@ -0,0 +1,153 @@ +for transform in (:permute, :transpose) + add_transform! = Symbol(:add_, transform, :!) + add_transform_pullback = Symbol(add_transform!, :_pullback) + @eval Mooncake.@is_primitive( + DefaultCtx, + ReverseMode, + Tuple{ + typeof(TK.$add_transform!), + AbstractTensorMap, + AbstractTensorMap, Index2Tuple, + Number, Number, Vararg{Any}, + } + ) + + @eval function Mooncake.rrule!!( + ::CoDual{typeof(TK.$add_transform!)}, + C_ΔC::CoDual{<:AbstractTensorMap}, + A_ΔA::CoDual{<:AbstractTensorMap}, p_Δp::CoDual{<:Index2Tuple}, + α_Δα::CoDual{<:Number}, β_Δβ::CoDual{<:Number}, + ba_Δba::CoDual... + ) + # prepare arguments + C, ΔC = arrayify(C_ΔC) + A, ΔA = arrayify(A_ΔA) + p = primal(p_Δp) + α, β = primal.((α_Δα, β_Δβ)) + ba = primal.(ba_Δba) + + C_cache = copy(C) + + # if we need to compute Δa, it is faster to allocate an intermediate permuted A + # and store that instead of repeating the permutation in the pullback each time. + # effectively, we replace `add_permute` by `add ∘ permute`. + Tdα = Mooncake.rdata_type(Mooncake.tangent_type(typeof(α))) + Ap = if Tdα === NoRData + TK.$add_transform!(C, A, p, α, β, ba...) + nothing + else + Ap = $transform(A, p) + add!(C, Ap, α, β) + Ap + end + + function $add_transform_pullback(::NoRData) + copy!(C, C_cache) + + scale!(ΔC, conj(β)) + ΔCr = NoRData() + + # ΔA + ip = invperm(linearize(p)) + pΔA = _repartition(ip, A) + TK.$add_transform!(ΔA, ΔC, pΔA, conj(α), One(), ba...) + ΔAr = NoRData() + + # Δα + Δαr = if isnothing(Ap) + NoRData() + else + Mooncake._rdata(inner(Ap, ΔC)) + end + + # Δβ + Tdβ = Mooncake.rdata_type(Mooncake.tangent_type(typeof(β))) + Δβr = if Tdβ === NoRData + NoRData() + else + Mooncake._rdata(inner(C, ΔC)) + end + + + return NoRData(), ΔCr, ΔAr, NoRData(), Δαr, Δβr, map(Returns(NoRData()), ba)... + end + + return C_ΔC, $add_transform_pullback + end +end + +Mooncake.@is_primitive( + DefaultCtx, + ReverseMode, + Tuple{ + typeof(TK.add_braid!), + AbstractTensorMap, + AbstractTensorMap, Index2Tuple, IndexTuple, + Number, Number, Vararg{Any}, + } +) + +function Mooncake.rrule!!( + ::CoDual{typeof(TK.add_braid!)}, + C_ΔC::CoDual{<:AbstractTensorMap}, + A_ΔA::CoDual{<:AbstractTensorMap}, p_Δp::CoDual{<:Index2Tuple}, levels_Δlevels::CoDual{<:IndexTuple}, + α_Δα::CoDual{<:Number}, β_Δβ::CoDual{<:Number}, + ba_Δba::CoDual... + ) + # prepare arguments + C, ΔC = arrayify(C_ΔC) + A, ΔA = arrayify(A_ΔA) + p = primal(p_Δp) + levels = primal(levels_Δlevels) + α, β = primal.((α_Δα, β_Δβ)) + ba = primal.(ba_Δba) + + C_cache = copy(C) + + # if we need to compute Δa, it is faster to allocate an intermediate braided A + # and store that instead of repeating the permutation in the pullback each time. + # effectively, we replace `add_permute` by `add ∘ permute`. + Tdα = Mooncake.rdata_type(Mooncake.tangent_type(typeof(α))) + Ap = if Tdα === NoRData + TK.add_braid!(C, A, p, levels, α, β, ba...) + nothing + else + Ap = braid(A, p, levels) + add!(C, Ap, α, β) + Ap + end + + function add_braid!_pullback(::NoRData) + copy!(C, C_cache) + + scale!(ΔC, conj(β)) + ΔCr = NoRData() + + # ΔA + ip = invperm(linearize(p)) + pΔA = _repartition(ip, A) + ilevels = TupleTools.permute(levels, linearize(p)) + TK.add_braid!(ΔA, ΔC, pΔA, ilevels, conj(α), One(), ba...) + ΔAr = NoRData() + + # Δα + Δαr = if isnothing(Ap) + NoRData() + else + Mooncake._rdata(inner(Ap, ΔC)) + end + + # Δβ + Tdβ = Mooncake.rdata_type(Mooncake.tangent_type(typeof(β))) + Δβr = if Tdβ === NoRData + NoRData() + else + Mooncake._rdata(inner(C, ΔC)) + end + + + return NoRData(), ΔCr, ΔAr, NoRData(), NoRData(), Δαr, Δβr, map(Returns(NoRData()), ba)... + end + + return C_ΔC, add_braid!_pullback +end diff --git a/ext/TensorKitMooncakeExt/tensoroperations.jl b/ext/TensorKitMooncakeExt/tensoroperations.jl index 7b9a674f8..915a10356 100644 --- a/ext/TensorKitMooncakeExt/tensoroperations.jl +++ b/ext/TensorKitMooncakeExt/tensoroperations.jl @@ -1,88 +1,88 @@ # tensoradd! # ---------- -Mooncake.@is_primitive( - DefaultCtx, - ReverseMode, - Tuple{ - typeof(TO.tensoradd!), - AbstractTensorMap, - AbstractTensorMap, Index2Tuple, Bool, - Number, Number, Vararg{Any}, - } -) - -function Mooncake.rrule!!( - ::CoDual{typeof(TO.tensoradd!)}, - C_ΔC::CoDual{<:AbstractTensorMap}, - A_ΔA::CoDual{<:AbstractTensorMap}, pA_ΔpA::CoDual{<:Index2Tuple}, conjA_ΔconjA::CoDual{Bool}, - α_Δα::CoDual{<:Number}, β_Δβ::CoDual{<:Number}, - ba_Δba::CoDual... - ) - # prepare arguments - C, ΔC = arrayify(C_ΔC) - A, ΔA = arrayify(A_ΔA) - pA = primal(pA_ΔpA) - conjA = primal(conjA_ΔconjA) - α, β = primal.((α_Δα, β_Δβ)) - ba = primal.(ba_Δba) - - # primal call - C_cache = copy(C) - TO.tensoradd!(C, A, pA, conjA, α, β, ba...) - - function tensoradd_pullback(::NoRData) - copy!(C, C_cache) - - ΔCr = tensoradd_pullback_ΔC!(ΔC, β) - ΔAr = tensoradd_pullback_ΔA!(ΔA, ΔC, A, pA, conjA, α, ba...) - Δαr = tensoradd_pullback_Δα(ΔC, A, pA, conjA, α, ba...) - Δβr = tensoradd_pullback_Δβ(ΔC, C, β) - - return NoRData(), - ΔCr, - ΔAr, NoRData(), NoRData(), - Δαr, Δβr, - map(Returns(NoRData()), ba)... - end - - return C_ΔC, tensoradd_pullback -end - -tensoradd_pullback_ΔC!(ΔC, β) = (scale!(ΔC, conj(β)); NoRData()) - -function tensoradd_pullback_ΔA!( - ΔA, ΔC, A, pA, conjA, α, ba... - ) - ipA = invperm(linearize(pA)) - pΔA = _repartition(ipA, A) - TO.tensoradd!(ΔA, ΔC, pΔA, conjA, conjA ? α : conj(α), Zero(), ba...) - return NoRData() -end - -function tensoradd_pullback_Δα( - ΔC, A, pA, conjA, α, ba... - ) - Tdα = Mooncake.rdata_type(Mooncake.tangent_type(typeof(α))) - Tdα === NoRData && return NoRData() - - tΔC = twist(ΔC, filter(x -> isdual(space(ΔC, x)), allind(ΔC)); copy = false) - Δα = TO.tensorscalar( - TO.tensorcontract( - A, ((), linearize(pA)), !conjA, - tΔC, (trivtuple(TO.numind(pA)), ()), false, - ((), ()), One(), ba... - ) - ) - return Mooncake._rdata(Δα) -end - -function tensoradd_pullback_Δβ(ΔC, C, β) - Tdβ = Mooncake.rdata_type(Mooncake.tangent_type(typeof(β))) - Tdβ === NoRData && return NoRData() - - Δβ = inner(C, ΔC) - return Mooncake._rdata(Δβ) -end +# Mooncake.@is_primitive( +# DefaultCtx, +# ReverseMode, +# Tuple{ +# typeof(TO.tensoradd!), +# AbstractTensorMap, +# AbstractTensorMap, Index2Tuple, Bool, +# Number, Number, Vararg{Any}, +# } +# ) +# +# function Mooncake.rrule!!( +# ::CoDual{typeof(TO.tensoradd!)}, +# C_ΔC::CoDual{<:AbstractTensorMap}, +# A_ΔA::CoDual{<:AbstractTensorMap}, pA_ΔpA::CoDual{<:Index2Tuple}, conjA_ΔconjA::CoDual{Bool}, +# α_Δα::CoDual{<:Number}, β_Δβ::CoDual{<:Number}, +# ba_Δba::CoDual... +# ) +# # prepare arguments +# C, ΔC = arrayify(C_ΔC) +# A, ΔA = arrayify(A_ΔA) +# pA = primal(pA_ΔpA) +# conjA = primal(conjA_ΔconjA) +# α, β = primal.((α_Δα, β_Δβ)) +# ba = primal.(ba_Δba) +# +# # primal call +# C_cache = copy(C) +# TO.tensoradd!(C, A, pA, conjA, α, β, ba...) +# +# function tensoradd_pullback(::NoRData) +# copy!(C, C_cache) +# +# ΔCr = tensoradd_pullback_ΔC!(ΔC, β) +# ΔAr = tensoradd_pullback_ΔA!(ΔA, ΔC, A, pA, conjA, α, ba...) +# Δαr = tensoradd_pullback_Δα(ΔC, A, pA, conjA, α, ba...) +# Δβr = tensoradd_pullback_Δβ(ΔC, C, β) +# +# return NoRData(), +# ΔCr, +# ΔAr, NoRData(), NoRData(), +# Δαr, Δβr, +# map(Returns(NoRData()), ba)... +# end +# +# return C_ΔC, tensoradd_pullback +# end +# +# tensoradd_pullback_ΔC!(ΔC, β) = (scale!(ΔC, conj(β)); NoRData()) +# +# function tensoradd_pullback_ΔA!( +# ΔA, ΔC, A, pA, conjA, α, ba... +# ) +# ipA = invperm(linearize(pA)) +# pΔA = _repartition(ipA, A) +# TO.tensoradd!(ΔA, ΔC, pΔA, conjA, conjA ? α : conj(α), Zero(), ba...) +# return NoRData() +# end +# +# function tensoradd_pullback_Δα( +# ΔC, A, pA, conjA, α, ba... +# ) +# Tdα = Mooncake.rdata_type(Mooncake.tangent_type(typeof(α))) +# Tdα === NoRData && return NoRData() +# +# tΔC = twist(ΔC, filter(x -> isdual(space(ΔC, x)), allind(ΔC)); copy = false) +# Δα = TO.tensorscalar( +# TO.tensorcontract( +# A, ((), linearize(pA)), !conjA, +# tΔC, (trivtuple(TO.numind(pA)), ()), false, +# ((), ()), One(), ba... +# ) +# ) +# return Mooncake._rdata(Δα) +# end +# +# function tensoradd_pullback_Δβ(ΔC, C, β) +# Tdβ = Mooncake.rdata_type(Mooncake.tangent_type(typeof(β))) +# Tdβ === NoRData && return NoRData() +# +# Δβ = inner(C, ΔC) +# return Mooncake._rdata(Δβ) +# end # tensorcontract! # --------------- diff --git a/test/autodiff/mooncake.jl b/test/autodiff/mooncake.jl index 38fa23c15..2ca21654e 100644 --- a/test/autodiff/mooncake.jl +++ b/test/autodiff/mooncake.jl @@ -3,6 +3,7 @@ using TensorKit using TensorOperations using Mooncake using Random +using TupleTools mode = Mooncake.ReverseMode rng = Random.default_rng() @@ -13,6 +14,14 @@ function randindextuple(N::Int, k::Int = rand(0:N)) _p = randperm(N) return (tuple(_p[1:k]...), tuple(_p[(k + 1):end]...)) end +function randcircshift(N₁::Int, N₂::Int, k::Int = rand(0:(N₁ + N₂))) + N = N₁ + N₂ + @assert 0 ≤ k ≤ N + p = TupleTools.vcat(ntuple(identity, N₁), reverse(ntuple(identity, N₂) .+ N₁)) + n = rand(0:N) + _p = TupleTools.circshift(p, n) + return (tuple(_p[1:k]...), reverse(tuple(_p[(k + 1):end]...))) +end const _repartition = @static if isdefined(Base, :get_extension) Base.get_extension(TensorKit, :TensorKitMooncakeExt)._repartition @@ -93,6 +102,54 @@ for V in spacelist Mooncake.TestUtils.test_rule(rng, inner, C', A'; atol, rtol, mode) end + @timedtestset "Index manipulations with scalartype $T" for T in eltypes + atol = precision(T) + rtol = precision(T) + + symmetricbraiding && @timedtestset "add_permute!" begin + A = randn(T, V[1] ⊗ V[2] ← V[4] ⊗ V[5]) + α = randn(T) + β = randn(T) + + # repeat a couple times to get some distribution of arrows + for _ in 1:5 + p = randindextuple(numind(A)) + C = randn!(permute(A, p)) + Mooncake.TestUtils.test_rule(rng, TensorKit.add_permute!, C, A, p, α, β; atol, rtol, mode) + A = C + end + end + + @timedtestset "add_transpose!" begin + A = randn(T, V[1] ⊗ V[2] ← V[4] ⊗ V[5]) + α = randn(T) + β = randn(T) + + # repeat a couple times to get some distribution of arrows + for _ in 1:5 + p = randcircshift(numout(A), numin(A)) + C = randn!(transpose(A, p)) + Mooncake.TestUtils.test_rule(rng, TensorKit.add_transpose!, C, A, p, α, β; atol, rtol, mode) + A = C + end + end + + @timedtestset "add_braid!" begin + A = randn(T, V[1] ⊗ V[2] ← V[4] ⊗ V[5]) + α = randn(T) + β = randn(T) + + # repeat a couple times to get some distribution of arrows + for _ in 1:5 + p = randcircshift(numout(A), numin(A)) + levels = tuple(randperm(numind(A))) + C = randn!(transpose(A, p)) + Mooncake.TestUtils.test_rule(rng, TensorKit.add_transpose!, C, A, p, α, β; atol, rtol, mode) + A = C + end + end + end + symmetricbraiding && @timedtestset "TensorOperations with scalartype $T" for T in eltypes atol = precision(T) rtol = precision(T) @@ -107,10 +164,10 @@ for V in spacelist p = randindextuple(numind(A)) C1 = randn!(TensorOperations.tensoralloc_add(T, A, p, false, Val(false))) - Mooncake.TestUtils.test_rule(rng, tensoradd!, C1, A, p, false, α, β; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, tensoradd!, C1, A, p, false, α, β; atol, rtol, mode, is_primitive = false) C2 = randn!(TensorOperations.tensoralloc_add(T, A, p, true, Val(false))) - Mooncake.TestUtils.test_rule(rng, tensoradd!, C2, A, p, true, α, β; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, tensoradd!, C2, A, p, true, α, β; atol, rtol, mode, is_primitive = false) A = rand(Bool) ? C1 : C2 end From 4696b306126ed75b6f7806a66c9992fe58840403 Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Tue, 20 Jan 2026 12:05:46 -0500 Subject: [PATCH 14/52] add mul rules --- ext/TensorKitMooncakeExt/linalg.jl | 39 ++++++++++++++++++++++++++++++ test/autodiff/mooncake.jl | 18 ++++++++++++++ 2 files changed, 57 insertions(+) diff --git a/ext/TensorKitMooncakeExt/linalg.jl b/ext/TensorKitMooncakeExt/linalg.jl index 56533d227..d0d73d951 100644 --- a/ext/TensorKitMooncakeExt/linalg.jl +++ b/ext/TensorKitMooncakeExt/linalg.jl @@ -1,3 +1,42 @@ +Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(mul!), AbstractTensorMap, AbstractTensorMap, AbstractTensorMap, Number, Number} + +function Mooncake.rrule!!( + ::CoDual{typeof(mul!)}, + C_ΔC::CoDual{<:AbstractTensorMap}, A_ΔA::CoDual{<:AbstractTensorMap}, B_ΔB::CoDual{<:AbstractTensorMap}, + α_Δα::CoDual{<:Number}, β_Δβ::CoDual{<:Number} + ) + (C, ΔC), (A, ΔA), (B, ΔB) = arrayify.((C_ΔC, A_ΔA, B_ΔB)) + α, β = primal.((α_Δα, β_Δβ)) + + # primal call + C_cache = copy(C) + AB = if _needs_tangent(α) + AB = A * B + add!(C, AB, α, β) + AB + else + mul!(C, A, B, α, β) + nothing + end + + function mul_pullback(::NoRData) + copy!(C, C_cache) + + scale!(ΔC, conj(β)) + mul!(ΔA, ΔC, B', conj(α), One()) + mul!(ΔB, A', ΔC, conj(α), One()) + ΔCr = NoRData() + ΔAr = NoRData() + ΔBr = NoRData() + Δαr = isnothing(AB) ? NoRData() : Mooncake._rdata(inner(AB, ΔC)) + Δβr = _needs_tangent(β) ? Mooncake._rdata(inner(C, ΔC)) : NoRData() + + return NoRData(), ΔCr, ΔAr, ΔBr, Δαr, Δβr + end + + return C_ΔC, mul_pullback +end + Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(norm), AbstractTensorMap, Real} function Mooncake.rrule!!(::CoDual{typeof(norm)}, tΔt::CoDual{<:AbstractTensorMap}, pdp::CoDual{<:Real}) diff --git a/test/autodiff/mooncake.jl b/test/autodiff/mooncake.jl index 2ca21654e..4df18a331 100644 --- a/test/autodiff/mooncake.jl +++ b/test/autodiff/mooncake.jl @@ -102,6 +102,24 @@ for V in spacelist Mooncake.TestUtils.test_rule(rng, inner, C', A'; atol, rtol, mode) end + @timedtestset "LinearAlgebra with scalartype $T" for T in eltypes + atol = precision(T) + rtol = precision(T) + + C = randn(T, V[1] ⊗ V[2] ← V[5]) + A = randn(T, codomain(C) ← V[3] ⊗ V[4]) + B = randn(T, domain(A) ← domain(C)) + α = randn(T) + β = randn(T) + + Mooncake.TestUtils.test_rule(rng, mul!, C, A, B, α, β; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, mul!, C, A, B; atol, rtol, mode, is_primitive = false) + + Mooncake.TestUtils.test_rule(rng, norm, C, 2; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, norm, C', 2; atol, rtol, mode) + end + + @timedtestset "Index manipulations with scalartype $T" for T in eltypes atol = precision(T) rtol = precision(T) From c551eb289ab3a8105917ce1929040072a78e4c77 Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Tue, 20 Jan 2026 14:56:06 -0500 Subject: [PATCH 15/52] temporarily disable Fibonacci (complex) spaces --- test/autodiff/mooncake.jl | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/test/autodiff/mooncake.jl b/test/autodiff/mooncake.jl index 4df18a331..3ca512f56 100644 --- a/test/autodiff/mooncake.jl +++ b/test/autodiff/mooncake.jl @@ -59,13 +59,13 @@ spacelist = ( Vect[SU2Irrep](1 // 2 => 2), Vect[SU2Irrep](0 => 1, 1 // 2 => 1, 3 // 2 => 1)', ), - ( - Vect[FibonacciAnyon](:I => 2, :τ => 1), - Vect[FibonacciAnyon](:I => 1, :τ => 2)', - Vect[FibonacciAnyon](:I => 2, :τ => 2)', - Vect[FibonacciAnyon](:I => 2, :τ => 3), - Vect[FibonacciAnyon](:I => 2, :τ => 2), - ), + # ( + # Vect[FibonacciAnyon](:I => 2, :τ => 1), + # Vect[FibonacciAnyon](:I => 1, :τ => 2)', + # Vect[FibonacciAnyon](:I => 2, :τ => 2)', + # Vect[FibonacciAnyon](:I => 2, :τ => 3), + # Vect[FibonacciAnyon](:I => 2, :τ => 2), + # ), ) for V in spacelist From 991a66e632095bffc1e299c1d0e7be28d54d94e5 Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Tue, 20 Jan 2026 17:10:35 -0500 Subject: [PATCH 16/52] bump TupleTools compat --- Project.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Project.toml b/Project.toml index ddcbe4141..83d716d92 100644 --- a/Project.toml +++ b/Project.toml @@ -56,7 +56,7 @@ TensorKitSectors = "0.3.3" TensorOperations = "5.1" Test = "1" TestExtras = "0.2,0.3" -TupleTools = "1.1" +TupleTools = "1.5" VectorInterface = "0.4.8, 0.5" Zygote = "0.7" cuTENSOR = "2" From 7a0dd5033cf49d1ba56f4c250c181f6168c8739e Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Wed, 21 Jan 2026 14:19:11 -0500 Subject: [PATCH 17/52] add twist! rule --- .../indexmanipulations.jl | 45 +++++++++++++++++++ test/autodiff/mooncake.jl | 8 ++++ 2 files changed, 53 insertions(+) diff --git a/ext/TensorKitMooncakeExt/indexmanipulations.jl b/ext/TensorKitMooncakeExt/indexmanipulations.jl index a0b73dde2..000ae5d83 100644 --- a/ext/TensorKitMooncakeExt/indexmanipulations.jl +++ b/ext/TensorKitMooncakeExt/indexmanipulations.jl @@ -151,3 +151,48 @@ function Mooncake.rrule!!( return C_ΔC, add_braid!_pullback end + +# both are needed for correctly capturing every dispatch +Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(twist!), AbstractTensorMap, Any} +Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(Core.kwcall), @NamedTuple{inv::Bool}, typeof(twist!), AbstractTensorMap, Any} + +function Mooncake.rrule!!(::CoDual{typeof(twist!)}, t_Δt::CoDual{<:AbstractTensorMap}, inds_Δinds::CoDual) + # prepare arguments + t, Δt = arrayify(t_Δt) + inv = false + inds = primal(inds_Δinds) + + # primal call + t_cache = copy(t) + twist!(t, inds; inv) + + function twist_pullback(::NoRData) + copy!(t, t_cache) + twist!(Δt, inds; inv = !inv) + return ntuple(Returns(NoRData()), 3) + end + + return t_Δt, twist_pullback + +end +function Mooncake.rrule!!( + ::CoDual{typeof(Core.kwcall)}, kwargs_Δkwargs::CoDual{@NamedTuple{inv::Bool}}, ::CoDual{typeof(twist!)}, + t_Δt::CoDual{<:AbstractTensorMap}, inds_Δinds::CoDual + ) + # prepare arguments + t, Δt = arrayify(t_Δt) + inv = primal(kwargs_Δkwargs).inv + inds = primal(inds_Δinds) + + # primal call + t_cache = copy(t) + twist!(t, inds; inv) + + function twist_pullback(::NoRData) + copy!(t, t_cache) + twist!(Δt, inds; inv = !inv) + return ntuple(Returns(NoRData()), 5) + end + + return t_Δt, twist_pullback +end diff --git a/test/autodiff/mooncake.jl b/test/autodiff/mooncake.jl index 3ca512f56..85b251885 100644 --- a/test/autodiff/mooncake.jl +++ b/test/autodiff/mooncake.jl @@ -166,6 +166,14 @@ for V in spacelist A = C end end + + @timedtestset "twist!" begin + A = randn(T, V[1] ⊗ V[2] ← V[4] ⊗ V[5]) + Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; inv = false), twist!, A, 1; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; inv = true), twist!, A, [1, 3]; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, twist!, A, 1; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, twist!, A, [1, 3]; atol, rtol, mode) + end end symmetricbraiding && @timedtestset "TensorOperations with scalartype $T" for T in eltypes From 87f49172a3230bcc836849316ca65c9711523020 Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Wed, 21 Jan 2026 14:50:48 -0500 Subject: [PATCH 18/52] add flip rule --- .../indexmanipulations.jl | 44 +++++++++++++++++++ test/autodiff/mooncake.jl | 7 ++- 2 files changed, 50 insertions(+), 1 deletion(-) diff --git a/ext/TensorKitMooncakeExt/indexmanipulations.jl b/ext/TensorKitMooncakeExt/indexmanipulations.jl index 000ae5d83..9e98023e2 100644 --- a/ext/TensorKitMooncakeExt/indexmanipulations.jl +++ b/ext/TensorKitMooncakeExt/indexmanipulations.jl @@ -196,3 +196,47 @@ function Mooncake.rrule!!( return t_Δt, twist_pullback end + +# both are needed for correctly capturing every dispatch +Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(flip), AbstractTensorMap, Any} +Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(Core.kwcall), @NamedTuple{inv::Bool}, typeof(flip), AbstractTensorMap, Any} + +function Mooncake.rrule!!(::CoDual{typeof(flip)}, t_Δt::CoDual{<:AbstractTensorMap}, inds_Δinds::CoDual) + # prepare arguments + t, Δt = arrayify(t_Δt) + inv = false + inds = primal(inds_Δinds) + + # primal call + t_flipped = flip(t, inds; inv) + t_flipped_Δt_flipped = Mooncake.zero_fcodual(t_flipped) + _, Δt_flipped = arrayify(t_flipped_Δt_flipped) + + function twist_pullback(::NoRData) + copy!(Δt, flip(Δt_flipped, inds; inv = !inv)) + return ntuple(Returns(NoRData()), 3) + end + + return t_flipped_Δt_flipped, twist_pullback +end +function Mooncake.rrule!!( + ::CoDual{typeof(Core.kwcall)}, kwargs_Δkwargs::CoDual{@NamedTuple{inv::Bool}}, ::CoDual{typeof(flip)}, + t_Δt::CoDual{<:AbstractTensorMap}, inds_Δinds::CoDual + ) + # prepare arguments + t, Δt = arrayify(t_Δt) + inv = primal(kwargs_Δkwargs).inv + inds = primal(inds_Δinds) + + # primal call + t_flipped = flip(t, inds; inv) + t_flipped_Δt_flipped = Mooncake.zero_fcodual(t_flipped) + _, Δt_flipped = arrayify(t_flipped_Δt_flipped) + + function twist_pullback(::NoRData) + copy!(Δt, flip(Δt_flipped, inds; inv = !inv)) + return ntuple(Returns(NoRData()), 5) + end + + return t_flipped_Δt_flipped, twist_pullback +end diff --git a/test/autodiff/mooncake.jl b/test/autodiff/mooncake.jl index 85b251885..ace67dae7 100644 --- a/test/autodiff/mooncake.jl +++ b/test/autodiff/mooncake.jl @@ -167,12 +167,17 @@ for V in spacelist end end - @timedtestset "twist!" begin + @timedtestset "flip_n_twist!" begin A = randn(T, V[1] ⊗ V[2] ← V[4] ⊗ V[5]) Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; inv = false), twist!, A, 1; atol, rtol, mode) Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; inv = true), twist!, A, [1, 3]; atol, rtol, mode) Mooncake.TestUtils.test_rule(rng, twist!, A, 1; atol, rtol, mode) Mooncake.TestUtils.test_rule(rng, twist!, A, [1, 3]; atol, rtol, mode) + + Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; inv = false), flip, A, 1; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; inv = true), flip, A, [1, 3]; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, flip, A, 1; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, flip, A, [1, 3]; atol, rtol, mode) end end From c0b15253269ef9f9ebda3a0fa9b84e38286243b7 Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Wed, 21 Jan 2026 15:37:21 -0500 Subject: [PATCH 19/52] vector spaces arent vector spaces! --- ext/TensorKitMooncakeExt/utility.jl | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ext/TensorKitMooncakeExt/utility.jl b/ext/TensorKitMooncakeExt/utility.jl index ca2c79b54..f45aaf3bc 100644 --- a/ext/TensorKitMooncakeExt/utility.jl +++ b/ext/TensorKitMooncakeExt/utility.jl @@ -25,4 +25,8 @@ end # Ignore derivatives # ------------------ + +# A VectorSpace has no meaningful notion of a vector space (tangent space) +Mooncake.tangent_type(::Type{<:VectorSpace}) = Mooncake.NoTangent + @zero_derivative DefaultCtx Tuple{typeof(TensorKit.fusionblockstructure), Any} From a2aba85c74da3781f9b38ef8294682478fd0419d Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Wed, 21 Jan 2026 15:50:17 -0500 Subject: [PATCH 20/52] insert and remove units --- .../indexmanipulations.jl | 167 ++++++++++++++++++ test/autodiff/mooncake.jl | 21 +++ 2 files changed, 188 insertions(+) diff --git a/ext/TensorKitMooncakeExt/indexmanipulations.jl b/ext/TensorKitMooncakeExt/indexmanipulations.jl index 9e98023e2..464c18392 100644 --- a/ext/TensorKitMooncakeExt/indexmanipulations.jl +++ b/ext/TensorKitMooncakeExt/indexmanipulations.jl @@ -240,3 +240,170 @@ function Mooncake.rrule!!( return t_flipped_Δt_flipped, twist_pullback end + +for insertunit in (:insertleftunit, :insertrightunit) + insertunit_pullback = Symbol(insertunit, :_pullback) + @eval begin + # both are needed for correctly capturing every dispatch + Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof($insertunit), AbstractTensorMap, Val} + Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(Core.kwcall), NamedTuple, typeof($insertunit), AbstractTensorMap, Val} + + function Mooncake.rrule!!(::CoDual{typeof($insertunit)}, tsrc_Δtsrc::CoDual{<:AbstractTensorMap}, ival_Δival::CoDual{<:Val}) + # prepare arguments + tsrc, Δtsrc = arrayify(tsrc_Δtsrc) + ival = primal(ival_Δival) + + # tdst shares data with tsrc if <:TensorMap, in this case we have to deal with correctly + # sharing address spaces + if tsrc isa TensorMap + tsrc_cache = copy(tsrc) + tdst = $insertunit(tsrc, ival) + # note: this is somewhat of a hack that makes use of the fact that the tangent is + # encoded without any information about the space, which allows us to simply reuse + # the tangent exactly without having to modify the space information + tdst_Δtdst = CoDual(tdst, Mooncake.tangent(tsrc_Δtsrc)) + else + tsrc_cache = nothing + tdst = $insertunit(tsrc, ival) + tdst_Δtdst = Mooncake.zero_fcodual(tdst) + end + + _, Δtdst = arrayify(tdst_Δtdst) + + function $insertunit_pullback(::NoRData) + if isnothing(tsrc_cache) + for (c, b) in blocks(Δtdst) + copy!(block(Δtsrc, c), b) + end + else + copy!(tsrc, tsrc_cache) + # note: since data is already shared, don't have to do anything here! + end + return ntuple(Returns(NoRData()), 3) + end + + return tdst_Δtdst, $insertunit_pullback + end + function Mooncake.rrule!!( + ::CoDual{typeof(Core.kwcall)}, kwargs_Δkwargs::CoDual{<:NamedTuple}, + ::CoDual{typeof($insertunit)}, tsrc_Δtsrc::CoDual{<:AbstractTensorMap}, ival_Δival::CoDual{<:Val} + ) + # prepare arguments + tsrc, Δtsrc = arrayify(tsrc_Δtsrc) + ival = primal(ival_Δival) + kwargs = primal(kwargs_Δkwargs) + + # tdst shares data with tsrc if <:TensorMap & copy=false, in this case we have to deal with correctly + # sharing address spaces + if tsrc isa TensorMap && !get(kwargs, :copy, false) + tsrc_cache = copy(tsrc) + tdst = $insertunit(tsrc, ival; kwargs...) + # note: this is somewhat of a hack that makes use of the fact that the tangent is + # encoded without any information about the space, which allows us to simply reuse + # the tangent exactly without having to modify the space information + tdst_Δtdst = CoDual(tdst, Mooncake.tangent(tsrc_Δtsrc)) + else + tsrc_cache = nothing + tdst = $insertunit(tsrc, ival; kwargs...) + tdst_Δtdst = Mooncake.zero_fcodual(tdst) + end + + _, Δtdst = arrayify(tdst_Δtdst) + + function $insertunit_pullback(::NoRData) + if isnothing(tsrc_cache) + for (c, b) in blocks(Δtdst) + copy!(block(Δtsrc, c), b) + end + else + copy!(tsrc, tsrc_cache) + # note: since data is already shared, don't have to do anything here! + end + return ntuple(Returns(NoRData()), 5) + end + + return tdst_Δtdst, $insertunit_pullback + end + end +end + + +Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(removeunit), AbstractTensorMap, Val} +Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(Core.kwcall), NamedTuple, typeof(removeunit), AbstractTensorMap, Val} + +function Mooncake.rrule!!(::CoDual{typeof(removeunit)}, tsrc_Δtsrc::CoDual{<:AbstractTensorMap}, ival_Δival::CoDual{Val{i}}) where {i} + # prepare arguments + tsrc, Δtsrc = arrayify(tsrc_Δtsrc) + ival = primal(ival_Δival) + + # tdst shares data with tsrc if <:TensorMap, in this case we have to deal with correctly + # sharing address spaces + if tsrc isa TensorMap + tsrc_cache = copy(tsrc) + tdst = removeunit(tsrc, ival) + # note: this is somewhat of a hack that makes use of the fact that the tangent is + # encoded without any information about the space, which allows us to simply reuse + # the tangent exactly without having to modify the space information + tdst_Δtdst = CoDual(tdst, Mooncake.tangent(tsrc_Δtsrc)) + else + tsrc_cache = nothing + tdst = removeunit(tsrc, ival) + tdst_Δtdst = Mooncake.zero_fcodual(tdst) + end + + _, Δtdst = arrayify(tdst_Δtdst) + + function removeunit_pullback(::NoRData) + if isnothing(tsrc_cache) + for (c, b) in blocks(Δtdst) + copy!(block(Δtsrc, c), b) + end + else + copy!(tsrc, tsrc_cache) + # note: since data is already shared, don't have to do anything here! + end + return ntuple(Returns(NoRData()), 3) + end + + return tdst_Δtdst, removeunit_pullback +end +function Mooncake.rrule!!( + ::CoDual{typeof(Core.kwcall)}, kwargs_Δkwargs::CoDual{<:NamedTuple}, + ::CoDual{typeof(removeunit)}, tsrc_Δtsrc::CoDual{<:AbstractTensorMap}, ival_Δival::CoDual{<:Val} + ) + # prepare arguments + tsrc, Δtsrc = arrayify(tsrc_Δtsrc) + ival = primal(ival_Δival) + kwargs = primal(kwargs_Δkwargs) + + # tdst shares data with tsrc if <:TensorMap & copy=false, in this case we have to deal with correctly + # sharing address spaces + if tsrc isa TensorMap && !get(kwargs, :copy, false) + tsrc_cache = copy(tsrc) + tdst = removeunit(tsrc, ival; kwargs...) + # note: this is somewhat of a hack that makes use of the fact that the tangent is + # encoded without any information about the space, which allows us to simply reuse + # the tangent exactly without having to modify the space information + tdst_Δtdst = CoDual(tdst, Mooncake.tangent(tsrc_Δtsrc)) + else + tsrc_cache = nothing + tdst = removeunit(tsrc, ival; kwargs...) + tdst_Δtdst = Mooncake.zero_fcodual(tdst) + end + + _, Δtdst = arrayify(tdst_Δtdst) + + function removeunit_pullback(::NoRData) + if isnothing(tsrc_cache) + for (c, b) in blocks(Δtdst) + copy!(block(Δtsrc, c), b) + end + else + copy!(tsrc, tsrc_cache) + # note: since data is already shared, don't have to do anything here! + end + return ntuple(Returns(NoRData()), 5) + end + + return tdst_Δtdst, removeunit_pullback +end diff --git a/test/autodiff/mooncake.jl b/test/autodiff/mooncake.jl index ace67dae7..a5b08fc90 100644 --- a/test/autodiff/mooncake.jl +++ b/test/autodiff/mooncake.jl @@ -179,6 +179,27 @@ for V in spacelist Mooncake.TestUtils.test_rule(rng, flip, A, 1; atol, rtol, mode) Mooncake.TestUtils.test_rule(rng, flip, A, [1, 3]; atol, rtol, mode) end + + @timedtestset "insert and remove units" begin + A = randn(T, V[1] ⊗ V[2] ← V[4] ⊗ V[5]) + + for insertunit in (insertleftunit, insertrightunit) + Mooncake.TestUtils.test_rule(rng, insertunit, A, Val(1); atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, insertunit, A, Val(4); atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, insertunit, A', Val(2); atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; copy = false), insertunit, A, Val(1); atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; copy = true), insertunit, A, Val(2); atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; copy = false, dual = true, conj = true), insertunit, A, Val(3); atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; copy = false, dual = true, conj = true), insertunit, A', Val(3); atol, rtol, mode) + end + + for i in 1:4 + B = insertleftunit(A, i; dual = rand(Bool)) + Mooncake.TestUtils.test_rule(rng, removeunit, B, Val(i); atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; copy = false), removeunit, B, Val(i); atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; copy = true), removeunit, B, Val(i); atol, rtol, mode) + end + end end symmetricbraiding && @timedtestset "TensorOperations with scalartype $T" for T in eltypes From d9cde8a43e11aa3c109e44f667de34763e0acc46 Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Wed, 21 Jan 2026 17:08:30 -0500 Subject: [PATCH 21/52] mark a bunch of things as non-differentiable --- ext/TensorKitMooncakeExt/utility.jl | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/ext/TensorKitMooncakeExt/utility.jl b/ext/TensorKitMooncakeExt/utility.jl index f45aaf3bc..e93de22be 100644 --- a/ext/TensorKitMooncakeExt/utility.jl +++ b/ext/TensorKitMooncakeExt/utility.jl @@ -30,3 +30,10 @@ end Mooncake.tangent_type(::Type{<:VectorSpace}) = Mooncake.NoTangent @zero_derivative DefaultCtx Tuple{typeof(TensorKit.fusionblockstructure), Any} + +@zero_derivative DefaultCtx Tuple{typeof(TensorKit.select), HomSpace, Index2Tuple} +@zero_derivative DefaultCtx Tuple{typeof(TensorKit.flip), HomSpace, Any} +@zero_derivative DefaultCtx Tuple{typeof(TensorKit.permute), HomSpace, Index2Tuple} +@zero_derivative DefaultCtx Tuple{typeof(TensorKit.braid), HomSpace, Index2Tuple, IndexTuple} +@zero_derivative DefaultCtx Tuple{typeof(TensorKit.compose), HomSpace, HomSpace} +@zero_derivative DefaultCtx Tuple{typeof(TensorOperations.tensorcontract), HomSpace, Index2Tuple, Bool, HomSpace, Index2Tuple, Bool, Index2Tuple} From 02c79a533c6dd58b4a3e9e868032e7a126bfed70 Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Wed, 21 Jan 2026 17:08:53 -0500 Subject: [PATCH 22/52] rewrite rule for `tensortrace!` in terms of `trace_permute!` --- ext/TensorKitMooncakeExt/tensoroperations.jl | 53 +++++++++----------- test/autodiff/mooncake.jl | 16 +++--- 2 files changed, 32 insertions(+), 37 deletions(-) diff --git a/ext/TensorKitMooncakeExt/tensoroperations.jl b/ext/TensorKitMooncakeExt/tensoroperations.jl index 915a10356..989ee2830 100644 --- a/ext/TensorKitMooncakeExt/tensoroperations.jl +++ b/ext/TensorKitMooncakeExt/tensoroperations.jl @@ -230,83 +230,80 @@ Mooncake.@is_primitive( DefaultCtx, ReverseMode, Tuple{ - typeof(TO.tensortrace!), + typeof(TensorKit.trace_permute!), AbstractTensorMap, - AbstractTensorMap, Index2Tuple, Index2Tuple, Bool, + AbstractTensorMap, Index2Tuple, Index2Tuple, Number, Number, - Vararg{Any}, + Any, } ) function Mooncake.rrule!!( - ::CoDual{typeof(TO.tensortrace!)}, + ::CoDual{typeof(TensorKit.trace_permute!)}, C_ΔC::CoDual{<:AbstractTensorMap}, - A_ΔA::CoDual{<:AbstractTensorMap}, p_Δp::CoDual{<:Index2Tuple}, q_Δq::CoDual{<:Index2Tuple}, conjA_ΔconjA::CoDual{Bool}, + A_ΔA::CoDual{<:AbstractTensorMap}, p_Δp::CoDual{<:Index2Tuple}, q_Δq::CoDual{<:Index2Tuple}, α_Δα::CoDual{<:Number}, β_Δβ::CoDual{<:Number}, - ba_Δba::CoDual... + backend_Δbackend::CoDual ) # prepare arguments C, ΔC = arrayify(C_ΔC) A, ΔA = arrayify(A_ΔA) p = primal(p_Δp) q = primal(q_Δq) - conjA = primal(conjA_ΔconjA) α, β = primal.((α_Δα, β_Δβ)) - ba = primal.(ba_Δba) + backend = primal(backend_Δbackend) # primal call C_cache = copy(C) - TO.tensortrace!(C, A, p, q, conjA, α, β, ba...) + TensorKit.trace_permute!(C, A, p, q, α, β, backend) - function tensortrace_pullback(::NoRData) + function trace_permute_pullback(::NoRData) copy!(C, C_cache) - ΔCr = tensortrace_pullback_ΔC!(ΔC, β) - ΔAr = tensortrace_pullback_ΔA!(ΔA, ΔC, A, p, q, conjA, α, ba...) - Δαr = tensortrace_pullback_Δα(ΔC, A, p, q, conjA, α, ba...) - Δβr = tensortrace_pullback_Δβ(ΔC, C, β) + ΔAr = trace_permute_pullback_ΔA!(ΔA, ΔC, A, p, q, α, backend) + Δαr = trace_permute_pullback_Δα(ΔC, A, p, q, α, backend) + Δβr = trace_permute_pullback_Δβ(ΔC, C, β) + ΔCr = trace_permute_pullback_ΔC!(ΔC, β) return NoRData(), - ΔCr, - ΔAr, NoRData(), NoRData(), NoRData(), - Δαr, Δβr, - map(Returns(NoRData()), ba)... + ΔCr, ΔAr, NoRData(), NoRData(), + Δαr, Δβr, NoRData() end - return C_ΔC, tensortrace_pullback + return C_ΔC, trace_permute_pullback end -tensortrace_pullback_ΔC!(ΔC, β) = (scale!(ΔC, conj(β)); NoRData()) +trace_permute_pullback_ΔC!(ΔC, β) = (scale!(ΔC, conj(β)); NoRData()) -function tensortrace_pullback_ΔA!( - ΔA, ΔC, A, p, q, conjA, α, ba... +function trace_permute_pullback_ΔA!( + ΔA, ΔC, A, p, q, α, backend ) ip = invperm((linearize(p)..., q[1]..., q[2]...)) pdA = _repartition(ip, A) - E = one!(TO.tensoralloc_add(scalartype(A), A, q, conjA)) + E = one!(TO.tensoralloc_add(scalartype(A), A, q, false)) twist!(E, filter(x -> !isdual(space(E, x)), codomainind(E))) pE = ((), trivtuple(TO.numind(q))) pΔC = (trivtuple(TO.numind(p)), ()) TO.tensorproduct!( - ΔA, ΔC, pΔC, conjA, E, pE, conjA, pdA, conjA ? α : conj(α), Zero(), ba... + ΔA, ΔC, pΔC, false, E, pE, false, pdA, conj(α), One(), backend ) return NoRData() end -function tensortrace_pullback_Δα( - ΔC, A, p, q, conjA, α, ba... +function trace_permute_pullback_Δα( + ΔC, A, p, q, α, backend ) Tdα = Mooncake.rdata_type(Mooncake.tangent_type(typeof(α))) Tdα === NoRData && return NoRData() # TODO: this result might be easier to compute as: # C′ = βC + α * trace(A) ⟹ At = (C′ - βC) / α - At = TO.tensortrace(A, p, q, conjA) + At = TO.tensortrace(A, p, q, false, One(), backend) Δα = inner(At, ΔC) return Mooncake._rdata(Δα) end -function tensortrace_pullback_Δβ(ΔC, C, β) +function trace_permute_pullback_Δβ(ΔC, C, β) Tdβ = Mooncake.rdata_type(Mooncake.tangent_type(typeof(β))) Tdβ === NoRData && return NoRData() diff --git a/test/autodiff/mooncake.jl b/test/autodiff/mooncake.jl index a5b08fc90..cca2c92d3 100644 --- a/test/autodiff/mooncake.jl +++ b/test/autodiff/mooncake.jl @@ -260,14 +260,14 @@ for V in spacelist ) Mooncake.TestUtils.test_rule( rng, tensorcontract!, C, A, pA, conjA, B, pB, conjB, pAB, α, β; - atol, rtol, mode, is_primitive + atol, rtol, mode ) end end end - @timedtestset "tensortrace!" begin + @timedtestset "trace_permute!" begin for _ in 1:5 k1 = rand(0:2) k2 = rand(1:2) @@ -282,13 +282,11 @@ for V in spacelist α = randn(T) β = randn(T) - for conjA in (false, true) - C = randn!(TensorOperations.tensoralloc_add(T, A, p, conjA, Val(false))) - Mooncake.TestUtils.test_rule( - rng, tensortrace!, C, A, p, q, conjA, α, β; - atol, rtol, mode, is_primitive = false - ) - end + C = randn!(TensorOperations.tensoralloc_add(T, A, p, false, Val(false))) + Mooncake.TestUtils.test_rule( + rng, TensorKit.trace_permute!, C, A, p, q, α, β, TensorOperations.DefaultBackend(); + atol, rtol, mode + ) end end end From 677779f83b352caa054f33643b6fb2673a76d991 Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Wed, 21 Jan 2026 17:10:38 -0500 Subject: [PATCH 23/52] dont need rules for `tensoradd!` --- ext/TensorKitMooncakeExt/tensoroperations.jl | 86 -------------------- test/autodiff/mooncake.jl | 19 ----- 2 files changed, 105 deletions(-) diff --git a/ext/TensorKitMooncakeExt/tensoroperations.jl b/ext/TensorKitMooncakeExt/tensoroperations.jl index 989ee2830..7b979d4cf 100644 --- a/ext/TensorKitMooncakeExt/tensoroperations.jl +++ b/ext/TensorKitMooncakeExt/tensoroperations.jl @@ -1,89 +1,3 @@ -# tensoradd! -# ---------- -# Mooncake.@is_primitive( -# DefaultCtx, -# ReverseMode, -# Tuple{ -# typeof(TO.tensoradd!), -# AbstractTensorMap, -# AbstractTensorMap, Index2Tuple, Bool, -# Number, Number, Vararg{Any}, -# } -# ) -# -# function Mooncake.rrule!!( -# ::CoDual{typeof(TO.tensoradd!)}, -# C_ΔC::CoDual{<:AbstractTensorMap}, -# A_ΔA::CoDual{<:AbstractTensorMap}, pA_ΔpA::CoDual{<:Index2Tuple}, conjA_ΔconjA::CoDual{Bool}, -# α_Δα::CoDual{<:Number}, β_Δβ::CoDual{<:Number}, -# ba_Δba::CoDual... -# ) -# # prepare arguments -# C, ΔC = arrayify(C_ΔC) -# A, ΔA = arrayify(A_ΔA) -# pA = primal(pA_ΔpA) -# conjA = primal(conjA_ΔconjA) -# α, β = primal.((α_Δα, β_Δβ)) -# ba = primal.(ba_Δba) -# -# # primal call -# C_cache = copy(C) -# TO.tensoradd!(C, A, pA, conjA, α, β, ba...) -# -# function tensoradd_pullback(::NoRData) -# copy!(C, C_cache) -# -# ΔCr = tensoradd_pullback_ΔC!(ΔC, β) -# ΔAr = tensoradd_pullback_ΔA!(ΔA, ΔC, A, pA, conjA, α, ba...) -# Δαr = tensoradd_pullback_Δα(ΔC, A, pA, conjA, α, ba...) -# Δβr = tensoradd_pullback_Δβ(ΔC, C, β) -# -# return NoRData(), -# ΔCr, -# ΔAr, NoRData(), NoRData(), -# Δαr, Δβr, -# map(Returns(NoRData()), ba)... -# end -# -# return C_ΔC, tensoradd_pullback -# end -# -# tensoradd_pullback_ΔC!(ΔC, β) = (scale!(ΔC, conj(β)); NoRData()) -# -# function tensoradd_pullback_ΔA!( -# ΔA, ΔC, A, pA, conjA, α, ba... -# ) -# ipA = invperm(linearize(pA)) -# pΔA = _repartition(ipA, A) -# TO.tensoradd!(ΔA, ΔC, pΔA, conjA, conjA ? α : conj(α), Zero(), ba...) -# return NoRData() -# end -# -# function tensoradd_pullback_Δα( -# ΔC, A, pA, conjA, α, ba... -# ) -# Tdα = Mooncake.rdata_type(Mooncake.tangent_type(typeof(α))) -# Tdα === NoRData && return NoRData() -# -# tΔC = twist(ΔC, filter(x -> isdual(space(ΔC, x)), allind(ΔC)); copy = false) -# Δα = TO.tensorscalar( -# TO.tensorcontract( -# A, ((), linearize(pA)), !conjA, -# tΔC, (trivtuple(TO.numind(pA)), ()), false, -# ((), ()), One(), ba... -# ) -# ) -# return Mooncake._rdata(Δα) -# end -# -# function tensoradd_pullback_Δβ(ΔC, C, β) -# Tdβ = Mooncake.rdata_type(Mooncake.tangent_type(typeof(β))) -# Tdβ === NoRData && return NoRData() -# -# Δβ = inner(C, ΔC) -# return Mooncake._rdata(Δβ) -# end - # tensorcontract! # --------------- Mooncake.@is_primitive( diff --git a/test/autodiff/mooncake.jl b/test/autodiff/mooncake.jl index cca2c92d3..066a3585f 100644 --- a/test/autodiff/mooncake.jl +++ b/test/autodiff/mooncake.jl @@ -206,25 +206,6 @@ for V in spacelist atol = precision(T) rtol = precision(T) - @timedtestset "tensoradd!" begin - A = randn(T, V[1] ⊗ V[2] ← V[4] ⊗ V[5]) - α = randn(T) - β = randn(T) - - # repeat a couple times to get some distribution of arrows - for _ in 1:5 - p = randindextuple(numind(A)) - - C1 = randn!(TensorOperations.tensoralloc_add(T, A, p, false, Val(false))) - Mooncake.TestUtils.test_rule(rng, tensoradd!, C1, A, p, false, α, β; atol, rtol, mode, is_primitive = false) - - C2 = randn!(TensorOperations.tensoralloc_add(T, A, p, true, Val(false))) - Mooncake.TestUtils.test_rule(rng, tensoradd!, C2, A, p, true, α, β; atol, rtol, mode, is_primitive = false) - - A = rand(Bool) ? C1 : C2 - end - end - @timedtestset "tensorcontract!" begin for _ in 1:5 d = 0 From 9d1625119534837687c80a78e0e4b6a1431c9b75 Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Wed, 21 Jan 2026 19:52:14 -0500 Subject: [PATCH 24/52] add planaroperations --- .../TensorKitMooncakeExt.jl | 1 + ext/TensorKitMooncakeExt/planaroperations.jl | 88 +++++++++++++++++++ test/autodiff/mooncake.jl | 73 +++++++++++++++ 3 files changed, 162 insertions(+) create mode 100644 ext/TensorKitMooncakeExt/planaroperations.jl diff --git a/ext/TensorKitMooncakeExt/TensorKitMooncakeExt.jl b/ext/TensorKitMooncakeExt/TensorKitMooncakeExt.jl index 15e0c4c9f..4c692adb9 100644 --- a/ext/TensorKitMooncakeExt/TensorKitMooncakeExt.jl +++ b/ext/TensorKitMooncakeExt/TensorKitMooncakeExt.jl @@ -15,5 +15,6 @@ include("linalg.jl") include("indexmanipulations.jl") include("vectorinterface.jl") include("tensoroperations.jl") +include("planaroperations.jl") end diff --git a/ext/TensorKitMooncakeExt/planaroperations.jl b/ext/TensorKitMooncakeExt/planaroperations.jl new file mode 100644 index 000000000..a480293af --- /dev/null +++ b/ext/TensorKitMooncakeExt/planaroperations.jl @@ -0,0 +1,88 @@ +# planartrace! +# ------------ +Mooncake.@is_primitive( + DefaultCtx, + ReverseMode, + Tuple{ + typeof(TensorKit.planartrace!), + AbstractTensorMap, + AbstractTensorMap, Index2Tuple, Index2Tuple, + Number, Number, + Any, Any, + } +) + +function Mooncake.rrule!!( + ::CoDual{typeof(TensorKit.planartrace!)}, + C_ΔC::CoDual{<:AbstractTensorMap}, + A_ΔA::CoDual{<:AbstractTensorMap}, p_Δp::CoDual{<:Index2Tuple}, q_Δq::CoDual{<:Index2Tuple}, + α_Δα::CoDual{<:Number}, β_Δβ::CoDual{<:Number}, + backend_Δbackend::CoDual, allocator_Δallocator::CoDual + ) + # prepare arguments + C, ΔC = arrayify(C_ΔC) + A, ΔA = arrayify(A_ΔA) + p = primal(p_Δp) + q = primal(q_Δq) + α, β = primal.((α_Δα, β_Δβ)) + backend, allocator = primal.((backend_Δbackend, allocator_Δallocator)) + + # primal call + C_cache = copy(C) + TensorKit.planartrace!(C, A, p, q, α, β, backend, allocator) + + function planartrace_pullback(::NoRData) + copy!(C, C_cache) + + ΔAr = planartrace_pullback_ΔA!(ΔA, ΔC, A, p, q, α, backend, allocator) + Δαr = planartrace_pullback_Δα(ΔC, A, p, q, α, backend, allocator) + Δβr = planartrace_pullback_Δβ(ΔC, C, β) + ΔCr = planartrace_pullback_ΔC!(ΔC, β) + + return NoRData(), + ΔCr, ΔAr, NoRData(), NoRData(), + Δαr, Δβr, NoRData(), NoRData() + end + + return C_ΔC, planartrace_pullback +end + +planartrace_pullback_ΔC!(ΔC, β) = (scale!(ΔC, conj(β)); NoRData()) + +function planartrace_pullback_ΔA!( + ΔA, ΔC, A, p, q, α, backend, allocator + ) + ip = invperm((linearize(p)..., q[1]..., q[2]...)) + pdA = _repartition(ip, A) + E = one!(TO.tensoralloc_add(scalartype(A), A, q, false)) + twist!(E, filter(x -> !isdual(space(E, x)), codomainind(E))) + pE = ((), trivtuple(TO.numind(q))) + pΔC = (trivtuple(TO.numind(p)), ()) + TensorKit.planarcontract!( + ΔA, ΔC, pΔC, E, pE, pdA, conj(α), One(), backend, allocator + ) + return NoRData() +end + +function planartrace_pullback_Δα( + ΔC, A, p, q, α, backend, allocator + ) + Tdα = Mooncake.rdata_type(Mooncake.tangent_type(typeof(α))) + Tdα === NoRData && return NoRData() + + # TODO: this result might be easier to compute as: + # C′ = βC + α * trace(A) ⟹ At = (C′ - βC) / α + At = TO.tensoralloc_add(scalartype(A), A, p, false, Val(true), allocator) + TensorKit.planartrace!(At, A, p, q, false, One(), backend, allocator) + Δα = inner(At, ΔC) + TO.tensorfree!(At, allocator) + return Mooncake._rdata(Δα) +end + +function planartrace_pullback_Δβ(ΔC, C, β) + Tdβ = Mooncake.rdata_type(Mooncake.tangent_type(typeof(β))) + Tdβ === NoRData && return NoRData() + + Δβ = inner(C, ΔC) + return Mooncake._rdata(Δβ) +end diff --git a/test/autodiff/mooncake.jl b/test/autodiff/mooncake.jl index 066a3585f..14aaea251 100644 --- a/test/autodiff/mooncake.jl +++ b/test/autodiff/mooncake.jl @@ -271,4 +271,77 @@ for V in spacelist end end end + + @timedtestset "PlanarOperations with scalartype $T" for T in eltypes + atol = precision(T) + rtol = precision(T) + + @timedtestset "planarcontract!" begin + for _ in 1:5 + d = 0 + local V1, V2, V3, k1, k2, k3 + # retry a couple times to make sure there are at least some nonzero elements + for _ in 1:10 + k1 = rand(0:3) + k2 = rand(0:2) + k3 = rand(0:2) + V1 = prod(v -> rand(Bool) ? v' : v, rand(V, k1); init = one(V[1])) + V2 = prod(v -> rand(Bool) ? v' : v, rand(V, k2); init = one(V[1])) + V3 = prod(v -> rand(Bool) ? v' : v, rand(V, k3); init = one(V[1])) + d = min(dim(V1 ← V2), dim(V1' ← V2), dim(V2 ← V3), dim(V2' ← V3)) + d > 1 && break + end + k′ = rand(0:(k1 + k2)) + pA = randcircshift(k′, k1 + k2 - k′, k1) + ipA = _repartition(invperm(linearize(pA)), k′) + k′ = rand(0:(k2 + k3)) + pB = randcircshift(k′, k2 + k3 - k′, k2) + ipB = _repartition(invperm(linearize(pB)), k′) + # TODO: primal value already is broken for this? + # pAB = randcircshift(k1, k3) + pAB = _repartition(tuple((1:(k1 + k3))...), k1) + + α = randn(T) + β = randn(T) + + A = randn(T, permute(V1 ← V2, ipA)) + B = randn(T, permute(V2 ← V3, ipB)) + C = randn!( + TensorOperations.tensoralloc_contract( + T, A, pA, false, B, pB, false, pAB, Val(false) + ) + ) + Mooncake.TestUtils.test_rule( + rng, TensorKit.planarcontract!, C, A, pA, B, pB, pAB, α, β; + atol, rtol, mode, is_primitive = false + ) + end + end + + @timedtestset "planartrace!" begin + for _ in 1:5 + k1 = rand(0:2) + k2 = rand(1:2) + V1 = map(v -> rand(Bool) ? v' : v, rand(V, k1)) + V2 = map(v -> rand(Bool) ? v' : v, rand(V, k2)) + + k′ = rand(0:(k1 + 2k2)) + (_p, _q) = randcircshift(k′, k1 + 2 * k2 - k′, k1) + p = _repartition(_p, rand(0:k1)) + q = _repartition(_q, k2) + ip = _repartition(invperm(linearize((_p, _q))), k′) + A = randn(T, permute(prod(V1) ⊗ prod(V2) ← prod(V2), ip)) + + α = randn(T) + β = randn(T) + C = randn!(TensorOperations.tensoralloc_add(T, A, p, false, Val(false))) + Mooncake.TestUtils.test_rule( + rng, TensorKit.planartrace!, + C, A, p, q, α, β, + TensorOperations.DefaultBackend(), TensorOperations.DefaultAllocator(); + atol, rtol, mode + ) + end + end + end end From 62d7c6c15e7cd1a692e631d9cb3e0bbe5bbddb42 Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Wed, 21 Jan 2026 19:52:39 -0500 Subject: [PATCH 25/52] rewrite rule `tensorcontract` in terms of `blas_contract!` --- ext/TensorKitMooncakeExt/tensoroperations.jl | 83 +++++++++----------- test/autodiff/mooncake.jl | 25 +++--- 2 files changed, 51 insertions(+), 57 deletions(-) diff --git a/ext/TensorKitMooncakeExt/tensoroperations.jl b/ext/TensorKitMooncakeExt/tensoroperations.jl index 7b979d4cf..59a398e27 100644 --- a/ext/TensorKitMooncakeExt/tensoroperations.jl +++ b/ext/TensorKitMooncakeExt/tensoroperations.jl @@ -4,72 +4,69 @@ Mooncake.@is_primitive( DefaultCtx, ReverseMode, Tuple{ - typeof(TO.tensorcontract!), + typeof(TensorKit.blas_contract!), AbstractTensorMap, - AbstractTensorMap, Index2Tuple, Bool, - AbstractTensorMap, Index2Tuple, Bool, + AbstractTensorMap, Index2Tuple, + AbstractTensorMap, Index2Tuple, Index2Tuple, Number, Number, - Vararg{Any}, + Any, Any, } ) function Mooncake.rrule!!( - ::CoDual{typeof(TO.tensorcontract!)}, + ::CoDual{typeof(TensorKit.blas_contract!)}, C_ΔC::CoDual{<:AbstractTensorMap}, - A_ΔA::CoDual{<:AbstractTensorMap}, pA_ΔpA::CoDual{<:Index2Tuple}, conjA_ΔconjA::CoDual{Bool}, - B_ΔB::CoDual{<:AbstractTensorMap}, pB_ΔpB::CoDual{<:Index2Tuple}, conjB_ΔconjB::CoDual{Bool}, + A_ΔA::CoDual{<:AbstractTensorMap}, pA_ΔpA::CoDual{<:Index2Tuple}, + B_ΔB::CoDual{<:AbstractTensorMap}, pB_ΔpB::CoDual{<:Index2Tuple}, pAB_ΔpAB::CoDual{<:Index2Tuple}, α_Δα::CoDual{<:Number}, β_Δβ::CoDual{<:Number}, - ba_Δba::CoDual..., + backend_Δbackend::CoDual, allocator_Δallocator::CoDual ) # prepare arguments (C, ΔC), (A, ΔA), (B, ΔB) = arrayify.((C_ΔC, A_ΔA, B_ΔB)) pA, pB, pAB = primal.((pA_ΔpA, pB_ΔpB, pAB_ΔpAB)) - conjA, conjB = primal.((conjA_ΔconjA, conjB_ΔconjB)) α, β = primal.((α_Δα, β_Δβ)) - ba = primal.(ba_Δba) + backend, allocator = primal.((backend_Δbackend, allocator_Δallocator)) # primal call C_cache = copy(C) - TO.tensorcontract!(C, A, pA, conjA, B, pB, conjB, pAB, α, β, ba...) + TensorKit.blas_contract!(C, A, pA, B, pB, pAB, α, β, backend, allocator) - function tensorcontract_pullback(::NoRData) + function blas_contract_pullback(::NoRData) copy!(C, C_cache) - ΔCr = tensorcontract_pullback_ΔC!(ΔC, β) - ΔAr = tensorcontract_pullback_ΔA!( - ΔA, ΔC, A, pA, conjA, B, pB, conjB, pAB, α, ba... + ΔAr = blas_contract_pullback_ΔA!( + ΔA, ΔC, A, pA, B, pB, pAB, α, backend, allocator ) - ΔBr = tensorcontract_pullback_ΔB!( - ΔB, ΔC, A, pA, conjA, B, pB, conjB, pAB, α, ba... + ΔBr = blas_contract_pullback_ΔB!( + ΔB, ΔC, A, pA, B, pB, pAB, α, backend, allocator ) - Δαr = tensorcontract_pullback_Δα( - ΔC, A, pA, conjA, B, pB, conjB, pAB, α, ba... + Δαr = blas_contract_pullback_Δα( + ΔC, A, pA, B, pB, pAB, α, backend, allocator ) - Δβr = tensorcontract_pullback_Δβ(ΔC, C, β) + Δβr = blas_contract_pullback_Δβ(ΔC, C, β) + ΔCr = blas_contract_pullback_ΔC!(ΔC, β) return NoRData(), ΔCr, - ΔAr, NoRData(), NoRData(), - ΔBr, NoRData(), NoRData(), + ΔAr, NoRData(), + ΔBr, NoRData(), NoRData(), Δαr, Δβr, - map(ba_ -> NoRData(), ba)... + NoRData(), NoRData() end - return C_ΔC, tensorcontract_pullback + return C_ΔC, blas_contract_pullback end -tensorcontract_pullback_ΔC!(ΔC, β) = (scale!(ΔC, conj(β)); NoRData()) +blas_contract_pullback_ΔC!(ΔC, β) = (scale!(ΔC, conj(β)); NoRData()) -function tensorcontract_pullback_ΔA!( - ΔA, ΔC, A, pA, conjA, B, pB, conjB, pAB, α, ba... +function blas_contract_pullback_ΔA!( + ΔA, ΔC, A, pA, B, pB, pAB, α, backend, allocator ) ipAB = invperm(linearize(pAB)) pΔC = _repartition(ipAB, TO.numout(pA)) ipA = _repartition(invperm(linearize(pA)), A) - conjΔC = conjA - conjB′ = conjA ? conjB : !conjB tB = twist( B, @@ -81,24 +78,22 @@ function tensorcontract_pullback_ΔA!( TO.tensorcontract!( ΔA, - ΔC, pΔC, conjΔC, - tB, reverse(pB), conjB′, + ΔC, pΔC, false, + tB, reverse(pB), true, ipA, - conjA ? α : conj(α), Zero(), - ba... + conj(α), Zero(), + backend, allocator ) return NoRData() end -function tensorcontract_pullback_ΔB!( - ΔB, ΔC, A, pA, conjA, B, pB, conjB, pAB, α, ba... +function blas_contract_pullback_ΔB!( + ΔB, ΔC, A, pA, B, pB, pAB, α, backend, allocator ) ipAB = invperm(linearize(pAB)) pΔC = _repartition(ipAB, TO.numout(pA)) ipB = _repartition(invperm(linearize(pB)), B) - conjΔC = conjB - conjA′ = conjB ? conjA : !conjA tA = twist( A, @@ -110,27 +105,27 @@ function tensorcontract_pullback_ΔB!( TO.tensorcontract!( ΔB, - tA, reverse(pA), conjA′, - ΔC, pΔC, conjΔC, + tA, reverse(pA), true, + ΔC, pΔC, false, ipB, - conjB ? α : conj(α), Zero(), ba... + conj(α), Zero(), backend, allocator ) return NoRData() end -function tensorcontract_pullback_Δα( - ΔC, A, pA, conjA, B, pB, conjB, pAB, α, ba... +function blas_contract_pullback_Δα( + ΔC, A, pA, B, pB, pAB, α, backend, allocator ) Tdα = Mooncake.rdata_type(Mooncake.tangent_type(typeof(α))) Tdα === NoRData && return NoRData() - AB = TO.tensorcontract(A, pA, conjA, B, pB, conjB, pAB, One(), ba...) + AB = TO.tensorcontract(A, pA, false, B, pB, false, pAB, One(), backend, allocator) Δα = inner(AB, ΔC) return Mooncake._rdata(Δα) end -function tensorcontract_pullback_Δβ(ΔC, C, β) +function blas_contract_pullback_Δβ(ΔC, C, β) Tdβ = Mooncake.rdata_type(Mooncake.tangent_type(typeof(β))) Tdβ === NoRData && return NoRData() diff --git a/test/autodiff/mooncake.jl b/test/autodiff/mooncake.jl index 14aaea251..a1bce9906 100644 --- a/test/autodiff/mooncake.jl +++ b/test/autodiff/mooncake.jl @@ -231,20 +231,19 @@ for V in spacelist β = randn(T) V2_conj = prod(conj, V2; init = one(V[1])) - for conjA in (false, true), conjB in (false, true) - A = randn(T, permute(V1 ← (conjA ? V2_conj : V2), ipA)) - B = randn(T, permute((conjB ? V2_conj : V2) ← V3, ipB)) - C = randn!( - TensorOperations.tensoralloc_contract( - T, A, pA, conjA, B, pB, conjB, pAB, Val(false) - ) - ) - Mooncake.TestUtils.test_rule( - rng, tensorcontract!, C, A, pA, conjA, B, pB, conjB, pAB, α, β; - atol, rtol, mode + A = randn(T, permute(V1 ← V2, ipA)) + B = randn(T, permute(V2 ← V3, ipB)) + C = randn!( + TensorOperations.tensoralloc_contract( + T, A, pA, false, B, pB, false, pAB, Val(false) ) - - end + ) + Mooncake.TestUtils.test_rule( + rng, TensorKit.blas_contract!, + C, A, pA, B, pB, pAB, α, β, + TensorOperations.DefaultBackend(), TensorOperations.DefaultAllocator(); + atol, rtol, mode + ) end end From bb9fc69cc3e11e78410fb5020a20758d687fab91 Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Wed, 21 Jan 2026 20:50:06 -0500 Subject: [PATCH 26/52] add rule `tr` --- ext/TensorKitMooncakeExt/linalg.jl | 16 ++++++++++++++++ test/autodiff/mooncake.jl | 8 ++++++++ 2 files changed, 24 insertions(+) diff --git a/ext/TensorKitMooncakeExt/linalg.jl b/ext/TensorKitMooncakeExt/linalg.jl index d0d73d951..092ddf369 100644 --- a/ext/TensorKitMooncakeExt/linalg.jl +++ b/ext/TensorKitMooncakeExt/linalg.jl @@ -51,3 +51,19 @@ function Mooncake.rrule!!(::CoDual{typeof(norm)}, tΔt::CoDual{<:AbstractTensorM end return CoDual(n, Mooncake.NoFData()), norm_pullback end + +Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(tr), AbstractTensorMap} + +function Mooncake.rrule!!(::CoDual{typeof(tr)}, A_ΔA::CoDual{<:AbstractTensorMap}) + A, ΔA = arrayify(A_ΔA) + trace = tr(A) + + function tr_pullback(Δtrace) + for (_, b) in blocks(ΔA) + TensorKit.diagview(b) .+= Δtrace + end + return NoRData(), NoRData() + end + + return CoDual(trace, Mooncake.NoFData()), tr_pullback +end diff --git a/test/autodiff/mooncake.jl b/test/autodiff/mooncake.jl index a1bce9906..e9f7d01d7 100644 --- a/test/autodiff/mooncake.jl +++ b/test/autodiff/mooncake.jl @@ -117,6 +117,14 @@ for V in spacelist Mooncake.TestUtils.test_rule(rng, norm, C, 2; atol, rtol, mode) Mooncake.TestUtils.test_rule(rng, norm, C', 2; atol, rtol, mode) + + D1 = randn(T, V[1] ← V[1]) + D2 = randn(T, V[1] ⊗ V[2] ← V[1] ⊗ V[2]) + D3 = randn(T, V[1] ⊗ V[2] ⊗ V[3] ← V[1] ⊗ V[2] ⊗ V[3]) + + Mooncake.TestUtils.test_rule(rng, tr, D1; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, tr, D2; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, tr, D3; atol, rtol, mode) end From 50882d81baa02db01b2952ba51ab7cca0627d258 Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Thu, 22 Jan 2026 08:02:00 -0500 Subject: [PATCH 27/52] give up on planartrace for now --- ext/TensorKitMooncakeExt/planaroperations.jl | 34 +++++++++---- src/fusiontrees/manipulations.jl | 2 +- test/autodiff/mooncake.jl | 53 +++++++++++--------- 3 files changed, 52 insertions(+), 37 deletions(-) diff --git a/ext/TensorKitMooncakeExt/planaroperations.jl b/ext/TensorKitMooncakeExt/planaroperations.jl index a480293af..3d1742a3a 100644 --- a/ext/TensorKitMooncakeExt/planaroperations.jl +++ b/ext/TensorKitMooncakeExt/planaroperations.jl @@ -49,19 +49,31 @@ end planartrace_pullback_ΔC!(ΔC, β) = (scale!(ΔC, conj(β)); NoRData()) +# This implementation is slightly more involved than its non-planar counterpart +# this is because we lack a general `pAB` argument in `planarcontract`, and need +# to keep things planar along the way. +# In particular, we can't simply tensor product with multiple identities in one go +# if they aren't "contiguous", e.g. p = ((1, 4, 5), ()), q = ((2, 6), (3, 7)) function planartrace_pullback_ΔA!( ΔA, ΔC, A, p, q, α, backend, allocator ) - ip = invperm((linearize(p)..., q[1]..., q[2]...)) - pdA = _repartition(ip, A) - E = one!(TO.tensoralloc_add(scalartype(A), A, q, false)) - twist!(E, filter(x -> !isdual(space(E, x)), codomainind(E))) - pE = ((), trivtuple(TO.numind(q))) - pΔC = (trivtuple(TO.numind(p)), ()) - TensorKit.planarcontract!( - ΔA, ΔC, pΔC, E, pE, pdA, conj(α), One(), backend, allocator - ) - return NoRData() + if length(q[1]) == 0 + ip = invperm(linearize(p)) + pΔA = _repartition(ip, A) + TK.add_transpose!(ΔA, ΔC, pΔA, conj(α), One(), backend, allocator) + return NoRData() + end + # if length(q[1]) == 1 + # ip = invperm((p[1]..., q[2]..., p[2]..., q[1]...)) + # pdA = _repartition(ip, A) + # E = one!(TO.tensoralloc_add(scalartype(A), A, q, false)) + # twist!(E, filter(x -> !isdual(space(E, x)), codomainind(E))) + # # pE = ((), trivtuple(TO.numind(q))) + # # pΔC = (trivtuple(TO.numind(p)), ()) + # TensorKit.planaradd!(ΔA, ΔC ⊗ E, pdA, conj(α), One(), backend, allocator) + # return NoRData() + # end + error("The reverse rule for `planartrace` is not yet implemented") end function planartrace_pullback_Δα( @@ -73,7 +85,7 @@ function planartrace_pullback_Δα( # TODO: this result might be easier to compute as: # C′ = βC + α * trace(A) ⟹ At = (C′ - βC) / α At = TO.tensoralloc_add(scalartype(A), A, p, false, Val(true), allocator) - TensorKit.planartrace!(At, A, p, q, false, One(), backend, allocator) + TensorKit.planartrace!(At, A, p, q, One(), Zero(), backend, allocator) Δα = inner(At, ΔC) TO.tensorfree!(At, allocator) return Mooncake._rdata(Δα) diff --git a/src/fusiontrees/manipulations.jl b/src/fusiontrees/manipulations.jl index 1564b1b67..3cc6a16b6 100644 --- a/src/fusiontrees/manipulations.jl +++ b/src/fusiontrees/manipulations.jl @@ -692,7 +692,7 @@ function planar_trace( k += 1 end end - k > N₃ && throw(ArgumentError("Not a planar trace")) + k > N₃ && throw(ArgumentError(lazy"not a planar trace: ($q1, $q2)")) q1′ = let i = i, j = j map(l -> (l - (l > i) - (l > j)), TupleTools.deleteat(q1, k)) diff --git a/test/autodiff/mooncake.jl b/test/autodiff/mooncake.jl index e9f7d01d7..db7e0c078 100644 --- a/test/autodiff/mooncake.jl +++ b/test/autodiff/mooncake.jl @@ -325,30 +325,33 @@ for V in spacelist end end - @timedtestset "planartrace!" begin - for _ in 1:5 - k1 = rand(0:2) - k2 = rand(1:2) - V1 = map(v -> rand(Bool) ? v' : v, rand(V, k1)) - V2 = map(v -> rand(Bool) ? v' : v, rand(V, k2)) - - k′ = rand(0:(k1 + 2k2)) - (_p, _q) = randcircshift(k′, k1 + 2 * k2 - k′, k1) - p = _repartition(_p, rand(0:k1)) - q = _repartition(_q, k2) - ip = _repartition(invperm(linearize((_p, _q))), k′) - A = randn(T, permute(prod(V1) ⊗ prod(V2) ← prod(V2), ip)) - - α = randn(T) - β = randn(T) - C = randn!(TensorOperations.tensoralloc_add(T, A, p, false, Val(false))) - Mooncake.TestUtils.test_rule( - rng, TensorKit.planartrace!, - C, A, p, q, α, β, - TensorOperations.DefaultBackend(), TensorOperations.DefaultAllocator(); - atol, rtol, mode - ) - end - end + # TODO: currently broken + # @timedtestset "planartrace!" begin + # for _ in 1:5 + # k1 = rand(0:2) + # k2 = rand(0:1) + # V1 = map(v -> rand(Bool) ? v' : v, rand(V, k1)) + # V2 = map(v -> rand(Bool) ? v' : v, rand(V, k2)) + # V3 = prod(x -> x ⊗ x', V2[1:k2]; init = one(V[1])) + # V4 = prod(x -> x ⊗ x', V2[(k2 + 1):end]; init = one(V[1])) + # + # k′ = rand(0:(k1 + 2k2)) + # (_p, _q) = randcircshift(k′, k1 + 2k2 - k′, k1) + # p = _repartition(_p, rand(0:k1)) + # q = (tuple(_q[1:2:end]...), tuple(_q[2:2:end]...)) + # ip = _repartition(invperm(linearize((_p, _q))), k′) + # A = randn(T, permute(prod(V1) ⊗ V3 ← V4, ip)) + # + # α = randn(T) + # β = randn(T) + # C = randn!(TensorOperations.tensoralloc_add(T, A, p, false, Val(false))) + # Mooncake.TestUtils.test_rule( + # rng, TensorKit.planartrace!, + # C, A, p, q, α, β, + # TensorOperations.DefaultBackend(), TensorOperations.DefaultAllocator(); + # atol, rtol, mode + # ) + # end + # end end end From fe1ce4f254348d6bd11ecc5e42a03d0b45e40e3c Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Thu, 22 Jan 2026 08:08:47 -0500 Subject: [PATCH 28/52] add rule `inv` --- ext/TensorKitMooncakeExt/linalg.jl | 15 +++++++++++++++ test/autodiff/mooncake.jl | 4 ++++ 2 files changed, 19 insertions(+) diff --git a/ext/TensorKitMooncakeExt/linalg.jl b/ext/TensorKitMooncakeExt/linalg.jl index 092ddf369..a35c1cea4 100644 --- a/ext/TensorKitMooncakeExt/linalg.jl +++ b/ext/TensorKitMooncakeExt/linalg.jl @@ -67,3 +67,18 @@ function Mooncake.rrule!!(::CoDual{typeof(tr)}, A_ΔA::CoDual{<:AbstractTensorMa return CoDual(trace, Mooncake.NoFData()), tr_pullback end + +Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(inv), AbstractTensorMap} + +function Mooncake.rrule!!(::CoDual{typeof(inv)}, A_ΔA::CoDual{<:AbstractTensorMap}) + A, ΔA = arrayify(A_ΔA) + Ainv_ΔAinv = Mooncake.zero_fcodual(inv(A)) + Ainv, ΔAinv = arrayify(Ainv_ΔAinv) + + function inv_pullback(::NoRData) + mul!(ΔA, Ainv' * ΔAinv, Ainv', -1, One()) + return NoRData(), NoRData() + end + + return Ainv_ΔAinv, inv_pullback +end diff --git a/test/autodiff/mooncake.jl b/test/autodiff/mooncake.jl index db7e0c078..0ae368235 100644 --- a/test/autodiff/mooncake.jl +++ b/test/autodiff/mooncake.jl @@ -125,6 +125,10 @@ for V in spacelist Mooncake.TestUtils.test_rule(rng, tr, D1; atol, rtol, mode) Mooncake.TestUtils.test_rule(rng, tr, D2; atol, rtol, mode) Mooncake.TestUtils.test_rule(rng, tr, D3; atol, rtol, mode) + + Mooncake.TestUtils.test_rule(rng, inv, D1; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, inv, D2; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, inv, D3; atol, rtol, mode) end From 39bc3a0ee25d04ed8bae3c5f42d7bf415c316cbf Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Thu, 22 Jan 2026 08:33:46 -0500 Subject: [PATCH 29/52] is_primitive in namespace --- .../TensorKitMooncakeExt.jl | 2 +- .../indexmanipulations.jl | 20 +++++++++---------- ext/TensorKitMooncakeExt/linalg.jl | 8 ++++---- ext/TensorKitMooncakeExt/planaroperations.jl | 2 +- ext/TensorKitMooncakeExt/tensoroperations.jl | 4 ++-- ext/TensorKitMooncakeExt/vectorinterface.jl | 8 ++++---- 6 files changed, 22 insertions(+), 22 deletions(-) diff --git a/ext/TensorKitMooncakeExt/TensorKitMooncakeExt.jl b/ext/TensorKitMooncakeExt/TensorKitMooncakeExt.jl index 4c692adb9..d3894c874 100644 --- a/ext/TensorKitMooncakeExt/TensorKitMooncakeExt.jl +++ b/ext/TensorKitMooncakeExt/TensorKitMooncakeExt.jl @@ -1,7 +1,7 @@ module TensorKitMooncakeExt using Mooncake -using Mooncake: @zero_derivative, DefaultCtx, ReverseMode, NoFData, NoRData, CoDual, arrayify, primal +using Mooncake: @zero_derivative, @is_primitive, DefaultCtx, ReverseMode, NoFData, NoRData, CoDual, arrayify, primal using TensorKit import TensorKit as TK using VectorInterface diff --git a/ext/TensorKitMooncakeExt/indexmanipulations.jl b/ext/TensorKitMooncakeExt/indexmanipulations.jl index 464c18392..39f7dd4fd 100644 --- a/ext/TensorKitMooncakeExt/indexmanipulations.jl +++ b/ext/TensorKitMooncakeExt/indexmanipulations.jl @@ -1,7 +1,7 @@ for transform in (:permute, :transpose) add_transform! = Symbol(:add_, transform, :!) add_transform_pullback = Symbol(add_transform!, :_pullback) - @eval Mooncake.@is_primitive( + @eval @is_primitive( DefaultCtx, ReverseMode, Tuple{ @@ -76,7 +76,7 @@ for transform in (:permute, :transpose) end end -Mooncake.@is_primitive( +@is_primitive( DefaultCtx, ReverseMode, Tuple{ @@ -153,8 +153,8 @@ function Mooncake.rrule!!( end # both are needed for correctly capturing every dispatch -Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(twist!), AbstractTensorMap, Any} -Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(Core.kwcall), @NamedTuple{inv::Bool}, typeof(twist!), AbstractTensorMap, Any} +@is_primitive DefaultCtx ReverseMode Tuple{typeof(twist!), AbstractTensorMap, Any} +@is_primitive DefaultCtx ReverseMode Tuple{typeof(Core.kwcall), @NamedTuple{inv::Bool}, typeof(twist!), AbstractTensorMap, Any} function Mooncake.rrule!!(::CoDual{typeof(twist!)}, t_Δt::CoDual{<:AbstractTensorMap}, inds_Δinds::CoDual) # prepare arguments @@ -198,8 +198,8 @@ function Mooncake.rrule!!( end # both are needed for correctly capturing every dispatch -Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(flip), AbstractTensorMap, Any} -Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(Core.kwcall), @NamedTuple{inv::Bool}, typeof(flip), AbstractTensorMap, Any} +@is_primitive DefaultCtx ReverseMode Tuple{typeof(flip), AbstractTensorMap, Any} +@is_primitive DefaultCtx ReverseMode Tuple{typeof(Core.kwcall), @NamedTuple{inv::Bool}, typeof(flip), AbstractTensorMap, Any} function Mooncake.rrule!!(::CoDual{typeof(flip)}, t_Δt::CoDual{<:AbstractTensorMap}, inds_Δinds::CoDual) # prepare arguments @@ -245,8 +245,8 @@ for insertunit in (:insertleftunit, :insertrightunit) insertunit_pullback = Symbol(insertunit, :_pullback) @eval begin # both are needed for correctly capturing every dispatch - Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof($insertunit), AbstractTensorMap, Val} - Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(Core.kwcall), NamedTuple, typeof($insertunit), AbstractTensorMap, Val} + @is_primitive DefaultCtx ReverseMode Tuple{typeof($insertunit), AbstractTensorMap, Val} + @is_primitive DefaultCtx ReverseMode Tuple{typeof(Core.kwcall), NamedTuple, typeof($insertunit), AbstractTensorMap, Val} function Mooncake.rrule!!(::CoDual{typeof($insertunit)}, tsrc_Δtsrc::CoDual{<:AbstractTensorMap}, ival_Δival::CoDual{<:Val}) # prepare arguments @@ -328,8 +328,8 @@ for insertunit in (:insertleftunit, :insertrightunit) end -Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(removeunit), AbstractTensorMap, Val} -Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(Core.kwcall), NamedTuple, typeof(removeunit), AbstractTensorMap, Val} +@is_primitive DefaultCtx ReverseMode Tuple{typeof(removeunit), AbstractTensorMap, Val} +@is_primitive DefaultCtx ReverseMode Tuple{typeof(Core.kwcall), NamedTuple, typeof(removeunit), AbstractTensorMap, Val} function Mooncake.rrule!!(::CoDual{typeof(removeunit)}, tsrc_Δtsrc::CoDual{<:AbstractTensorMap}, ival_Δival::CoDual{Val{i}}) where {i} # prepare arguments diff --git a/ext/TensorKitMooncakeExt/linalg.jl b/ext/TensorKitMooncakeExt/linalg.jl index a35c1cea4..a75e77922 100644 --- a/ext/TensorKitMooncakeExt/linalg.jl +++ b/ext/TensorKitMooncakeExt/linalg.jl @@ -1,4 +1,4 @@ -Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(mul!), AbstractTensorMap, AbstractTensorMap, AbstractTensorMap, Number, Number} +@is_primitive DefaultCtx ReverseMode Tuple{typeof(mul!), AbstractTensorMap, AbstractTensorMap, AbstractTensorMap, Number, Number} function Mooncake.rrule!!( ::CoDual{typeof(mul!)}, @@ -37,7 +37,7 @@ function Mooncake.rrule!!( return C_ΔC, mul_pullback end -Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(norm), AbstractTensorMap, Real} +@is_primitive DefaultCtx ReverseMode Tuple{typeof(norm), AbstractTensorMap, Real} function Mooncake.rrule!!(::CoDual{typeof(norm)}, tΔt::CoDual{<:AbstractTensorMap}, pdp::CoDual{<:Real}) t, Δt = arrayify(tΔt) @@ -52,7 +52,7 @@ function Mooncake.rrule!!(::CoDual{typeof(norm)}, tΔt::CoDual{<:AbstractTensorM return CoDual(n, Mooncake.NoFData()), norm_pullback end -Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(tr), AbstractTensorMap} +@is_primitive DefaultCtx ReverseMode Tuple{typeof(tr), AbstractTensorMap} function Mooncake.rrule!!(::CoDual{typeof(tr)}, A_ΔA::CoDual{<:AbstractTensorMap}) A, ΔA = arrayify(A_ΔA) @@ -68,7 +68,7 @@ function Mooncake.rrule!!(::CoDual{typeof(tr)}, A_ΔA::CoDual{<:AbstractTensorMa return CoDual(trace, Mooncake.NoFData()), tr_pullback end -Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(inv), AbstractTensorMap} +@is_primitive DefaultCtx ReverseMode Tuple{typeof(inv), AbstractTensorMap} function Mooncake.rrule!!(::CoDual{typeof(inv)}, A_ΔA::CoDual{<:AbstractTensorMap}) A, ΔA = arrayify(A_ΔA) diff --git a/ext/TensorKitMooncakeExt/planaroperations.jl b/ext/TensorKitMooncakeExt/planaroperations.jl index 3d1742a3a..df75d60fe 100644 --- a/ext/TensorKitMooncakeExt/planaroperations.jl +++ b/ext/TensorKitMooncakeExt/planaroperations.jl @@ -1,6 +1,6 @@ # planartrace! # ------------ -Mooncake.@is_primitive( +@is_primitive( DefaultCtx, ReverseMode, Tuple{ diff --git a/ext/TensorKitMooncakeExt/tensoroperations.jl b/ext/TensorKitMooncakeExt/tensoroperations.jl index 59a398e27..e38271200 100644 --- a/ext/TensorKitMooncakeExt/tensoroperations.jl +++ b/ext/TensorKitMooncakeExt/tensoroperations.jl @@ -1,6 +1,6 @@ # tensorcontract! # --------------- -Mooncake.@is_primitive( +@is_primitive( DefaultCtx, ReverseMode, Tuple{ @@ -135,7 +135,7 @@ end # tensortrace! # ------------ -Mooncake.@is_primitive( +@is_primitive( DefaultCtx, ReverseMode, Tuple{ diff --git a/ext/TensorKitMooncakeExt/vectorinterface.jl b/ext/TensorKitMooncakeExt/vectorinterface.jl index 2c1bfe984..625aadd61 100644 --- a/ext/TensorKitMooncakeExt/vectorinterface.jl +++ b/ext/TensorKitMooncakeExt/vectorinterface.jl @@ -1,4 +1,4 @@ -Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(scale!), AbstractTensorMap, Number} +@is_primitive DefaultCtx ReverseMode Tuple{typeof(scale!), AbstractTensorMap, Number} function Mooncake.rrule!!(::CoDual{typeof(scale!)}, C_ΔC::CoDual{<:AbstractTensorMap}, α_Δα::CoDual{<:Number}) # prepare arguments @@ -20,7 +20,7 @@ function Mooncake.rrule!!(::CoDual{typeof(scale!)}, C_ΔC::CoDual{<:AbstractTens return C_ΔC, scale_pullback end -Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(scale!), AbstractTensorMap, AbstractTensorMap, Number} +@is_primitive DefaultCtx ReverseMode Tuple{typeof(scale!), AbstractTensorMap, AbstractTensorMap, Number} function Mooncake.rrule!!(::CoDual{typeof(scale!)}, C_ΔC::CoDual{<:AbstractTensorMap}, A_ΔA::CoDual{<:AbstractTensorMap}, α_Δα::CoDual{<:Number}) # prepare arguments @@ -44,7 +44,7 @@ function Mooncake.rrule!!(::CoDual{typeof(scale!)}, C_ΔC::CoDual{<:AbstractTens return C_ΔC, scale_pullback end -Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(add!), AbstractTensorMap, AbstractTensorMap, Number, Number} +@is_primitive DefaultCtx ReverseMode Tuple{typeof(add!), AbstractTensorMap, AbstractTensorMap, Number, Number} function Mooncake.rrule!!(::CoDual{typeof(add!)}, C_ΔC::CoDual{<:AbstractTensorMap}, A_ΔA::CoDual{<:AbstractTensorMap}, α_Δα::CoDual{<:Number}, β_Δβ::CoDual{<:Number}) # prepare arguments @@ -73,7 +73,7 @@ function Mooncake.rrule!!(::CoDual{typeof(add!)}, C_ΔC::CoDual{<:AbstractTensor return C_ΔC, add_pullback end -Mooncake.@is_primitive DefaultCtx ReverseMode Tuple{typeof(inner), AbstractTensorMap, AbstractTensorMap} +@is_primitive DefaultCtx ReverseMode Tuple{typeof(inner), AbstractTensorMap, AbstractTensorMap} function Mooncake.rrule!!(::CoDual{typeof(inner)}, A_ΔA::CoDual{<:AbstractTensorMap}, B_ΔB::CoDual{<:AbstractTensorMap}) # prepare arguments From 2c966c7c82eb1ffd70c765d95b22cfdcf8a36ffd Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Thu, 22 Jan 2026 08:49:50 -0500 Subject: [PATCH 30/52] share more code --- .../indexmanipulations.jl | 44 +++++-------------- ext/TensorKitMooncakeExt/linalg.jl | 10 +++-- ext/TensorKitMooncakeExt/tensoroperations.jl | 28 ++---------- ext/TensorKitMooncakeExt/utility.jl | 6 +-- 4 files changed, 26 insertions(+), 62 deletions(-) diff --git a/ext/TensorKitMooncakeExt/indexmanipulations.jl b/ext/TensorKitMooncakeExt/indexmanipulations.jl index 39f7dd4fd..8a97ac81c 100644 --- a/ext/TensorKitMooncakeExt/indexmanipulations.jl +++ b/ext/TensorKitMooncakeExt/indexmanipulations.jl @@ -31,22 +31,18 @@ for transform in (:permute, :transpose) # if we need to compute Δa, it is faster to allocate an intermediate permuted A # and store that instead of repeating the permutation in the pullback each time. # effectively, we replace `add_permute` by `add ∘ permute`. - Tdα = Mooncake.rdata_type(Mooncake.tangent_type(typeof(α))) - Ap = if Tdα === NoRData - TK.$add_transform!(C, A, p, α, β, ba...) - nothing - else + Ap = if _needs_tangent(α) Ap = $transform(A, p) add!(C, Ap, α, β) Ap + else + TK.$add_transform!(C, A, p, α, β, ba...) + nothing end function $add_transform_pullback(::NoRData) copy!(C, C_cache) - scale!(ΔC, conj(β)) - ΔCr = NoRData() - # ΔA ip = invperm(linearize(p)) pΔA = _repartition(ip, A) @@ -60,14 +56,8 @@ for transform in (:permute, :transpose) Mooncake._rdata(inner(Ap, ΔC)) end - # Δβ - Tdβ = Mooncake.rdata_type(Mooncake.tangent_type(typeof(β))) - Δβr = if Tdβ === NoRData - NoRData() - else - Mooncake._rdata(inner(C, ΔC)) - end - + Δβr = pullback_dβ(C, ΔC, β) + ΔCr = pullback_dC!(ΔC, β) return NoRData(), ΔCr, ΔAr, NoRData(), Δαr, Δβr, map(Returns(NoRData()), ba)... end @@ -107,22 +97,18 @@ function Mooncake.rrule!!( # if we need to compute Δa, it is faster to allocate an intermediate braided A # and store that instead of repeating the permutation in the pullback each time. # effectively, we replace `add_permute` by `add ∘ permute`. - Tdα = Mooncake.rdata_type(Mooncake.tangent_type(typeof(α))) - Ap = if Tdα === NoRData - TK.add_braid!(C, A, p, levels, α, β, ba...) - nothing - else + Ap = if _needs_tangent(α) Ap = braid(A, p, levels) add!(C, Ap, α, β) Ap + else + TK.add_braid!(C, A, p, levels, α, β, ba...) + nothing end function add_braid!_pullback(::NoRData) copy!(C, C_cache) - scale!(ΔC, conj(β)) - ΔCr = NoRData() - # ΔA ip = invperm(linearize(p)) pΔA = _repartition(ip, A) @@ -137,14 +123,8 @@ function Mooncake.rrule!!( Mooncake._rdata(inner(Ap, ΔC)) end - # Δβ - Tdβ = Mooncake.rdata_type(Mooncake.tangent_type(typeof(β))) - Δβr = if Tdβ === NoRData - NoRData() - else - Mooncake._rdata(inner(C, ΔC)) - end - + Δβr = pullback_dβ(C, ΔC, β) + ΔCr = pullback_dC!(ΔC, β) return NoRData(), ΔCr, ΔAr, NoRData(), NoRData(), Δαr, Δβr, map(Returns(NoRData()), ba)... end diff --git a/ext/TensorKitMooncakeExt/linalg.jl b/ext/TensorKitMooncakeExt/linalg.jl index a75e77922..2a77792c9 100644 --- a/ext/TensorKitMooncakeExt/linalg.jl +++ b/ext/TensorKitMooncakeExt/linalg.jl @@ -1,3 +1,8 @@ +# Shared +# ------ +pullback_dC!(ΔC, β) = (scale!(ΔC, conj(β)); return NoRData()) +pullback_dβ(C, ΔC, β) = _needs_tangent(β) ? inner(C, ΔC) : NoRData() + @is_primitive DefaultCtx ReverseMode Tuple{typeof(mul!), AbstractTensorMap, AbstractTensorMap, AbstractTensorMap, Number, Number} function Mooncake.rrule!!( @@ -22,14 +27,13 @@ function Mooncake.rrule!!( function mul_pullback(::NoRData) copy!(C, C_cache) - scale!(ΔC, conj(β)) mul!(ΔA, ΔC, B', conj(α), One()) mul!(ΔB, A', ΔC, conj(α), One()) - ΔCr = NoRData() ΔAr = NoRData() ΔBr = NoRData() Δαr = isnothing(AB) ? NoRData() : Mooncake._rdata(inner(AB, ΔC)) - Δβr = _needs_tangent(β) ? Mooncake._rdata(inner(C, ΔC)) : NoRData() + Δβr = pullback_dβ(C, ΔC, β) + ΔCr = pullback_dC!(ΔC, β) return NoRData(), ΔCr, ΔAr, ΔBr, Δαr, Δβr end diff --git a/ext/TensorKitMooncakeExt/tensoroperations.jl b/ext/TensorKitMooncakeExt/tensoroperations.jl index e38271200..66c3f257a 100644 --- a/ext/TensorKitMooncakeExt/tensoroperations.jl +++ b/ext/TensorKitMooncakeExt/tensoroperations.jl @@ -45,8 +45,8 @@ function Mooncake.rrule!!( Δαr = blas_contract_pullback_Δα( ΔC, A, pA, B, pB, pAB, α, backend, allocator ) - Δβr = blas_contract_pullback_Δβ(ΔC, C, β) - ΔCr = blas_contract_pullback_ΔC!(ΔC, β) + Δβr = pullback_dβ(ΔC, C, β) + ΔCr = pullback_dC!(ΔC, β) return NoRData(), ΔCr, ΔAr, NoRData(), @@ -59,8 +59,6 @@ function Mooncake.rrule!!( return C_ΔC, blas_contract_pullback end -blas_contract_pullback_ΔC!(ΔC, β) = (scale!(ΔC, conj(β)); NoRData()) - function blas_contract_pullback_ΔA!( ΔA, ΔC, A, pA, B, pB, pAB, α, backend, allocator ) @@ -125,14 +123,6 @@ function blas_contract_pullback_Δα( return Mooncake._rdata(Δα) end -function blas_contract_pullback_Δβ(ΔC, C, β) - Tdβ = Mooncake.rdata_type(Mooncake.tangent_type(typeof(β))) - Tdβ === NoRData && return NoRData() - - Δβ = inner(C, ΔC) - return Mooncake._rdata(Δβ) -end - # tensortrace! # ------------ @is_primitive( @@ -171,8 +161,8 @@ function Mooncake.rrule!!( ΔAr = trace_permute_pullback_ΔA!(ΔA, ΔC, A, p, q, α, backend) Δαr = trace_permute_pullback_Δα(ΔC, A, p, q, α, backend) - Δβr = trace_permute_pullback_Δβ(ΔC, C, β) - ΔCr = trace_permute_pullback_ΔC!(ΔC, β) + Δβr = pullback_dβ(ΔC, C, β) + ΔCr = pullback_dC!(ΔC, β) return NoRData(), ΔCr, ΔAr, NoRData(), NoRData(), @@ -182,8 +172,6 @@ function Mooncake.rrule!!( return C_ΔC, trace_permute_pullback end -trace_permute_pullback_ΔC!(ΔC, β) = (scale!(ΔC, conj(β)); NoRData()) - function trace_permute_pullback_ΔA!( ΔA, ΔC, A, p, q, α, backend ) @@ -211,11 +199,3 @@ function trace_permute_pullback_Δα( Δα = inner(At, ΔC) return Mooncake._rdata(Δα) end - -function trace_permute_pullback_Δβ(ΔC, C, β) - Tdβ = Mooncake.rdata_type(Mooncake.tangent_type(typeof(β))) - Tdβ === NoRData && return NoRData() - - Δβ = inner(C, ΔC) - return Mooncake._rdata(Δβ) -end diff --git a/ext/TensorKitMooncakeExt/utility.jl b/ext/TensorKitMooncakeExt/utility.jl index e93de22be..261c1dcc2 100644 --- a/ext/TensorKitMooncakeExt/utility.jl +++ b/ext/TensorKitMooncakeExt/utility.jl @@ -1,7 +1,7 @@ _needs_tangent(x) = _needs_tangent(typeof(x)) -_needs_tangent(::Type{<:Number}) = true -_needs_tangent(::Type{<:Integer}) = false -_needs_tangent(::Type{<:Union{One, Zero}}) = false +function _needs_tangent(::Type{T}) where {T <: Number} + return Mooncake.rdata_type(Mooncake.tangent_type(T)) !== NoRData() +end # IndexTuple utility # ------------------ From 1e1ca96e6cc93f23c023223f2b93c1f9ee4ff3e7 Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Thu, 22 Jan 2026 11:56:00 -0500 Subject: [PATCH 31/52] split AD tests to reduce CI pressure properly setup setup --- .github/workflows/CI.yml | 6 +- test/autodiff/mooncake.jl | 361 -------------------- test/{autodiff => chainrules}/chainrules.jl | 0 test/mooncake/indexmanipulations.jl | 134 ++++++++ test/mooncake/linalg.jl | 80 +++++ test/mooncake/planaroperations.jl | 128 +++++++ test/mooncake/tensoroperations.jl | 121 +++++++ test/mooncake/vectorinterface.jl | 75 ++++ test/runtests.jl | 2 +- test/setup.jl | 38 +++ 10 files changed, 581 insertions(+), 364 deletions(-) delete mode 100644 test/autodiff/mooncake.jl rename test/{autodiff => chainrules}/chainrules.jl (100%) create mode 100644 test/mooncake/indexmanipulations.jl create mode 100644 test/mooncake/linalg.jl create mode 100644 test/mooncake/planaroperations.jl create mode 100644 test/mooncake/tensoroperations.jl create mode 100644 test/mooncake/vectorinterface.jl diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 434f33ed4..8880dfcf1 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -30,7 +30,8 @@ jobs: - symmetries - tensors - other - - autodiff + - mooncake + - chainrules os: - ubuntu-latest - macOS-latest @@ -55,7 +56,8 @@ jobs: - symmetries - tensors - other - - autodiff + - mooncake + - chainrules os: - ubuntu-latest - macOS-latest diff --git a/test/autodiff/mooncake.jl b/test/autodiff/mooncake.jl deleted file mode 100644 index 0ae368235..000000000 --- a/test/autodiff/mooncake.jl +++ /dev/null @@ -1,361 +0,0 @@ -using Test, TestExtras -using TensorKit -using TensorOperations -using Mooncake -using Random -using TupleTools - -mode = Mooncake.ReverseMode -rng = Random.default_rng() -is_primitive = false - -function randindextuple(N::Int, k::Int = rand(0:N)) - @assert 0 ≤ k ≤ N - _p = randperm(N) - return (tuple(_p[1:k]...), tuple(_p[(k + 1):end]...)) -end -function randcircshift(N₁::Int, N₂::Int, k::Int = rand(0:(N₁ + N₂))) - N = N₁ + N₂ - @assert 0 ≤ k ≤ N - p = TupleTools.vcat(ntuple(identity, N₁), reverse(ntuple(identity, N₂) .+ N₁)) - n = rand(0:N) - _p = TupleTools.circshift(p, n) - return (tuple(_p[1:k]...), reverse(tuple(_p[(k + 1):end]...))) -end - -const _repartition = @static if isdefined(Base, :get_extension) - Base.get_extension(TensorKit, :TensorKitMooncakeExt)._repartition -else - TensorKit.TensorKitMooncakeExt._repartition -end - -spacelist = ( - (ℂ^2, (ℂ^3)', ℂ^3, ℂ^2, (ℂ^2)'), - ( - Vect[Z2Irrep](0 => 1, 1 => 1), - Vect[Z2Irrep](0 => 1, 1 => 2)', - Vect[Z2Irrep](0 => 2, 1 => 2)', - Vect[Z2Irrep](0 => 2, 1 => 3), - Vect[Z2Irrep](0 => 2, 1 => 2), - ), - ( - Vect[FermionParity](0 => 1, 1 => 1), - Vect[FermionParity](0 => 1, 1 => 2)', - Vect[FermionParity](0 => 2, 1 => 1)', - Vect[FermionParity](0 => 2, 1 => 3), - Vect[FermionParity](0 => 2, 1 => 2), - ), - ( - Vect[U1Irrep](0 => 2, 1 => 1, -1 => 1), - Vect[U1Irrep](0 => 2, 1 => 1, -1 => 1), - Vect[U1Irrep](0 => 2, 1 => 2, -1 => 1)', - Vect[U1Irrep](0 => 1, 1 => 1, -1 => 2), - Vect[U1Irrep](0 => 1, 1 => 2, -1 => 1)', - ), - ( - Vect[SU2Irrep](0 => 2, 1 // 2 => 1), - Vect[SU2Irrep](0 => 1, 1 => 1), - Vect[SU2Irrep](1 // 2 => 1, 1 => 1)', - Vect[SU2Irrep](1 // 2 => 2), - Vect[SU2Irrep](0 => 1, 1 // 2 => 1, 3 // 2 => 1)', - ), - # ( - # Vect[FibonacciAnyon](:I => 2, :τ => 1), - # Vect[FibonacciAnyon](:I => 1, :τ => 2)', - # Vect[FibonacciAnyon](:I => 2, :τ => 2)', - # Vect[FibonacciAnyon](:I => 2, :τ => 3), - # Vect[FibonacciAnyon](:I => 2, :τ => 2), - # ), -) - -for V in spacelist - I = sectortype(eltype(V)) - Istr = TensorKit.type_repr(I) - - symmetricbraiding = BraidingStyle(sectortype(eltype(V))) isa SymmetricBraiding - println("---------------------------------------") - println("Mooncake with symmetry: $Istr") - println("---------------------------------------") - eltypes = (Float64,) # no complex support yet - - @timedtestset "VectorInterface with scalartype $T" for T in eltypes - atol = precision(T) - rtol = precision(T) - - C = randn(T, V[1] ⊗ V[2] ← V[3] ⊗ V[4] ⊗ V[5]) - A = randn(T, V[1] ⊗ V[2] ← V[3] ⊗ V[4] ⊗ V[5]) - α = randn(T) - β = randn(T) - - Mooncake.TestUtils.test_rule(rng, scale!, C, α; atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, scale!, C', α; atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, scale!, C, A, α; atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, scale!, C', A', α; atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, scale!, copy(C'), A', α; atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, scale!, C', copy(A'), α; atol, rtol, mode) - - Mooncake.TestUtils.test_rule(rng, add!, C, A; atol, rtol, mode, is_primitive = false) - Mooncake.TestUtils.test_rule(rng, add!, C, A, α; atol, rtol, mode, is_primitive = false) - Mooncake.TestUtils.test_rule(rng, add!, C, A, α, β; atol, rtol, mode) - - Mooncake.TestUtils.test_rule(rng, inner, C, A; atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, inner, C', A'; atol, rtol, mode) - end - - @timedtestset "LinearAlgebra with scalartype $T" for T in eltypes - atol = precision(T) - rtol = precision(T) - - C = randn(T, V[1] ⊗ V[2] ← V[5]) - A = randn(T, codomain(C) ← V[3] ⊗ V[4]) - B = randn(T, domain(A) ← domain(C)) - α = randn(T) - β = randn(T) - - Mooncake.TestUtils.test_rule(rng, mul!, C, A, B, α, β; atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, mul!, C, A, B; atol, rtol, mode, is_primitive = false) - - Mooncake.TestUtils.test_rule(rng, norm, C, 2; atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, norm, C', 2; atol, rtol, mode) - - D1 = randn(T, V[1] ← V[1]) - D2 = randn(T, V[1] ⊗ V[2] ← V[1] ⊗ V[2]) - D3 = randn(T, V[1] ⊗ V[2] ⊗ V[3] ← V[1] ⊗ V[2] ⊗ V[3]) - - Mooncake.TestUtils.test_rule(rng, tr, D1; atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, tr, D2; atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, tr, D3; atol, rtol, mode) - - Mooncake.TestUtils.test_rule(rng, inv, D1; atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, inv, D2; atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, inv, D3; atol, rtol, mode) - end - - - @timedtestset "Index manipulations with scalartype $T" for T in eltypes - atol = precision(T) - rtol = precision(T) - - symmetricbraiding && @timedtestset "add_permute!" begin - A = randn(T, V[1] ⊗ V[2] ← V[4] ⊗ V[5]) - α = randn(T) - β = randn(T) - - # repeat a couple times to get some distribution of arrows - for _ in 1:5 - p = randindextuple(numind(A)) - C = randn!(permute(A, p)) - Mooncake.TestUtils.test_rule(rng, TensorKit.add_permute!, C, A, p, α, β; atol, rtol, mode) - A = C - end - end - - @timedtestset "add_transpose!" begin - A = randn(T, V[1] ⊗ V[2] ← V[4] ⊗ V[5]) - α = randn(T) - β = randn(T) - - # repeat a couple times to get some distribution of arrows - for _ in 1:5 - p = randcircshift(numout(A), numin(A)) - C = randn!(transpose(A, p)) - Mooncake.TestUtils.test_rule(rng, TensorKit.add_transpose!, C, A, p, α, β; atol, rtol, mode) - A = C - end - end - - @timedtestset "add_braid!" begin - A = randn(T, V[1] ⊗ V[2] ← V[4] ⊗ V[5]) - α = randn(T) - β = randn(T) - - # repeat a couple times to get some distribution of arrows - for _ in 1:5 - p = randcircshift(numout(A), numin(A)) - levels = tuple(randperm(numind(A))) - C = randn!(transpose(A, p)) - Mooncake.TestUtils.test_rule(rng, TensorKit.add_transpose!, C, A, p, α, β; atol, rtol, mode) - A = C - end - end - - @timedtestset "flip_n_twist!" begin - A = randn(T, V[1] ⊗ V[2] ← V[4] ⊗ V[5]) - Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; inv = false), twist!, A, 1; atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; inv = true), twist!, A, [1, 3]; atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, twist!, A, 1; atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, twist!, A, [1, 3]; atol, rtol, mode) - - Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; inv = false), flip, A, 1; atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; inv = true), flip, A, [1, 3]; atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, flip, A, 1; atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, flip, A, [1, 3]; atol, rtol, mode) - end - - @timedtestset "insert and remove units" begin - A = randn(T, V[1] ⊗ V[2] ← V[4] ⊗ V[5]) - - for insertunit in (insertleftunit, insertrightunit) - Mooncake.TestUtils.test_rule(rng, insertunit, A, Val(1); atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, insertunit, A, Val(4); atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, insertunit, A', Val(2); atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; copy = false), insertunit, A, Val(1); atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; copy = true), insertunit, A, Val(2); atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; copy = false, dual = true, conj = true), insertunit, A, Val(3); atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; copy = false, dual = true, conj = true), insertunit, A', Val(3); atol, rtol, mode) - end - - for i in 1:4 - B = insertleftunit(A, i; dual = rand(Bool)) - Mooncake.TestUtils.test_rule(rng, removeunit, B, Val(i); atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; copy = false), removeunit, B, Val(i); atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; copy = true), removeunit, B, Val(i); atol, rtol, mode) - end - end - end - - symmetricbraiding && @timedtestset "TensorOperations with scalartype $T" for T in eltypes - atol = precision(T) - rtol = precision(T) - - @timedtestset "tensorcontract!" begin - for _ in 1:5 - d = 0 - local V1, V2, V3 - # retry a couple times to make sure there are at least some nonzero elements - for _ in 1:10 - k1 = rand(0:3) - k2 = rand(0:2) - k3 = rand(0:2) - V1 = prod(v -> rand(Bool) ? v' : v, rand(V, k1); init = one(V[1])) - V2 = prod(v -> rand(Bool) ? v' : v, rand(V, k2); init = one(V[1])) - V3 = prod(v -> rand(Bool) ? v' : v, rand(V, k3); init = one(V[1])) - d = min(dim(V1 ← V2), dim(V1' ← V2), dim(V2 ← V3), dim(V2' ← V3)) - d > 0 && break - end - ipA = randindextuple(length(V1) + length(V2)) - pA = _repartition(invperm(linearize(ipA)), length(V1)) - ipB = randindextuple(length(V2) + length(V3)) - pB = _repartition(invperm(linearize(ipB)), length(V2)) - pAB = randindextuple(length(V1) + length(V3)) - - α = randn(T) - β = randn(T) - V2_conj = prod(conj, V2; init = one(V[1])) - - A = randn(T, permute(V1 ← V2, ipA)) - B = randn(T, permute(V2 ← V3, ipB)) - C = randn!( - TensorOperations.tensoralloc_contract( - T, A, pA, false, B, pB, false, pAB, Val(false) - ) - ) - Mooncake.TestUtils.test_rule( - rng, TensorKit.blas_contract!, - C, A, pA, B, pB, pAB, α, β, - TensorOperations.DefaultBackend(), TensorOperations.DefaultAllocator(); - atol, rtol, mode - ) - end - end - - @timedtestset "trace_permute!" begin - for _ in 1:5 - k1 = rand(0:2) - k2 = rand(1:2) - V1 = map(v -> rand(Bool) ? v' : v, rand(V, k1)) - V2 = map(v -> rand(Bool) ? v' : v, rand(V, k2)) - - (_p, _q) = randindextuple(k1 + 2 * k2, k1) - p = _repartition(_p, rand(0:k1)) - q = _repartition(_q, k2) - ip = _repartition(invperm(linearize((_p, _q))), rand(0:(k1 + 2 * k2))) - A = randn(T, permute(prod(V1) ⊗ prod(V2) ← prod(V2), ip)) - - α = randn(T) - β = randn(T) - C = randn!(TensorOperations.tensoralloc_add(T, A, p, false, Val(false))) - Mooncake.TestUtils.test_rule( - rng, TensorKit.trace_permute!, C, A, p, q, α, β, TensorOperations.DefaultBackend(); - atol, rtol, mode - ) - end - end - end - - @timedtestset "PlanarOperations with scalartype $T" for T in eltypes - atol = precision(T) - rtol = precision(T) - - @timedtestset "planarcontract!" begin - for _ in 1:5 - d = 0 - local V1, V2, V3, k1, k2, k3 - # retry a couple times to make sure there are at least some nonzero elements - for _ in 1:10 - k1 = rand(0:3) - k2 = rand(0:2) - k3 = rand(0:2) - V1 = prod(v -> rand(Bool) ? v' : v, rand(V, k1); init = one(V[1])) - V2 = prod(v -> rand(Bool) ? v' : v, rand(V, k2); init = one(V[1])) - V3 = prod(v -> rand(Bool) ? v' : v, rand(V, k3); init = one(V[1])) - d = min(dim(V1 ← V2), dim(V1' ← V2), dim(V2 ← V3), dim(V2' ← V3)) - d > 1 && break - end - k′ = rand(0:(k1 + k2)) - pA = randcircshift(k′, k1 + k2 - k′, k1) - ipA = _repartition(invperm(linearize(pA)), k′) - k′ = rand(0:(k2 + k3)) - pB = randcircshift(k′, k2 + k3 - k′, k2) - ipB = _repartition(invperm(linearize(pB)), k′) - # TODO: primal value already is broken for this? - # pAB = randcircshift(k1, k3) - pAB = _repartition(tuple((1:(k1 + k3))...), k1) - - α = randn(T) - β = randn(T) - - A = randn(T, permute(V1 ← V2, ipA)) - B = randn(T, permute(V2 ← V3, ipB)) - C = randn!( - TensorOperations.tensoralloc_contract( - T, A, pA, false, B, pB, false, pAB, Val(false) - ) - ) - Mooncake.TestUtils.test_rule( - rng, TensorKit.planarcontract!, C, A, pA, B, pB, pAB, α, β; - atol, rtol, mode, is_primitive = false - ) - end - end - - # TODO: currently broken - # @timedtestset "planartrace!" begin - # for _ in 1:5 - # k1 = rand(0:2) - # k2 = rand(0:1) - # V1 = map(v -> rand(Bool) ? v' : v, rand(V, k1)) - # V2 = map(v -> rand(Bool) ? v' : v, rand(V, k2)) - # V3 = prod(x -> x ⊗ x', V2[1:k2]; init = one(V[1])) - # V4 = prod(x -> x ⊗ x', V2[(k2 + 1):end]; init = one(V[1])) - # - # k′ = rand(0:(k1 + 2k2)) - # (_p, _q) = randcircshift(k′, k1 + 2k2 - k′, k1) - # p = _repartition(_p, rand(0:k1)) - # q = (tuple(_q[1:2:end]...), tuple(_q[2:2:end]...)) - # ip = _repartition(invperm(linearize((_p, _q))), k′) - # A = randn(T, permute(prod(V1) ⊗ V3 ← V4, ip)) - # - # α = randn(T) - # β = randn(T) - # C = randn!(TensorOperations.tensoralloc_add(T, A, p, false, Val(false))) - # Mooncake.TestUtils.test_rule( - # rng, TensorKit.planartrace!, - # C, A, p, q, α, β, - # TensorOperations.DefaultBackend(), TensorOperations.DefaultAllocator(); - # atol, rtol, mode - # ) - # end - # end - end -end diff --git a/test/autodiff/chainrules.jl b/test/chainrules/chainrules.jl similarity index 100% rename from test/autodiff/chainrules.jl rename to test/chainrules/chainrules.jl diff --git a/test/mooncake/indexmanipulations.jl b/test/mooncake/indexmanipulations.jl new file mode 100644 index 000000000..a2909c38f --- /dev/null +++ b/test/mooncake/indexmanipulations.jl @@ -0,0 +1,134 @@ +using Test, TestExtras +using TensorKit +using TensorOperations +using Mooncake +using Random + +@isdefined(TestSetup) || include("../setup.jl") +using .TestSetup + +mode = Mooncake.ReverseMode +rng = Random.default_rng() + +spacelist = ( + (ℂ^2, (ℂ^3)', ℂ^3, ℂ^2, (ℂ^2)'), + ( + Vect[Z2Irrep](0 => 1, 1 => 1), + Vect[Z2Irrep](0 => 1, 1 => 2)', + Vect[Z2Irrep](0 => 2, 1 => 2)', + Vect[Z2Irrep](0 => 2, 1 => 3), + Vect[Z2Irrep](0 => 2, 1 => 2), + ), + ( + Vect[FermionParity](0 => 1, 1 => 1), + Vect[FermionParity](0 => 1, 1 => 2)', + Vect[FermionParity](0 => 2, 1 => 1)', + Vect[FermionParity](0 => 2, 1 => 3), + Vect[FermionParity](0 => 2, 1 => 2), + ), + ( + Vect[U1Irrep](0 => 2, 1 => 1, -1 => 1), + Vect[U1Irrep](0 => 2, 1 => 1, -1 => 1), + Vect[U1Irrep](0 => 2, 1 => 2, -1 => 1)', + Vect[U1Irrep](0 => 1, 1 => 1, -1 => 2), + Vect[U1Irrep](0 => 1, 1 => 2, -1 => 1)', + ), + ( + Vect[SU2Irrep](0 => 2, 1 // 2 => 1), + Vect[SU2Irrep](0 => 1, 1 => 1), + Vect[SU2Irrep](1 // 2 => 1, 1 => 1)', + Vect[SU2Irrep](1 // 2 => 2), + Vect[SU2Irrep](0 => 1, 1 // 2 => 1, 3 // 2 => 1)', + ), + # ( + # Vect[FibonacciAnyon](:I => 2, :τ => 1), + # Vect[FibonacciAnyon](:I => 1, :τ => 2)', + # Vect[FibonacciAnyon](:I => 2, :τ => 2)', + # Vect[FibonacciAnyon](:I => 2, :τ => 3), + # Vect[FibonacciAnyon](:I => 2, :τ => 2), + # ), +) +eltypes = (Float64,) # no complex support yet + +@timedtestset "Mooncake - Index Manipulations: $(TensorKit.type_repr(sectortype(eltype(V)))) ($T)" for V in spacelist, T in eltypes + atol = precision(T) + rtol = precision(T) + symmetricbraiding = BraidingStyle(sectortype(eltype(V))) isa SymmetricBraiding + + symmetricbraiding && @timedtestset "add_permute!" begin + A = randn(T, V[1] ⊗ V[2] ← V[4] ⊗ V[5]) + α = randn(T) + β = randn(T) + + # repeat a couple times to get some distribution of arrows + for _ in 1:5 + p = randindextuple(numind(A)) + C = randn!(permute(A, p)) + Mooncake.TestUtils.test_rule(rng, TensorKit.add_permute!, C, A, p, α, β; atol, rtol, mode) + A = C + end + end + + @timedtestset "add_transpose!" begin + A = randn(T, V[1] ⊗ V[2] ← V[4] ⊗ V[5]) + α = randn(T) + β = randn(T) + + # repeat a couple times to get some distribution of arrows + for _ in 1:5 + p = randcircshift(numout(A), numin(A)) + C = randn!(transpose(A, p)) + Mooncake.TestUtils.test_rule(rng, TensorKit.add_transpose!, C, A, p, α, β; atol, rtol, mode) + A = C + end + end + + @timedtestset "add_braid!" begin + A = randn(T, V[1] ⊗ V[2] ← V[4] ⊗ V[5]) + α = randn(T) + β = randn(T) + + # repeat a couple times to get some distribution of arrows + for _ in 1:5 + p = randcircshift(numout(A), numin(A)) + levels = tuple(randperm(numind(A))) + C = randn!(transpose(A, p)) + Mooncake.TestUtils.test_rule(rng, TensorKit.add_transpose!, C, A, p, α, β; atol, rtol, mode) + A = C + end + end + + @timedtestset "flip_n_twist!" begin + A = randn(T, V[1] ⊗ V[2] ← V[4] ⊗ V[5]) + Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; inv = false), twist!, A, 1; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; inv = true), twist!, A, [1, 3]; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, twist!, A, 1; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, twist!, A, [1, 3]; atol, rtol, mode) + + Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; inv = false), flip, A, 1; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; inv = true), flip, A, [1, 3]; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, flip, A, 1; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, flip, A, [1, 3]; atol, rtol, mode) + end + + @timedtestset "insert and remove units" begin + A = randn(T, V[1] ⊗ V[2] ← V[4] ⊗ V[5]) + + for insertunit in (insertleftunit, insertrightunit) + Mooncake.TestUtils.test_rule(rng, insertunit, A, Val(1); atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, insertunit, A, Val(4); atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, insertunit, A', Val(2); atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; copy = false), insertunit, A, Val(1); atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; copy = true), insertunit, A, Val(2); atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; copy = false, dual = true, conj = true), insertunit, A, Val(3); atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; copy = false, dual = true, conj = true), insertunit, A', Val(3); atol, rtol, mode) + end + + for i in 1:4 + B = insertleftunit(A, i; dual = rand(Bool)) + Mooncake.TestUtils.test_rule(rng, removeunit, B, Val(i); atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; copy = false), removeunit, B, Val(i); atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; copy = true), removeunit, B, Val(i); atol, rtol, mode) + end + end +end diff --git a/test/mooncake/linalg.jl b/test/mooncake/linalg.jl new file mode 100644 index 000000000..426619549 --- /dev/null +++ b/test/mooncake/linalg.jl @@ -0,0 +1,80 @@ +using Test, TestExtras +using TensorKit +using TensorOperations +using Mooncake +using Random + +@isdefined(TestSetup) || include("../setup.jl") +using .TestSetup + +mode = Mooncake.ReverseMode +rng = Random.default_rng() + +spacelist = ( + (ℂ^2, (ℂ^3)', ℂ^3, ℂ^2, (ℂ^2)'), + ( + Vect[Z2Irrep](0 => 1, 1 => 1), + Vect[Z2Irrep](0 => 1, 1 => 2)', + Vect[Z2Irrep](0 => 2, 1 => 2)', + Vect[Z2Irrep](0 => 2, 1 => 3), + Vect[Z2Irrep](0 => 2, 1 => 2), + ), + ( + Vect[FermionParity](0 => 1, 1 => 1), + Vect[FermionParity](0 => 1, 1 => 2)', + Vect[FermionParity](0 => 2, 1 => 1)', + Vect[FermionParity](0 => 2, 1 => 3), + Vect[FermionParity](0 => 2, 1 => 2), + ), + ( + Vect[U1Irrep](0 => 2, 1 => 1, -1 => 1), + Vect[U1Irrep](0 => 2, 1 => 1, -1 => 1), + Vect[U1Irrep](0 => 2, 1 => 2, -1 => 1)', + Vect[U1Irrep](0 => 1, 1 => 1, -1 => 2), + Vect[U1Irrep](0 => 1, 1 => 2, -1 => 1)', + ), + ( + Vect[SU2Irrep](0 => 2, 1 // 2 => 1), + Vect[SU2Irrep](0 => 1, 1 => 1), + Vect[SU2Irrep](1 // 2 => 1, 1 => 1)', + Vect[SU2Irrep](1 // 2 => 2), + Vect[SU2Irrep](0 => 1, 1 // 2 => 1, 3 // 2 => 1)', + ), + # ( + # Vect[FibonacciAnyon](:I => 2, :τ => 1), + # Vect[FibonacciAnyon](:I => 1, :τ => 2)', + # Vect[FibonacciAnyon](:I => 2, :τ => 2)', + # Vect[FibonacciAnyon](:I => 2, :τ => 3), + # Vect[FibonacciAnyon](:I => 2, :τ => 2), + # ), +) +eltypes = (Float64,) # no complex support yet + +@timedtestset "Mooncake - LinearAlgebra: $(TensorKit.type_repr(sectortype(eltype(V)))) ($T)" for V in spacelist, T in eltypes + atol = precision(T) + rtol = precision(T) + + C = randn(T, V[1] ⊗ V[2] ← V[5]) + A = randn(T, codomain(C) ← V[3] ⊗ V[4]) + B = randn(T, domain(A) ← domain(C)) + α = randn(T) + β = randn(T) + + Mooncake.TestUtils.test_rule(rng, mul!, C, A, B, α, β; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, mul!, C, A, B; atol, rtol, mode, is_primitive = false) + + Mooncake.TestUtils.test_rule(rng, norm, C, 2; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, norm, C', 2; atol, rtol, mode) + + D1 = randn(T, V[1] ← V[1]) + D2 = randn(T, V[1] ⊗ V[2] ← V[1] ⊗ V[2]) + D3 = randn(T, V[1] ⊗ V[2] ⊗ V[3] ← V[1] ⊗ V[2] ⊗ V[3]) + + Mooncake.TestUtils.test_rule(rng, tr, D1; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, tr, D2; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, tr, D3; atol, rtol, mode) + + Mooncake.TestUtils.test_rule(rng, inv, D1; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, inv, D2; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, inv, D3; atol, rtol, mode) +end diff --git a/test/mooncake/planaroperations.jl b/test/mooncake/planaroperations.jl new file mode 100644 index 000000000..cbdc7ec76 --- /dev/null +++ b/test/mooncake/planaroperations.jl @@ -0,0 +1,128 @@ +using Test, TestExtras +using TensorKit +using TensorOperations +using Mooncake +using Random + +@isdefined(TestSetup) || include("../setup.jl") +using .TestSetup +using .TestSetup: _repartition + +mode = Mooncake.ReverseMode +rng = Random.default_rng() + +spacelist = ( + (ℂ^2, (ℂ^3)', ℂ^3, ℂ^2, (ℂ^2)'), + ( + Vect[Z2Irrep](0 => 1, 1 => 1), + Vect[Z2Irrep](0 => 1, 1 => 2)', + Vect[Z2Irrep](0 => 2, 1 => 2)', + Vect[Z2Irrep](0 => 2, 1 => 3), + Vect[Z2Irrep](0 => 2, 1 => 2), + ), + ( + Vect[FermionParity](0 => 1, 1 => 1), + Vect[FermionParity](0 => 1, 1 => 2)', + Vect[FermionParity](0 => 2, 1 => 1)', + Vect[FermionParity](0 => 2, 1 => 3), + Vect[FermionParity](0 => 2, 1 => 2), + ), + ( + Vect[U1Irrep](0 => 2, 1 => 1, -1 => 1), + Vect[U1Irrep](0 => 2, 1 => 1, -1 => 1), + Vect[U1Irrep](0 => 2, 1 => 2, -1 => 1)', + Vect[U1Irrep](0 => 1, 1 => 1, -1 => 2), + Vect[U1Irrep](0 => 1, 1 => 2, -1 => 1)', + ), + ( + Vect[SU2Irrep](0 => 2, 1 // 2 => 1), + Vect[SU2Irrep](0 => 1, 1 => 1), + Vect[SU2Irrep](1 // 2 => 1, 1 => 1)', + Vect[SU2Irrep](1 // 2 => 2), + Vect[SU2Irrep](0 => 1, 1 // 2 => 1, 3 // 2 => 1)', + ), + # ( + # Vect[FibonacciAnyon](:I => 2, :τ => 1), + # Vect[FibonacciAnyon](:I => 1, :τ => 2)', + # Vect[FibonacciAnyon](:I => 2, :τ => 2)', + # Vect[FibonacciAnyon](:I => 2, :τ => 3), + # Vect[FibonacciAnyon](:I => 2, :τ => 2), + # ), +) +eltypes = (Float64,) # no complex support yet + +@timedtestset "Mooncake - PlanarOperations: $(TensorKit.type_repr(sectortype(eltype(V)))) ($T)" for V in spacelist, T in eltypes + atol = precision(T) + rtol = precision(T) + + @timedtestset "planarcontract!" begin + for _ in 1:5 + d = 0 + local V1, V2, V3, k1, k2, k3 + # retry a couple times to make sure there are at least some nonzero elements + for _ in 1:10 + k1 = rand(0:3) + k2 = rand(0:2) + k3 = rand(0:2) + V1 = prod(v -> rand(Bool) ? v' : v, rand(V, k1); init = one(V[1])) + V2 = prod(v -> rand(Bool) ? v' : v, rand(V, k2); init = one(V[1])) + V3 = prod(v -> rand(Bool) ? v' : v, rand(V, k3); init = one(V[1])) + d = min(dim(V1 ← V2), dim(V1' ← V2), dim(V2 ← V3), dim(V2' ← V3)) + d > 1 && break + end + k′ = rand(0:(k1 + k2)) + pA = randcircshift(k′, k1 + k2 - k′, k1) + ipA = _repartition(invperm(linearize(pA)), k′) + k′ = rand(0:(k2 + k3)) + pB = randcircshift(k′, k2 + k3 - k′, k2) + ipB = _repartition(invperm(linearize(pB)), k′) + # TODO: primal value already is broken for this? + # pAB = randcircshift(k1, k3) + pAB = _repartition(tuple((1:(k1 + k3))...), k1) + + α = randn(T) + β = randn(T) + + A = randn(T, permute(V1 ← V2, ipA)) + B = randn(T, permute(V2 ← V3, ipB)) + C = randn!( + TensorOperations.tensoralloc_contract( + T, A, pA, false, B, pB, false, pAB, Val(false) + ) + ) + Mooncake.TestUtils.test_rule( + rng, TensorKit.planarcontract!, C, A, pA, B, pB, pAB, α, β; + atol, rtol, mode, is_primitive = false + ) + end + end + + # TODO: currently broken + # @timedtestset "planartrace!" begin + # for _ in 1:5 + # k1 = rand(0:2) + # k2 = rand(0:1) + # V1 = map(v -> rand(Bool) ? v' : v, rand(V, k1)) + # V2 = map(v -> rand(Bool) ? v' : v, rand(V, k2)) + # V3 = prod(x -> x ⊗ x', V2[1:k2]; init = one(V[1])) + # V4 = prod(x -> x ⊗ x', V2[(k2 + 1):end]; init = one(V[1])) + # + # k′ = rand(0:(k1 + 2k2)) + # (_p, _q) = randcircshift(k′, k1 + 2k2 - k′, k1) + # p = _repartition(_p, rand(0:k1)) + # q = (tuple(_q[1:2:end]...), tuple(_q[2:2:end]...)) + # ip = _repartition(invperm(linearize((_p, _q))), k′) + # A = randn(T, permute(prod(V1) ⊗ V3 ← V4, ip)) + # + # α = randn(T) + # β = randn(T) + # C = randn!(TensorOperations.tensoralloc_add(T, A, p, false, Val(false))) + # Mooncake.TestUtils.test_rule( + # rng, TensorKit.planartrace!, + # C, A, p, q, α, β, + # TensorOperations.DefaultBackend(), TensorOperations.DefaultAllocator(); + # atol, rtol, mode + # ) + # end + # end +end diff --git a/test/mooncake/tensoroperations.jl b/test/mooncake/tensoroperations.jl new file mode 100644 index 000000000..43372a011 --- /dev/null +++ b/test/mooncake/tensoroperations.jl @@ -0,0 +1,121 @@ +using Test, TestExtras +using TensorKit +using TensorOperations +using Mooncake +using Random + +@isdefined(TestSetup) || include("../setup.jl") +using .TestSetup + +mode = Mooncake.ReverseMode +rng = Random.default_rng() + +spacelist = ( + (ℂ^2, (ℂ^3)', ℂ^3, ℂ^2, (ℂ^2)'), + ( + Vect[Z2Irrep](0 => 1, 1 => 1), + Vect[Z2Irrep](0 => 1, 1 => 2)', + Vect[Z2Irrep](0 => 2, 1 => 2)', + Vect[Z2Irrep](0 => 2, 1 => 3), + Vect[Z2Irrep](0 => 2, 1 => 2), + ), + ( + Vect[FermionParity](0 => 1, 1 => 1), + Vect[FermionParity](0 => 1, 1 => 2)', + Vect[FermionParity](0 => 2, 1 => 1)', + Vect[FermionParity](0 => 2, 1 => 3), + Vect[FermionParity](0 => 2, 1 => 2), + ), + ( + Vect[U1Irrep](0 => 2, 1 => 1, -1 => 1), + Vect[U1Irrep](0 => 2, 1 => 1, -1 => 1), + Vect[U1Irrep](0 => 2, 1 => 2, -1 => 1)', + Vect[U1Irrep](0 => 1, 1 => 1, -1 => 2), + Vect[U1Irrep](0 => 1, 1 => 2, -1 => 1)', + ), + ( + Vect[SU2Irrep](0 => 2, 1 // 2 => 1), + Vect[SU2Irrep](0 => 1, 1 => 1), + Vect[SU2Irrep](1 // 2 => 1, 1 => 1)', + Vect[SU2Irrep](1 // 2 => 2), + Vect[SU2Irrep](0 => 1, 1 // 2 => 1, 3 // 2 => 1)', + ), + # ( + # Vect[FibonacciAnyon](:I => 2, :τ => 1), + # Vect[FibonacciAnyon](:I => 1, :τ => 2)', + # Vect[FibonacciAnyon](:I => 2, :τ => 2)', + # Vect[FibonacciAnyon](:I => 2, :τ => 3), + # Vect[FibonacciAnyon](:I => 2, :τ => 2), + # ), +) +eltypes = (Float64,) # no complex support yet + +@timedtestset "Mooncake - TensorOperations: $(TensorKit.type_repr(sectortype(eltype(V)))) ($T)" for V in spacelist, T in eltypes + atol = precision(T) + rtol = precision(T) + symmetricbraiding = BraidingStyle(sectortype(eltype(V))) isa SymmetricBraiding + + symmetricbraiding && @timedtestset "tensorcontract!" begin + for _ in 1:5 + d = 0 + local V1, V2, V3 + # retry a couple times to make sure there are at least some nonzero elements + for _ in 1:10 + k1 = rand(0:3) + k2 = rand(0:2) + k3 = rand(0:2) + V1 = prod(v -> rand(Bool) ? v' : v, rand(V, k1); init = one(V[1])) + V2 = prod(v -> rand(Bool) ? v' : v, rand(V, k2); init = one(V[1])) + V3 = prod(v -> rand(Bool) ? v' : v, rand(V, k3); init = one(V[1])) + d = min(dim(V1 ← V2), dim(V1' ← V2), dim(V2 ← V3), dim(V2' ← V3)) + d > 0 && break + end + ipA = randindextuple(length(V1) + length(V2)) + pA = _repartition(invperm(linearize(ipA)), length(V1)) + ipB = randindextuple(length(V2) + length(V3)) + pB = _repartition(invperm(linearize(ipB)), length(V2)) + pAB = randindextuple(length(V1) + length(V3)) + + α = randn(T) + β = randn(T) + V2_conj = prod(conj, V2; init = one(V[1])) + + A = randn(T, permute(V1 ← V2, ipA)) + B = randn(T, permute(V2 ← V3, ipB)) + C = randn!( + TensorOperations.tensoralloc_contract( + T, A, pA, false, B, pB, false, pAB, Val(false) + ) + ) + Mooncake.TestUtils.test_rule( + rng, TensorKit.blas_contract!, + C, A, pA, B, pB, pAB, α, β, + TensorOperations.DefaultBackend(), TensorOperations.DefaultAllocator(); + atol, rtol, mode + ) + end + end + + symmetricbraiding && @timedtestset "trace_permute!" begin + for _ in 1:5 + k1 = rand(0:2) + k2 = rand(1:2) + V1 = map(v -> rand(Bool) ? v' : v, rand(V, k1)) + V2 = map(v -> rand(Bool) ? v' : v, rand(V, k2)) + + (_p, _q) = randindextuple(k1 + 2 * k2, k1) + p = _repartition(_p, rand(0:k1)) + q = _repartition(_q, k2) + ip = _repartition(invperm(linearize((_p, _q))), rand(0:(k1 + 2 * k2))) + A = randn(T, permute(prod(V1) ⊗ prod(V2) ← prod(V2), ip)) + + α = randn(T) + β = randn(T) + C = randn!(TensorOperations.tensoralloc_add(T, A, p, false, Val(false))) + Mooncake.TestUtils.test_rule( + rng, TensorKit.trace_permute!, C, A, p, q, α, β, TensorOperations.DefaultBackend(); + atol, rtol, mode + ) + end + end +end diff --git a/test/mooncake/vectorinterface.jl b/test/mooncake/vectorinterface.jl new file mode 100644 index 000000000..131521c44 --- /dev/null +++ b/test/mooncake/vectorinterface.jl @@ -0,0 +1,75 @@ +using Test, TestExtras +using TensorKit +using TensorOperations +using Mooncake +using Random + +@isdefined(TestSetup) || include("../setup.jl") +using .TestSetup + +mode = Mooncake.ReverseMode +rng = Random.default_rng() + +spacelist = ( + (ℂ^2, (ℂ^3)', ℂ^3, ℂ^2, (ℂ^2)'), + ( + Vect[Z2Irrep](0 => 1, 1 => 1), + Vect[Z2Irrep](0 => 1, 1 => 2)', + Vect[Z2Irrep](0 => 2, 1 => 2)', + Vect[Z2Irrep](0 => 2, 1 => 3), + Vect[Z2Irrep](0 => 2, 1 => 2), + ), + ( + Vect[FermionParity](0 => 1, 1 => 1), + Vect[FermionParity](0 => 1, 1 => 2)', + Vect[FermionParity](0 => 2, 1 => 1)', + Vect[FermionParity](0 => 2, 1 => 3), + Vect[FermionParity](0 => 2, 1 => 2), + ), + ( + Vect[U1Irrep](0 => 2, 1 => 1, -1 => 1), + Vect[U1Irrep](0 => 2, 1 => 1, -1 => 1), + Vect[U1Irrep](0 => 2, 1 => 2, -1 => 1)', + Vect[U1Irrep](0 => 1, 1 => 1, -1 => 2), + Vect[U1Irrep](0 => 1, 1 => 2, -1 => 1)', + ), + ( + Vect[SU2Irrep](0 => 2, 1 // 2 => 1), + Vect[SU2Irrep](0 => 1, 1 => 1), + Vect[SU2Irrep](1 // 2 => 1, 1 => 1)', + Vect[SU2Irrep](1 // 2 => 2), + Vect[SU2Irrep](0 => 1, 1 // 2 => 1, 3 // 2 => 1)', + ), + # ( + # Vect[FibonacciAnyon](:I => 2, :τ => 1), + # Vect[FibonacciAnyon](:I => 1, :τ => 2)', + # Vect[FibonacciAnyon](:I => 2, :τ => 2)', + # Vect[FibonacciAnyon](:I => 2, :τ => 3), + # Vect[FibonacciAnyon](:I => 2, :τ => 2), + # ), +) +eltypes = (Float64,) # no complex support yet + +@timedtestset "Mooncake - VectorInterface: $(TensorKit.type_repr(sectortype(eltype(V)))) ($T)" for V in spacelist, T in eltypes + atol = precision(T) + rtol = precision(T) + + C = randn(T, V[1] ⊗ V[2] ← V[3] ⊗ V[4] ⊗ V[5]) + A = randn(T, V[1] ⊗ V[2] ← V[3] ⊗ V[4] ⊗ V[5]) + α = randn(T) + β = randn(T) + + Mooncake.TestUtils.test_rule(rng, scale!, C, α; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, scale!, C', α; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, scale!, C, A, α; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, scale!, C', A', α; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, scale!, copy(C'), A', α; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, scale!, C', copy(A'), α; atol, rtol, mode) + + Mooncake.TestUtils.test_rule(rng, add!, C, A; atol, rtol, mode, is_primitive = false) + Mooncake.TestUtils.test_rule(rng, add!, C, A, α; atol, rtol, mode, is_primitive = false) + Mooncake.TestUtils.test_rule(rng, add!, C, A, α, β; atol, rtol, mode) + + Mooncake.TestUtils.test_rule(rng, inner, C, A; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, inner, C', A'; atol, rtol, mode) +end diff --git a/test/runtests.jl b/test/runtests.jl index 3b0bfe8b0..8f58d7dc8 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -57,7 +57,7 @@ istestfile(fn) = endswith(fn, ".jl") && !contains(fn, "setup") # somehow AD tests are unreasonably slow on Apple CI # and ChainRulesTestUtils doesn't like prereleases - if group == "autodiff" + if group == "chainrules" Sys.isapple() && get(ENV, "CI", "false") == "true" && continue isempty(VERSION.prerelease) || continue end diff --git a/test/setup.jl b/test/setup.jl index 5c8516eb9..3f6dde923 100644 --- a/test/setup.jl +++ b/test/setup.jl @@ -1,5 +1,6 @@ module TestSetup +export randindextuple, randcircshift, _repartition, trivtuple export smallset, randsector, hasfusiontensor, force_planar export random_fusion export sectorlist @@ -11,9 +12,46 @@ using Test: @test using TensorKit using TensorKit: ℙ, PlanarTrivial using Base.Iterators: take, product +using TupleTools Random.seed!(123456) +# IndexTuple utility +# ------------------ +function randindextuple(N::Int, k::Int = rand(0:N)) + @assert 0 ≤ k ≤ N + _p = randperm(N) + return (tuple(_p[1:k]...), tuple(_p[(k + 1):end]...)) +end +function randcircshift(N₁::Int, N₂::Int, k::Int = rand(0:(N₁ + N₂))) + N = N₁ + N₂ + @assert 0 ≤ k ≤ N + p = TupleTools.vcat(ntuple(identity, N₁), reverse(ntuple(identity, N₂) .+ N₁)) + n = rand(0:N) + _p = TupleTools.circshift(p, n) + return (tuple(_p[1:k]...), reverse(tuple(_p[(k + 1):end]...))) +end + +trivtuple(N) = ntuple(identity, N) + +Base.@constprop :aggressive function _repartition(p::IndexTuple, N₁::Int) + length(p) >= N₁ || + throw(ArgumentError("cannot repartition $(typeof(p)) to $N₁, $(length(p) - N₁)")) + return TupleTools.getindices(p, trivtuple(N₁)), + TupleTools.getindices(p, trivtuple(length(p) - N₁) .+ N₁) +end +Base.@constprop :aggressive function _repartition(p::Index2Tuple, N₁::Int) + return _repartition(linearize(p), N₁) +end +function _repartition(p::Union{IndexTuple, Index2Tuple}, ::Index2Tuple{N₁}) where {N₁} + return _repartition(p, N₁) +end +function _repartition(p::Union{IndexTuple, Index2Tuple}, t::AbstractTensorMap) + return _repartition(p, TensorKit.numout(t)) +end + +# Sector utility +# -------------- smallset(::Type{I}) where {I <: Sector} = take(values(I), 5) function smallset(::Type{ProductSector{Tuple{I1, I2}}}) where {I1, I2} iter = product(smallset(I1), smallset(I2)) From b1da2cc7dae3bd945f2b39cf36f98f5a718ad6da Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Thu, 22 Jan 2026 17:48:04 -0500 Subject: [PATCH 32/52] add missing imports --- test/setup.jl | 1 + 1 file changed, 1 insertion(+) diff --git a/test/setup.jl b/test/setup.jl index 3f6dde923..9b3a51d01 100644 --- a/test/setup.jl +++ b/test/setup.jl @@ -11,6 +11,7 @@ using Random using Test: @test using TensorKit using TensorKit: ℙ, PlanarTrivial +using TensorOperations: IndexTuple, Index2Tuple using Base.Iterators: take, product using TupleTools From 7e0dfbd5272bfcdbe0e20187b641a384716fc172 Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Mon, 26 Jan 2026 10:29:03 -0500 Subject: [PATCH 33/52] remove the use of the internal `Mooncake._rdata` --- ext/TensorKitMooncakeExt/indexmanipulations.jl | 4 ++-- ext/TensorKitMooncakeExt/linalg.jl | 2 +- ext/TensorKitMooncakeExt/planaroperations.jl | 4 ++-- ext/TensorKitMooncakeExt/tensoroperations.jl | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/ext/TensorKitMooncakeExt/indexmanipulations.jl b/ext/TensorKitMooncakeExt/indexmanipulations.jl index 8a97ac81c..450f391e0 100644 --- a/ext/TensorKitMooncakeExt/indexmanipulations.jl +++ b/ext/TensorKitMooncakeExt/indexmanipulations.jl @@ -53,7 +53,7 @@ for transform in (:permute, :transpose) Δαr = if isnothing(Ap) NoRData() else - Mooncake._rdata(inner(Ap, ΔC)) + inner(Ap, ΔC) end Δβr = pullback_dβ(C, ΔC, β) @@ -120,7 +120,7 @@ function Mooncake.rrule!!( Δαr = if isnothing(Ap) NoRData() else - Mooncake._rdata(inner(Ap, ΔC)) + inner(Ap, ΔC) end Δβr = pullback_dβ(C, ΔC, β) diff --git a/ext/TensorKitMooncakeExt/linalg.jl b/ext/TensorKitMooncakeExt/linalg.jl index 2a77792c9..3d5ac8610 100644 --- a/ext/TensorKitMooncakeExt/linalg.jl +++ b/ext/TensorKitMooncakeExt/linalg.jl @@ -31,7 +31,7 @@ function Mooncake.rrule!!( mul!(ΔB, A', ΔC, conj(α), One()) ΔAr = NoRData() ΔBr = NoRData() - Δαr = isnothing(AB) ? NoRData() : Mooncake._rdata(inner(AB, ΔC)) + Δαr = isnothing(AB) ? NoRData() : inner(AB, ΔC) Δβr = pullback_dβ(C, ΔC, β) ΔCr = pullback_dC!(ΔC, β) diff --git a/ext/TensorKitMooncakeExt/planaroperations.jl b/ext/TensorKitMooncakeExt/planaroperations.jl index df75d60fe..58d714d82 100644 --- a/ext/TensorKitMooncakeExt/planaroperations.jl +++ b/ext/TensorKitMooncakeExt/planaroperations.jl @@ -88,7 +88,7 @@ function planartrace_pullback_Δα( TensorKit.planartrace!(At, A, p, q, One(), Zero(), backend, allocator) Δα = inner(At, ΔC) TO.tensorfree!(At, allocator) - return Mooncake._rdata(Δα) + return Δα end function planartrace_pullback_Δβ(ΔC, C, β) @@ -96,5 +96,5 @@ function planartrace_pullback_Δβ(ΔC, C, β) Tdβ === NoRData && return NoRData() Δβ = inner(C, ΔC) - return Mooncake._rdata(Δβ) + return Δβ end diff --git a/ext/TensorKitMooncakeExt/tensoroperations.jl b/ext/TensorKitMooncakeExt/tensoroperations.jl index 66c3f257a..30850bb8c 100644 --- a/ext/TensorKitMooncakeExt/tensoroperations.jl +++ b/ext/TensorKitMooncakeExt/tensoroperations.jl @@ -120,7 +120,7 @@ function blas_contract_pullback_Δα( AB = TO.tensorcontract(A, pA, false, B, pB, false, pAB, One(), backend, allocator) Δα = inner(AB, ΔC) - return Mooncake._rdata(Δα) + return Δα end # tensortrace! @@ -197,5 +197,5 @@ function trace_permute_pullback_Δα( # C′ = βC + α * trace(A) ⟹ At = (C′ - βC) / α At = TO.tensortrace(A, p, q, false, One(), backend) Δα = inner(At, ΔC) - return Mooncake._rdata(Δα) + return Δα end From 377347ac4d518e5ea41a833058d59a3c674cbe53 Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Mon, 26 Jan 2026 10:41:28 -0500 Subject: [PATCH 34/52] add comments about `NoRData()` --- ext/TensorKitMooncakeExt/indexmanipulations.jl | 4 ++-- ext/TensorKitMooncakeExt/planaroperations.jl | 4 ++-- ext/TensorKitMooncakeExt/tensoroperations.jl | 10 +++++----- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/ext/TensorKitMooncakeExt/indexmanipulations.jl b/ext/TensorKitMooncakeExt/indexmanipulations.jl index 450f391e0..fe871a52d 100644 --- a/ext/TensorKitMooncakeExt/indexmanipulations.jl +++ b/ext/TensorKitMooncakeExt/indexmanipulations.jl @@ -57,7 +57,7 @@ for transform in (:permute, :transpose) end Δβr = pullback_dβ(C, ΔC, β) - ΔCr = pullback_dC!(ΔC, β) + ΔCr = pullback_dC!(ΔC, β) # this typically returns NoRData() return NoRData(), ΔCr, ΔAr, NoRData(), Δαr, Δβr, map(Returns(NoRData()), ba)... end @@ -124,7 +124,7 @@ function Mooncake.rrule!!( end Δβr = pullback_dβ(C, ΔC, β) - ΔCr = pullback_dC!(ΔC, β) + ΔCr = pullback_dC!(ΔC, β) # this typically returns NoRData() return NoRData(), ΔCr, ΔAr, NoRData(), NoRData(), Δαr, Δβr, map(Returns(NoRData()), ba)... end diff --git a/ext/TensorKitMooncakeExt/planaroperations.jl b/ext/TensorKitMooncakeExt/planaroperations.jl index 58d714d82..5fe762cbb 100644 --- a/ext/TensorKitMooncakeExt/planaroperations.jl +++ b/ext/TensorKitMooncakeExt/planaroperations.jl @@ -34,10 +34,10 @@ function Mooncake.rrule!!( function planartrace_pullback(::NoRData) copy!(C, C_cache) - ΔAr = planartrace_pullback_ΔA!(ΔA, ΔC, A, p, q, α, backend, allocator) + ΔAr = planartrace_pullback_ΔA!(ΔA, ΔC, A, p, q, α, backend, allocator) # this typically returns NoRData() Δαr = planartrace_pullback_Δα(ΔC, A, p, q, α, backend, allocator) Δβr = planartrace_pullback_Δβ(ΔC, C, β) - ΔCr = planartrace_pullback_ΔC!(ΔC, β) + ΔCr = planartrace_pullback_ΔC!(ΔC, β) # this typically returns NoRData() return NoRData(), ΔCr, ΔAr, NoRData(), NoRData(), diff --git a/ext/TensorKitMooncakeExt/tensoroperations.jl b/ext/TensorKitMooncakeExt/tensoroperations.jl index 30850bb8c..6c3f7442e 100644 --- a/ext/TensorKitMooncakeExt/tensoroperations.jl +++ b/ext/TensorKitMooncakeExt/tensoroperations.jl @@ -38,15 +38,15 @@ function Mooncake.rrule!!( ΔAr = blas_contract_pullback_ΔA!( ΔA, ΔC, A, pA, B, pB, pAB, α, backend, allocator - ) + ) # this typically returns NoRData() ΔBr = blas_contract_pullback_ΔB!( ΔB, ΔC, A, pA, B, pB, pAB, α, backend, allocator - ) + ) # this typically returns NoRData() Δαr = blas_contract_pullback_Δα( ΔC, A, pA, B, pB, pAB, α, backend, allocator ) Δβr = pullback_dβ(ΔC, C, β) - ΔCr = pullback_dC!(ΔC, β) + ΔCr = pullback_dC!(ΔC, β) # this typically returns NoRData() return NoRData(), ΔCr, ΔAr, NoRData(), @@ -159,10 +159,10 @@ function Mooncake.rrule!!( function trace_permute_pullback(::NoRData) copy!(C, C_cache) - ΔAr = trace_permute_pullback_ΔA!(ΔA, ΔC, A, p, q, α, backend) + ΔAr = trace_permute_pullback_ΔA!(ΔA, ΔC, A, p, q, α, backend) # this typically returns NoRData() Δαr = trace_permute_pullback_Δα(ΔC, A, p, q, α, backend) Δβr = pullback_dβ(ΔC, C, β) - ΔCr = pullback_dC!(ΔC, β) + ΔCr = pullback_dC!(ΔC, β) # this typically returns NoRData() return NoRData(), ΔCr, ΔAr, NoRData(), NoRData(), From 815d7c3e21ddcccbbeb751e28d2b212cdf532ebe Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Mon, 26 Jan 2026 10:42:14 -0500 Subject: [PATCH 35/52] add TODO --- ext/TensorKitMooncakeExt/planaroperations.jl | 1 + 1 file changed, 1 insertion(+) diff --git a/ext/TensorKitMooncakeExt/planaroperations.jl b/ext/TensorKitMooncakeExt/planaroperations.jl index 5fe762cbb..9633dfad6 100644 --- a/ext/TensorKitMooncakeExt/planaroperations.jl +++ b/ext/TensorKitMooncakeExt/planaroperations.jl @@ -49,6 +49,7 @@ end planartrace_pullback_ΔC!(ΔC, β) = (scale!(ΔC, conj(β)); NoRData()) +# TODO: Fix planartrace pullback # This implementation is slightly more involved than its non-planar counterpart # this is because we lack a general `pAB` argument in `planarcontract`, and need # to keep things planar along the way. From b082e4ea07a2a3821bcad7553e74a39ebf175c7d Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Thu, 29 Jan 2026 09:45:04 -0500 Subject: [PATCH 36/52] correctly implement `_needs_tangent` --- ext/TensorKitMooncakeExt/utility.jl | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ext/TensorKitMooncakeExt/utility.jl b/ext/TensorKitMooncakeExt/utility.jl index 261c1dcc2..83c6d8592 100644 --- a/ext/TensorKitMooncakeExt/utility.jl +++ b/ext/TensorKitMooncakeExt/utility.jl @@ -1,7 +1,6 @@ _needs_tangent(x) = _needs_tangent(typeof(x)) -function _needs_tangent(::Type{T}) where {T <: Number} - return Mooncake.rdata_type(Mooncake.tangent_type(T)) !== NoRData() -end +_needs_tangent(::Type{T}) where {T <: Number} = + Mooncake.rdata_type(Mooncake.tangent_type(T)) !== NoRData # IndexTuple utility # ------------------ From 1ba41879c676b79b7952fb0cdb73e2f883980a31 Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Thu, 29 Jan 2026 11:27:45 -0500 Subject: [PATCH 37/52] update to Mooncake 0.5 --- Project.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Project.toml b/Project.toml index 83d716d92..fc7d7f1ef 100644 --- a/Project.toml +++ b/Project.toml @@ -45,7 +45,7 @@ GPUArrays = "11.3.1" LRUCache = "1.0.2" LinearAlgebra = "1" MatrixAlgebraKit = "0.6.3" -Mooncake = "0.4.183" +Mooncake = "0.5" OhMyThreads = "0.8.0" Printf = "1" Random = "1" From bdfef4412275f074d921ccc9d0a150681f4079a3 Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Thu, 29 Jan 2026 11:27:55 -0500 Subject: [PATCH 38/52] add TensorMap tangent type --- .../TensorKitMooncakeExt.jl | 5 +- ext/TensorKitMooncakeExt/tangent.jl | 198 ++++++++++++++++++ ext/TensorKitMooncakeExt/utility.jl | 1 + 3 files changed, 203 insertions(+), 1 deletion(-) diff --git a/ext/TensorKitMooncakeExt/TensorKitMooncakeExt.jl b/ext/TensorKitMooncakeExt/TensorKitMooncakeExt.jl index d3894c874..7067bb280 100644 --- a/ext/TensorKitMooncakeExt/TensorKitMooncakeExt.jl +++ b/ext/TensorKitMooncakeExt/TensorKitMooncakeExt.jl @@ -1,13 +1,16 @@ module TensorKitMooncakeExt using Mooncake -using Mooncake: @zero_derivative, @is_primitive, DefaultCtx, ReverseMode, NoFData, NoRData, CoDual, arrayify, primal +using Mooncake: @zero_derivative, @is_primitive, + DefaultCtx, MinimalCtx, ReverseMode, NoFData, NoRData, CoDual, Dual, + arrayify, primal, tangent using TensorKit import TensorKit as TK using VectorInterface using TensorOperations: TensorOperations, IndexTuple, Index2Tuple, linearize import TensorOperations as TO using TupleTools +using Random: AbstractRNG include("utility.jl") include("tangent.jl") diff --git a/ext/TensorKitMooncakeExt/tangent.jl b/ext/TensorKitMooncakeExt/tangent.jl index 9fa6e401a..12921faec 100644 --- a/ext/TensorKitMooncakeExt/tangent.jl +++ b/ext/TensorKitMooncakeExt/tangent.jl @@ -13,3 +13,201 @@ function Mooncake.arrayify(Aᴴ_ΔAᴴ::CoDual{<:TensorKit.AdjointTensorMap}) A, ΔA = arrayify(A_ΔA) return A', ΔA' end + +# Define the tangent type of a TensorMap to be TensorMap itself. +# This has a number of benefits, but also correctly alters the +# inner product when dealing with non-abelian symmetries. +# +# Note: this implementation is technically a little lazy, since we are +# assuming that the tangent type of the underlying storage is also given +# by that same type. This should in principle work out fine, and will only +# fail for types that would be self-referential, which we choose to not support +# for now. + +Mooncake.@foldable Mooncake.tangent_type(::Type{T}) where {T <: TensorMap} = T +Mooncake.@foldable Mooncake.tangent_type(::Type{T}, ::Type{NoRData}) where {T <: TensorMap} = T + +Mooncake.@foldable Mooncake.fdata_type(::Type{T}) where {T <: TensorMap} = T +Mooncake.@foldable Mooncake.rdata_type(::Type{T}) where {T <: TensorMap} = NoRData + +Mooncake.tangent(t::TensorMap, ::NoRData) = t +Mooncake.zero_tangent_internal(t::TensorMap, ::Mooncake.MaybeCache) = zerovector(t) + +Mooncake.randn_tangent_internal(rng::AbstractRNG, p::TensorMap, ::Mooncake.MaybeCache) = + randn!(rng, similar(p)) + +Mooncake.set_to_zero_internal!!(::Mooncake.SetToZeroCache, t::TensorMap) = zerovector!(t) +Mooncake.increment_internal!!(::Mooncake.IncCache, x::T, y::T) where {T <: TensorMap} = add!(x, y) + + +Mooncake._add_to_primal_internal(::Mooncake.MaybeCache, p::T, t::T, unsafe::Bool) where {T <: TensorMap} = add(p, t) +Mooncake.tangent_to_primal_internal!!(p::T, t::T, ::Mooncake.MaybeCache) where {T <: TensorMap} = copy!(p, t) +Mooncake.primal_to_tangent_internal!!(t::T, p::T, ::Mooncake.MaybeCache) where {T <: TensorMap} = copy!(t, p) + +Mooncake._dot_internal(::Mooncake.MaybeCache, t::T, s::T) where {T <: TensorMap} = Float64(real(inner(t, s))) +Mooncake._scale_internal(::Mooncake.MaybeCache, a::Float64, t::T) where {T <: TensorMap} = scale(t, a) + +function Mooncake.TestUtils.populate_address_map_internal( + m::Mooncake.AddressMap, primal::T, tangent::T + ) where {T <: TensorMap} + return Mooncake.TestUtils.populate_address_map_internal(m, primal.data, tangent.data) +end + +function Mooncake.__verify_fdata_value(::IdDict{Any, Nothing}, p::TensorMap, f::TensorMap) + space(p) == space(f) || + throw(Mooncake.InvalidFDataException(lazy"p has space $(space(p)) but f has size $(space(f))")) + return nothing +end + + +@is_primitive MinimalCtx Tuple{typeof(Mooncake.lgetfield), <:TensorMap, Val} + +# TODO: double-check if this has to include quantum dimensinos for non-abelian? +function Mooncake.frule!!( + ::Dual{typeof(Mooncake.lgetfield)}, t::Dual{<:TensorMap}, ::Dual{Val{FieldName}} + ) where {FieldName} + y = getfield(primal(t), FieldName) + + return if FieldName === 1 || FieldName === :data + dval = tangent(t).data + Dual(val, dval) + elseif FieldName === 2 || FieldName === :space + Dual(val, NoFData()), getfield_pullback + else + throw(ArgumentError(lazy"Invalid fieldname `$FieldName`")) + end +end + +function Mooncake.rrule!!( + ::CoDual{typeof(Mooncake.lgetfield)}, t::CoDual{<:TensorMap}, ::CoDual{Val{FieldName}} + ) where {FieldName} + val = getfield(primal(t), FieldName) + getfield_pullback = Mooncake.NoPullback(ntuple(Returns(NoRData()), 3)) + + return if FieldName === 1 || FieldName === :data + dval = Mooncake.tangent(t).data + CoDual(val, dval), getfield_pullback + elseif FieldName === 2 || FieldName === :space + Mooncake.zero_fcodual(val), getfield_pullback + else + throw(ArgumentError(lazy"Invalid fieldname `$FieldName`")) + end +end + +@is_primitive MinimalCtx Tuple{typeof(getfield), <:TensorMap, Any, Vararg{Symbol}} + +Base.@constprop :aggressive function Mooncake.frule!!( + ::Dual{typeof(getfield)}, t::Dual{<:TensorMap}, name::Dual + ) + y = getfield(primal(t), primal(name)) + + return if primal(name) === 1 || primal(name) === :data + dval = tangent(t).data + Dual(val, dval) + elseif primal(name) === 2 || primal(name) === :space + Dual(val, NoFData()) + else + throw(ArgumentError(lazy"Invalid fieldname `$(primal(name))`")) + end +end + +Base.@constprop :aggressive function Mooncake.rrule!!( + ::CoDual{typeof(getfield)}, t::CoDual{<:TensorMap}, name::CoDual + ) + val = getfield(primal(t), primal(name)) + getfield_pullback = Mooncake.NoPullback(ntuple(Returns(NoRData()), 3)) + + return if primal(name) === 1 || primal(name) === :data + dval = Mooncake.tangent(t).data + CoDual(val, dval), getfield_pullback + elseif primal(name) === 2 || primal(name) === :space + Mooncake.zero_fcodual(val), getfield_pullback + else + throw(ArgumentError(lazy"Invalid fieldname `$(primal(name))`")) + end +end + +Base.@constprop :aggressive function Mooncake.frule!!( + ::Dual{typeof(getfield)}, t::Dual{<:TensorMap}, name::Dual, order::Dual + ) + y = getfield(primal(t), primal(name), primal(order)) + + return if primal(name) === 1 || primal(name) === :data + dval = tangent(t).data + Dual(val, dval) + elseif primal(name) === 2 || primal(name) === :space + Dual(val, NoFData()) + else + throw(ArgumentError(lazy"Invalid fieldname `$(primal(name))`")) + end +end + +Base.@constprop :aggressive function Mooncake.rrule!!( + ::CoDual{typeof(getfield)}, t::CoDual{<:TensorMap}, name::CoDual, order::CoDual + ) + val = getfield(primal(t), primal(name), primal(order)) + getfield_pullback = Mooncake.NoPullback(ntuple(Returns(NoRData()), 4)) + + return if primal(name) === 1 || primal(name) === :data + dval = Mooncake.tangent(t).data + CoDual(val, dval), getfield_pullback + elseif primal(name) === 2 || primal(name) === :space + Mooncake.zero_fcodual(val), getfield_pullback + else + throw(ArgumentError(lazy"Invalid fieldname `$(primal(name))`")) + end +end + + +@is_primitive MinimalCtx Tuple{typeof(Mooncake.lgetfield), <:TensorMap, Val, Val} + +# TODO: double-check if this has to include quantum dimensinos for non-abelian? +function Mooncake.frule!!( + ::Dual{typeof(Mooncake.lgetfield)}, t::Dual{<:TensorMap}, ::Dual{Val{FieldName}}, ::Dual{Val{Order}} + ) where {FieldName, Order} + y = getfield(primal(t), FieldName, Order) + + return if FieldName === 1 || FieldName === :data + dval = tangent(t).data + Dual(val, dval) + elseif FieldName === 2 || FieldName === :space + Dual(val, NoFData()) + else + throw(ArgumentError(lazy"Invalid fieldname `$FieldName`")) + end +end + +function Mooncake.rrule!!( + ::CoDual{typeof(Mooncake.lgetfield)}, t::CoDual{<:TensorMap}, ::CoDual{Val{FieldName}}, ::CoDual{Val{Order}} + ) where {FieldName, Order} + val = getfield(primal(t), FieldName, Order) + getfield_pullback = Mooncake.NoPullback(ntuple(Returns(NoRData()), 4)) + + return if FieldName === 1 || FieldName === :data + dval = Mooncake.tangent(t).data + CoDual(val, dval), getfield_pullback + elseif FieldName === 2 || FieldName === :space + Mooncake.zero_fcodual(val), getfield_pullback + else + throw(ArgumentError(lazy"Invalid fieldname `$FieldName`")) + end +end + + +Mooncake.@zero_derivative Mooncake.MinimalCtx Tuple{typeof(Mooncake._new_), Type{TensorMap{T, S, N₁, N₂, A}}, UndefInitializer, TensorMapSpace{S, N₁, N₂}} where {T, S, N₁, N₂, A} +@is_primitive Mooncake.MinimalCtx Tuple{typeof(Mooncake._new_), Type{TensorMap{T, S, N₁, N₂, A}}, A, TensorMapSpace{S, N₁, N₂}} where {T, S, N₁, N₂, A} + +function Mooncake.frule!!( + ::Dual{typeof(Mooncake._new_)}, ::Dual{Type{TensorMap{T, S, N₁, N₂, A}}}, data::Dual{A}, space::Dual{TensorMapSpace{S, N₁, N₂}} + ) where {T, S, N₁, N₂, A} + t = Mooncake._new_(TensorMap{T, S, N₁, N₂, A}, primal(data), primal(space)) + dt = Mooncake._new_(TensorMap{T, S, N₁, N₂, A}, tangent(data), primal(space)) + return Dual(t, dt) +end + +function Mooncake.rrule!!( + ::CoDual{typeof(Mooncake._new_)}, ::CoDual{Type{TensorMap{T, S, N₁, N₂, A}}}, data::CoDual{A}, space::CoDual{TensorMapSpace{S, N₁, N₂}} + ) where {T, S, N₁, N₂, A} + return Mooncake.zero_fcodual(Mooncake._new_(TensorMap{T, S, N₁, N₂, A}, primal(data), primal(space))), + Returns(ntuple(Returns(NoRData()), 4)) +end diff --git a/ext/TensorKitMooncakeExt/utility.jl b/ext/TensorKitMooncakeExt/utility.jl index 83c6d8592..bfbca5264 100644 --- a/ext/TensorKitMooncakeExt/utility.jl +++ b/ext/TensorKitMooncakeExt/utility.jl @@ -27,6 +27,7 @@ end # A VectorSpace has no meaningful notion of a vector space (tangent space) Mooncake.tangent_type(::Type{<:VectorSpace}) = Mooncake.NoTangent +Mooncake.tangent_type(::Type{<:HomSpace}) = Mooncake.NoTangent @zero_derivative DefaultCtx Tuple{typeof(TensorKit.fusionblockstructure), Any} From f7aa7399ead6293a4ff71f745a4e18939a1b3028 Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Thu, 29 Jan 2026 11:30:51 -0500 Subject: [PATCH 39/52] fix stupid tolerance mistake --- test/mooncake/indexmanipulations.jl | 4 ++-- test/mooncake/linalg.jl | 4 ++-- test/mooncake/planaroperations.jl | 4 ++-- test/mooncake/tensoroperations.jl | 4 ++-- test/mooncake/vectorinterface.jl | 4 ++-- test/setup.jl | 5 +++++ 6 files changed, 15 insertions(+), 10 deletions(-) diff --git a/test/mooncake/indexmanipulations.jl b/test/mooncake/indexmanipulations.jl index a2909c38f..5155cd46f 100644 --- a/test/mooncake/indexmanipulations.jl +++ b/test/mooncake/indexmanipulations.jl @@ -51,8 +51,8 @@ spacelist = ( eltypes = (Float64,) # no complex support yet @timedtestset "Mooncake - Index Manipulations: $(TensorKit.type_repr(sectortype(eltype(V)))) ($T)" for V in spacelist, T in eltypes - atol = precision(T) - rtol = precision(T) + atol = default_tol(T) + rtol = default_tol(T) symmetricbraiding = BraidingStyle(sectortype(eltype(V))) isa SymmetricBraiding symmetricbraiding && @timedtestset "add_permute!" begin diff --git a/test/mooncake/linalg.jl b/test/mooncake/linalg.jl index 426619549..67d19a66b 100644 --- a/test/mooncake/linalg.jl +++ b/test/mooncake/linalg.jl @@ -51,8 +51,8 @@ spacelist = ( eltypes = (Float64,) # no complex support yet @timedtestset "Mooncake - LinearAlgebra: $(TensorKit.type_repr(sectortype(eltype(V)))) ($T)" for V in spacelist, T in eltypes - atol = precision(T) - rtol = precision(T) + atol = default_tol(T) + rtol = default_tol(T) C = randn(T, V[1] ⊗ V[2] ← V[5]) A = randn(T, codomain(C) ← V[3] ⊗ V[4]) diff --git a/test/mooncake/planaroperations.jl b/test/mooncake/planaroperations.jl index cbdc7ec76..eb1a265d4 100644 --- a/test/mooncake/planaroperations.jl +++ b/test/mooncake/planaroperations.jl @@ -52,8 +52,8 @@ spacelist = ( eltypes = (Float64,) # no complex support yet @timedtestset "Mooncake - PlanarOperations: $(TensorKit.type_repr(sectortype(eltype(V)))) ($T)" for V in spacelist, T in eltypes - atol = precision(T) - rtol = precision(T) + atol = default_tol(T) + rtol = default_tol(T) @timedtestset "planarcontract!" begin for _ in 1:5 diff --git a/test/mooncake/tensoroperations.jl b/test/mooncake/tensoroperations.jl index 43372a011..e0ab89280 100644 --- a/test/mooncake/tensoroperations.jl +++ b/test/mooncake/tensoroperations.jl @@ -51,8 +51,8 @@ spacelist = ( eltypes = (Float64,) # no complex support yet @timedtestset "Mooncake - TensorOperations: $(TensorKit.type_repr(sectortype(eltype(V)))) ($T)" for V in spacelist, T in eltypes - atol = precision(T) - rtol = precision(T) + atol = default_tol(T) + rtol = default_tol(T) symmetricbraiding = BraidingStyle(sectortype(eltype(V))) isa SymmetricBraiding symmetricbraiding && @timedtestset "tensorcontract!" begin diff --git a/test/mooncake/vectorinterface.jl b/test/mooncake/vectorinterface.jl index 131521c44..3e439b3fc 100644 --- a/test/mooncake/vectorinterface.jl +++ b/test/mooncake/vectorinterface.jl @@ -51,8 +51,8 @@ spacelist = ( eltypes = (Float64,) # no complex support yet @timedtestset "Mooncake - VectorInterface: $(TensorKit.type_repr(sectortype(eltype(V)))) ($T)" for V in spacelist, T in eltypes - atol = precision(T) - rtol = precision(T) + atol = default_tol(T) + rtol = default_tol(T) C = randn(T, V[1] ⊗ V[2] ← V[3] ⊗ V[4] ⊗ V[5]) A = randn(T, V[1] ⊗ V[2] ← V[3] ⊗ V[4] ⊗ V[5]) diff --git a/test/setup.jl b/test/setup.jl index 9b3a51d01..c99fbdad1 100644 --- a/test/setup.jl +++ b/test/setup.jl @@ -1,6 +1,7 @@ module TestSetup export randindextuple, randcircshift, _repartition, trivtuple +export default_tol export smallset, randsector, hasfusiontensor, force_planar export random_fusion export sectorlist @@ -51,6 +52,10 @@ function _repartition(p::Union{IndexTuple, Index2Tuple}, t::AbstractTensorMap) return _repartition(p, TensorKit.numout(t)) end +# Float32 and finite differences don't mix well +default_tol(::Type{<:Union{Float32, Complex{Float32}}}) = 1.0e-2 +default_tol(::Type{<:Union{Float64, Complex{Float64}}}) = 1.0e-5 + # Sector utility # -------------- smallset(::Type{I}) where {I <: Sector} = take(values(I), 5) From 40287bc67e135aecaf1fa879d6cee431a73e10cc Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Thu, 29 Jan 2026 11:31:02 -0500 Subject: [PATCH 40/52] enable complex tests --- test/mooncake/indexmanipulations.jl | 16 ++++++++-------- test/mooncake/linalg.jl | 17 ++++++++--------- test/mooncake/planaroperations.jl | 16 ++++++++-------- test/mooncake/tensoroperations.jl | 16 ++++++++-------- test/mooncake/vectorinterface.jl | 16 ++++++++-------- 5 files changed, 40 insertions(+), 41 deletions(-) diff --git a/test/mooncake/indexmanipulations.jl b/test/mooncake/indexmanipulations.jl index 5155cd46f..945f4482b 100644 --- a/test/mooncake/indexmanipulations.jl +++ b/test/mooncake/indexmanipulations.jl @@ -40,15 +40,15 @@ spacelist = ( Vect[SU2Irrep](1 // 2 => 2), Vect[SU2Irrep](0 => 1, 1 // 2 => 1, 3 // 2 => 1)', ), - # ( - # Vect[FibonacciAnyon](:I => 2, :τ => 1), - # Vect[FibonacciAnyon](:I => 1, :τ => 2)', - # Vect[FibonacciAnyon](:I => 2, :τ => 2)', - # Vect[FibonacciAnyon](:I => 2, :τ => 3), - # Vect[FibonacciAnyon](:I => 2, :τ => 2), - # ), + ( + Vect[FibonacciAnyon](:I => 2, :τ => 1), + Vect[FibonacciAnyon](:I => 1, :τ => 2)', + Vect[FibonacciAnyon](:I => 2, :τ => 2)', + Vect[FibonacciAnyon](:I => 2, :τ => 3), + Vect[FibonacciAnyon](:I => 2, :τ => 2), + ), ) -eltypes = (Float64,) # no complex support yet +eltypes = (Float64, ComplexF64) @timedtestset "Mooncake - Index Manipulations: $(TensorKit.type_repr(sectortype(eltype(V)))) ($T)" for V in spacelist, T in eltypes atol = default_tol(T) diff --git a/test/mooncake/linalg.jl b/test/mooncake/linalg.jl index 67d19a66b..ead21f7a1 100644 --- a/test/mooncake/linalg.jl +++ b/test/mooncake/linalg.jl @@ -1,6 +1,5 @@ using Test, TestExtras using TensorKit -using TensorOperations using Mooncake using Random @@ -40,15 +39,15 @@ spacelist = ( Vect[SU2Irrep](1 // 2 => 2), Vect[SU2Irrep](0 => 1, 1 // 2 => 1, 3 // 2 => 1)', ), - # ( - # Vect[FibonacciAnyon](:I => 2, :τ => 1), - # Vect[FibonacciAnyon](:I => 1, :τ => 2)', - # Vect[FibonacciAnyon](:I => 2, :τ => 2)', - # Vect[FibonacciAnyon](:I => 2, :τ => 3), - # Vect[FibonacciAnyon](:I => 2, :τ => 2), - # ), + ( + Vect[FibonacciAnyon](:I => 2, :τ => 1), + Vect[FibonacciAnyon](:I => 1, :τ => 2)', + Vect[FibonacciAnyon](:I => 2, :τ => 2)', + Vect[FibonacciAnyon](:I => 2, :τ => 3), + Vect[FibonacciAnyon](:I => 2, :τ => 2), + ), ) -eltypes = (Float64,) # no complex support yet +eltypes = (Float64, ComplexF64) @timedtestset "Mooncake - LinearAlgebra: $(TensorKit.type_repr(sectortype(eltype(V)))) ($T)" for V in spacelist, T in eltypes atol = default_tol(T) diff --git a/test/mooncake/planaroperations.jl b/test/mooncake/planaroperations.jl index eb1a265d4..dcc424b9a 100644 --- a/test/mooncake/planaroperations.jl +++ b/test/mooncake/planaroperations.jl @@ -41,15 +41,15 @@ spacelist = ( Vect[SU2Irrep](1 // 2 => 2), Vect[SU2Irrep](0 => 1, 1 // 2 => 1, 3 // 2 => 1)', ), - # ( - # Vect[FibonacciAnyon](:I => 2, :τ => 1), - # Vect[FibonacciAnyon](:I => 1, :τ => 2)', - # Vect[FibonacciAnyon](:I => 2, :τ => 2)', - # Vect[FibonacciAnyon](:I => 2, :τ => 3), - # Vect[FibonacciAnyon](:I => 2, :τ => 2), - # ), + ( + Vect[FibonacciAnyon](:I => 2, :τ => 1), + Vect[FibonacciAnyon](:I => 1, :τ => 2)', + Vect[FibonacciAnyon](:I => 2, :τ => 2)', + Vect[FibonacciAnyon](:I => 2, :τ => 3), + Vect[FibonacciAnyon](:I => 2, :τ => 2), + ), ) -eltypes = (Float64,) # no complex support yet +eltypes = (Float64, ComplexF64) @timedtestset "Mooncake - PlanarOperations: $(TensorKit.type_repr(sectortype(eltype(V)))) ($T)" for V in spacelist, T in eltypes atol = default_tol(T) diff --git a/test/mooncake/tensoroperations.jl b/test/mooncake/tensoroperations.jl index e0ab89280..922ac227a 100644 --- a/test/mooncake/tensoroperations.jl +++ b/test/mooncake/tensoroperations.jl @@ -40,15 +40,15 @@ spacelist = ( Vect[SU2Irrep](1 // 2 => 2), Vect[SU2Irrep](0 => 1, 1 // 2 => 1, 3 // 2 => 1)', ), - # ( - # Vect[FibonacciAnyon](:I => 2, :τ => 1), - # Vect[FibonacciAnyon](:I => 1, :τ => 2)', - # Vect[FibonacciAnyon](:I => 2, :τ => 2)', - # Vect[FibonacciAnyon](:I => 2, :τ => 3), - # Vect[FibonacciAnyon](:I => 2, :τ => 2), - # ), + ( + Vect[FibonacciAnyon](:I => 2, :τ => 1), + Vect[FibonacciAnyon](:I => 1, :τ => 2)', + Vect[FibonacciAnyon](:I => 2, :τ => 2)', + Vect[FibonacciAnyon](:I => 2, :τ => 3), + Vect[FibonacciAnyon](:I => 2, :τ => 2), + ), ) -eltypes = (Float64,) # no complex support yet +eltypes = (Float64, ComplexF64) @timedtestset "Mooncake - TensorOperations: $(TensorKit.type_repr(sectortype(eltype(V)))) ($T)" for V in spacelist, T in eltypes atol = default_tol(T) diff --git a/test/mooncake/vectorinterface.jl b/test/mooncake/vectorinterface.jl index 3e439b3fc..d43f7014d 100644 --- a/test/mooncake/vectorinterface.jl +++ b/test/mooncake/vectorinterface.jl @@ -40,15 +40,15 @@ spacelist = ( Vect[SU2Irrep](1 // 2 => 2), Vect[SU2Irrep](0 => 1, 1 // 2 => 1, 3 // 2 => 1)', ), - # ( - # Vect[FibonacciAnyon](:I => 2, :τ => 1), - # Vect[FibonacciAnyon](:I => 1, :τ => 2)', - # Vect[FibonacciAnyon](:I => 2, :τ => 2)', - # Vect[FibonacciAnyon](:I => 2, :τ => 3), - # Vect[FibonacciAnyon](:I => 2, :τ => 2), - # ), + ( + Vect[FibonacciAnyon](:I => 2, :τ => 1), + Vect[FibonacciAnyon](:I => 1, :τ => 2)', + Vect[FibonacciAnyon](:I => 2, :τ => 2)', + Vect[FibonacciAnyon](:I => 2, :τ => 3), + Vect[FibonacciAnyon](:I => 2, :τ => 2), + ), ) -eltypes = (Float64,) # no complex support yet +eltypes = (Float64, ComplexF64) @timedtestset "Mooncake - VectorInterface: $(TensorKit.type_repr(sectortype(eltype(V)))) ($T)" for V in spacelist, T in eltypes atol = default_tol(T) From 6d1bbdb0de5cf856f44d0d476e1962c5ba199a79 Mon Sep 17 00:00:00 2001 From: Lukas Devos Date: Thu, 29 Jan 2026 11:31:10 -0500 Subject: [PATCH 41/52] add tangent type test --- Project.toml | 9 ++++--- test/mooncake/tangent.jl | 58 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 64 insertions(+), 3 deletions(-) create mode 100644 test/mooncake/tangent.jl diff --git a/Project.toml b/Project.toml index fc7d7f1ef..838965d09 100644 --- a/Project.toml +++ b/Project.toml @@ -1,7 +1,7 @@ name = "TensorKit" uuid = "07d1fe3e-3e46-537d-9eac-e9e13d0d4cec" -authors = ["Jutho Haegeman, Lukas Devos"] version = "0.16.0" +authors = ["Jutho Haegeman, Lukas Devos"] [deps] LRUCache = "8ac3fa9e-de4c-5943-b1dc-09c6b5f20637" @@ -22,8 +22,8 @@ Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e" CUDA = "052768ef-5323-5732-b1bb-66c8b64840ba" ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4" FiniteDifferences = "26cc04aa-876d-5657-8c51-4c34ba976000" -cuTENSOR = "011b41b2-24ef-40a8-b3eb-fa098493e9e1" Mooncake = "da2b9cff-9c12-43a0-ae48-6db2b0edb7d6" +cuTENSOR = "011b41b2-24ef-40a8-b3eb-fa098493e9e1" [extensions] TensorKitAdaptExt = "Adapt" @@ -34,6 +34,7 @@ TensorKitMooncakeExt = "Mooncake" [compat] Adapt = "4" +AllocCheck = "0.2.3" Aqua = "0.6, 0.7, 0.8" ArgParse = "1.2.0" CUDA = "5.9" @@ -64,6 +65,7 @@ julia = "1.10" [extras] Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e" +AllocCheck = "9b6a8646-10ed-4001-bbdc-1d2f46dfbb1a" Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595" ArgParse = "c7e460c6-2fb9-53a9-8c5b-16f535851c63" CUDA = "052768ef-5323-5732-b1bb-66c8b64840ba" @@ -72,6 +74,7 @@ ChainRulesTestUtils = "cdddcdb0-9152-4a09-a978-84456f9df70a" Combinatorics = "861a8166-3701-5b0c-9a16-15d98fcdc6aa" FiniteDifferences = "26cc04aa-876d-5657-8c51-4c34ba976000" GPUArrays = "0c68f7d7-f131-5f86-a1c3-88cf8149b2d7" +JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b" LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e" Mooncake = "da2b9cff-9c12-43a0-ae48-6db2b0edb7d6" SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f" @@ -82,4 +85,4 @@ Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f" cuTENSOR = "011b41b2-24ef-40a8-b3eb-fa098493e9e1" [targets] -test = ["ArgParse", "Adapt", "Aqua", "Combinatorics", "CUDA", "cuTENSOR", "GPUArrays", "LinearAlgebra", "SafeTestsets", "TensorOperations", "Test", "TestExtras", "ChainRulesCore", "ChainRulesTestUtils", "FiniteDifferences", "Zygote", "Mooncake"] +test = ["ArgParse", "Adapt", "Aqua", "AllocCheck", "Combinatorics", "CUDA", "cuTENSOR", "GPUArrays", "LinearAlgebra", "SafeTestsets", "TensorOperations", "Test", "TestExtras", "ChainRulesCore", "ChainRulesTestUtils", "FiniteDifferences", "Zygote", "Mooncake", "JET"] diff --git a/test/mooncake/tangent.jl b/test/mooncake/tangent.jl new file mode 100644 index 000000000..5b001fc51 --- /dev/null +++ b/test/mooncake/tangent.jl @@ -0,0 +1,58 @@ +using Test, TestExtras +using TensorKit +using Mooncake +using Random +using JET, AllocCheck + +@isdefined(TestSetup) || include("../setup.jl") +using .TestSetup +using .TestSetup: _repartition + +mode = Mooncake.ReverseMode +rng = Random.default_rng() + +spacelist = ( + (ℂ^2, (ℂ^3)', ℂ^3, ℂ^2, (ℂ^2)'), + ( + Vect[Z2Irrep](0 => 1, 1 => 1), + Vect[Z2Irrep](0 => 1, 1 => 2)', + Vect[Z2Irrep](0 => 2, 1 => 2)', + Vect[Z2Irrep](0 => 2, 1 => 3), + Vect[Z2Irrep](0 => 2, 1 => 2), + ), + ( + Vect[FermionParity](0 => 1, 1 => 1), + Vect[FermionParity](0 => 1, 1 => 2)', + Vect[FermionParity](0 => 2, 1 => 1)', + Vect[FermionParity](0 => 2, 1 => 3), + Vect[FermionParity](0 => 2, 1 => 2), + ), + ( + Vect[U1Irrep](0 => 2, 1 => 1, -1 => 1), + Vect[U1Irrep](0 => 2, 1 => 1, -1 => 1), + Vect[U1Irrep](0 => 2, 1 => 2, -1 => 1)', + Vect[U1Irrep](0 => 1, 1 => 1, -1 => 2), + Vect[U1Irrep](0 => 1, 1 => 2, -1 => 1)', + ), + ( + Vect[SU2Irrep](0 => 2, 1 // 2 => 1), + Vect[SU2Irrep](0 => 1, 1 => 1), + Vect[SU2Irrep](1 // 2 => 1, 1 => 1)', + Vect[SU2Irrep](1 // 2 => 2), + Vect[SU2Irrep](0 => 1, 1 // 2 => 1, 3 // 2 => 1)', + ), + ( + Vect[FibonacciAnyon](:I => 2, :τ => 1), + Vect[FibonacciAnyon](:I => 1, :τ => 2)', + Vect[FibonacciAnyon](:I => 2, :τ => 2)', + Vect[FibonacciAnyon](:I => 2, :τ => 3), + Vect[FibonacciAnyon](:I => 2, :τ => 2), + ), +) +eltypes = (Float64, ComplexF64) + +# only run on Linux since allocation tests are broken on other versions +Sys.islinux() && @timedtestset "Mooncake - Tangent type: $(TensorKit.type_repr(sectortype(eltype(V)))) ($T)" for V in spacelist, T in eltypes + A = randn(T, V[1] ⊗ V[2] ← V[4] ⊗ V[5]) + Mooncake.TestUtils.test_data(rng, A) +end From f165420ae03682b046429465ab6bec5b56cbc8f9 Mon Sep 17 00:00:00 2001 From: lkdvos Date: Thu, 29 Jan 2026 14:45:42 -0500 Subject: [PATCH 42/52] correct arrayify --- ext/TensorKitMooncakeExt/tangent.jl | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/ext/TensorKitMooncakeExt/tangent.jl b/ext/TensorKitMooncakeExt/tangent.jl index 12921faec..f5c03d646 100644 --- a/ext/TensorKitMooncakeExt/tangent.jl +++ b/ext/TensorKitMooncakeExt/tangent.jl @@ -1,12 +1,6 @@ -function Mooncake.arrayify(A_dA::CoDual{<:TensorMap}) - A = Mooncake.primal(A_dA) - dA_fw = Mooncake.tangent(A_dA) - data = dA_fw.data.data - dA = typeof(A)(data, A.space) - return A, dA -end +Mooncake.arrayify(A_dA::CoDual{<:TensorMap}) = primal(A_dA), tangent(A_dA) -function Mooncake.arrayify(Aᴴ_ΔAᴴ::CoDual{<:TensorKit.AdjointTensorMap}) +function Mooncake.arrayify(Aᴴ_ΔAᴴ::CoDual{<:TK.AdjointTensorMap}) Aᴴ = Mooncake.primal(Aᴴ_ΔAᴴ) ΔAᴴ = Mooncake.tangent(Aᴴ_ΔAᴴ) A_ΔA = CoDual(Aᴴ', ΔAᴴ.data.parent) From d9de88525627477865e957c13eac4327ba71ad1c Mon Sep 17 00:00:00 2001 From: lkdvos Date: Thu, 29 Jan 2026 17:13:39 -0500 Subject: [PATCH 43/52] fix indexmanipulations --- .../indexmanipulations.jl | 47 +++++++++---------- ext/TensorKitMooncakeExt/tangent.jl | 47 ++++++++++++------- 2 files changed, 52 insertions(+), 42 deletions(-) diff --git a/ext/TensorKitMooncakeExt/indexmanipulations.jl b/ext/TensorKitMooncakeExt/indexmanipulations.jl index fe871a52d..28c142522 100644 --- a/ext/TensorKitMooncakeExt/indexmanipulations.jl +++ b/ext/TensorKitMooncakeExt/indexmanipulations.jl @@ -193,7 +193,7 @@ function Mooncake.rrule!!(::CoDual{typeof(flip)}, t_Δt::CoDual{<:AbstractTensor _, Δt_flipped = arrayify(t_flipped_Δt_flipped) function twist_pullback(::NoRData) - copy!(Δt, flip(Δt_flipped, inds; inv = !inv)) + add!(Δt, flip(Δt_flipped, inds; inv = !inv)) return ntuple(Returns(NoRData()), 3) end @@ -214,7 +214,7 @@ function Mooncake.rrule!!( _, Δt_flipped = arrayify(t_flipped_Δt_flipped) function twist_pullback(::NoRData) - copy!(Δt, flip(Δt_flipped, inds; inv = !inv)) + add!(Δt, flip(Δt_flipped, inds; inv = !inv)) return ntuple(Returns(NoRData()), 5) end @@ -237,11 +237,10 @@ for insertunit in (:insertleftunit, :insertrightunit) # sharing address spaces if tsrc isa TensorMap tsrc_cache = copy(tsrc) - tdst = $insertunit(tsrc, ival) - # note: this is somewhat of a hack that makes use of the fact that the tangent is - # encoded without any information about the space, which allows us to simply reuse - # the tangent exactly without having to modify the space information - tdst_Δtdst = CoDual(tdst, Mooncake.tangent(tsrc_Δtsrc)) + tdst_Δtdst = CoDual( + $insertunit(tsrc, ival), + $insertunit(Mooncake.tangent(tsrc_Δtsrc), ival) + ) else tsrc_cache = nothing tdst = $insertunit(tsrc, ival) @@ -253,7 +252,7 @@ for insertunit in (:insertleftunit, :insertrightunit) function $insertunit_pullback(::NoRData) if isnothing(tsrc_cache) for (c, b) in blocks(Δtdst) - copy!(block(Δtsrc, c), b) + add!(block(Δtsrc, c), b) end else copy!(tsrc, tsrc_cache) @@ -278,10 +277,10 @@ for insertunit in (:insertleftunit, :insertrightunit) if tsrc isa TensorMap && !get(kwargs, :copy, false) tsrc_cache = copy(tsrc) tdst = $insertunit(tsrc, ival; kwargs...) - # note: this is somewhat of a hack that makes use of the fact that the tangent is - # encoded without any information about the space, which allows us to simply reuse - # the tangent exactly without having to modify the space information - tdst_Δtdst = CoDual(tdst, Mooncake.tangent(tsrc_Δtsrc)) + tdst_Δtdst = CoDual( + $insertunit(tsrc, ival; kwargs...), + $insertunit(Mooncake.tangent(tsrc_Δtsrc), ival; kwargs...) + ) else tsrc_cache = nothing tdst = $insertunit(tsrc, ival; kwargs...) @@ -293,7 +292,7 @@ for insertunit in (:insertleftunit, :insertrightunit) function $insertunit_pullback(::NoRData) if isnothing(tsrc_cache) for (c, b) in blocks(Δtdst) - copy!(block(Δtsrc, c), b) + add!(block(Δtsrc, c), b) end else copy!(tsrc, tsrc_cache) @@ -320,11 +319,10 @@ function Mooncake.rrule!!(::CoDual{typeof(removeunit)}, tsrc_Δtsrc::CoDual{<:Ab # sharing address spaces if tsrc isa TensorMap tsrc_cache = copy(tsrc) - tdst = removeunit(tsrc, ival) - # note: this is somewhat of a hack that makes use of the fact that the tangent is - # encoded without any information about the space, which allows us to simply reuse - # the tangent exactly without having to modify the space information - tdst_Δtdst = CoDual(tdst, Mooncake.tangent(tsrc_Δtsrc)) + tdst_Δtdst = CoDual( + removeunit(tsrc, ival), + removeunit(Mooncake.tangent(tsrc_Δtsrc), ival) + ) else tsrc_cache = nothing tdst = removeunit(tsrc, ival) @@ -336,7 +334,7 @@ function Mooncake.rrule!!(::CoDual{typeof(removeunit)}, tsrc_Δtsrc::CoDual{<:Ab function removeunit_pullback(::NoRData) if isnothing(tsrc_cache) for (c, b) in blocks(Δtdst) - copy!(block(Δtsrc, c), b) + add!(block(Δtsrc, c), b) end else copy!(tsrc, tsrc_cache) @@ -360,11 +358,10 @@ function Mooncake.rrule!!( # sharing address spaces if tsrc isa TensorMap && !get(kwargs, :copy, false) tsrc_cache = copy(tsrc) - tdst = removeunit(tsrc, ival; kwargs...) - # note: this is somewhat of a hack that makes use of the fact that the tangent is - # encoded without any information about the space, which allows us to simply reuse - # the tangent exactly without having to modify the space information - tdst_Δtdst = CoDual(tdst, Mooncake.tangent(tsrc_Δtsrc)) + tdst_Δtdst = CoDual( + removeunit(tsrc, ival; kwargs...), + removeunit(Mooncake.tangent(tsrc_Δtsrc), ival) + ) else tsrc_cache = nothing tdst = removeunit(tsrc, ival; kwargs...) @@ -376,7 +373,7 @@ function Mooncake.rrule!!( function removeunit_pullback(::NoRData) if isnothing(tsrc_cache) for (c, b) in blocks(Δtdst) - copy!(block(Δtsrc, c), b) + add!(block(Δtsrc, c), b) end else copy!(tsrc, tsrc_cache) diff --git a/ext/TensorKitMooncakeExt/tangent.jl b/ext/TensorKitMooncakeExt/tangent.jl index f5c03d646..42aed83bd 100644 --- a/ext/TensorKitMooncakeExt/tangent.jl +++ b/ext/TensorKitMooncakeExt/tangent.jl @@ -18,41 +18,54 @@ end # fail for types that would be self-referential, which we choose to not support # for now. -Mooncake.@foldable Mooncake.tangent_type(::Type{T}) where {T <: TensorMap} = T Mooncake.@foldable Mooncake.tangent_type(::Type{T}, ::Type{NoRData}) where {T <: TensorMap} = T +Mooncake.@foldable Mooncake.tangent_type(::Type{TensorMap{T, S, N₁, N₂, A}}) where {T, S, N₁, N₂, A} = + TK.tensormaptype(S, N₁, N₂, Mooncake.tangent_type(A)) -Mooncake.@foldable Mooncake.fdata_type(::Type{T}) where {T <: TensorMap} = T +Mooncake.@foldable Mooncake.fdata_type(::Type{T}) where {T <: TensorMap} = Mooncake.tangent_type(T) Mooncake.@foldable Mooncake.rdata_type(::Type{T}) where {T <: TensorMap} = NoRData Mooncake.tangent(t::TensorMap, ::NoRData) = t -Mooncake.zero_tangent_internal(t::TensorMap, ::Mooncake.MaybeCache) = zerovector(t) +Mooncake.zero_tangent_internal(t::TensorMap, c::Mooncake.MaybeCache) = + TensorMap(Mooncake.zero_tangent_internal(t.data, c), space(t)) -Mooncake.randn_tangent_internal(rng::AbstractRNG, p::TensorMap, ::Mooncake.MaybeCache) = - randn!(rng, similar(p)) +Mooncake.randn_tangent_internal(rng::AbstractRNG, p::TensorMap, c::Mooncake.MaybeCache) = + TensorMap(Mooncake.randn_tangent_internal(rng, p.data, c), space(p)) Mooncake.set_to_zero_internal!!(::Mooncake.SetToZeroCache, t::TensorMap) = zerovector!(t) -Mooncake.increment_internal!!(::Mooncake.IncCache, x::T, y::T) where {T <: TensorMap} = add!(x, y) - +function Mooncake.increment!!(x::TensorMap, y::TensorMap) + data = Mooncake.increment!!(x.data, y.data) + return x.data === data ? x : TensorMap(data, space(x)) +end +function Mooncake.increment_internal!!(c::Mooncake.IncCache, x::TensorMap, y::TensorMap) + data = Mooncake.increment_internal!!(c, x.data, y.data) + return x.data === data ? x : TensorMap(data, space(x)) +end -Mooncake._add_to_primal_internal(::Mooncake.MaybeCache, p::T, t::T, unsafe::Bool) where {T <: TensorMap} = add(p, t) -Mooncake.tangent_to_primal_internal!!(p::T, t::T, ::Mooncake.MaybeCache) where {T <: TensorMap} = copy!(p, t) +Mooncake._add_to_primal_internal(c::Mooncake.MaybeCache, p::TensorMap, t::TensorMap, unsafe::Bool) = + TensorMap(Mooncake._add_to_primal_internal(c, p.data, t.data, unsafe), space(p)) +function Mooncake.tangent_to_primal_internal!!(p::TensorMap, t::TensorMap, c::Mooncake.MaybeCache) + data = Mooncake.tangent_to_primal_internal!!(p.data, t.data, c) + data === p.data || copy!(p.data, data) + return p +end Mooncake.primal_to_tangent_internal!!(t::T, p::T, ::Mooncake.MaybeCache) where {T <: TensorMap} = copy!(t, p) -Mooncake._dot_internal(::Mooncake.MaybeCache, t::T, s::T) where {T <: TensorMap} = Float64(real(inner(t, s))) -Mooncake._scale_internal(::Mooncake.MaybeCache, a::Float64, t::T) where {T <: TensorMap} = scale(t, a) +Mooncake._dot_internal(::Mooncake.MaybeCache, t::TensorMap, s::TensorMap) = Float64(real(inner(t, s))) +Mooncake._scale_internal(::Mooncake.MaybeCache, a::Float64, t::TensorMap) = scale(t, a) -function Mooncake.TestUtils.populate_address_map_internal( - m::Mooncake.AddressMap, primal::T, tangent::T - ) where {T <: TensorMap} - return Mooncake.TestUtils.populate_address_map_internal(m, primal.data, tangent.data) -end +Mooncake.TestUtils.populate_address_map_internal(m::Mooncake.TestUtils.AddressMap, primal::TensorMap, tangent::TensorMap) = + Mooncake.populate_address_map_internal(m, primal.data, tangent.data) +@inline Mooncake.TestUtils.__get_data_field(t::TensorMap, n) = getfield(t, n) function Mooncake.__verify_fdata_value(::IdDict{Any, Nothing}, p::TensorMap, f::TensorMap) space(p) == space(f) || throw(Mooncake.InvalidFDataException(lazy"p has space $(space(p)) but f has size $(space(f))")) return nothing end - +function Mooncake.__verify_fdata_value(c::IdDict{Any, Nothing}, p::TensorMap, t::TensorMap) + return Mooncake.__verify_fdata_value(c, p.data, t.data) +end @is_primitive MinimalCtx Tuple{typeof(Mooncake.lgetfield), <:TensorMap, Val} From af87833dd803de95f4ab7923b9a3877f19bff052 Mon Sep 17 00:00:00 2001 From: lkdvos Date: Thu, 29 Jan 2026 17:20:13 -0500 Subject: [PATCH 44/52] bump versions --- Project.toml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Project.toml b/Project.toml index 838965d09..b5d0e64a0 100644 --- a/Project.toml +++ b/Project.toml @@ -45,7 +45,7 @@ FiniteDifferences = "0.12" GPUArrays = "11.3.1" LRUCache = "1.0.2" LinearAlgebra = "1" -MatrixAlgebraKit = "0.6.3" +MatrixAlgebraKit = "0.6.4" Mooncake = "0.5" OhMyThreads = "0.8.0" Printf = "1" @@ -86,3 +86,6 @@ cuTENSOR = "011b41b2-24ef-40a8-b3eb-fa098493e9e1" [targets] test = ["ArgParse", "Adapt", "Aqua", "AllocCheck", "Combinatorics", "CUDA", "cuTENSOR", "GPUArrays", "LinearAlgebra", "SafeTestsets", "TensorOperations", "Test", "TestExtras", "ChainRulesCore", "ChainRulesTestUtils", "FiniteDifferences", "Zygote", "Mooncake", "JET"] + +[sources] +MatrixAlgebraKit = {url = "https://github.com/QuantumKitHub/MatrixAlgebraKit.jl", rev = "v0.6.4"} From d7a08fcb335d0c251e78d46e398f6bd0ed2b1e7d Mon Sep 17 00:00:00 2001 From: lkdvos Date: Thu, 29 Jan 2026 17:43:42 -0500 Subject: [PATCH 45/52] deal with more complex sector shenanigans --- ext/TensorKitMooncakeExt/indexmanipulations.jl | 14 ++++++++------ src/tensors/indexmanipulations.jl | 2 ++ test/mooncake/indexmanipulations.jl | 11 +++++++---- 3 files changed, 17 insertions(+), 10 deletions(-) diff --git a/ext/TensorKitMooncakeExt/indexmanipulations.jl b/ext/TensorKitMooncakeExt/indexmanipulations.jl index 28c142522..b5938bc08 100644 --- a/ext/TensorKitMooncakeExt/indexmanipulations.jl +++ b/ext/TensorKitMooncakeExt/indexmanipulations.jl @@ -192,12 +192,13 @@ function Mooncake.rrule!!(::CoDual{typeof(flip)}, t_Δt::CoDual{<:AbstractTensor t_flipped_Δt_flipped = Mooncake.zero_fcodual(t_flipped) _, Δt_flipped = arrayify(t_flipped_Δt_flipped) - function twist_pullback(::NoRData) - add!(Δt, flip(Δt_flipped, inds; inv = !inv)) + function flip_pullback(::NoRData) + Δt_flipflipped = flip(Δt_flipped, inds; inv = !inv) + add!(Δt, scalartype(Δt) <: Real ? real(Δt_flipflipped) : Δt_flipflipped) return ntuple(Returns(NoRData()), 3) end - return t_flipped_Δt_flipped, twist_pullback + return t_flipped_Δt_flipped, flip_pullback end function Mooncake.rrule!!( ::CoDual{typeof(Core.kwcall)}, kwargs_Δkwargs::CoDual{@NamedTuple{inv::Bool}}, ::CoDual{typeof(flip)}, @@ -213,12 +214,13 @@ function Mooncake.rrule!!( t_flipped_Δt_flipped = Mooncake.zero_fcodual(t_flipped) _, Δt_flipped = arrayify(t_flipped_Δt_flipped) - function twist_pullback(::NoRData) - add!(Δt, flip(Δt_flipped, inds; inv = !inv)) + function flip_pullback(::NoRData) + Δt_flipflipped = flip(Δt_flipped, inds; inv = !inv) + add!(Δt, scalartype(Δt) <: Real ? real(Δt_flipflipped) : Δt_flipflipped) return ntuple(Returns(NoRData()), 5) end - return t_flipped_Δt_flipped, twist_pullback + return t_flipped_Δt_flipped, flip_pullback end for insertunit in (:insertleftunit, :insertrightunit) diff --git a/src/tensors/indexmanipulations.jl b/src/tensors/indexmanipulations.jl index d30a732a5..9bbcd564e 100644 --- a/src/tensors/indexmanipulations.jl +++ b/src/tensors/indexmanipulations.jl @@ -268,6 +268,8 @@ function twist!(t::AbstractTensorMap, inds; inv::Bool = false) msg = "Can't twist indices $inds of a tensor with only $(numind(t)) indices." throw(ArgumentError(msg)) end + (scalartype(t) <: Real && !(sectorscalartype(sectortype(t)) <: Real)) && + throw(ArgumentError("Can't in-place twist a real tensor with complex sector type")) has_shared_twist(t, inds) && return t (scalartype(t) <: Real && !(sectorscalartype(sectortype(t)) <: Real)) && diff --git a/test/mooncake/indexmanipulations.jl b/test/mooncake/indexmanipulations.jl index 945f4482b..614439b23 100644 --- a/test/mooncake/indexmanipulations.jl +++ b/test/mooncake/indexmanipulations.jl @@ -100,10 +100,13 @@ eltypes = (Float64, ComplexF64) @timedtestset "flip_n_twist!" begin A = randn(T, V[1] ⊗ V[2] ← V[4] ⊗ V[5]) - Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; inv = false), twist!, A, 1; atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; inv = true), twist!, A, [1, 3]; atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, twist!, A, 1; atol, rtol, mode) - Mooncake.TestUtils.test_rule(rng, twist!, A, [1, 3]; atol, rtol, mode) + + if !(T <: Real && !(sectorscalartype(sectortype(A)) <: Real)) + Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; inv = false), twist!, A, 1; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; inv = true), twist!, A, [1, 3]; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, twist!, A, 1; atol, rtol, mode) + Mooncake.TestUtils.test_rule(rng, twist!, A, [1, 3]; atol, rtol, mode) + end Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; inv = false), flip, A, 1; atol, rtol, mode) Mooncake.TestUtils.test_rule(rng, Core.kwcall, (; inv = true), flip, A, [1, 3]; atol, rtol, mode) From 226b248804c494802c45cbb25c31f55746c7c588 Mon Sep 17 00:00:00 2001 From: lkdvos Date: Thu, 29 Jan 2026 17:57:27 -0500 Subject: [PATCH 46/52] properly accumulate --- ext/TensorKitMooncakeExt/tensoroperations.jl | 7 +++---- test/mooncake/tensoroperations.jl | 7 +++++++ 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/ext/TensorKitMooncakeExt/tensoroperations.jl b/ext/TensorKitMooncakeExt/tensoroperations.jl index 6c3f7442e..7c2dd1085 100644 --- a/ext/TensorKitMooncakeExt/tensoroperations.jl +++ b/ext/TensorKitMooncakeExt/tensoroperations.jl @@ -79,7 +79,7 @@ function blas_contract_pullback_ΔA!( ΔC, pΔC, false, tB, reverse(pB), true, ipA, - conj(α), Zero(), + conj(α), One(), backend, allocator ) @@ -106,7 +106,7 @@ function blas_contract_pullback_ΔB!( tA, reverse(pA), true, ΔC, pΔC, false, ipB, - conj(α), Zero(), backend, allocator + conj(α), One(), backend, allocator ) return NoRData() @@ -115,8 +115,7 @@ end function blas_contract_pullback_Δα( ΔC, A, pA, B, pB, pAB, α, backend, allocator ) - Tdα = Mooncake.rdata_type(Mooncake.tangent_type(typeof(α))) - Tdα === NoRData && return NoRData() + _needs_tangent(α) || return NoRData() AB = TO.tensorcontract(A, pA, false, B, pB, false, pAB, One(), backend, allocator) Δα = inner(AB, ΔC) diff --git a/test/mooncake/tensoroperations.jl b/test/mooncake/tensoroperations.jl index 922ac227a..3a4a1dd4a 100644 --- a/test/mooncake/tensoroperations.jl +++ b/test/mooncake/tensoroperations.jl @@ -1,6 +1,7 @@ using Test, TestExtras using TensorKit using TensorOperations +using VectorInterface: One, Zero using Mooncake using Random @@ -87,6 +88,12 @@ eltypes = (Float64, ComplexF64) T, A, pA, false, B, pB, false, pAB, Val(false) ) ) + Mooncake.TestUtils.test_rule( + rng, TensorKit.blas_contract!, + C, A, pA, B, pB, pAB, One(), Zero(), + TensorOperations.DefaultBackend(), TensorOperations.DefaultAllocator(); + atol, rtol, mode + ) Mooncake.TestUtils.test_rule( rng, TensorKit.blas_contract!, C, A, pA, B, pB, pAB, α, β, From b7f5fe4982058694ea19c9b3a37678b88b0f4f37 Mon Sep 17 00:00:00 2001 From: lkdvos Date: Fri, 30 Jan 2026 09:48:58 -0500 Subject: [PATCH 47/52] nicer _needs_tangent --- ext/TensorKitMooncakeExt/tensoroperations.jl | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ext/TensorKitMooncakeExt/tensoroperations.jl b/ext/TensorKitMooncakeExt/tensoroperations.jl index 7c2dd1085..8dac1e4d8 100644 --- a/ext/TensorKitMooncakeExt/tensoroperations.jl +++ b/ext/TensorKitMooncakeExt/tensoroperations.jl @@ -189,8 +189,7 @@ end function trace_permute_pullback_Δα( ΔC, A, p, q, α, backend ) - Tdα = Mooncake.rdata_type(Mooncake.tangent_type(typeof(α))) - Tdα === NoRData && return NoRData() + _needs_tangent(α) || return NoRData() # TODO: this result might be easier to compute as: # C′ = βC + α * trace(A) ⟹ At = (C′ - βC) / α From fb395e6d9e513ccbe6cce373ff046546133edeef Mon Sep 17 00:00:00 2001 From: lkdvos Date: Fri, 30 Jan 2026 09:49:15 -0500 Subject: [PATCH 48/52] remove source --- Project.toml | 3 --- 1 file changed, 3 deletions(-) diff --git a/Project.toml b/Project.toml index b5d0e64a0..8487859da 100644 --- a/Project.toml +++ b/Project.toml @@ -86,6 +86,3 @@ cuTENSOR = "011b41b2-24ef-40a8-b3eb-fa098493e9e1" [targets] test = ["ArgParse", "Adapt", "Aqua", "AllocCheck", "Combinatorics", "CUDA", "cuTENSOR", "GPUArrays", "LinearAlgebra", "SafeTestsets", "TensorOperations", "Test", "TestExtras", "ChainRulesCore", "ChainRulesTestUtils", "FiniteDifferences", "Zygote", "Mooncake", "JET"] - -[sources] -MatrixAlgebraKit = {url = "https://github.com/QuantumKitHub/MatrixAlgebraKit.jl", rev = "v0.6.4"} From 4bc9ac3fef8c57bc3f64bfe399c06e7a532f1499 Mon Sep 17 00:00:00 2001 From: lkdvos Date: Fri, 30 Jan 2026 13:16:18 -0500 Subject: [PATCH 49/52] fix TensorOperations --- ext/TensorKitMooncakeExt/linalg.jl | 2 +- ext/TensorKitMooncakeExt/tensoroperations.jl | 2 +- ext/TensorKitMooncakeExt/utility.jl | 9 +++++++++ test/mooncake/tensoroperations.jl | 6 ++++++ 4 files changed, 17 insertions(+), 2 deletions(-) diff --git a/ext/TensorKitMooncakeExt/linalg.jl b/ext/TensorKitMooncakeExt/linalg.jl index 3d5ac8610..ff49e68e3 100644 --- a/ext/TensorKitMooncakeExt/linalg.jl +++ b/ext/TensorKitMooncakeExt/linalg.jl @@ -1,7 +1,7 @@ # Shared # ------ pullback_dC!(ΔC, β) = (scale!(ΔC, conj(β)); return NoRData()) -pullback_dβ(C, ΔC, β) = _needs_tangent(β) ? inner(C, ΔC) : NoRData() +pullback_dβ(C, ΔC, β) = _needs_tangent(β) ? project_scalar(β, inner(ΔC, C)) : NoRData() @is_primitive DefaultCtx ReverseMode Tuple{typeof(mul!), AbstractTensorMap, AbstractTensorMap, AbstractTensorMap, Number, Number} diff --git a/ext/TensorKitMooncakeExt/tensoroperations.jl b/ext/TensorKitMooncakeExt/tensoroperations.jl index 8dac1e4d8..c4468ef65 100644 --- a/ext/TensorKitMooncakeExt/tensoroperations.jl +++ b/ext/TensorKitMooncakeExt/tensoroperations.jl @@ -119,7 +119,7 @@ function blas_contract_pullback_Δα( AB = TO.tensorcontract(A, pA, false, B, pB, false, pAB, One(), backend, allocator) Δα = inner(AB, ΔC) - return Δα + return project_scalar(α, Δα) end # tensortrace! diff --git a/ext/TensorKitMooncakeExt/utility.jl b/ext/TensorKitMooncakeExt/utility.jl index bfbca5264..3f50bffa0 100644 --- a/ext/TensorKitMooncakeExt/utility.jl +++ b/ext/TensorKitMooncakeExt/utility.jl @@ -2,6 +2,15 @@ _needs_tangent(x) = _needs_tangent(typeof(x)) _needs_tangent(::Type{T}) where {T <: Number} = Mooncake.rdata_type(Mooncake.tangent_type(T)) !== NoRData +""" + project_scalar(x::Number, dx::Number) + +Project a computed tangent `dx` onto the correct tangent type for `x`. +For example, we might compute a complex `dx` but only require the real part. +""" +project_scalar(x::Number, dx::Number) = oftype(x, dx) +project_scalar(x::Real, dx::Complex) = project_scalar(x, real(dx)) + # IndexTuple utility # ------------------ trivtuple(N) = ntuple(identity, N) diff --git a/test/mooncake/tensoroperations.jl b/test/mooncake/tensoroperations.jl index 3a4a1dd4a..6802e4a73 100644 --- a/test/mooncake/tensoroperations.jl +++ b/test/mooncake/tensoroperations.jl @@ -100,6 +100,12 @@ eltypes = (Float64, ComplexF64) TensorOperations.DefaultBackend(), TensorOperations.DefaultAllocator(); atol, rtol, mode ) + T <: Complex && Mooncake.TestUtils.test_rule( + rng, TensorKit.blas_contract!, + C, A, pA, B, pB, pAB, real(α), real(β), + TensorOperations.DefaultBackend(), TensorOperations.DefaultAllocator(); + atol, rtol, mode + ) end end From 717d34c02977643f37c6d3e02783ea61ad410fc1 Mon Sep 17 00:00:00 2001 From: lkdvos Date: Fri, 30 Jan 2026 13:16:22 -0500 Subject: [PATCH 50/52] remove duplicate method --- ext/TensorKitMooncakeExt/tangent.jl | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/ext/TensorKitMooncakeExt/tangent.jl b/ext/TensorKitMooncakeExt/tangent.jl index 42aed83bd..079037132 100644 --- a/ext/TensorKitMooncakeExt/tangent.jl +++ b/ext/TensorKitMooncakeExt/tangent.jl @@ -58,12 +58,9 @@ Mooncake.TestUtils.populate_address_map_internal(m::Mooncake.TestUtils.AddressMa Mooncake.populate_address_map_internal(m, primal.data, tangent.data) @inline Mooncake.TestUtils.__get_data_field(t::TensorMap, n) = getfield(t, n) -function Mooncake.__verify_fdata_value(::IdDict{Any, Nothing}, p::TensorMap, f::TensorMap) - space(p) == space(f) || - throw(Mooncake.InvalidFDataException(lazy"p has space $(space(p)) but f has size $(space(f))")) - return nothing -end function Mooncake.__verify_fdata_value(c::IdDict{Any, Nothing}, p::TensorMap, t::TensorMap) + space(p) == space(t) || + throw(Mooncake.InvalidFDataException(lazy"p has space $(space(p)) but t has size $(space(t))")) return Mooncake.__verify_fdata_value(c, p.data, t.data) end From ae6ffd24f1b57053232cdda7e26f67a1f418799c Mon Sep 17 00:00:00 2001 From: lkdvos Date: Fri, 30 Jan 2026 14:51:16 -0500 Subject: [PATCH 51/52] fix arg order --- ext/TensorKitMooncakeExt/linalg.jl | 4 ++-- test/mooncake/planaroperations.jl | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/ext/TensorKitMooncakeExt/linalg.jl b/ext/TensorKitMooncakeExt/linalg.jl index ff49e68e3..8f5306ac4 100644 --- a/ext/TensorKitMooncakeExt/linalg.jl +++ b/ext/TensorKitMooncakeExt/linalg.jl @@ -1,7 +1,7 @@ # Shared # ------ pullback_dC!(ΔC, β) = (scale!(ΔC, conj(β)); return NoRData()) -pullback_dβ(C, ΔC, β) = _needs_tangent(β) ? project_scalar(β, inner(ΔC, C)) : NoRData() +pullback_dβ(ΔC, C, β) = _needs_tangent(β) ? project_scalar(β, inner(C, ΔC)) : NoRData() @is_primitive DefaultCtx ReverseMode Tuple{typeof(mul!), AbstractTensorMap, AbstractTensorMap, AbstractTensorMap, Number, Number} @@ -32,7 +32,7 @@ function Mooncake.rrule!!( ΔAr = NoRData() ΔBr = NoRData() Δαr = isnothing(AB) ? NoRData() : inner(AB, ΔC) - Δβr = pullback_dβ(C, ΔC, β) + Δβr = pullback_dβ(ΔC, C, β) ΔCr = pullback_dC!(ΔC, β) return NoRData(), ΔCr, ΔAr, ΔBr, Δαr, Δβr diff --git a/test/mooncake/planaroperations.jl b/test/mooncake/planaroperations.jl index dcc424b9a..98a9afe22 100644 --- a/test/mooncake/planaroperations.jl +++ b/test/mooncake/planaroperations.jl @@ -90,6 +90,10 @@ eltypes = (Float64, ComplexF64) T, A, pA, false, B, pB, false, pAB, Val(false) ) ) + Mooncake.TestUtils.test_rule( + rng, TensorKit.planarcontract!, C, A, pA, B, pB, pAB, One(), Zero(); + atol, rtol, mode, is_primitive = false + ) Mooncake.TestUtils.test_rule( rng, TensorKit.planarcontract!, C, A, pA, B, pB, pAB, α, β; atol, rtol, mode, is_primitive = false From e36ab52326c70518c561577057d8c666b0a90b3c Mon Sep 17 00:00:00 2001 From: lkdvos Date: Fri, 30 Jan 2026 14:51:24 -0500 Subject: [PATCH 52/52] add missing ChainRules import --- ext/TensorKitMooncakeExt/tangent.jl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ext/TensorKitMooncakeExt/tangent.jl b/ext/TensorKitMooncakeExt/tangent.jl index 079037132..9154ba6f7 100644 --- a/ext/TensorKitMooncakeExt/tangent.jl +++ b/ext/TensorKitMooncakeExt/tangent.jl @@ -64,6 +64,8 @@ function Mooncake.__verify_fdata_value(c::IdDict{Any, Nothing}, p::TensorMap, t: return Mooncake.__verify_fdata_value(c, p.data, t.data) end +Mooncake.to_cr_tangent(x::TensorMap) = x + @is_primitive MinimalCtx Tuple{typeof(Mooncake.lgetfield), <:TensorMap, Val} # TODO: double-check if this has to include quantum dimensinos for non-abelian?