-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Labels
discussionissues or PR's created for future planning or soliciting feedback and discussionissues or PR's created for future planning or soliciting feedback and discussion
Milestone
Description
This is an issue for compiling a list of breaking API changes that would be nice to have, but arent really worth doing on their own. The plan is to save them all up and apply them all at once whenever version 1.0 is considered ready.
The list:
- rename the model classes to have more descriptive names
- give all the model classes a consistent API (and maybe create some superclass or interface for this?)
- make the
parse()methods on each class generic (using fields and methods defined by the model classes) and pull it up into a superclass for deduplication
- make the
- convert the constructor of the
Daysclass to a class methodfrom_rangeand make a simpler constructor (this will require some pretty major refactoring) - allow the output format to be customized #3
- rename
TimestoTimeRangeand create a classTimesthat can store multipleTimeRange's similar toDays(see support several opening and closing times for a single day #5) - make
is_24_hr()andis_12_hour()inTimeconsistent - create a common system for specifying assumptions to make when the information is not available (for AM/PM, and century/year)
- make all the
from_parse_resultsmethods consistent with regard to if they are processing a clean dictionary or apyparsing.ParseResultobject and possibly rename them tofrom_parse_result_dict
Metadata
Metadata
Assignees
Labels
discussionissues or PR's created for future planning or soliciting feedback and discussionissues or PR's created for future planning or soliciting feedback and discussion