forked from googleapis/google-cloud-node
-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
dependenciesPull requests that update a dependency filePull requests that update a dependency filedocumentationImprovements or additions to documentationImprovements or additions to documentationduplicateThis issue or pull request already existsThis issue or pull request already existsenhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomersinvalidThis doesn't seem rightThis doesn't seem rightjavascriptPull requests that update javascript codePull requests that update javascript codequestionFurther information is requestedFurther information is requested
Description
Reviewer's Guide
Refactors the CircleCI configuration to use a single Docker-based 'say-hello' job and a simple workflow, removing the previous custom executor and project-specific job.
Sequence diagram for CircleCI say-hello job execution
sequenceDiagram
actor Dev
participant GitHub
participant CircleCI
participant Workflow_say_hello_workflow
participant Job_say_hello
participant Docker_executor
participant Docker_image_cimg_base_current
Dev->>GitHub: push_changes
GitHub-->>CircleCI: webhook_repository_update
CircleCI->>Workflow_say_hello_workflow: start_workflow
Workflow_say_hello_workflow->>Job_say_hello: enqueue_job
Job_say_hello->>Docker_executor: request_container
Docker_executor->>Docker_image_cimg_base_current: pull_image
Docker_image_cimg_base_current-->>Docker_executor: image_ready
Docker_executor-->>Job_say_hello: container_running
Job_say_hello->>Job_say_hello: step_checkout
Job_say_hello->>Job_say_hello: step_run_Say_hello_echo_Hello_World
Job_say_hello-->>Workflow_say_hello_workflow: job_success
Workflow_say_hello_workflow-->>CircleCI: workflow_success
CircleCI-->>Dev: report_build_status
File-Level Changes
| Change | Details | Files |
|---|---|---|
| Replace custom executor-based CircleCI setup with a single Docker job and simplified workflow. |
|
.circleci/config.yml |
Tips and commands
Interacting with Sourcery
- Trigger a new review: Comment
@sourcery-ai reviewon the pull request. - Continue discussions: Reply directly to Sourcery's review comments.
- Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with@sourcery-ai issueto create an issue from it. - Generate a pull request title: Write
@sourcery-aianywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai titleon the pull request to (re-)generate the title at any time. - Generate a pull request summary: Write
@sourcery-ai summaryanywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment@sourcery-ai summaryon the pull request to
(re-)generate the summary at any time. - Generate reviewer's guide: Comment
@sourcery-ai guideon the pull
request to (re-)generate the reviewer's guide at any time. - Resolve all Sourcery comments: Comment
@sourcery-ai resolveon the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore. - Dismiss all Sourcery reviews: Comment
@sourcery-ai dismisson the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai reviewto trigger a new review!
Customizing Your Experience
Access your dashboard to:
- Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others. - Change the review language.
- Add, remove or edit custom review instructions.
- Adjust other review settings.
Getting Help
- Contact our support team for questions or feedback.
- Visit our documentation for detailed guides and information.
- Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.
Originally posted by @sourcery-ai[bot] in #232 (comment)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
dependenciesPull requests that update a dependency filePull requests that update a dependency filedocumentationImprovements or additions to documentationImprovements or additions to documentationduplicateThis issue or pull request already existsThis issue or pull request already existsenhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomersinvalidThis doesn't seem rightThis doesn't seem rightjavascriptPull requests that update javascript codePull requests that update javascript codequestionFurther information is requestedFurther information is requested
Projects
Status
Backlog
Status
Todo