Return value not defined

[Nirator78]

Hi,
I've install your librairie on php 7.4.16 and php 8.0.4 on symfony 4 and 5. And I've got the same error was :

Declaration of Pagerfanta\Adapter\DoctrineORMAdapter::getSlice($offset, $length) must be compatible with Pagerfanta\Adapter\AdapterInterface::getSlice(int $offset, int $length): iterable in C:\svn\galatee\api\vendor\page
rfanta\pagerfanta\src\Adapter\DoctrineORMAdapter.php on line 62

And

Declaration of Pagerfanta\Adapter\DoctrineORMAdapter::getNbResults() must be compatible with Pagerfanta\Adapter\AdapterInterface::getNbResults(): int in C:\svn\galatee\api\vendor\pagerfanta\pagerfanta\src\Adapter\Doctrin
eORMAdapter.php on line 51

So can you resolve it on the futur version with this code on DoctrineORMAdapter.php

   /**
   * @return int
   */
  public function getNbResults(): int
  {
      return \count($this->paginator);
  }

  /**
   * @param int $offset
   * @param int $length
   *
   * @return iterable
   */
  public function getSlice($offset, $length): iterable
  {
      $this->paginator->getQuery()
          ->setFirstResult($offset)
          ->setMaxResults($length);

      return $this->paginator->getIterator();
  }

Just add the type of returned value (int and iterable) actually.

Thank's for your futur response

[mbabker]

Can you give the output from composer show please?

The Pagerfanta\Adapter\DoctrineORMAdapter class is deprecated as of Pagerfanta 2.4 (replaced with Pagerfanta\Doctrine\ORM\QueryAdapter) and was removed in Pagerfanta 3.0.

In Pagerfanta 2.x, Pagerfanta\Adapter\AdapterInterface does not have typehints on its methods, those were added in 3.0.

So if you're getting that error, somehow you have the 3.0 version of the interface and an incompatible class from the 2.x branch installed, which shouldn't be possible.

[Nirator78]

Hi,
Thanks for your answer, I do the composer show and i see pagerfanta/pagerfanta v2.3.0 Pagination for PHP, so that's was the problem.
But in my composer.json i d'ont install pagerfanta/pagerfanta just your librairy in this version "babdev/pagerfanta-bundle": "3.0.2" can you tell me how to update the version of pagerfanta/pagerfanta in 3.0.2 please?

Thank's again

[mbabker]

You would need to add the pagerfanta/pagerfanta package to your application’s dependencies. Starting with 2.4, the main Pagerfanta package is split into several smaller packages (the same way the Symfony components are all split from the main repo). With the bundle’s 3.0 release, only the core Pagerfanta API (the main Pagerfanta class, the view factory, and all the interfaces mainly) is installed by default and you’d need to add the other packages your application uses.

[Nirator78]

I install pagefanta/pagefanta in my project dependencies and now it's working find ;)
Thank you so much for your help and your time ;)